144252 2015-04-27 01:19:46 -0700 Numeric setter on prototype doesn't get called. 2015-08-11 23:48:13 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 145358 140491 1 rniwa ysuzuki benjamin darin fpizlo ggaren joepeck mark.lam saam ysuzuki oldest_to_newest 1088955 0 rniwa 2015-04-27 01:19:46 -0700 var y = {set 2(x) { alert(x) }} y[2] = 5; var z = {__proto__: {set 3(x) { alert(x) }}}; z[3] = 7; Chrome and Firefox both alerts 5 and 7. Safari only alerts 5. If you replace '3' with 'foo', Safari also alerts 7 and 7. 1115266 1 ysuzuki 2015-08-05 21:11:27 -0700 I think there are 2 issues, correct? 1. If the __proto__-executed object is categorized into ALL_BLANK_INDEXING_TYPES, we don't set SlowPut into its structure. 2. And if the newly generated object is not the array, we don't set the SlowPut into its structure even if there's SlowPut structure in the [[Prototype]] chain. 1115296 2 rniwa 2015-08-05 23:37:56 -0700 FWIW, I have no idea. 1116497 3 258706 ysuzuki 2015-08-10 23:12:13 -0700 Created attachment 258706 Patch 1116571 4 258706 darin 2015-08-11 10:32:38 -0700 Comment on attachment 258706 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258706&action=review > Source/JavaScriptCore/runtime/JSObject.cpp:2045 > + // Reloop. This word “reloop” doesn’t exist. I suggest removing this comment unless there’s something clear to say here. 1116572 5 258706 darin 2015-08-11 10:33:52 -0700 Comment on attachment 258706 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258706&action=review >> Source/JavaScriptCore/runtime/JSObject.cpp:2045 >> + // Reloop. > > This word “reloop” doesn’t exist. I suggest removing this comment unless there’s something clear to say here. If we do write a comment here, I think the focus of the comment should be on why it’s safe to call putByIndex and why we’re guaranteed this won’t result in an infinite loop. 1116573 6 258706 ysuzuki 2015-08-11 10:35:39 -0700 Comment on attachment 258706 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258706&action=review Thank you! >> Source/JavaScriptCore/runtime/JSObject.cpp:2045 >> + // Reloop. > > This word “reloop” doesn’t exist. I suggest removing this comment unless there’s something clear to say here. Oh, I can see many "Reloop"s in JSObject.cpp[1]... In the mean time, I'll drop this comment! [1]: http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/runtime/JSObject.cpp 1116576 7 darin 2015-08-11 10:40:42 -0700 (In reply to comment #6) > Oh, I can see many "Reloop"s in JSObject.cpp[1]... I guess I wasn’t there when these changes went in to discourage use of this “word”! 1116577 8 258706 ysuzuki 2015-08-11 10:42:41 -0700 Comment on attachment 258706 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258706&action=review >>>> Source/JavaScriptCore/runtime/JSObject.cpp:2045 >>>> + // Reloop. >>> >>> This word “reloop” doesn’t exist. I suggest removing this comment unless there’s something clear to say here. >> >> If we do write a comment here, I think the focus of the comment should be on why it’s safe to call putByIndex and why we’re guaranteed this won’t result in an infinite loop. > > Oh, I can see many "Reloop"s in JSObject.cpp[1]... > In the mean time, I'll drop this comment! > > [1]: http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/runtime/JSObject.cpp > If we do write a comment here, I think the focus of the comment should be on why it’s safe to call putByIndex and why we’re guaranteed this won’t result in an infinite loop. OK, I'll add the comment "Convert the indexing type to the SlowPutArrayStorage and retry.", what do you think of? 1116629 9 ysuzuki 2015-08-11 12:12:14 -0700 Committed r188269: <http://trac.webkit.org/changeset/188269> 1116630 10 ysuzuki 2015-08-11 12:12:43 -0700 (In reply to comment #8) > Comment on attachment 258706 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=258706&action=review > > >>>> Source/JavaScriptCore/runtime/JSObject.cpp:2045 > >>>> + // Reloop. > >>> > >>> This word “reloop” doesn’t exist. I suggest removing this comment unless there’s something clear to say here. > >> > >> If we do write a comment here, I think the focus of the comment should be on why it’s safe to call putByIndex and why we’re guaranteed this won’t result in an infinite loop. > > > > Oh, I can see many "Reloop"s in JSObject.cpp[1]... > > In the mean time, I'll drop this comment! > > > > [1]: http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/runtime/JSObject.cpp > > > If we do write a comment here, I think the focus of the comment should be on why it’s safe to call putByIndex and why we’re guaranteed this won’t result in an infinite loop. > > OK, I'll add the comment "Convert the indexing type to the > SlowPutArrayStorage and retry.", what do you think of? In the meantime, I've added the above comment here. 1116894 11 258706 rniwa 2015-08-11 22:59:59 -0700 Comment on attachment 258706 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258706&action=review > LayoutTests/ChangeLog:8 > + Update the test expectation file. Nit: You're updating the expected result, not a test expectation file. Test expectation files are files such as LayoutTests/TestExpectations that list the expected outcome of each test. 1116909 12 258706 ysuzuki 2015-08-11 23:46:51 -0700 Comment on attachment 258706 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258706&action=review >> LayoutTests/ChangeLog:8 >> + Update the test expectation file. > > Nit: You're updating the expected result, not a test expectation file. > Test expectation files are files such as LayoutTests/TestExpectations that list the expected outcome of each test. Oh, I see. Thank you for your comment :D 258706 2015-08-10 23:12:13 -0700 2015-08-11 10:32:38 -0700 Patch bug-144252-20150810231158.patch text/plain 9331 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4MjQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh NGZlYmY3Y2I3YTlkZDI0NDg4Zjk4ZGZlMGQyYWU5Njk3YjU5MTQ0Li43NGM3NjI1MzM5Zjg4MzBm NDA0YTdkNTFhMTk3Njk5YzU3NmJlODBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSw0NyBAQAorMjAxNS0wOC0xMCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBOdW1lcmljIHNldHRlciBvbiBwcm90b3R5cGUgZG9lc24ndCBnZXQg Y2FsbGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQ0MjUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V2hlbiBzd2l0Y2hpbmcgdGhlIGJsYW5rIGluZGV4aW5nIHR5cGUgdG8gdGhlIG90aGVyIG9uZSBp biBwdXRCeUluZGV4LAorICAgICAgICBpZiB0aGUgYHN0cnVjdHVyZSh2bSktPm5lZWRzU2xvd1B1 dEluZGV4aW5nKClgIGlzIHRydWUsIHdlIG5lZWQgdG8gc3dpdGNoCisgICAgICAgIGl0IHRvIHRo ZSBzbG93IHB1dCBpbmRleGluZyB0eXBlIGFuZCByZWxvb3AgdGhlIHB1dEJ5SW5kZXggc2luY2Ug dGhlcmUgbWF5CisgICAgICAgIGJlIHNvbWUgaW5kZXhpbmcgYWNjZXNzb3IgaW4gdGhlIHByb3Rv dHlwZSBjaGFpbi4gUHJldmlvdXNseSwgd2UganVzdCBzZXQKKyAgICAgICAgdGhlIHZhbHVlIGlu dG8gdGhlIGFsbG9jYXRlZCB2ZWN0b3IuCisKKyAgICAgICAgSW4gdGhlIHB1dERpcmVjdEluZGV4 IGNhc2UsIHdlIGp1c3Qgc3RvcmUgdGhlIHZhbHVlIHRvIHRoZSB2ZWN0b3IuCisgICAgICAgIFRo aXMgaXMgYmVjYXVzZSBwdXREaXJlY3RJbmRleCBpcyB0aGUgb3BlcmF0aW9uIHRvIHN0b3JlIHRo ZSBvd24gcHJvcGVydHkKKyAgICAgICAgYW5kIGl0IGRvZXMgbm90IGNoZWNrIHRoZSBhY2Nlc3Nv cnMgaW4gdGhlIHByb3RvdHlwZSBjaGFpbi4KKworICAgICAgICAqIHJ1bnRpbWUvSlNPYmplY3Qu Y3BwOgorICAgICAgICAoSlNDOjpKU09iamVjdDo6cHV0QnlJbmRleEJleW9uZFZlY3Rvckxlbmd0 aCk6CisgICAgICAgICogdGVzdHMvc3RyZXNzL2luamVjdGVkLW51bWVyaWMtc2V0dGVyLW9uLXBy b3RvdHlwZS5qczogQWRkZWQuCisgICAgICAgIChzaG91bGRCZSk6CisgICAgICAgIChUcmFjZSk6 CisgICAgICAgIChUcmFjZS5wcm90b3R5cGUudHJhY2UpOgorICAgICAgICAoVHJhY2UucHJvdG90 eXBlLmdldCBjb3VudCk6CisgICAgICAgICguKToKKyAgICAgICAgKiB0ZXN0cy9zdHJlc3MvbnVt ZXJpYy1zZXR0ZXItb24tcHJvdG90eXBlLW5vbi1ibGFuay1hcnJheS5qczogQWRkZWQuCisgICAg ICAgIChzaG91bGRCZSk6CisgICAgICAgIChUcmFjZSk6CisgICAgICAgIChUcmFjZS5wcm90b3R5 cGUudHJhY2UpOgorICAgICAgICAoVHJhY2UucHJvdG90eXBlLmdldCBjb3VudCk6CisgICAgICAg ICguKToKKyAgICAgICAgKiB0ZXN0cy9zdHJlc3MvbnVtZXJpYy1zZXR0ZXItb24tcHJvdG90eXBl LmpzOiBBZGRlZC4KKyAgICAgICAgKHNob3VsZEJlKToKKyAgICAgICAgKFRyYWNlKToKKyAgICAg ICAgKFRyYWNlLnByb3RvdHlwZS50cmFjZSk6CisgICAgICAgIChUcmFjZS5wcm90b3R5cGUuZ2V0 IGNvdW50KToKKyAgICAgICAgKC56Ll9fcHJvdG9fXy5zZXQgMyk6CisgICAgICAgICogdGVzdHMv c3RyZXNzL251bWVyaWMtc2V0dGVyLW9uLXNlbGYuanM6IEFkZGVkLgorICAgICAgICAoc2hvdWxk QmUpOgorICAgICAgICAoVHJhY2UpOgorICAgICAgICAoVHJhY2UucHJvdG90eXBlLnRyYWNlKToK KyAgICAgICAgKFRyYWNlLnByb3RvdHlwZS5nZXQgY291bnQpOgorICAgICAgICAoLnkuc2V0IDIp OgorCiAyMDE1LTA4LTEwICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAg ICAgICAgU3RhcnQgYmVhdGluZyBVbmxpbmtlZENvZGVCbG9jay5oLy5jcHAgd2l0aCB0aGUgIk9u ZSBDbGFzcyBwZXIgRmlsZSIgc3RpY2sKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0pTT2JqZWN0LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pT T2JqZWN0LmNwcAppbmRleCA0MjY0M2Q0ODNkNjZlYTY5OGRiZDhkZWU1ODAzYWI2OThjZmZhYzQ1 Li5iYTNhYmNiYWRiZGNkMmY0NTUxZmZmNWQ2NTBlOTA4OWYwYTJiNGM0IDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHAKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuY3BwCkBAIC0yMDQxLDkgKzIwNDEsOSBAQCB2 b2lkIEpTT2JqZWN0OjpwdXRCeUluZGV4QmV5b25kVmVjdG9yTGVuZ3RoKEV4ZWNTdGF0ZSogZXhl YywgdW5zaWduZWQgaSwgSlNWYWx1ZQogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KICAg ICAgICAgaWYgKHN0cnVjdHVyZSh2bSktPm5lZWRzU2xvd1B1dEluZGV4aW5nKCkpIHsKLSAgICAg ICAgICAgIEFycmF5U3RvcmFnZSogc3RvcmFnZSA9IGNyZWF0ZUFycmF5U3RvcmFnZSh2bSwgaSAr IDEsIGdldE5ld1ZlY3Rvckxlbmd0aCgwLCAwLCBpICsgMSkpOwotICAgICAgICAgICAgc3RvcmFn ZS0+bV92ZWN0b3JbaV0uc2V0KHZtLCB0aGlzLCB2YWx1ZSk7Ci0gICAgICAgICAgICBzdG9yYWdl LT5tX251bVZhbHVlc0luVmVjdG9yKys7CisgICAgICAgICAgICBjcmVhdGVBcnJheVN0b3JhZ2Uo dm0sIGkgKyAxLCBnZXROZXdWZWN0b3JMZW5ndGgoMCwgMCwgaSArIDEpKTsKKyAgICAgICAgICAg IC8vIFJlbG9vcC4KKyAgICAgICAgICAgIHB1dEJ5SW5kZXgodGhpcywgZXhlYywgaSwgdmFsdWUs IHNob3VsZFRocm93KTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgICAgIApk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9pbmplY3RlZC1u dW1lcmljLXNldHRlci1vbi1wcm90b3R5cGUuanMgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVz dHMvc3RyZXNzL2luamVjdGVkLW51bWVyaWMtc2V0dGVyLW9uLXByb3RvdHlwZS5qcwpuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwLi41OTRkZTMzNzQ2YmIwOTA3NDgxNjgxZjYyYzUyMTE3ZjJlYjEwOGJlCi0tLSAvZGV2L251 bGwKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9pbmplY3RlZC1udW1l cmljLXNldHRlci1vbi1wcm90b3R5cGUuanMKQEAgLTAsMCArMSwzNiBAQAorZnVuY3Rpb24gc2hv dWxkQmUoYWN0dWFsLCBleHBlY3RlZCkKK3sKKyAgICBpZiAoYWN0dWFsICE9PSBleHBlY3RlZCkK KyAgICAgICAgdGhyb3cgbmV3IEVycm9yKCdiYWQgdmFsdWU6ICcgKyBhY3R1YWwpOworfQorCitj bGFzcyBUcmFjZSB7CisgICAgY29uc3RydWN0b3IoKQorICAgIHsKKyAgICAgICAgdGhpcy5fX2Nv dW50ID0gMDsKKyAgICB9CisKKyAgICB0cmFjZSgpCisgICAgeworICAgICAgICB0aGlzLl9fY291 bnQrKzsKKyAgICB9CisKKyAgICBnZXQgY291bnQoKQorICAgIHsKKyAgICAgICAgcmV0dXJuIHRo aXMuX19jb3VudDsKKyAgICB9Cit9CisKK2ZvciAodmFyIGkgPSAwOyBpIDwgMTAwMDA7ICsraSkg eworICAgIHZhciB0MCA9IG5ldyBUcmFjZSgpOworCisgICAgdmFyIG9iamVjdCA9IHt9OworICAg IHNob3VsZEJlKHQwLmNvdW50LCAwKTsKKyAgICB2YXIgYSA9IHtfX3Byb3RvX186IG9iamVjdCB9 OworICAgIHNob3VsZEJlKHQwLmNvdW50LCAwKTsKKyAgICBPYmplY3QuZGVmaW5lUHJvcGVydHko b2JqZWN0LCAzLCB7CisgICAgICAgIHNldDogZnVuY3Rpb24gKHgpIHsgdDAudHJhY2UoKSB9Cisg ICAgfSk7CisgICAgYVszXSA9IDc7CisgICAgc2hvdWxkQmUodDAuY291bnQsIDEpOworfQpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9udW1lcmljLXNldHRl ci1vbi1wcm90b3R5cGUtbm9uLWJsYW5rLWFycmF5LmpzIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3Rlc3RzL3N0cmVzcy9udW1lcmljLXNldHRlci1vbi1wcm90b3R5cGUtbm9uLWJsYW5rLWFycmF5 LmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAuLmViNDRlZDdiNTYxNTI5YWU3YWNjYTJiMmY4YzA3ZTY4MzJkMThkOTEK LS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL251 bWVyaWMtc2V0dGVyLW9uLXByb3RvdHlwZS1ub24tYmxhbmstYXJyYXkuanMKQEAgLTAsMCArMSwz NiBAQAorZnVuY3Rpb24gc2hvdWxkQmUoYWN0dWFsLCBleHBlY3RlZCkKK3sKKyAgICBpZiAoYWN0 dWFsICE9PSBleHBlY3RlZCkKKyAgICAgICAgdGhyb3cgbmV3IEVycm9yKCdiYWQgdmFsdWU6ICcg KyBhY3R1YWwpOworfQorCitjbGFzcyBUcmFjZSB7CisgICAgY29uc3RydWN0b3IoKQorICAgIHsK KyAgICAgICAgdGhpcy5fX2NvdW50ID0gMDsKKyAgICB9CisKKyAgICB0cmFjZSgpCisgICAgewor ICAgICAgICB0aGlzLl9fY291bnQrKzsKKyAgICB9CisKKyAgICBnZXQgY291bnQoKQorICAgIHsK KyAgICAgICAgcmV0dXJuIHRoaXMuX19jb3VudDsKKyAgICB9Cit9CisKK2ZvciAodmFyIGkgPSAw OyBpIDwgMTAwMDA7ICsraSkgeworICAgIHZhciB0MyA9IG5ldyBUcmFjZSgpOworCisgICAgdmFy IG9iamVjdCA9IHsgMjogMiwgNDogNCB9OworICAgIHNob3VsZEJlKHQzLmNvdW50LCAwKTsKKyAg ICB2YXIgYSA9IHtfX3Byb3RvX186IG9iamVjdCB9OworICAgIHNob3VsZEJlKHQzLmNvdW50LCAw KTsKKyAgICBPYmplY3QuZGVmaW5lUHJvcGVydHkob2JqZWN0LCAzLCB7CisgICAgICAgIHNldDog ZnVuY3Rpb24gKHgpIHsgdDMudHJhY2UoKSB9CisgICAgfSk7CisgICAgYVszXSA9IDc7CisgICAg c2hvdWxkQmUodDMuY291bnQsIDEpOworfQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD b3JlL3Rlc3RzL3N0cmVzcy9udW1lcmljLXNldHRlci1vbi1wcm90b3R5cGUuanMgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL251bWVyaWMtc2V0dGVyLW9uLXByb3RvdHlwZS5q cwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi4xN2UwYjNjOWZlMzMwMDMyYjg3N2Y2MDE4MDI1ZjgxN2ZmZWQwNzZmCi0t LSAvZGV2L251bGwKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9udW1l cmljLXNldHRlci1vbi1wcm90b3R5cGUuanMKQEAgLTAsMCArMSwzMiBAQAorZnVuY3Rpb24gc2hv dWxkQmUoYWN0dWFsLCBleHBlY3RlZCkKK3sKKyAgICBpZiAoYWN0dWFsICE9PSBleHBlY3RlZCkK KyAgICAgICAgdGhyb3cgbmV3IEVycm9yKCdiYWQgdmFsdWU6ICcgKyBhY3R1YWwpOworfQorCitj bGFzcyBUcmFjZSB7CisgICAgY29uc3RydWN0b3IoKQorICAgIHsKKyAgICAgICAgdGhpcy5fX2Nv dW50ID0gMDsKKyAgICB9CisKKyAgICB0cmFjZSgpCisgICAgeworICAgICAgICB0aGlzLl9fY291 bnQrKzsKKyAgICB9CisKKyAgICBnZXQgY291bnQoKQorICAgIHsKKyAgICAgICAgcmV0dXJuIHRo aXMuX19jb3VudDsKKyAgICB9Cit9CisKK2ZvciAodmFyIGkgPSAwOyBpIDwgMTAwMDA7ICsraSkg eworICAgIHZhciB0MCA9IG5ldyBUcmFjZSgpOworCisgICAgc2hvdWxkQmUodDAuY291bnQsIDAp OworICAgIHZhciB6ID0ge19fcHJvdG9fXzoge3NldCAzKHgpIHsgdDAudHJhY2UoKSB9fX07Cisg ICAgc2hvdWxkQmUodDAuY291bnQsIDApOworICAgIHpbM10gPSA3OworICAgIHNob3VsZEJlKHQw LmNvdW50LCAxKTsKK30KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9z dHJlc3MvbnVtZXJpYy1zZXR0ZXItb24tc2VsZi5qcyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90 ZXN0cy9zdHJlc3MvbnVtZXJpYy1zZXR0ZXItb24tc2VsZi5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41YjE5NDYw ZjE1M2M2YTllMWFmMmExNzM2YTMxOWMwMzJkNjlhMzI1Ci0tLSAvZGV2L251bGwKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9udW1lcmljLXNldHRlci1vbi1zZWxmLmpz CkBAIC0wLDAgKzEsMzIgQEAKK2Z1bmN0aW9uIHNob3VsZEJlKGFjdHVhbCwgZXhwZWN0ZWQpCit7 CisgICAgaWYgKGFjdHVhbCAhPT0gZXhwZWN0ZWQpCisgICAgICAgIHRocm93IG5ldyBFcnJvcign YmFkIHZhbHVlOiAnICsgYWN0dWFsKTsKK30KKworY2xhc3MgVHJhY2UgeworICAgIGNvbnN0cnVj dG9yKCkKKyAgICB7CisgICAgICAgIHRoaXMuX19jb3VudCA9IDA7CisgICAgfQorCisgICAgdHJh Y2UoKQorICAgIHsKKyAgICAgICAgdGhpcy5fX2NvdW50Kys7CisgICAgfQorCisgICAgZ2V0IGNv dW50KCkKKyAgICB7CisgICAgICAgIHJldHVybiB0aGlzLl9fY291bnQ7CisgICAgfQorfQorCitm b3IgKHZhciBpID0gMDsgaSA8IDEwMDAwOyArK2kpIHsKKyAgICB2YXIgdDAgPSBuZXcgVHJhY2Uo KTsKKworICAgIHNob3VsZEJlKHQwLmNvdW50LCAwKTsKKyAgICB2YXIgeSA9IHtzZXQgMih4KSB7 IHQwLnRyYWNlKCkgfX07CisgICAgc2hvdWxkQmUodDAuY291bnQsIDApOworICAgIHlbMl0gPSA1 OworICAgIHNob3VsZEJlKHQwLmNvdW50LCAxKTsKK30KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwMWVmNWNiYzBmMTEzYWQ4 ZTMxMjYyNTNhN2Q3MmUxOGFkYzE0YzNmLi43YmI5MmJkMGI5ODBiNTU1ZDUxMGEzOWRlYWU5YTVi Y2RiMjI4M2VkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTUtMDgtMTAgIFl1c3VrZSBTdXp1 a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CisKKyAgICAgICAgTnVtZXJpYyBzZXR0ZXIgb24g cHJvdG90eXBlIGRvZXNuJ3QgZ2V0IGNhbGxlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDI1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSB0aGUgdGVzdCBleHBlY3RhdGlvbiBmaWxlLgor CisgICAgICAgICoganMvY2xhc3Mtc3ludGF4LXN0cmluZy1hbmQtbnVtZXJpYy1uYW1lcy1leHBl Y3RlZC50eHQ6CisKIDIwMTUtMDgtMTAgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29t PgogCiAgICAgICAgIGh0dHAvdGVzdHMvY2FjaGUvZGlzay1jYWNoZS9kaXNrLWNhY2hlLXZhbGlk YXRpb24uaHRtbCBoYXMgdG9vIG1hbnkgc3VidGVzdHMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2pzL2NsYXNzLXN5bnRheC1zdHJpbmctYW5kLW51bWVyaWMtbmFtZXMtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvanMvY2xhc3Mtc3ludGF4LXN0cmluZy1hbmQtbnVtZXJpYy1uYW1lcy1leHBl Y3RlZC50eHQKaW5kZXggYWE5ZmJkNTU3YWIzN2NlMGFlNzg0OGEzYzY0MTRkNjViYzU1NjVkOC4u OTZkMDVmNmY1MzkxODE1YjQzNWQ2NTIxZThmMjZhZjg1N2YyOTFkMyAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvanMvY2xhc3Mtc3ludGF4LXN0cmluZy1hbmQtbnVtZXJpYy1uYW1lcy1leHBlY3Rl ZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvanMvY2xhc3Mtc3ludGF4LXN0cmluZy1hbmQtbnVtZXJp Yy1uYW1lcy1leHBlY3RlZC50eHQKQEAgLTI4LDE0ICsyOCwxNCBAQCBQQVNTIGNsYXNzIEEgeyBn ZXQgMCgpIHsgcmV0dXJuIDIwOyB9IH07IChuZXcgQSlbMF0gaXMgMjAKIFBBU1MgY2xhc3MgQSB7 IGdldCAwKCkgeyByZXR1cm4gMjA7IH0gfTsgQVswXSBpcyB1bmRlZmluZWQKIFBBU1MgY2xhc3Mg QSB7IHN0YXRpYyBnZXQgMSgpIHsgcmV0dXJuIDIxOyB9IH07IEFbMV0gaXMgMjEKIFBBU1MgY2xh c3MgQSB7IHN0YXRpYyBnZXQgMSgpIHsgcmV0dXJuIDIxOyB9IH07IChuZXcgQSlbMV0gaXMgdW5k ZWZpbmVkCi1GQUlMIHNldHRlclZhbHVlID0gMDsgWCA9IGNsYXNzIHsgc2V0IDIoeCkgeyBzZXR0 ZXJWYWx1ZSA9IHg7IH0gfTsgKG5ldyBYKVsyXSA9IDIyOyBzZXR0ZXJWYWx1ZSBzaG91bGQgYmUg MjIuIFdhcyAwLgotRkFJTCBYWzJdID0gMjM7IHNldHRlclZhbHVlIHNob3VsZCBiZSAyMi4gV2Fz IDAuCitQQVNTIHNldHRlclZhbHVlID0gMDsgWCA9IGNsYXNzIHsgc2V0IDIoeCkgeyBzZXR0ZXJW YWx1ZSA9IHg7IH0gfTsgKG5ldyBYKVsyXSA9IDIyOyBzZXR0ZXJWYWx1ZSBpcyAyMgorUEFTUyBY WzJdID0gMjM7IHNldHRlclZhbHVlIGlzIDIyCiBQQVNTIHNldHRlclZhbHVlID0gMDsgWCA9IGNs YXNzIHsgc3RhdGljIHNldCAzKHgpIHsgc2V0dGVyVmFsdWUgPSB4OyB9IH07IFhbM10gPSAyMzsg c2V0dGVyVmFsdWUgaXMgMjMKIFBBU1MgKG5ldyBYKVszXSA9IDIzOyBzZXR0ZXJWYWx1ZSBpcyAy MwogUEFTUyBYID0gY2xhc3MgeyBnZXQgNCgpIHsgcmV0dXJuIDI0IH0gc2V0IDQoeCkgeyB9IH07 IHggPSBuZXcgWDsgeFs0XSBpcyAyNAogUEFTUyBYWzRdIGlzIHVuZGVmaW5lZAotRkFJTCBzZXR0 ZXJWYWx1ZSA9IDA7IFggPSBjbGFzcyB7IGdldCA1KCkgeyB9IHNldCA1KHgpIHsgc2V0dGVyVmFs dWUgPSB4OyB9IH07IChuZXcgWClbNV0gPSAyNTsgc2V0dGVyVmFsdWUgc2hvdWxkIGJlIDI1LiBX YXMgMC4KLUZBSUwgWFs1XSA9IDI2OyBzZXR0ZXJWYWx1ZSBzaG91bGQgYmUgMjUuIFdhcyAwLgor UEFTUyBzZXR0ZXJWYWx1ZSA9IDA7IFggPSBjbGFzcyB7IGdldCA1KCkgeyB9IHNldCA1KHgpIHsg c2V0dGVyVmFsdWUgPSB4OyB9IH07IChuZXcgWClbNV0gPSAyNTsgc2V0dGVyVmFsdWUgaXMgMjUK K1BBU1MgWFs1XSA9IDI2OyBzZXR0ZXJWYWx1ZSBpcyAyNQogUEFTUyBYID0gY2xhc3MgeyBzdGF0 aWMgc2V0IDYoeCkgeyB9IHN0YXRpYyBnZXQgNigpIHsgcmV0dXJuIDI2IH0gfTsgWFs2XSBpcyAy NgogUEFTUyAobmV3IFgpWzZdIGlzIHVuZGVmaW5lZAogUEFTUyBzZXR0ZXJWYWx1ZSA9IDA7IFgg PSBjbGFzcyB7IHN0YXRpYyBzZXQgNyh4KSB7IHNldHRlclZhbHVlID0geCB9IHN0YXRpYyBnZXQg NygpIHsgfSB9OyBYWzddID0gMjc7IHNldHRlclZhbHVlIGlzIDI3Cg==