144239 2015-04-26 16:24:39 -0700 Web Inspector: Don't use treeElement.revealAndSelect when showing a default content view 2015-04-26 18:25:53 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 timothy timothy commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1088866 0 timothy 2015-04-26 16:24:39 -0700 Using revealAndSelect will end up calling WebInspector.showRepresentedObject. That is not bad is most cases, but if the select tab supports the same represented object, it can end up showing the content view in the wrong tab. 1088867 1 251712 timothy 2015-04-26 16:26:23 -0700 Created attachment 251712 Patch 1088889 2 251712 commit-queue 2015-04-26 18:25:49 -0700 Comment on attachment 251712 Patch Clearing flags on attachment: 251712 Committed r183375: <http://trac.webkit.org/changeset/183375> 1088890 3 commit-queue 2015-04-26 18:25:53 -0700 All reviewed patches have been landed. Closing bug. 251712 2015-04-26 16:26:23 -0700 2015-04-26 18:25:49 -0700 Patch bug-144239-20150426162515.patch text/plain 7581 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzMzQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAy YmZhZjNhNTFiMGI4NTI1NzcyMjI5N2VjNDk2ZGU1NDVjNjUwMGRkLi5jZDlhODcyMTk4OGVjMWEw NGUyMGFlMTJhM2I2Yjc1Y2Q2YTVkZmMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwzMSBAQAogMjAxNS0wNC0yNiAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRG9uJ3QgdXNlIHRyZWVFbGVtZW50LnJldmVh bEFuZFNlbGVjdCB3aGVuIHNob3dpbmcgYSBkZWZhdWx0IGNvbnRlbnQgdmlldworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0MjM5CisKKyAgICAgICAg VXNpbmcgcmV2ZWFsQW5kU2VsZWN0IHdpbGwgZW5kIHVwIGNhbGxpbmcgV2ViSW5zcGVjdG9yLnNo b3dSZXByZXNlbnRlZE9iamVjdC4gVGhhdCBpcyBub3QgYmFkCisgICAgICAgIGlzIG1vc3QgY2Fz ZXMsIGJ1dCBpZiB0aGUgc2VsZWN0IHRhYiBzdXBwb3J0cyB0aGUgc2FtZSByZXByZXNlbnRlZCBv YmplY3QsIGl0IGNhbiBlbmQgdXAgc2hvd2luZworICAgICAgICB0aGUgY29udGVudCB2aWV3IGlu IHRoZSB3cm9uZyB0YWIuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnRlbnRCcm93c2VyVGFiQ29udGVudFZp ZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29udGVudEJyb3dzZXJUYWJDb250ZW50Vmll dy5wcm90b3R5cGUuX3JldmVhbEFuZFNlbGVjdFJlcHJlc2VudGVkT2JqZWN0SW5OYXZpZ2F0aW9u U2lkZWJhcik6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9EZWJ1Z2dlclNpZGViYXJQ YW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5EZWJ1Z2dlclNpZGViYXJQYW5lbC5wcm90 b3R5cGUuc2hvd0RlZmF1bHRDb250ZW50Vmlldyk6CisgICAgICAgICogVXNlckludGVyZmFjZS9W aWV3cy9OYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5h dmlnYXRpb25TaWRlYmFyUGFuZWwucHJvdG90eXBlLnNob3dEZWZhdWx0Q29udGVudFZpZXdGb3JU cmVlRWxlbWVudCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTmF2aWdhdGlvblNpZGViYXJQYW5l bC5wcm90b3R5cGUuX2NoZWNrRWxlbWVudHNGb3JQZW5kaW5nVmlld1N0YXRlQ29va2llKToKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5OYXZpZ2F0aW9uU2lkZWJhclBhbmVsKToKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5OYXZpZ2F0aW9uU2lkZWJhclBhbmVsLnByb3RvdHlwZS5zaG93Q29udGVudFZp ZXdGb3JDdXJyZW50U2VsZWN0aW9uKTogRGVsZXRlZC4KKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L1ZpZXdzL1Jlc291cmNlU2lkZWJhclBhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJl c291cmNlU2lkZWJhclBhbmVsLnByb3RvdHlwZS5zaG93RGVmYXVsdENvbnRlbnRWaWV3KToKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5SZXNvdXJjZVNpZGViYXJQYW5lbC5wcm90b3R5cGUuX21haW5G cmFtZURpZENoYW5nZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVzb3VyY2VTaWRlYmFyUGFu ZWwucHJvdG90eXBlLl9tYWluRnJhbWVNYWluUmVzb3VyY2VEaWRDaGFuZ2UuZGVsYXllZFdvcmsp OgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJlc291cmNlU2lkZWJhclBhbmVsLnByb3RvdHlwZS5f bWFpbkZyYW1lTWFpblJlc291cmNlRGlkQ2hhbmdlKToKKworMjAxNS0wNC0yNiAgVGltb3RoeSBI YXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogVGFi Q29udGVudFZpZXcgY2xvc2VkKCkgaXNuJ3QgYmVpbmcgY2FsbGVkIHdoZW4gYSB0YWIgaXMgY2xv c2VkIC8gcmVtb3ZlZAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQ0MjI5CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL0NvbnRlbnRCcm93c2VyVGFiQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db250ZW50QnJvd3NlclRhYkNvbnRlbnRW aWV3LmpzCmluZGV4IDBiNDdkZTU0ODFiZTllNWU4MWMwZjU5MGUyODVmNzBjYzJhNGRiY2EuLjI1 MjdmOTE5ZDZlMjAyZGNkYjk3ZWZhYTliN2Y3OGQxYjQyNmRhYjIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnRlbnRCcm93c2VyVGFiQ29u dGVudFZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvQ29udGVudEJyb3dzZXJUYWJDb250ZW50Vmlldy5qcwpAQCAtMjU2LDcgKzI1Niw3IEBAIFdl Ykluc3BlY3Rvci5Db250ZW50QnJvd3NlclRhYkNvbnRlbnRWaWV3LnByb3RvdHlwZSA9IHsKICAg ICAgICAgdmFyIHRyZWVFbGVtZW50ID0gdGhpcy5uYXZpZ2F0aW9uU2lkZWJhclBhbmVsLnRyZWVF bGVtZW50Rm9yUmVwcmVzZW50ZWRPYmplY3QocmVwcmVzZW50ZWRPYmplY3QpOwogCiAgICAgICAg IGlmICh0cmVlRWxlbWVudCkKLSAgICAgICAgICAgIHRyZWVFbGVtZW50LnJldmVhbEFuZFNlbGVj dCh0cnVlLCBmYWxzZSwgZmFsc2UsIHRydWUpOworICAgICAgICAgICAgdHJlZUVsZW1lbnQucmV2 ZWFsQW5kU2VsZWN0KHRydWUsIGZhbHNlLCB0cnVlLCB0cnVlKTsKICAgICAgICAgZWxzZSBpZiAo dGhpcy5uYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmNvbnRlbnRUcmVlT3V0bGluZS5zZWxlY3RlZFRy ZWVFbGVtZW50KQogICAgICAgICAgICAgdGhpcy5uYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmNvbnRl bnRUcmVlT3V0bGluZS5zZWxlY3RlZFRyZWVFbGVtZW50LmRlc2VsZWN0KHRydWUpOwogICAgIH0K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0Rl YnVnZ2VyU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvRGVidWdnZXJTaWRlYmFyUGFuZWwuanMKaW5kZXggNjE5ZGRiYzUxZjE1NjQwZTMx NWMwMWFmODQ2NWFhMWZlODZiZDI5OC4uNmI2MjgzMjEyY2VmZjg2N2I2YjNiYjlmNmVjM2I4MWI1 MjI2MGFhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvRGVidWdnZXJTaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvRGVidWdnZXJTaWRlYmFyUGFuZWwuanMKQEAgLTE4NCw3ICsx ODQsNyBAQCBXZWJJbnNwZWN0b3IuRGVidWdnZXJTaWRlYmFyUGFuZWwgPSBjbGFzcyBEZWJ1Z2dl clNpZGViYXJQYW5lbCBleHRlbmRzIFdlYkluc3BlYwogICAgICAgICB2YXIgY3VycmVudFRyZWVF bGVtZW50ID0gdGhpcy5fY29udGVudFRyZWVPdXRsaW5lLmNoaWxkcmVuWzBdOwogICAgICAgICB3 aGlsZSAoY3VycmVudFRyZWVFbGVtZW50ICYmICFjdXJyZW50VHJlZUVsZW1lbnQucm9vdCkgewog ICAgICAgICAgICAgaWYgKGN1cnJlbnRUcmVlRWxlbWVudCBpbnN0YW5jZW9mIFdlYkluc3BlY3Rv ci5SZXNvdXJjZVRyZWVFbGVtZW50IHx8IGN1cnJlbnRUcmVlRWxlbWVudCBpbnN0YW5jZW9mIFdl Ykluc3BlY3Rvci5TY3JpcHRUcmVlRWxlbWVudCkgewotICAgICAgICAgICAgICAgIGN1cnJlbnRU cmVlRWxlbWVudC5yZXZlYWxBbmRTZWxlY3QoKTsKKyAgICAgICAgICAgICAgICB0aGlzLnNob3dE ZWZhdWx0Q29udGVudFZpZXdGb3JUcmVlRWxlbWVudChjdXJyZW50VHJlZUVsZW1lbnQpOwogICAg ICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmF2aWdhdGlvblNpZGViYXJQYW5l bC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05hdmlnYXRp b25TaWRlYmFyUGFuZWwuanMKaW5kZXggMmI1MWM5ZWNmMzNjYzg3YzVhZTNkN2I5ZjEzNzE5M2Fj YWQwYmMzNi4uNjUyZDk5ZTk4MTM5MzIzNTBhNmQwMDZlOWFlMzRjMmIxMmRhYmFlNCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmF2aWdhdGlv blNpZGViYXJQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9OYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzCkBAIC0xNzMsMTIgKzE3MywxNCBAQCBX ZWJJbnNwZWN0b3IuTmF2aWdhdGlvblNpZGViYXJQYW5lbCA9IGNsYXNzIE5hdmlnYXRpb25TaWRl YmFyUGFuZWwgZXh0ZW5kcyBXZWJJbgogICAgICAgICAvLyBJbXBsZW1uZXRlZCBieSBzdWJjbGFz c2VzIGlmIG5lZWRlZCB0byBzaG93IGEgY29udGVudCB2aWV3IHdoZW4gbm8gZXhpc3RpbmcgdHJl ZSBlbGVtZW50IGlzIHNlbGVjdGVkLgogICAgIH0KIAotICAgIHNob3dDb250ZW50Vmlld0ZvckN1 cnJlbnRTZWxlY3Rpb24oKQorICAgIHNob3dEZWZhdWx0Q29udGVudFZpZXdGb3JUcmVlRWxlbWVu dCh0cmVlRWxlbWVudCkKICAgICB7Ci0gICAgICAgIC8vIFJlc2VsZWN0IHRoZSBzZWxlY3RlZCB0 cmVlIGVsZW1lbnQgdG8gY2F1c2UgdGhlIGNvbnRlbnQgdmlldyB0byBiZSBzaG93biBhcyB3ZWxs LiA8cmRhcjovL3Byb2JsZW0vMTA4NTQ3Mjc+Ci0gICAgICAgIHZhciBzZWxlY3RlZFRyZWVFbGVt ZW50ID0gdGhpcy5fY29udGVudFRyZWVPdXRsaW5lLnNlbGVjdGVkVHJlZUVsZW1lbnQ7Ci0gICAg ICAgIGlmIChzZWxlY3RlZFRyZWVFbGVtZW50KQotICAgICAgICAgICAgc2VsZWN0ZWRUcmVlRWxl bWVudC5zZWxlY3QoKTsKKyAgICAgICAgY29uc29sZS5hc3NlcnQodHJlZUVsZW1lbnQpOworICAg ICAgICBjb25zb2xlLmFzc2VydCh0cmVlRWxlbWVudC5yZXByZXNlbnRlZE9iamVjdCk7CisgICAg ICAgIGlmICghdHJlZUVsZW1lbnQgfHwgIXRyZWVFbGVtZW50LnJlcHJlc2VudGVkT2JqZWN0KQor ICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB0aGlzLmNvbnRlbnRCcm93c2VyLnNob3dDb250 ZW50Vmlld0ZvclJlcHJlc2VudGVkT2JqZWN0KHRyZWVFbGVtZW50LnJlcHJlc2VudGVkT2JqZWN0 KTsKKyAgICAgICAgdHJlZUVsZW1lbnQucmV2ZWFsQW5kU2VsZWN0KHRydWUsIGZhbHNlLCB0cnVl LCB0cnVlKTsKICAgICB9CiAKICAgICBzYXZlU3RhdGVUb0Nvb2tpZShjb29raWUpCkBAIC02ODgs NyArNjkwLDcgQEAgV2ViSW5zcGVjdG9yLk5hdmlnYXRpb25TaWRlYmFyUGFuZWwgPSBjbGFzcyBO YXZpZ2F0aW9uU2lkZWJhclBhbmVsIGV4dGVuZHMgV2ViSW4KICAgICAgICAgfSwgdGhpcyk7CiAK ICAgICAgICAgaWYgKG1hdGNoZWRFbGVtZW50KSB7Ci0gICAgICAgICAgICBtYXRjaGVkRWxlbWVu dC5yZXZlYWxBbmRTZWxlY3QoKTsKKyAgICAgICAgICAgIHRoaXMuc2hvd0RlZmF1bHRDb250ZW50 Vmlld0ZvclRyZWVFbGVtZW50KG1hdGNoZWRFbGVtZW50KTsKIAogICAgICAgICAgICAgZGVsZXRl IHRoaXMuX3BlbmRpbmdWaWV3U3RhdGVDb29raWU7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlU2lkZWJhclBhbmVsLmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVzb3VyY2VTaWRlYmFy UGFuZWwuanMKaW5kZXggODFlMmE5MjIwYjYwZTkwYzZjNmY2YjIxMjlkNjI2NDI5YmJjNjE1YS4u ZDE5NDc4N2Q4NzY1ODg3YjJkM2Y0ZWRiNjFiZmUwNWNlYWFhMDIwYSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVzb3VyY2VTaWRlYmFyUGFu ZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVz b3VyY2VTaWRlYmFyUGFuZWwuanMKQEAgLTg1LDcgKzg1LDcgQEAgV2ViSW5zcGVjdG9yLlJlc291 cmNlU2lkZWJhclBhbmVsID0gY2xhc3MgUmVzb3VyY2VTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXZWJJ bnNwZWMKIAogICAgICAgICB2YXIgZmlyc3RUcmVlRWxlbWVudCA9IHRoaXMuY29udGVudFRyZWVP dXRsaW5lLmNoaWxkcmVuWzBdOwogICAgICAgICBpZiAoZmlyc3RUcmVlRWxlbWVudCkKLSAgICAg ICAgICAgIGZpcnN0VHJlZUVsZW1lbnQucmV2ZWFsQW5kU2VsZWN0KCk7CisgICAgICAgICAgICB0 aGlzLnNob3dEZWZhdWx0Q29udGVudFZpZXdGb3JUcmVlRWxlbWVudChmaXJzdFRyZWVFbGVtZW50 KTsKICAgICB9CiAKICAgICB0cmVlRWxlbWVudEZvclJlcHJlc2VudGVkT2JqZWN0KHJlcHJlc2Vu dGVkT2JqZWN0KQpAQCAtMTg0LDcgKzE4NCw3IEBAIFdlYkluc3BlY3Rvci5SZXNvdXJjZVNpZGVi YXJQYW5lbCA9IGNsYXNzIFJlc291cmNlU2lkZWJhclBhbmVsIGV4dGVuZHMgV2ViSW5zcGVjCiAg ICAgICAgICAgICAgICAgdmFyIHRyZWVFbGVtZW50ID0gY3VycmVudENvbnRlbnRWaWV3ID8gdGhp cy50cmVlRWxlbWVudEZvclJlcHJlc2VudGVkT2JqZWN0KGN1cnJlbnRDb250ZW50Vmlldy5yZXBy ZXNlbnRlZE9iamVjdCkgOiBudWxsOwogICAgICAgICAgICAgICAgIGlmICghdHJlZUVsZW1lbnQp CiAgICAgICAgICAgICAgICAgICAgIHRyZWVFbGVtZW50ID0gdGhpcy5fbWFpbkZyYW1lVHJlZUVs ZW1lbnQ7Ci0gICAgICAgICAgICAgICAgdHJlZUVsZW1lbnQucmV2ZWFsQW5kU2VsZWN0KHRydWUs IGZhbHNlLCAhIWN1cnJlbnRDb250ZW50VmlldywgdHJ1ZSk7CisgICAgICAgICAgICAgICAgdGhp cy5zaG93RGVmYXVsdENvbnRlbnRWaWV3Rm9yVHJlZUVsZW1lbnQodHJlZUVsZW1lbnQpOwogICAg ICAgICAgICAgfQogICAgICAgICB9CiAKQEAgLTIyMCw3ICsyMjAsNyBAQCBXZWJJbnNwZWN0b3Iu UmVzb3VyY2VTaWRlYmFyUGFuZWwgPSBjbGFzcyBSZXNvdXJjZVNpZGViYXJQYW5lbCBleHRlbmRz IFdlYkluc3BlYwogICAgICAgICAgICAgaWYgKCF0aGlzLmNvbnRlbnRCcm93c2VyLmN1cnJlbnRD b250ZW50VmlldyB8fCB3YXNTaG93aW5nUmVzb3VyY2VDb250ZW50VmlldykgewogICAgICAgICAg ICAgICAgIC8vIE5PVEU6IFRoaXMgc2VsZWN0aW9uLCBkdXJpbmcgcHJvdmlzaW9uYWwgbG9hZGlu Zywgd29uJ3QgYmUgc2F2ZWQsIHNvIGl0IGlzCiAgICAgICAgICAgICAgICAgLy8gc2FmZSB0byBk byBhbmQgbm90LWNsb2JiZXIgY29va2llIHJlc3RvcmF0aW9uLgotICAgICAgICAgICAgICAgIHRo aXMuX21haW5GcmFtZVRyZWVFbGVtZW50LnJldmVhbEFuZFNlbGVjdCh0cnVlLCBmYWxzZSk7Cisg ICAgICAgICAgICAgICAgdGhpcy5zaG93RGVmYXVsdENvbnRlbnRWaWV3Rm9yVHJlZUVsZW1lbnQo dGhpcy5fbWFpbkZyYW1lVHJlZUVsZW1lbnQpOwogICAgICAgICAgICAgfQogICAgICAgICB9CiAK