144233 2015-04-26 13:01:27 -0700 REGRESSION (r182952): Plug-in service fails to load because it links against WebKit2.framework 2015-04-26 13:24:44 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mitz mitz oldest_to_newest 1088821 0 mitz 2015-04-26 13:01:27 -0700 <rdar://problem/20702337> 1088822 1 251704 mitz 2015-04-26 13:07:02 -0700 Created attachment 251704 Link against WebKit.framework instead of WebKit2.framework 1088823 2 251704 simon.fraser 2015-04-26 13:09:53 -0700 Comment on attachment 251704 Link against WebKit.framework instead of WebKit2.framework View in context: https://bugs.webkit.org/attachment.cgi?id=251704&action=review > Source/WebKit2/WebKit2.xcodeproj/project.pbxproj:764 > + 371E69591AED7A0F00495E48 /* Foundation.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = BC3DE46815A91763008D26FC /* Foundation.framework */; }; > + 371E695A1AED7A5B00495E48 /* Foundation.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = BC3DE46815A91763008D26FC /* Foundation.framework */; }; Is it OK that this is here twice? 1088824 3 mitz 2015-04-26 13:11:49 -0700 (In reply to comment #2) > Comment on attachment 251704 [details] > Link against WebKit.framework instead of WebKit2.framework > > View in context: > https://bugs.webkit.org/attachment.cgi?id=251704&action=review > > > Source/WebKit2/WebKit2.xcodeproj/project.pbxproj:764 > > + 371E69591AED7A0F00495E48 /* Foundation.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = BC3DE46815A91763008D26FC /* Foundation.framework */; }; > > + 371E695A1AED7A5B00495E48 /* Foundation.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = BC3DE46815A91763008D26FC /* Foundation.framework */; }; > > Is it OK that this is here twice? Yes, one is the item in the 32-bit service’s list and the other is the one in the 64-bit service’s. But I did mix it up in the change log: it’s WebKit, not Foundation, that was already being linked by one of them. I’ll fix that. Thanks! 1088825 4 mitz 2015-04-26 13:24:44 -0700 Fixed in <http://trac.webkit.org/r183360>. 251704 2015-04-26 13:07:02 -0700 2015-04-26 13:09:53 -0700 Link against WebKit.framework instead of WebKit2.framework bug-144233-20150426130554.patch text/plain 5149 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MzM1OSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA0LTI2ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjE4Mjk1Mik6 IFBsdWctaW4gc2VydmljZSBmYWlscyB0byBsb2FkIGJlY2F1c2UgaXQgbGlua3MgYWdhaW5zdCBX ZWJLaXQyLmZyYW1ld29yaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTQ0MjMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgSGF2ZSB0aGUgcGx1Zy1pbiBzZXJ2aWNlIGxpbmsgYWdhaW5zdCBXZWJLaXQuZnJh bWV3b3JrIHJhdGhlciB0aGFuIFdlYktpdDIuZnJhbWV3b3JrLgorCisgICAgICAgICogQ29uZmln dXJhdGlvbnMvUGx1Z2luU2VydmljZS4zMi54Y2NvbmZpZzogUmVtb3ZlZCBsaW5rZXIgZmxhZ3Mg Zm9yIGxpbmtpbmcgYWdhaW5zdCBXZWJLaXQyCisgICAgICAgIGFuZCBGb3VuZGF0aW9uIGZyb20g dGhlIGRlZmluaXRpb24gb2YgT1RIRVJfTERGTEFHUy4gU2luY2UgbGlua2luZyBpcyBubyBsb25n ZXIgY29uZGl0aW9uYWwsCisgICAgICAgIHdlIGNhbiBqdXN0IGRvIGl0IGluIHRoZSB0YXJnZXTi gJlzIExpbmsgQmluYXJ5IFdpdGggTGlicmFyaWVzIGJ1aWxkIHBoYXNlLgorCisgICAgICAgICog Q29uZmlndXJhdGlvbnMvUGx1Z2luU2VydmljZS42NC54Y2NvbmZpZzogRGl0dG8uCisKKyAgICAg ICAgKiBXZWJLaXQyLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2o6IEhhdmUgRm91bmRhdGlvbiBh bmQgV2ViS2l0IGxpc3RlZCBpbiB0aGUgc2VydmljZXPigJkgTGluaworICAgICAgICBCaW5hcml5 IFdpdGggTGlicmFyaWVzIGJ1aWxkIHBoYXNlcyAob25lIHNlcnZpY2UgYWxyZWFkeSBoYWQgRm91 bmRhdGlvbikuCisKIDIwMTUtMDQtMjYgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4K IAogICAgICAgICBGaXhlZCB0aGUgYnVpbGQuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9Db25maWd1 cmF0aW9ucy9QbHVnaW5TZXJ2aWNlLjMyLnhjY29uZmlnCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQyL0NvbmZpZ3VyYXRpb25zL1BsdWdpblNlcnZpY2UuMzIueGNjb25maWcJKHJldmlzaW9u IDE4MzM1MikKKysrIFNvdXJjZS9XZWJLaXQyL0NvbmZpZ3VyYXRpb25zL1BsdWdpblNlcnZpY2Uu MzIueGNjb25maWcJKHdvcmtpbmcgY29weSkKQEAgLTMyLDkgKzMyLDcgQEAgVkFMSURfQVJDSFNf bWFjb3N4X05PID0gaTM4NjsKIFBST0RVQ1RfTkFNRSA9IGNvbS5hcHBsZS5XZWJLaXQuUGx1Z2lu LjMyOwogSU5GT1BMSVNUX0ZJTEUgPSBQbHVnaW5Qcm9jZXNzL0VudHJ5UG9pbnQvbWFjL1hQQ1Nl cnZpY2UvUGx1Z2luU2VydmljZS4zMi02NC5JbmZvLnBsaXN0OwogCi1GUkFNRVdPUktfTERGTEFH UyA9IC1mcmFtZXdvcmsgRm91bmRhdGlvbiAtZnJhbWV3b3JrIFdlYktpdDI7Ci0KLU9USEVSX0xE RkxBR1MgPSAkKEZSQU1FV09SS19MREZMQUdTKSAkKE9USEVSX0xERkxBR1MpICQoT1RIRVJfTERG TEFHU19QTEFURk9STSkgJChPVEhFUl9MREZMQUdTX1ZFUlNJT05FRF9GUkFNRVdPUktfUEFUSCk7 CitPVEhFUl9MREZMQUdTID0gJChPVEhFUl9MREZMQUdTKSAkKE9USEVSX0xERkxBR1NfUExBVEZP Uk0pICQoT1RIRVJfTERGTEFHU19WRVJTSU9ORURfRlJBTUVXT1JLX1BBVEgpOwogT1RIRVJfTERG TEFHU19QTEFURk9STVtzZGs9bWFjb3N4Kl0gPSAtZnJhbWV3b3JrIEFwcEtpdDsKIAogQ09ERV9T SUdOX0VOVElUTEVNRU5UUyA9IENvbmZpZ3VyYXRpb25zL1BsdWdpblNlcnZpY2UuZW50aXRsZW1l bnRzOwpJbmRleDogU291cmNlL1dlYktpdDIvQ29uZmlndXJhdGlvbnMvUGx1Z2luU2VydmljZS42 NC54Y2NvbmZpZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9Db25maWd1cmF0aW9ucy9Q bHVnaW5TZXJ2aWNlLjY0LnhjY29uZmlnCShyZXZpc2lvbiAxODMzNTIpCisrKyBTb3VyY2UvV2Vi S2l0Mi9Db25maWd1cmF0aW9ucy9QbHVnaW5TZXJ2aWNlLjY0LnhjY29uZmlnCSh3b3JraW5nIGNv cHkpCkBAIC0zMiw5ICszMiw3IEBAIFZBTElEX0FSQ0hTX21hY29zeF9OTyA9IHg4Nl82NDsKIFBS T0RVQ1RfTkFNRSA9IGNvbS5hcHBsZS5XZWJLaXQuUGx1Z2luLjY0OwogSU5GT1BMSVNUX0ZJTEUg PSBQbHVnaW5Qcm9jZXNzL0VudHJ5UG9pbnQvbWFjL1hQQ1NlcnZpY2UvUGx1Z2luU2VydmljZS4z Mi02NC5JbmZvLnBsaXN0OwogCi1GUkFNRVdPUktfTERGTEFHUyA9IC1mcmFtZXdvcmsgRm91bmRh dGlvbiAtZnJhbWV3b3JrIFdlYktpdDI7Ci0KLU9USEVSX0xERkxBR1MgPSAkKEZSQU1FV09SS19M REZMQUdTKSAkKE9USEVSX0xERkxBR1MpICQoT1RIRVJfTERGTEFHU19QTEFURk9STSkgJChPVEhF Ul9MREZMQUdTX1ZFUlNJT05FRF9GUkFNRVdPUktfUEFUSCk7CitPVEhFUl9MREZMQUdTID0gJChP VEhFUl9MREZMQUdTKSAkKE9USEVSX0xERkxBR1NfUExBVEZPUk0pICQoT1RIRVJfTERGTEFHU19W RVJTSU9ORURfRlJBTUVXT1JLX1BBVEgpOwogT1RIRVJfTERGTEFHU19QTEFURk9STVtzZGs9bWFj b3N4Kl0gPSAtZnJhbWV3b3JrIEFwcEtpdDsKIAogQ09ERV9TSUdOX0VOVElUTEVNRU5UUyA9IENv bmZpZ3VyYXRpb25zL1BsdWdpblNlcnZpY2UuZW50aXRsZW1lbnRzOwpJbmRleDogU291cmNlL1dl YktpdDIvV2ViS2l0Mi54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQyL1dlYktpdDIueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagkocmV2aXNpb24g MTgzMzUyKQorKysgU291cmNlL1dlYktpdDIvV2ViS2l0Mi54Y29kZXByb2ovcHJvamVjdC5wYnhw cm9qCSh3b3JraW5nIGNvcHkpCkBAIC03NjAsNiArNzYwLDkgQEAKIAkJMzcxODNENTcxODJGNEU3 MDAwODBDODExIC8qIFdLTlNVUkxFeHRyYXMuaCBpbiBIZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1 aWxkRmlsZTsgZmlsZVJlZiA9IDM3MTgzRDU1MTgyRjRFNzAwMDgwQzgxMSAvKiBXS05TVVJMRXh0 cmFzLmggKi87IH07CiAJCTM3MUExOTQxMTgyNEQyOTMwMEYzMkE1RSAvKiBXS05TRGljdGlvbmFy eS5tbSBpbiBTb3VyY2VzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDM3MUEx OTNGMTgyNEQyOTMwMEYzMkE1RSAvKiBXS05TRGljdGlvbmFyeS5tbSAqLzsgfTsKIAkJMzcxQTE5 NDIxODI0RDI5MzAwRjMyQTVFIC8qIFdLTlNEaWN0aW9uYXJ5LmggaW4gSGVhZGVycyAqLyA9IHtp c2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSAzNzFBMTk0MDE4MjREMjkzMDBGMzJBNUUgLyog V0tOU0RpY3Rpb25hcnkuaCAqLzsgfTsKKwkJMzcxRTY5NTkxQUVEN0EwRjAwNDk1RTQ4IC8qIEZv dW5kYXRpb24uZnJhbWV3b3JrIGluIEZyYW1ld29ya3MgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxl OyBmaWxlUmVmID0gQkMzREU0NjgxNUE5MTc2MzAwOEQyNkZDIC8qIEZvdW5kYXRpb24uZnJhbWV3 b3JrICovOyB9OworCQkzNzFFNjk1QTFBRUQ3QTVCMDA0OTVFNDggLyogRm91bmRhdGlvbi5mcmFt ZXdvcmsgaW4gRnJhbWV3b3JrcyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSBC QzNERTQ2ODE1QTkxNzYzMDA4RDI2RkMgLyogRm91bmRhdGlvbi5mcmFtZXdvcmsgKi87IH07CisJ CTM3MUU2OTVCMUFFRDdBNjcwMDQ5NUU0OCAvKiBXZWJLaXQuZnJhbWV3b3JrIGluIEZyYW1ld29y a3MgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gOERDMkVGNUIwNDg2QTY5NDAw OThCMjE2IC8qIFdlYktpdC5mcmFtZXdvcmsgKi87IH07CiAJCTM3MkNBRjBCMTgzM0ZEOTEwMDQw QUMyNyAvKiBXS05TRXJyb3IuaCBpbiBIZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsg ZmlsZVJlZiA9IDM3MkNBRjA5MTgzM0ZEOTEwMDQwQUMyNyAvKiBXS05TRXJyb3IuaCAqLzsgfTsK IAkJMzcyQ0FGMEMxODMzRkQ5MTAwNDBBQzI3IC8qIFdLTlNFcnJvci5tbSBpbiBTb3VyY2VzICov ID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDM3MkNBRjBBMTgzM0ZEOTEwMDQwQUMy NyAvKiBXS05TRXJyb3IubW0gKi87IH07CiAJCTM3M0NFQUQ1MTg1NDE3QUUwMDhDMzYzRCAvKiBX S05TRGF0YS5tbSBpbiBTb3VyY2VzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9 IDM3M0NFQUQzMTg1NDE3QUUwMDhDMzYzRCAvKiBXS05TRGF0YS5tbSAqLzsgfTsKQEAgLTQxODks NiArNDE5Miw4IEBACiAJCQlpc2EgPSBQQlhGcmFtZXdvcmtzQnVpbGRQaGFzZTsKIAkJCWJ1aWxk QWN0aW9uTWFzayA9IDIxNDc0ODM2NDc7CiAJCQlmaWxlcyA9ICgKKwkJCQkzNzFFNjk1QTFBRUQ3 QTVCMDA0OTVFNDggLyogRm91bmRhdGlvbi5mcmFtZXdvcmsgaW4gRnJhbWV3b3JrcyAqLywKKwkJ CQkzNzFFNjk1QjFBRUQ3QTY3MDA0OTVFNDggLyogV2ViS2l0LmZyYW1ld29yayBpbiBGcmFtZXdv cmtzICovLAogCQkJKTsKIAkJCXJ1bk9ubHlGb3JEZXBsb3ltZW50UG9zdHByb2Nlc3NpbmcgPSAw OwogCQl9OwpAQCAtNDE5Niw2ICs0MjAxLDcgQEAKIAkJCWlzYSA9IFBCWEZyYW1ld29ya3NCdWls ZFBoYXNlOwogCQkJYnVpbGRBY3Rpb25NYXNrID0gMjE0NzQ4MzY0NzsKIAkJCWZpbGVzID0gKAor CQkJCTM3MUU2OTU5MUFFRDdBMEYwMDQ5NUU0OCAvKiBGb3VuZGF0aW9uLmZyYW1ld29yayBpbiBG cmFtZXdvcmtzICovLAogCQkJCUJDODI4NDRGMTZCNTA4OTgwMEEyNzhGRSAvKiBXZWJLaXQuZnJh bWV3b3JrIGluIEZyYW1ld29ya3MgKi8sCiAJCQkpOwogCQkJcnVuT25seUZvckRlcGxveW1lbnRQ b3N0cHJvY2Vzc2luZyA9IDA7Cg==