144229 2015-04-26 11:13:27 -0700 Web Inspector: TabContentView closed() isn't being called when a tab is closed / removed 2015-04-27 14:30:12 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1088784 0 timothy 2015-04-26 11:13:27 -0700 There can be event listener leaks because closed() is never being called. 1088785 1 webkit-bug-importer 2015-04-26 11:13:36 -0700 <rdar://problem/20702147> 1088786 2 251700 timothy 2015-04-26 11:15:21 -0700 Created attachment 251700 Patch 1089164 3 251700 joepeck 2015-04-27 13:41:32 -0700 Comment on attachment 251700 Patch Good fix! r=me! 1089192 4 251700 commit-queue 2015-04-27 14:30:10 -0700 Comment on attachment 251700 Patch Clearing flags on attachment: 251700 Committed r183422: <http://trac.webkit.org/changeset/183422> 1089193 5 commit-queue 2015-04-27 14:30:12 -0700 All reviewed patches have been landed. Closing bug. 251700 2015-04-26 11:15:21 -0700 2015-04-27 14:30:10 -0700 Patch bug-144229-20150426111413.patch text/plain 1923 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzMzQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAw NjEwNTE0YmI0MjA5MTdkYmE1YjQ1NWEyNWQ2MzM4OTJhZTBjMTY4Li4yYmZhZjNhNTFiMGI4NTI1 NzcyMjI5N2VjNDk2ZGU1NDVjNjUwMGRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNyBAQAogMjAxNS0wNC0yNiAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVGFiQ29udGVudFZpZXcgY2xvc2VkKCkgaXNu J3QgYmVpbmcgY2FsbGVkIHdoZW4gYSB0YWIgaXMgY2xvc2VkIC8gcmVtb3ZlZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0MjI5CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1Zp ZXdzL0NvbnRlbnRWaWV3Q29udGFpbmVyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbnRl bnRWaWV3Q29udGFpbmVyLnByb3RvdHlwZS5fZGlzYXNzb2NpYXRlRnJvbUNvbnRlbnRWaWV3KToK KyAgICAgICAgVGFiQ29udGVudFZpZXdzIGRvbid0IGhhdmUgYSByZXByZXNlbnRlZE9iamVjdCwg c28gcmV0dXJuaW5nIGVhcmx5IGFuZCBub3QKKyAgICAgICAgY2FsbGluZyBjbG9zZWQoKSB3YXMg bm90IGNvcnJlY3QuCisKKzIwMTUtMDQtMjYgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBw bGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEVsZW1lbnRzIHRhYiBkZXRhaWxzIHNp ZGViYXIgYmVjb21lcyBub24tZXhwYW5kYWJsZSBhZnRlciB1c2luZyBDb25zb2xlIHRhYgogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0MjEyCiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnRl bnRWaWV3Q29udGFpbmVyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvQ29udGVudFZpZXdDb250YWluZXIuanMKaW5kZXggMmE2Nzg5YWRiMjcyZDA1Nzc4ZGRi MjEzN2NjMWQ5NjAyOWMxZDA0Ny4uZmNkMzdiNTE2OWQyNzU2M2U0MDgxZWNhZmZiMzEwNTdkYTI1 MmI5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvQ29udGVudFZpZXdDb250YWluZXIuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvQ29udGVudFZpZXdDb250YWluZXIuanMKQEAgLTQ0NywxMCArNDQ3 LDggQEAgV2ViSW5zcGVjdG9yLkNvbnRlbnRWaWV3Q29udGFpbmVyLnByb3RvdHlwZSA9IHsKICAg ICAgICAgY29udGVudFZpZXcuX3BhcmVudENvbnRhaW5lciA9IG51bGw7CiAKICAgICAgICAgdmFy IHJlcHJlc2VudGVkT2JqZWN0ID0gY29udGVudFZpZXcucmVwcmVzZW50ZWRPYmplY3Q7Ci0gICAg ICAgIGlmICghcmVwcmVzZW50ZWRPYmplY3QgfHwgIXJlcHJlc2VudGVkT2JqZWN0Ll9fY29udGVu dFZpZXdzKQotICAgICAgICAgICAgcmV0dXJuOwotCi0gICAgICAgIHJlcHJlc2VudGVkT2JqZWN0 Ll9fY29udGVudFZpZXdzLnJlbW92ZShjb250ZW50Vmlldyk7CisgICAgICAgIGlmIChyZXByZXNl bnRlZE9iamVjdCAmJiByZXByZXNlbnRlZE9iamVjdC5fX2NvbnRlbnRWaWV3cykKKyAgICAgICAg ICAgIHJlcHJlc2VudGVkT2JqZWN0Ll9fY29udGVudFZpZXdzLnJlbW92ZShjb250ZW50Vmlldyk7 CiAKICAgICAgICAgY29udGVudFZpZXcuY2xvc2VkKCk7CiAgICAgfSwK