144223 2015-04-26 06:50:49 -0700 [WK2] API::Point, API::Size, API::Rect creation functions should return Ref<> 2015-04-27 23:36:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan oldest_to_newest 1088750 0 zan 2015-04-26 06:50:49 -0700 API::Point, API::Size, API::Rect creation functions should return Ref<> 1088751 1 251687 zan 2015-04-26 06:52:30 -0700 Created attachment 251687 Patch 1088760 2 251694 zan 2015-04-26 07:10:28 -0700 Created attachment 251694 Patch 1089420 3 251694 zan 2015-04-27 23:36:51 -0700 Comment on attachment 251694 Patch Clearing flags on attachment: 251694 Committed r183460: <http://trac.webkit.org/changeset/183460> 1089421 4 zan 2015-04-27 23:36:58 -0700 All reviewed patches have been landed. Closing bug. 251687 2015-04-26 06:52:30 -0700 2015-04-26 07:10:22 -0700 Patch bug-144223-20150426155123.patch text/plain 3281 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzMzUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTUwODgyZTc0MTE2ZTM5 NzJhZDkzYjZjYTVjYTBjYTZiODI2MDEzNC4uNzAxNzkyMzdjZTM2NTA1MmUzYzg2YzZhYTFlZjA4 ZjVmMGQwNWFmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTA0LTI2ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBBUEk6OlBvaW50LCBB UEk6OlNpemUsIEFQSTo6UmVjdCBjcmVhdGlvbiBmdW5jdGlvbnMgc2hvdWxkIHJldHVybiBSZWY8 PgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0MjIz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSGF2ZSBB UEk6OlBvaW50LCBBUEk6OlNpemUgYW5kIEFQSTo6UmVjdCBjcmVhdGlvbiBmdW5jdGlvbnMgcmV0 dXJuIFJlZjw+LgorICAgICAgICBDYWxsLXNpdGVzIGFyZSBhbHNvIHVwZGF0ZWQsIHVzaW5nIGFu ZCBvcGVyYXRpbmcgb24gdGhlIHJldHVybmVkIFJlZjw+IG9iamVjdAorICAgICAgICB3aGVyZSBw b3NzaWJsZS4KKworICAgICAgICAqIFNoYXJlZC9BUEkvQVBJR2VvbWV0cnkuaDoKKyAgICAgICAg KEFQSTo6U2l6ZTo6Y3JlYXRlKToKKyAgICAgICAgKEFQSTo6UG9pbnQ6OmNyZWF0ZSk6CisgICAg ICAgIChBUEk6OlJlY3Q6OmNyZWF0ZSk6CisgICAgICAgICogU2hhcmVkL0FQSS9jL1dLR2VvbWV0 cnkuY3BwOgorICAgICAgICAoV0tQb2ludENyZWF0ZSk6CisgICAgICAgIChXS1NpemVDcmVhdGUp OgorICAgICAgICAoV0tSZWN0Q3JlYXRlKToKKwogMjAxNS0wNC0yNSAgVGltIEhvcnRvbiAgPHRp bW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBGdXJ0aGVyIHVwZGF0ZSBnZXN0dXJl IHN3aXBlIHNoYWRvdyBzdHlsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQ SS9BUElHZW9tZXRyeS5oIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9BUElHZW9tZXRyeS5o CmluZGV4IDJlZmNiNDdjMTRhMzM4NTUwOTgxMjVmMmU3YzA4Y2VmMTNiYWFlMzMuLmQ2YmRlYzA5 OWNlZGNhNGM1OTg3NGJjMWMzMmVlMzc3YWRmOWYzY2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1NoYXJlZC9BUEkvQVBJR2VvbWV0cnkuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQv QVBJL0FQSUdlb21ldHJ5LmgKQEAgLTQwLDkgKzQwLDkgQEAgbmFtZXNwYWNlIEFQSSB7CiAKIGNs YXNzIFNpemUgOiBwdWJsaWMgQVBJOjpPYmplY3RJbXBsPEFQSTo6T2JqZWN0OjpUeXBlOjpTaXpl PiB7CiBwdWJsaWM6Ci0gICAgc3RhdGljIFBhc3NSZWZQdHI8U2l6ZT4gY3JlYXRlKGNvbnN0IFdL U2l6ZSYgc2l6ZSkKKyAgICBzdGF0aWMgUmVmPFNpemU+IGNyZWF0ZShjb25zdCBXS1NpemUmIHNp emUpCiAgICAgewotICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IFNpemUoc2l6ZSkpOworICAg ICAgICByZXR1cm4gYWRvcHRSZWYoKm5ldyBTaXplKHNpemUpKTsKICAgICB9CiAKICAgICBjb25z dCBXS1NpemUmIHNpemUoKSBjb25zdCB7IHJldHVybiBtX3NpemU7IH0KQEAgLTYxLDkgKzYxLDkg QEAgcHJpdmF0ZToKIAogY2xhc3MgUG9pbnQgOiBwdWJsaWMgQVBJOjpPYmplY3RJbXBsPEFQSTo6 T2JqZWN0OjpUeXBlOjpQb2ludD4gewogcHVibGljOgotICAgIHN0YXRpYyBQYXNzUmVmUHRyPFBv aW50PiBjcmVhdGUoY29uc3QgV0tQb2ludCYgcG9pbnQpCisgICAgc3RhdGljIFJlZjxQb2ludD4g Y3JlYXRlKGNvbnN0IFdLUG9pbnQmIHBvaW50KQogICAgIHsKLSAgICAgICAgcmV0dXJuIGFkb3B0 UmVmKG5ldyBQb2ludChwb2ludCkpOworICAgICAgICByZXR1cm4gYWRvcHRSZWYoKm5ldyBQb2lu dChwb2ludCkpOwogICAgIH0KIAogICAgIGNvbnN0IFdLUG9pbnQmIHBvaW50KCkgY29uc3QgeyBy ZXR1cm4gbV9wb2ludDsgfQpAQCAtODEsOSArODEsOSBAQCBwcml2YXRlOgogCiBjbGFzcyBSZWN0 IDogcHVibGljIEFQSTo6T2JqZWN0SW1wbDxBUEk6Ok9iamVjdDo6VHlwZTo6UmVjdD4gewogcHVi bGljOgotICAgIHN0YXRpYyBQYXNzUmVmUHRyPFJlY3Q+IGNyZWF0ZShjb25zdCBXS1JlY3QmIHJl Y3QpCisgICAgc3RhdGljIFJlZjxSZWN0PiBjcmVhdGUoY29uc3QgV0tSZWN0JiByZWN0KQogICAg IHsKLSAgICAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBSZWN0KHJlY3QpKTsKKyAgICAgICAgcmV0 dXJuIGFkb3B0UmVmKCpuZXcgUmVjdChyZWN0KSk7CiAgICAgfQogCiAgICAgY29uc3QgV0tSZWN0 JiByZWN0KCkgY29uc3QgeyByZXR1cm4gbV9yZWN0OyB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9TaGFyZWQvQVBJL2MvV0tHZW9tZXRyeS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQv QVBJL2MvV0tHZW9tZXRyeS5jcHAKaW5kZXggOTZjM2YxOWY3ZmYyZDdkYmVmMmI5ZTE0ZTAyMTc4 YzA0NzJkYjUzMi4uZTFlYTgyNDM1ZmFlYjEyNzNhMDJkMDEzYmQwZTgwMjFmNTFiM2M1MyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9jL1dLR2VvbWV0cnkuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvYy9XS0dlb21ldHJ5LmNwcApAQCAtNDgsMTcgKzQ4 LDE3IEBAIFdLVHlwZUlEIFdLUmVjdEdldFR5cGVJRCgpCiAKIFdLUG9pbnRSZWYgV0tQb2ludENy ZWF0ZShXS1BvaW50IHBvaW50KQogewotICAgIHJldHVybiB0b0FQSShBUEk6OlBvaW50OjpjcmVh dGUocG9pbnQpLmxlYWtSZWYoKSk7CisgICAgcmV0dXJuIHRvQVBJKCZBUEk6OlBvaW50OjpjcmVh dGUocG9pbnQpLmxlYWtSZWYoKSk7CiB9CiAKIFdLU2l6ZVJlZiBXS1NpemVDcmVhdGUoV0tTaXpl IHNpemUpCiB7Ci0gICAgcmV0dXJuIHRvQVBJKEFQSTo6U2l6ZTo6Y3JlYXRlKHNpemUpLmxlYWtS ZWYoKSk7CisgICAgcmV0dXJuIHRvQVBJKCZBUEk6OlNpemU6OmNyZWF0ZShzaXplKS5sZWFrUmVm KCkpOwogfQogCiBXS1JlY3RSZWYgV0tSZWN0Q3JlYXRlKFdLUmVjdCByZWN0KQogewotICAgIHJl dHVybiB0b0FQSShBUEk6OlJlY3Q6OmNyZWF0ZShyZWN0KS5sZWFrUmVmKCkpOworICAgIHJldHVy biB0b0FQSSgmQVBJOjpSZWN0OjpjcmVhdGUocmVjdCkubGVha1JlZigpKTsKIH0KIAogV0tTaXpl IFdLU2l6ZUdldFZhbHVlKFdLU2l6ZVJlZiBzaXplKQo= 251694 2015-04-26 07:10:28 -0700 2015-04-27 23:36:51 -0700 Patch bug-144223-20150426160920.patch text/plain 3458 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzMzUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTUwODgyZTc0MTE2ZTM5 NzJhZDkzYjZjYTVjYTBjYTZiODI2MDEzNC4uM2YzYWU3OGQ0NDBjMjA1YWRiOWFjMjQ3NjRkNTcx MzkyMWI1OTRlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTA0LTI2ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbV0syXSBBUEk6OlBv aW50LCBBUEk6OlNpemUsIEFQSTo6UmVjdCBjcmVhdGlvbiBmdW5jdGlvbnMgc2hvdWxkIHJldHVy biBSZWY8PgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQ0MjIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SGF2ZSBBUEk6OlBvaW50LCBBUEk6OlNpemUgYW5kIEFQSTo6UmVjdCBjcmVhdGlvbiBmdW5jdGlv bnMgcmV0dXJuIFJlZjw+LgorICAgICAgICBDYWxsLXNpdGVzIGFyZSBhbHNvIHVwZGF0ZWQsIHVz aW5nIGFuZCBvcGVyYXRpbmcgb24gdGhlIHJldHVybmVkIFJlZjw+IG9iamVjdAorICAgICAgICB3 aGVyZSBwb3NzaWJsZS4KKworICAgICAgICAqIFNoYXJlZC9BUEkvQVBJR2VvbWV0cnkuaDoKKyAg ICAgICAgKEFQSTo6U2l6ZTo6Y3JlYXRlKToKKyAgICAgICAgKEFQSTo6UG9pbnQ6OmNyZWF0ZSk6 CisgICAgICAgIChBUEk6OlJlY3Q6OmNyZWF0ZSk6CisgICAgICAgICogU2hhcmVkL0FQSS9jL1dL R2VvbWV0cnkuY3BwOgorICAgICAgICAoV0tQb2ludENyZWF0ZSk6CisgICAgICAgIChXS1NpemVD cmVhdGUpOgorICAgICAgICAoV0tSZWN0Q3JlYXRlKToKKwogMjAxNS0wNC0yNSAgVGltIEhvcnRv biAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBGdXJ0aGVyIHVwZGF0ZSBn ZXN0dXJlIHN3aXBlIHNoYWRvdyBzdHlsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hh cmVkL0FQSS9BUElHZW9tZXRyeS5oIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9BUElHZW9t ZXRyeS5oCmluZGV4IDJlZmNiNDdjMTRhMzM4NTUwOTgxMjVmMmU3YzA4Y2VmMTNiYWFlMzMuLjEy MjIxOTgzYjNhYTgyM2FhNTM0OWQ2YWFkMTc4NmJjMWZhZjRkZjggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1NoYXJlZC9BUEkvQVBJR2VvbWV0cnkuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9T aGFyZWQvQVBJL0FQSUdlb21ldHJ5LmgKQEAgLTI5LDcgKzI5LDYgQEAKICNpbmNsdWRlICJBUElP YmplY3QuaCIKICNpbmNsdWRlICJXS0dlb21ldHJ5LmgiCiAjaW5jbHVkZSA8V2ViQ29yZS9GbG9h dFJlY3QuaD4KLSNpbmNsdWRlIDx3dGYvUGFzc1JlZlB0ci5oPgogCiBuYW1lc3BhY2UgSVBDIHsK IGNsYXNzIEFyZ3VtZW50RGVjb2RlcjsKQEAgLTQwLDkgKzM5LDkgQEAgbmFtZXNwYWNlIEFQSSB7 CiAKIGNsYXNzIFNpemUgOiBwdWJsaWMgQVBJOjpPYmplY3RJbXBsPEFQSTo6T2JqZWN0OjpUeXBl OjpTaXplPiB7CiBwdWJsaWM6Ci0gICAgc3RhdGljIFBhc3NSZWZQdHI8U2l6ZT4gY3JlYXRlKGNv bnN0IFdLU2l6ZSYgc2l6ZSkKKyAgICBzdGF0aWMgUmVmPFNpemU+IGNyZWF0ZShjb25zdCBXS1Np emUmIHNpemUpCiAgICAgewotICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IFNpemUoc2l6ZSkp OworICAgICAgICByZXR1cm4gYWRvcHRSZWYoKm5ldyBTaXplKHNpemUpKTsKICAgICB9CiAKICAg ICBjb25zdCBXS1NpemUmIHNpemUoKSBjb25zdCB7IHJldHVybiBtX3NpemU7IH0KQEAgLTYxLDkg KzYwLDkgQEAgcHJpdmF0ZToKIAogY2xhc3MgUG9pbnQgOiBwdWJsaWMgQVBJOjpPYmplY3RJbXBs PEFQSTo6T2JqZWN0OjpUeXBlOjpQb2ludD4gewogcHVibGljOgotICAgIHN0YXRpYyBQYXNzUmVm UHRyPFBvaW50PiBjcmVhdGUoY29uc3QgV0tQb2ludCYgcG9pbnQpCisgICAgc3RhdGljIFJlZjxQ b2ludD4gY3JlYXRlKGNvbnN0IFdLUG9pbnQmIHBvaW50KQogICAgIHsKLSAgICAgICAgcmV0dXJu IGFkb3B0UmVmKG5ldyBQb2ludChwb2ludCkpOworICAgICAgICByZXR1cm4gYWRvcHRSZWYoKm5l dyBQb2ludChwb2ludCkpOwogICAgIH0KIAogICAgIGNvbnN0IFdLUG9pbnQmIHBvaW50KCkgY29u c3QgeyByZXR1cm4gbV9wb2ludDsgfQpAQCAtODEsOSArODAsOSBAQCBwcml2YXRlOgogCiBjbGFz cyBSZWN0IDogcHVibGljIEFQSTo6T2JqZWN0SW1wbDxBUEk6Ok9iamVjdDo6VHlwZTo6UmVjdD4g ewogcHVibGljOgotICAgIHN0YXRpYyBQYXNzUmVmUHRyPFJlY3Q+IGNyZWF0ZShjb25zdCBXS1Jl Y3QmIHJlY3QpCisgICAgc3RhdGljIFJlZjxSZWN0PiBjcmVhdGUoY29uc3QgV0tSZWN0JiByZWN0 KQogICAgIHsKLSAgICAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBSZWN0KHJlY3QpKTsKKyAgICAg ICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgUmVjdChyZWN0KSk7CiAgICAgfQogCiAgICAgY29uc3Qg V0tSZWN0JiByZWN0KCkgY29uc3QgeyByZXR1cm4gbV9yZWN0OyB9CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tHZW9tZXRyeS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9T aGFyZWQvQVBJL2MvV0tHZW9tZXRyeS5jcHAKaW5kZXggOTZjM2YxOWY3ZmYyZDdkYmVmMmI5ZTE0 ZTAyMTc4YzA0NzJkYjUzMi4uZTFlYTgyNDM1ZmFlYjEyNzNhMDJkMDEzYmQwZTgwMjFmNTFiM2M1 MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9jL1dLR2VvbWV0cnkuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvYy9XS0dlb21ldHJ5LmNwcApAQCAtNDgs MTcgKzQ4LDE3IEBAIFdLVHlwZUlEIFdLUmVjdEdldFR5cGVJRCgpCiAKIFdLUG9pbnRSZWYgV0tQ b2ludENyZWF0ZShXS1BvaW50IHBvaW50KQogewotICAgIHJldHVybiB0b0FQSShBUEk6OlBvaW50 OjpjcmVhdGUocG9pbnQpLmxlYWtSZWYoKSk7CisgICAgcmV0dXJuIHRvQVBJKCZBUEk6OlBvaW50 OjpjcmVhdGUocG9pbnQpLmxlYWtSZWYoKSk7CiB9CiAKIFdLU2l6ZVJlZiBXS1NpemVDcmVhdGUo V0tTaXplIHNpemUpCiB7Ci0gICAgcmV0dXJuIHRvQVBJKEFQSTo6U2l6ZTo6Y3JlYXRlKHNpemUp LmxlYWtSZWYoKSk7CisgICAgcmV0dXJuIHRvQVBJKCZBUEk6OlNpemU6OmNyZWF0ZShzaXplKS5s ZWFrUmVmKCkpOwogfQogCiBXS1JlY3RSZWYgV0tSZWN0Q3JlYXRlKFdLUmVjdCByZWN0KQogewot ICAgIHJldHVybiB0b0FQSShBUEk6OlJlY3Q6OmNyZWF0ZShyZWN0KS5sZWFrUmVmKCkpOworICAg IHJldHVybiB0b0FQSSgmQVBJOjpSZWN0OjpjcmVhdGUocmVjdCkubGVha1JlZigpKTsKIH0KIAog V0tTaXplIFdLU2l6ZUdldFZhbHVlKFdLU2l6ZVJlZiBzaXplKQo=