144216 2015-04-26 04:35:00 -0700 Remove PluginView::renderer() 2015-04-26 16:42:36 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sungmann.cho sungmann.cho commit-queue oldest_to_newest 1088727 0 sungmann.cho 2015-04-26 04:35:00 -0700 Nobody should have to know about the plug-in view's renderer except the plug-in view itself. 1088728 1 251680 sungmann.cho 2015-04-26 04:38:44 -0700 Created attachment 251680 Patch 1088871 2 251680 commit-queue 2015-04-26 16:42:33 -0700 Comment on attachment 251680 Patch Clearing flags on attachment: 251680 Committed r183372: <http://trac.webkit.org/changeset/183372> 1088872 3 commit-queue 2015-04-26 16:42:36 -0700 All reviewed patches have been landed. Closing bug. 251680 2015-04-26 04:38:44 -0700 2015-04-26 16:42:33 -0700 Patch bug-144216-20150426203736.patch text/plain 5150 sungmann.cho U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzMzUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTUwODgyZTc0MTE2ZTM5 NzJhZDkzYjZjYTVjYTBjYTZiODI2MDEzNC4uNWMyNmZiZDRmNjE0ODdiNWYwNWNiNTE3ODA0N2Zi MTllZGQxZGFmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA0LTI2ICBTdW5n bWFubiBDaG8gIDxzdW5nbWFubi5jaG9AbmF2ZXJjb3JwLmNvbT4KKworICAgICAgICBSZW1vdmUg UGx1Z2luVmlldzo6cmVuZGVyZXIoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0NDIxNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5vYm9keSBzaG91bGQgaGF2ZSB0byBrbm93IGFib3V0IHRoZSBwbHVn LWluIHZpZXcncyByZW5kZXJlciBleGNlcHQgdGhlIHBsdWctaW4gdmlldyBpdHNlbGYuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5tbToKKyAgICAgICAgKFdlYktpdDo6UERGUGx1 Z2luOjpjb252ZXJ0RnJvbVNjcm9sbGJhclRvQ29udGFpbmluZ1ZpZXcpOgorICAgICAgICAoV2Vi S2l0OjpQREZQbHVnaW46OmNvbnZlcnRGcm9tQ29udGFpbmluZ1ZpZXdUb1Njcm9sbGJhcik6Cisg ICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuY3BwOgorICAgICAgICAoV2Vi S2l0OjpQbHVnaW5WaWV3OjpyZW5kZXJlcik6IERlbGV0ZWQuCisgICAgICAgICogV2ViUHJvY2Vz cy9QbHVnaW5zL1BsdWdpblZpZXcuaDoKKwogMjAxNS0wNC0yNSAgVGltIEhvcnRvbiAgPHRpbW90 aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBGdXJ0aGVyIHVwZGF0ZSBnZXN0dXJlIHN3 aXBlIHNoYWRvdyBzdHlsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Q bHVnaW5zL1BERi9QREZQbHVnaW4ubW0gYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdp bnMvUERGL1BERlBsdWdpbi5tbQppbmRleCAyYzU0ODlmMjY1OTlhYTQ3NDExMzZlOGM2Y2Y5NDI0 MzQ1M2FiNmE2Li45ZGRmYjgzOWI2ZTU5YTU2ZDdkYTE2MDliNTM5ZWQxMWE3M2MzMTI5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5t bQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5t bQpAQCAtNjYsNiArNjYsNyBAQAogI2ltcG9ydCA8V2ViQ29yZS9HcmFwaGljc0NvbnRleHQuaD4K ICNpbXBvcnQgPFdlYkNvcmUvSFRNTEVsZW1lbnQuaD4KICNpbXBvcnQgPFdlYkNvcmUvSFRNTEZv cm1FbGVtZW50Lmg+CisjaW1wb3J0IDxXZWJDb3JlL0hUTUxQbHVnSW5FbGVtZW50Lmg+CiAjaW1w b3J0IDxXZWJDb3JlL0xvY2FsaXplZFN0cmluZ3MuaD4KICNpbXBvcnQgPFdlYkNvcmUvTW91c2VF dmVudC5oPgogI2ltcG9ydCA8V2ViQ29yZS9QYWdlLmg+CkBAIC02ODcsMTIgKzY4OCwxMiBAQCBJ bnRSZWN0IFBERlBsdWdpbjo6Y29udmVydEZyb21TY3JvbGxiYXJUb0NvbnRhaW5pbmdWaWV3KGNv bnN0IFNjcm9sbGJhciogc2Nyb2xsYgogICAgIEludFJlY3QgcmVjdCA9IHNjcm9sbGJhclJlY3Q7 CiAgICAgcmVjdC5tb3ZlKHNjcm9sbGJhci0+bG9jYXRpb24oKSAtIHBsdWdpblZpZXcoKS0+bG9j YXRpb24oKSk7CiAKLSAgICByZXR1cm4gcGx1Z2luVmlldygpLT5mcmFtZSgpLT52aWV3KCktPmNv bnZlcnRGcm9tUmVuZGVyZXJUb0NvbnRhaW5pbmdWaWV3KHBsdWdpblZpZXcoKS0+cmVuZGVyZXIo KSwgcmVjdCk7CisgICAgcmV0dXJuIHBsdWdpblZpZXcoKS0+ZnJhbWUoKS0+dmlldygpLT5jb252 ZXJ0RnJvbVJlbmRlcmVyVG9Db250YWluaW5nVmlldyhwbHVnaW5WaWV3KCktPnBsdWdpbkVsZW1l bnQoKS0+cmVuZGVyZXIoKSwgcmVjdCk7CiB9CiAKIEludFJlY3QgUERGUGx1Z2luOjpjb252ZXJ0 RnJvbUNvbnRhaW5pbmdWaWV3VG9TY3JvbGxiYXIoY29uc3QgU2Nyb2xsYmFyKiBzY3JvbGxiYXIs IGNvbnN0IEludFJlY3QmIHBhcmVudFJlY3QpIGNvbnN0CiB7Ci0gICAgSW50UmVjdCByZWN0ID0g cGx1Z2luVmlldygpLT5mcmFtZSgpLT52aWV3KCktPmNvbnZlcnRGcm9tQ29udGFpbmluZ1ZpZXdU b1JlbmRlcmVyKHBsdWdpblZpZXcoKS0+cmVuZGVyZXIoKSwgcGFyZW50UmVjdCk7CisgICAgSW50 UmVjdCByZWN0ID0gcGx1Z2luVmlldygpLT5mcmFtZSgpLT52aWV3KCktPmNvbnZlcnRGcm9tQ29u dGFpbmluZ1ZpZXdUb1JlbmRlcmVyKHBsdWdpblZpZXcoKS0+cGx1Z2luRWxlbWVudCgpLT5yZW5k ZXJlcigpLCBwYXJlbnRSZWN0KTsKICAgICByZWN0Lm1vdmUocGx1Z2luVmlldygpLT5sb2NhdGlv bigpIC0gc2Nyb2xsYmFyLT5sb2NhdGlvbigpKTsKIAogICAgIHJldHVybiByZWN0OwpAQCAtNzAz LDEyICs3MDQsMTIgQEAgSW50UG9pbnQgUERGUGx1Z2luOjpjb252ZXJ0RnJvbVNjcm9sbGJhclRv Q29udGFpbmluZ1ZpZXcoY29uc3QgU2Nyb2xsYmFyKiBzY3JvbGwKICAgICBJbnRQb2ludCBwb2lu dCA9IHNjcm9sbGJhclBvaW50OwogICAgIHBvaW50Lm1vdmUoc2Nyb2xsYmFyLT5sb2NhdGlvbigp IC0gcGx1Z2luVmlldygpLT5sb2NhdGlvbigpKTsKIAotICAgIHJldHVybiBwbHVnaW5WaWV3KCkt PmZyYW1lKCktPnZpZXcoKS0+Y29udmVydEZyb21SZW5kZXJlclRvQ29udGFpbmluZ1ZpZXcocGx1 Z2luVmlldygpLT5yZW5kZXJlcigpLCBwb2ludCk7CisgICAgcmV0dXJuIHBsdWdpblZpZXcoKS0+ ZnJhbWUoKS0+dmlldygpLT5jb252ZXJ0RnJvbVJlbmRlcmVyVG9Db250YWluaW5nVmlldyhwbHVn aW5WaWV3KCktPnBsdWdpbkVsZW1lbnQoKS0+cmVuZGVyZXIoKSwgcG9pbnQpOwogfQogCiBJbnRQ b2ludCBQREZQbHVnaW46OmNvbnZlcnRGcm9tQ29udGFpbmluZ1ZpZXdUb1Njcm9sbGJhcihjb25z dCBTY3JvbGxiYXIqIHNjcm9sbGJhciwgY29uc3QgSW50UG9pbnQmIHBhcmVudFBvaW50KSBjb25z dAogewotICAgIEludFBvaW50IHBvaW50ID0gcGx1Z2luVmlldygpLT5mcmFtZSgpLT52aWV3KCkt PmNvbnZlcnRGcm9tQ29udGFpbmluZ1ZpZXdUb1JlbmRlcmVyKHBsdWdpblZpZXcoKS0+cmVuZGVy ZXIoKSwgcGFyZW50UG9pbnQpOworICAgIEludFBvaW50IHBvaW50ID0gcGx1Z2luVmlldygpLT5m cmFtZSgpLT52aWV3KCktPmNvbnZlcnRGcm9tQ29udGFpbmluZ1ZpZXdUb1JlbmRlcmVyKHBsdWdp blZpZXcoKS0+cGx1Z2luRWxlbWVudCgpLT5yZW5kZXJlcigpLCBwYXJlbnRQb2ludCk7CiAgICAg cG9pbnQubW92ZShwbHVnaW5WaWV3KCktPmxvY2F0aW9uKCkgLSBzY3JvbGxiYXItPmxvY2F0aW9u KCkpOwogICAgIAogICAgIHJldHVybiBwb2ludDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmNwcAppbmRleCBhNmE1MjBiNzJjNGQ0OTQyMjU1Yjll NTNhMmE3MTQ5OTkxZWFlMDY0Li4xODc2OTk3ZWJmMTJlYTNlZThkYzU2ZGNjYWUwMjUwNzNkYmRk ZWI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2lu Vmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZp ZXcuY3BwCkBAIC00NjUsMTEgKzQ2NSw2IEBAIHZvaWQgUGx1Z2luVmlldzo6bWFudWFsTG9hZERp ZEZhaWwoY29uc3QgUmVzb3VyY2VFcnJvciYgZXJyb3IpCiAgICAgbV9wbHVnaW4tPm1hbnVhbFN0 cmVhbURpZEZhaWwoZXJyb3IuaXNDYW5jZWxsYXRpb24oKSk7CiB9CiAKLVJlbmRlckJveE1vZGVs T2JqZWN0KiBQbHVnaW5WaWV3OjpyZW5kZXJlcigpIGNvbnN0Ci17Ci0gICAgcmV0dXJuIGRvd25j YXN0PFJlbmRlckJveE1vZGVsT2JqZWN0PihtX3BsdWdpbkVsZW1lbnQtPnJlbmRlcmVyKCkpOwot fQotCiB2b2lkIFBsdWdpblZpZXc6OnBhZ2VTY2FsZUZhY3RvckRpZENoYW5nZSgpCiB7CiAgICAg dmlld0dlb21ldHJ5RGlkQ2hhbmdlKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Q bHVnaW5zL1BsdWdpblZpZXcuaAppbmRleCBmY2ViNzM4YTg1ODY1ZTEyY2Y0YmQ1OTRhNTVhNGY1 NjQ0ZDNkYWJmLi45NjI2YWI2NDk0MjFmZTQ1Y2QxOGQ2M2IxODkyYzJhNDM4Mjc1Mzg2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5oCisr KyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmgKQEAgLTU4 LDcgKzU4LDYgQEAgY2xhc3MgRnJhbWU7CiBjbGFzcyBIVE1MUGx1Z0luRWxlbWVudDsKIGNsYXNz IE1hY2hTZW5kUmlnaHQ7CiBjbGFzcyBNb3VzZUV2ZW50OwotY2xhc3MgUmVuZGVyQm94TW9kZWxP YmplY3Q7CiB9CiAKIG5hbWVzcGFjZSBXZWJLaXQgewpAQCAtOTUsOSArOTQsNiBAQCBwdWJsaWM6 CiAgICAgY29uc3QgUGx1Z2luOjpQYXJhbWV0ZXJzJiBpbml0aWFsUGFyYW1ldGVycygpIGNvbnN0 IHsgcmV0dXJuIG1fcGFyYW1ldGVyczsgfQogICAgIFBsdWdpbiogcGx1Z2luKCkgY29uc3QgeyBy ZXR1cm4gbV9wbHVnaW4uZ2V0KCk7IH0KIAotICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhpczsgbm9i b2R5IHNob3VsZCBoYXZlIHRvIGtub3cgYWJvdXQgdGhlIHBsdWctaW4gdmlldydzIHJlbmRlcmVy IGV4Y2VwdCB0aGUgcGx1Zy1pbiB2aWV3IGl0c2VsZi4KLSAgICBXZWJDb3JlOjpSZW5kZXJCb3hN b2RlbE9iamVjdCogcmVuZGVyZXIoKSBjb25zdDsKLSAgICAKICAgICB2b2lkIHNldFBhZ2VTY2Fs ZUZhY3Rvcihkb3VibGUgc2NhbGVGYWN0b3IsIFdlYkNvcmU6OkludFBvaW50IG9yaWdpbik7CiAg ICAgZG91YmxlIHBhZ2VTY2FsZUZhY3RvcigpIGNvbnN0OwogICAgIGJvb2wgaGFuZGxlc1BhZ2VT Y2FsZUZhY3RvcigpIGNvbnN0Owo=