144212 2015-04-25 20:33:19 -0700 Web Inspector: Elements tab details sidebar becomes non-expandable after using Console tab 2015-04-27 14:32:14 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck timothy commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1088677 0 joepeck 2015-04-25 20:33:19 -0700 * SUMMARY Elements tab details sidebar becomes non-expandable after using Console tab * STEPS TO REPRODUCE 1. Inspect <http://bogojoker.com/shell/> 2. Show Elements Tab with Details sidebar collapsed 3. Show Console Tab 4. Reload 5. Show Elements Tab => Details Sidebar cannot be expanded, button is disabled * NOTES - Apparently at the end of WebInspector.ContentBrowserTabContentView.prototype._contentBrowserRepresentedObjectsDidChange, WebInspector.detailsSidebar.sidebarPanels.length is 0 even though this.detailsSidebarPanels.length is 3. Somehow the sidebar panels were not added to WebInspector.detailsSidebar correctly. 1088678 1 webkit-bug-importer 2015-04-25 20:33:29 -0700 <rdar://problem/20700543> 1088679 2 joepeck 2015-04-25 20:40:04 -0700 Apparently in this case, the currentRepresentedObjects is an empty list despite the DOM Tree appearing to have a selected node. Selecting a different node fixes the UI. 1088683 3 joepeck 2015-04-25 20:44:23 -0700 Indeed, in this scenario the Path Components are also empty. 1088684 4 joepeck 2015-04-25 20:55:08 -0700 I don't even see WebInspector.FrameResourceManager.Event.MainFrameDidChange getting dispatched at all. I wonder what is broken as a result? 1088685 5 joepeck 2015-04-25 20:58:45 -0700 (In reply to comment #4) > I don't even see WebInspector.FrameResourceManager.Event.MainFrameDidChange > getting dispatched at all. I wonder what is broken as a result? Hmm, maybe that is fine. Maybe the frame isn't changing just the main resource. Something updates the DOM Tree and its selection, whatever does should be updating the current selected represented objects. Just don't know what updates that yet. 1088696 6 joepeck 2015-04-25 22:24:51 -0700 Well this is very weird. DOMTreeContentView selected node changes trigger the right things. However, during the last of these events, the DOMTreeOutline.selectedTreeElement is null, which of course leads to what we have. The DOMTreeContentView updates the selected node multiples times, ending up with: - <html> (root node?) - null (removing all nodes) - <body> (restoring selection) But in the process of revealAndSelect for <body> it fails to create a tree element for it. It looks like during creation it walks up the DOMNode hierarchy, trying to find a DOMTreeElement parent (which should be the DOMTreeElement for the <html> node) and doesn't find one, so it doesn't create a tree element. I don't know what is different here. 1088733 7 timothy 2015-04-26 05:51:47 -0700 I'm seeing "Error during DOMAgent operation: No node with given path found". Looks like we might be asking to push the node path for the last selected path component too soon. Having ElementsTabContentView close and open a new DOMTreeContentView for each main frame main resource change fixes the sidebar issue, but the last DOM node still ins't restored on reload. 1088734 8 timothy 2015-04-26 05:58:12 -0700 Delaying the call to _restoreSelectedNodeAfterUpdate for 1.5-2 seconds makes it work. But I'm not sure what changed here. There is likely two bugs going on. 1) Even when _restoreSelectedNodeAfterUpdate fails, it should still have a selectedTreeElement. The details sidebars work if you reload with Elements tab showing. And a selected element is visible even when switching from Console. 2) InspectorDOMAgent::pushNodeByPathToFrontend is giving an error when pushing a path. The DOM might not be done being built after the load when we call for the push? 1088780 9 251698 timothy 2015-04-26 11:06:13 -0700 Created attachment 251698 Patch 1088792 10 timothy 2015-04-26 11:19:40 -0700 Filed the DOMAgent error as bug 144231. 1089165 11 251698 joepeck 2015-04-27 13:43:18 -0700 Comment on attachment 251698 Patch NicE! R=ME 1089166 12 joepeck 2015-04-27 13:43:37 -0700 > NicE! R=ME I apparently triggered caps lock while typing this =P 1089194 13 251698 commit-queue 2015-04-27 14:32:11 -0700 Comment on attachment 251698 Patch Clearing flags on attachment: 251698 Committed r183423: <http://trac.webkit.org/changeset/183423> 1089195 14 commit-queue 2015-04-27 14:32:14 -0700 All reviewed patches have been landed. Closing bug. 251698 2015-04-26 11:06:13 -0700 2015-04-27 14:32:11 -0700 Patch bug-144212-20150426110504.patch text/plain 3778 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzMzQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBl ZDBjMWQ1ZWVjZjNkYzY2Mzk0OWE0ODg0NzVmMTQ4Y2M0YmMxMDFkLi4wNjEwNTE0YmI0MjA5MTdk YmE1YjQ1NWEyNWQ2MzM4OTJhZTBjMTY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMyBAQAogMjAxNS0wNC0yNiAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRWxlbWVudHMgdGFiIGRldGFpbHMgc2lkZWJh ciBiZWNvbWVzIG5vbi1leHBhbmRhYmxlIGFmdGVyIHVzaW5nIENvbnNvbGUgdGFiCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQyMTIKKworICAgICAg ICBTaG93IHRoZSBET00gdHJlZSBjb250ZW50IHZpZXcgYWdhaW4gb24gbWFpbiByZXNvdXJjZSBj aGFuZ2UuIFRoaXMgYmV0dGVyIG1hdGNoZXMgd2hhdCB3ZSBkaWQKKyAgICAgICAgaW4gdGhlIHBy ZSB0YWIgdXNlciBpbnRlcmZhY2Ugd2l0aCB0aGUgRE9NIGJlaW5nIG9mZiB0aGUgbWFpbiByZXNv dXJjZSB0cmVlIGVsZW1lbnQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0VsZW1lbnRzVGFiQ29udGVudFZpZXcu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxlbWVudHNUYWJDb250ZW50Vmlldyk6IExpc3Rl biBmb3IgbWFpbiByZXNvdXJjZSBjaGFuZ2UuIENhbGwgX3Nob3dET01UcmVlQ29udGVudFZpZXcu CisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxlbWVudHNUYWJDb250ZW50Vmlldy5wcm90b3R5cGUu Y2xvc2VkKTogRml4IGEgbGVhayBhbmQgZXhjZXB0aW9uLgorICAgICAgICBUaGUgcmVtb3ZlRXZl bnRMaXN0ZW5lciB3YXMgd3JvbmcuIEFkZCBhIG5ldyByZW1vdmVFdmVudExpc3RlbmVyIGZvciBX ZWJJbnNwZWN0b3IuRnJhbWUuCisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxlbWVudHNUYWJDb250 ZW50Vmlldy5wcm90b3R5cGUuX3Nob3dET01UcmVlQ29udGVudFZpZXcpOiBBZGRlZC4KKyAgICAg ICAgKFdlYkluc3BlY3Rvci5FbGVtZW50c1RhYkNvbnRlbnRWaWV3LnByb3RvdHlwZS5fbWFpbkZy YW1lRGlkQ2hhbmdlKTogQ2FsbCBfc2hvd0RPTVRyZWVDb250ZW50Vmlldy4KKyAgICAgICAgKFdl Ykluc3BlY3Rvci5FbGVtZW50c1RhYkNvbnRlbnRWaWV3LnByb3RvdHlwZS5fbWFpblJlc291cmNl RGlkQ2hhbmdlKTogQWRkZWQuCisKKzIwMTUtMDQtMjYgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90 aHlAYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEF0dGVtcHQgdG8gd29ya2Fy b3VuZCBleGNlcHRpb24gaW4gVGltZWxpbmVSdWxlcgogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0MjI4CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0VsZW1lbnRzVGFiQ29udGVudFZpZXcuanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9FbGVtZW50c1RhYkNv bnRlbnRWaWV3LmpzCmluZGV4IGEzNzViNmE5ZGE1MDYxMWY2OTI1NTNmOWM1ZDYyYjQ3ZGM2NDAw ZjEuLjFjOGY4YmNhMTMwOTc2ZjZmZmY5NmRiODIwZjAwMmY5Y2NiNzJkMjYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0VsZW1lbnRzVGFiQ29u dGVudFZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvRWxlbWVudHNUYWJDb250ZW50Vmlldy5qcwpAQCAtMzQsOSArMzQsOSBAQCBXZWJJbnNwZWN0 b3IuRWxlbWVudHNUYWJDb250ZW50VmlldyA9IGZ1bmN0aW9uKGlkZW50aWZpZXIpCiAgICAgV2Vi SW5zcGVjdG9yLkNvbnRlbnRCcm93c2VyVGFiQ29udGVudFZpZXcuY2FsbCh0aGlzLCBpZGVudGlm aWVyIHx8ICJlbGVtZW50cyIsICJlbGVtZW50cyIsIHRhYkJhckl0ZW0sIG51bGwsIGRldGFpbHNT aWRlYmFyUGFuZWxzLCB0cnVlKTsKIAogICAgIFdlYkluc3BlY3Rvci5mcmFtZVJlc291cmNlTWFu YWdlci5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5GcmFtZVJlc291cmNlTWFuYWdlci5F dmVudC5NYWluRnJhbWVEaWRDaGFuZ2UsIHRoaXMuX21haW5GcmFtZURpZENoYW5nZSwgdGhpcyk7 CisgICAgV2ViSW5zcGVjdG9yLkZyYW1lLmFkZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLkZy YW1lLkV2ZW50Lk1haW5SZXNvdXJjZURpZENoYW5nZSwgdGhpcy5fbWFpblJlc291cmNlRGlkQ2hh bmdlLCB0aGlzKTsKIAotICAgIGlmIChXZWJJbnNwZWN0b3IuZnJhbWVSZXNvdXJjZU1hbmFnZXIu bWFpbkZyYW1lKQotICAgICAgICB0aGlzLmNvbnRlbnRCcm93c2VyLnNob3dDb250ZW50Vmlld0Zv clJlcHJlc2VudGVkT2JqZWN0KFdlYkluc3BlY3Rvci5mcmFtZVJlc291cmNlTWFuYWdlci5tYWlu RnJhbWUuZG9tVHJlZSk7CisgICAgdGhpcy5fc2hvd0RPTVRyZWVDb250ZW50VmlldygpOwogfTsK IAogV2ViSW5zcGVjdG9yLkVsZW1lbnRzVGFiQ29udGVudFZpZXcucHJvdG90eXBlID0gewpAQCAt NzgsMTggKzc4LDMyIEBAIFdlYkluc3BlY3Rvci5FbGVtZW50c1RhYkNvbnRlbnRWaWV3LnByb3Rv dHlwZSA9IHsKICAgICB7CiAgICAgICAgIFdlYkluc3BlY3Rvci5Db250ZW50QnJvd3NlclRhYkNv bnRlbnRWaWV3LnByb3RvdHlwZS5jbG9zZWQuY2FsbCh0aGlzKTsKIAotICAgICAgICBXZWJJbnNw ZWN0b3IucmVtb3ZlUmVzb3VyY2VNYW5hZ2VyLmFkZEV2ZW50TGlzdGVuZXIobnVsbCwgbnVsbCwg dGhpcyk7CisgICAgICAgIFdlYkluc3BlY3Rvci5mcmFtZVJlc291cmNlTWFuYWdlci5yZW1vdmVF dmVudExpc3RlbmVyKG51bGwsIG51bGwsIHRoaXMpOworICAgICAgICBXZWJJbnNwZWN0b3IuRnJh bWUucmVtb3ZlRXZlbnRMaXN0ZW5lcihudWxsLCBudWxsLCB0aGlzKTsKICAgICB9LAogCiAgICAg Ly8gUHJpdmF0ZQogCi0gICAgX21haW5GcmFtZURpZENoYW5nZTogZnVuY3Rpb24oZXZlbnQpCisg ICAgX3Nob3dET01UcmVlQ29udGVudFZpZXc6IGZ1bmN0aW9uKCkKICAgICB7CiAgICAgICAgIHRo aXMuY29udGVudEJyb3dzZXIuY29udGVudFZpZXdDb250YWluZXIuY2xvc2VBbGxDb250ZW50Vmll d3MoKTsKIAogICAgICAgICB2YXIgbWFpbkZyYW1lID0gV2ViSW5zcGVjdG9yLmZyYW1lUmVzb3Vy Y2VNYW5hZ2VyLm1haW5GcmFtZTsKICAgICAgICAgaWYgKG1haW5GcmFtZSkKICAgICAgICAgICAg IHRoaXMuY29udGVudEJyb3dzZXIuc2hvd0NvbnRlbnRWaWV3Rm9yUmVwcmVzZW50ZWRPYmplY3Qo bWFpbkZyYW1lLmRvbVRyZWUpOworICAgIH0sCisKKyAgICBfbWFpbkZyYW1lRGlkQ2hhbmdlOiBm dW5jdGlvbihldmVudCkKKyAgICB7CisgICAgICAgIHRoaXMuX3Nob3dET01UcmVlQ29udGVudFZp ZXcoKTsKKyAgICB9LAorCisgICAgX21haW5SZXNvdXJjZURpZENoYW5nZTogZnVuY3Rpb24oZXZl bnQpCisgICAgeworICAgICAgICBpZiAoIWV2ZW50LnRhcmdldC5pc01haW5GcmFtZSgpKQorICAg ICAgICAgICAgcmV0dXJuOworCisgICAgICAgIHRoaXMuX3Nob3dET01UcmVlQ29udGVudFZpZXco KTsKICAgICB9CiB9OwogCg==