144208 2015-04-25 20:04:45 -0700 Web Inspector: Tabs should have Context Menus 2015-05-29 11:46:27 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1088669 0 joepeck 2015-04-25 20:04:45 -0700 * SUMMARY Inspector Tabs should have Context Menus. Right now it seems it would be logical to have "Close Tab" for the closable tabs. Anything else? 1088670 1 webkit-bug-importer 2015-04-25 20:05:01 -0700 <rdar://problem/20700511> 1097973 2 253870 joepeck 2015-05-28 15:19:40 -0700 Created attachment 253870 [PATCH] Proposed Fix These menu items match other OS X applications like Safari and Terminal. 1097994 3 253870 timothy 2015-05-28 16:08:14 -0700 Comment on attachment 253870 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=253870&action=review > Source/WebInspectorUI/UserInterface/Views/TabBarItem.js:202 > + contextMenu.appendItem(WebInspector.UIString("Close Other Tabs"), closeOtherTabs.bind(this), !hasOtherNonPinnedTabs); Not super convinced this is useful for us. 1098005 4 joepeck 2015-05-28 16:18:26 -0700 (In reply to comment #3) > Comment on attachment 253870 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253870&action=review > > > Source/WebInspectorUI/UserInterface/Views/TabBarItem.js:202 > > + contextMenu.appendItem(WebInspector.UIString("Close Other Tabs"), closeOtherTabs.bind(this), !hasOtherNonPinnedTabs); > > Not super convinced this is useful for us. Yeah... I just added it to be consistent with everything else I could find on the system, which all had it. 1098141 5 joepeck 2015-05-29 11:46:27 -0700 http://trac.webkit.org/changeset/184996 253870 2015-05-28 15:19:40 -0700 2015-05-28 16:08:14 -0700 [PATCH] Proposed Fix context-menus.patch text/plain 4160 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDAxMzEwZDUuLjRkMzAyOTYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE1LTA1LTI4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVGFicyBz aG91bGQgaGF2ZSBDb250ZXh0IE1lbnVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDQyMDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBHaXZlIG5vbi1waW5uZWQgdGFicyAiQ2xvc2UgVGFiIiBhbmQgIkNs b3NlIE90aGVyIFRhYnMiIGNvbnRleHQKKyAgICAgICAgbWVudSBpdGVtcyB0byBhZmZlY3Qgb3Ro ZXIgbm9uLXBpbm5lZCB0YWJzLgorCisgICAgICAgICogTG9jYWxpemF0aW9ucy9lbi5scHJvai9s b2NhbGl6ZWRTdHJpbmdzLmpzOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGFiQmFy SXRlbS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UYWJCYXJJdGVtKToKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5UYWJCYXJJdGVtLnByb3RvdHlwZS5faGFuZGxlQ29udGV4dE1lbnVFdmVudC5j bG9zZVRhYik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGFiQmFySXRlbS5wcm90b3R5cGUuX2hh bmRsZUNvbnRleHRNZW51RXZlbnQuY2xvc2VPdGhlclRhYnMpOgorICAgICAgICAoV2ViSW5zcGVj dG9yLlRhYkJhckl0ZW0ucHJvdG90eXBlLl9oYW5kbGVDb250ZXh0TWVudUV2ZW50KToKKworMjAx NS0wNS0yOCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IFNob3VsZCBoYXZlIGEga2V5Ym9hcmQgc2hvcnRjdXQgdG8gc3dpdGNo IGJldHdlZW4gaW5zcGVjdG9yIHRhYnMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0NDIwNwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcwpp bmRleCA1ODM5Zjg0Y2RkYzVjMDkzYzQwZDBlNTVmODkxZmE4M2RiY2M2MzJmLi40NDEyMjZlYzBj NzBlZDE1MTZkMjY4YWFkZDNjZTFjNzVmZTg0OGM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCisrKyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0 cmluZ3MuanMKQEAgLTk5LDYgKzk5LDggQEAgbG9jYWxpemVkU3RyaW5nc1siQ2xpY2sgdG8gb3Bl biBhIGNvbG9ycGlja2VyLiBTaGlmdC1jbGljayB0byBjaGFuZ2UgY29sb3IgZm9ybWEKIGxvY2Fs aXplZFN0cmluZ3NbIkNsaWNrYWJsZSJdID0gIkNsaWNrYWJsZSI7CiBsb2NhbGl6ZWRTdHJpbmdz WyJDbG9zZSJdID0gIkNsb3NlIjsKIGxvY2FsaXplZFN0cmluZ3NbIkNsb3NlICVzIHRpbWVsaW5l IHZpZXciXSA9ICJDbG9zZSAlcyB0aW1lbGluZSB2aWV3IjsKK2xvY2FsaXplZFN0cmluZ3NbIkNs b3NlIE90aGVyIFRhYnMiXSA9ICJDbG9zZSBPdGhlciBUYWJzIjsKK2xvY2FsaXplZFN0cmluZ3Nb IkNsb3NlIFRhYiJdID0gIkNsb3NlIFRhYiI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJDbG9zZSByZXNv dXJjZSB2aWV3Il0gPSAiQ2xvc2UgcmVzb3VyY2UgdmlldyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJD bG9zdXJlIFZhcmlhYmxlcyJdID0gIkNsb3N1cmUgVmFyaWFibGVzIjsKIGxvY2FsaXplZFN0cmlu Z3NbIkNvZGUiXSA9ICJDb2RlIjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1RhYkJhckl0ZW0uanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9UYWJCYXJJdGVtLmpzCmluZGV4IDJhN2E5ZTguLjU0ZTBlNjYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Rh YkJhckl0ZW0uanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvVGFiQmFySXRlbS5qcwpAQCAtNDYsNiArNDYsOCBAQCBXZWJJbnNwZWN0b3IuVGFiQmFySXRl bSA9IGNsYXNzIFRhYkJhckl0ZW0gZXh0ZW5kcyBXZWJJbnNwZWN0b3IuT2JqZWN0CiAgICAgICAg ICAgICB2YXIgZmxleFNwYWNlRWxlbWVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIp OwogICAgICAgICAgICAgZmxleFNwYWNlRWxlbWVudC5jbGFzc0xpc3QuYWRkKCJmbGV4LXNwYWNl Iik7CiAgICAgICAgICAgICB0aGlzLl9lbGVtZW50LmFwcGVuZENoaWxkKGZsZXhTcGFjZUVsZW1l bnQpOworCisgICAgICAgICAgICB0aGlzLl9lbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoImNvbnRl eHRtZW51IiwgdGhpcy5faGFuZGxlQ29udGV4dE1lbnVFdmVudC5iaW5kKHRoaXMpKTsKICAgICAg ICAgfQogCiAgICAgICAgIHRoaXMuX2ljb25FbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVu dCgiaW1nIik7CkBAIC0xNjMsNiArMTY1LDQzIEBAIFdlYkluc3BlY3Rvci5UYWJCYXJJdGVtID0g Y2xhc3MgVGFiQmFySXRlbSBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplY3QKIAogICAgICAgICB0 aGlzLl9lbGVtZW50LnRpdGxlID0gdGl0bGUgfHwgIiI7CiAgICAgfQorCisgICAgLy8gUHJpdmF0 ZQorCisgICAgX2hhbmRsZUNvbnRleHRNZW51RXZlbnQoZXZlbnQpCisgICAgeworICAgICAgICBp ZiAoIXRoaXMuX3BhcmVudFRhYkJhcikKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICB2 YXIgaGFzT3RoZXJOb25QaW5uZWRUYWJzID0gZmFsc2U7CisgICAgICAgIGZvciAodmFyIGl0ZW0g b2YgdGhpcy5fcGFyZW50VGFiQmFyLnRhYkJhckl0ZW1zKSB7CisgICAgICAgICAgICBpZiAoaXRl bSA9PT0gdGhpcyB8fCBpdGVtLnBpbm5lZCkKKyAgICAgICAgICAgICAgICBjb250aW51ZTsKKyAg ICAgICAgICAgIGhhc090aGVyTm9uUGlubmVkVGFicyA9IHRydWU7CisgICAgICAgICAgICBicmVh azsgCisgICAgICAgIH0KKworICAgICAgICBmdW5jdGlvbiBjbG9zZVRhYigpCisgICAgICAgIHsK KyAgICAgICAgICAgIHRoaXMuX3BhcmVudFRhYkJhci5yZW1vdmVUYWJCYXJJdGVtKHRoaXMpOwor ICAgICAgICB9CisKKyAgICAgICAgZnVuY3Rpb24gY2xvc2VPdGhlclRhYnMoKQorICAgICAgICB7 CisgICAgICAgICAgICB2YXIgdGFiQmFySXRlbXMgPSB0aGlzLl9wYXJlbnRUYWJCYXIudGFiQmFy SXRlbXM7CisgICAgICAgICAgICBmb3IgKHZhciBpID0gdGFiQmFySXRlbXMubGVuZ3RoIC0gMTsg aSA+PSAwOyAtLWkpIHsKKyAgICAgICAgICAgICAgICB2YXIgaXRlbSA9IHRhYkJhckl0ZW1zW2ld OworICAgICAgICAgICAgICAgIGlmIChpdGVtID09PSB0aGlzIHx8IGl0ZW0ucGlubmVkKQorICAg ICAgICAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgICAgICAgICB0aGlzLl9wYXJlbnRU YWJCYXIucmVtb3ZlVGFiQmFySXRlbShpdGVtKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQor CisgICAgICAgIHZhciBjb250ZXh0TWVudSA9IG5ldyBXZWJJbnNwZWN0b3IuQ29udGV4dE1lbnUo ZXZlbnQpOworICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRJdGVtKFdlYkluc3BlY3Rvci5VSVN0 cmluZygiQ2xvc2UgVGFiIiksIGNsb3NlVGFiLmJpbmQodGhpcyksICFoYXNPdGhlck5vblBpbm5l ZFRhYnMpOworICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRJdGVtKFdlYkluc3BlY3Rvci5VSVN0 cmluZygiQ2xvc2UgT3RoZXIgVGFicyIpLCBjbG9zZU90aGVyVGFicy5iaW5kKHRoaXMpLCAhaGFz T3RoZXJOb25QaW5uZWRUYWJzKTsKKyAgICAgICAgY29udGV4dE1lbnUuc2hvdygpOworICAgIH0K IH07CiAKIFdlYkluc3BlY3Rvci5UYWJCYXJJdGVtLlN0eWxlQ2xhc3NOYW1lID0gIml0ZW0iOwo=