144207 2015-04-25 20:03:21 -0700 Web Inspector: Should have a keyboard shortcut to switch between inspector tabs 2015-06-29 02:53:46 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned adam.g.helm commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1088666 0 joepeck 2015-04-25 20:03:21 -0700 * SUMMARY Should have a keyboard shortcut to switch between inspector tabs. This is something I frequently want to do. Though there are keyboard shortcuts to jump directly to certain tabs, moving left/right should also be possible. 1088667 1 webkit-bug-importer 2015-04-25 20:03:40 -0700 <rdar://problem/20700509> 1097963 2 253867 joepeck 2015-05-28 14:52:35 -0700 Created attachment 253867 [PATCH] Proposed Fix 1097988 3 253867 timothy 2015-05-28 15:58:51 -0700 Comment on attachment 253867 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=253867&action=review > Source/WebInspectorUI/ChangeLog:11 > + Be careful that some keyboard shortcuts, when used inside a text > + editor / text field are just text actions. However, some keyboard > + shortcuts will work no matter where you trigger them. Do we need to use WebInspector.isEventTargetAnEditableField to abort early? 1098042 4 joepeck 2015-05-28 18:16:22 -0700 (In reply to comment #3) > Comment on attachment 253867 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253867&action=review > > > Source/WebInspectorUI/ChangeLog:11 > > + Be careful that some keyboard shortcuts, when used inside a text > > + editor / text field are just text actions. However, some keyboard > > + shortcuts will work no matter where you trigger them. > > Do we need to use WebInspector.isEventTargetAnEditableField to abort early? Naw, we match the system here. If you're in a text editor and do something like Shift+Command+Left, it should select text instead of change tabs. 1098049 5 253867 commit-queue 2015-05-28 19:06:28 -0700 Comment on attachment 253867 [PATCH] Proposed Fix Clearing flags on attachment: 253867 Committed r184974: <http://trac.webkit.org/changeset/184974> 1098050 6 commit-queue 2015-05-28 19:06:32 -0700 All reviewed patches have been landed. Closing bug. 1098885 7 joepeck 2015-06-02 13:53:11 -0700 (In reply to comment #4) > (In reply to comment #3) > > Comment on attachment 253867 [details] > > [PATCH] Proposed Fix > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=253867&action=review > > > > > Source/WebInspectorUI/ChangeLog:11 > > > + Be careful that some keyboard shortcuts, when used inside a text > > > + editor / text field are just text actions. However, some keyboard > > > + shortcuts will work no matter where you trigger them. > > > > Do we need to use WebInspector.isEventTargetAnEditableField to abort early? > > Naw, we match the system here. If you're in a text editor and do something > like Shift+Command+Left, it should select text instead of change tabs. Oops, yes we do for native editable fields. When I tested this, I tested in the QuickConsole, and code mirror was handling that keyboard input and I was seeing the desired behavior, but we don't get that in <input>, etc. 253867 2015-05-28 14:52:35 -0700 2015-05-28 19:06:28 -0700 [PATCH] Proposed Fix keyboard-shortcut.patch text/plain 6483 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDRiNDVmNzYuLjAxMzEwZDUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE1LTA1LTI4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogU2hvdWxk IGhhdmUgYSBrZXlib2FyZCBzaG9ydGN1dCB0byBzd2l0Y2ggYmV0d2VlbiBpbnNwZWN0b3IgdGFi cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0MjA3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlc2Ug a2V5Ym9hcmQgc2hvcnRjdXRzIHdvcmsgd2VsbCBpbiBhbiB1bmRvY2tlZCBpbnNwZWN0b3Igd2lu ZG93LgorICAgICAgICBCZSBjYXJlZnVsIHRoYXQgc29tZSBrZXlib2FyZCBzaG9ydGN1dHMsIHdo ZW4gdXNlZCBpbnNpZGUgYSB0ZXh0CisgICAgICAgIGVkaXRvciAvIHRleHQgZmllbGQgYXJlIGp1 c3QgdGV4dCBhY3Rpb25zLiBIb3dldmVyLCBzb21lIGtleWJvYXJkCisgICAgICAgIHNob3J0Y3V0 cyB3aWxsIHdvcmsgbm8gbWF0dGVyIHdoZXJlIHlvdSB0cmlnZ2VyIHRoZW0uCisKKyAgICAgICAg KiBVc2VySW50ZXJmYWNlL01vZGVscy9LZXlib2FyZFNob3J0Y3V0LmpzOgorICAgICAgICAqIFVz ZXJJbnRlcmZhY2UvVmlld3MvVGFiQmFyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRhYkJh ci5wcm90b3R5cGUuc2VsZWN0UHJldmlvdXNUYWIpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRh YkJhci5wcm90b3R5cGUuc2VsZWN0TmV4dFRhYik6CisgICAgICAgICogVXNlckludGVyZmFjZS9W aWV3cy9UYWJCcm93c2VyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRhYkJyb3dzZXIpOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLlRhYkJyb3dzZXIucHJvdG90eXBlLl9zaG93UHJldmlvdXNU YWIpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRhYkJyb3dzZXIucHJvdG90eXBlLl9zaG93TmV4 dFRhYik6CisKIDIwMTUtMDUtMjcgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNv bT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTaG93IFBhZ2UgU291cmNlIGRvZXMgbm90IHN3 aXRjaCB0byBSZXNvdXJjZXMgdGFiIGlmIGluc3BlY3RvciB3YXMgY2xvc2VkCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvS2V5Ym9hcmRTaG9y dGN1dC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9LZXli b2FyZFNob3J0Y3V0LmpzCmluZGV4IDkwOWY3YzEuLjQzZThhNzQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9LZXlib2FyZFNob3J0Y3V0Lmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9LZXlib2Fy ZFNob3J0Y3V0LmpzCkBAIC0yNjEsNyArMjYxLDkgQEAgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hv cnRjdXQuS2V5ID0gewogICAgIE1pbnVzOiBuZXcgV2ViSW5zcGVjdG9yLktleSgxODksICItIiks CiAgICAgUGVyaW9kOiBuZXcgV2ViSW5zcGVjdG9yLktleSgxOTAsICIuIiksCiAgICAgU2xhc2g6 IG5ldyBXZWJJbnNwZWN0b3IuS2V5KDE5MSwgIi8iKSwKLSAgICBCYWNrc2xhc2g6IG5ldyBXZWJJ bnNwZWN0b3IuS2V5KDIyMCwgIlxcIiksCiAgICAgQXBvc3Ryb3BoZTogbmV3IFdlYkluc3BlY3Rv ci5LZXkoMTkyLCAiYCIpLAorICAgIExlZnRDdXJseUJyYWNlOiBuZXcgV2ViSW5zcGVjdG9yLktl eSgyMTksICJ7IiksCisgICAgQmFja3NsYXNoOiBuZXcgV2ViSW5zcGVjdG9yLktleSgyMjAsICJc XCIpLAorICAgIFJpZ2h0Q3VybHlCcmFjZTogbmV3IFdlYkluc3BlY3Rvci5LZXkoMjIxLCAifSIp LAogICAgIFNpbmdsZVF1b3RlOiBuZXcgV2ViSW5zcGVjdG9yLktleSgyMjIsICJcJyIpCiB9Owpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFi QmFyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFiQmFy LmpzCmluZGV4IGY0NGZiNmUuLmNmODMxZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYkJhci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UYWJCYXIuanMKQEAgLTI4OCw2ICsyODgsNTIgQEAg V2ViSW5zcGVjdG9yLlRhYkJhciA9IGNsYXNzIFRhYkJhciBleHRlbmRzIFdlYkluc3BlY3Rvci5P YmplY3QKICAgICAgICAgcmV0dXJuIHRhYkJhckl0ZW07CiAgICAgfQogCisgICAgc2VsZWN0UHJl dmlvdXNUYWIoKQorICAgIHsKKyAgICAgICAgaWYgKHRoaXMuX3RhYkJhckl0ZW1zLmxlbmd0aCA8 PSAxKQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIHZhciBzdGFydEluZGV4ID0gdGhp cy5fdGFiQmFySXRlbXMuaW5kZXhPZih0aGlzLl9zZWxlY3RlZFRhYkJhckl0ZW0pOworICAgICAg ICB2YXIgbmV3SW5kZXggPSBzdGFydEluZGV4OworICAgICAgICBkbyB7CisgICAgICAgICAgICBp ZiAobmV3SW5kZXggPT09IDApCisgICAgICAgICAgICAgICAgbmV3SW5kZXggPSB0aGlzLl90YWJC YXJJdGVtcy5sZW5ndGggLSAxOworICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgIG5l d0luZGV4LS07CisKKyAgICAgICAgICAgIGlmICghdGhpcy5fdGFiQmFySXRlbXNbbmV3SW5kZXhd LnBpbm5lZCkKKyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgfSB3aGlsZSAobmV3SW5k ZXggIT09IHN0YXJ0SW5kZXgpOworCisgICAgICAgIGlmIChuZXdJbmRleCA9PT0gc3RhcnRJbmRl eCkKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICB0aGlzLnNlbGVjdGVkVGFiQmFySXRl bSA9IHRoaXMuX3RhYkJhckl0ZW1zW25ld0luZGV4XTsKKyAgICB9CisKKyAgICBzZWxlY3ROZXh0 VGFiKCkKKyAgICB7CisgICAgICAgIGlmICh0aGlzLl90YWJCYXJJdGVtcy5sZW5ndGggPD0gMSkK KyAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICB2YXIgc3RhcnRJbmRleCA9IHRoaXMuX3Rh YkJhckl0ZW1zLmluZGV4T2YodGhpcy5fc2VsZWN0ZWRUYWJCYXJJdGVtKTsKKyAgICAgICAgdmFy IG5ld0luZGV4ID0gc3RhcnRJbmRleDsKKyAgICAgICAgZG8geworICAgICAgICAgICAgaWYgKG5l d0luZGV4ID09PSB0aGlzLl90YWJCYXJJdGVtcy5sZW5ndGggLSAxKQorICAgICAgICAgICAgICAg IG5ld0luZGV4ID0gMDsKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBuZXdJbmRl eCsrOworCisgICAgICAgICAgICBpZiAoIXRoaXMuX3RhYkJhckl0ZW1zW25ld0luZGV4XS5waW5u ZWQpCisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0gd2hpbGUgKG5ld0luZGV4ICE9 PSBzdGFydEluZGV4KTsKKworICAgICAgICBpZiAobmV3SW5kZXggPT09IHN0YXJ0SW5kZXgpCisg ICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgdGhpcy5zZWxlY3RlZFRhYkJhckl0ZW0gPSB0 aGlzLl90YWJCYXJJdGVtc1tuZXdJbmRleF07CisgICAgfQorCiAgICAgdXBkYXRlTGF5b3V0U29v bigpCiAgICAgewogICAgICAgICBpZiAodGhpcy5fdXBkYXRlTGF5b3V0SWRlbnRpZmllcikKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYkJy b3dzZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UYWJC cm93c2VyLmpzCmluZGV4IDA1OGQ5MmIuLjQzZGY2NDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYkJyb3dzZXIuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFiQnJvd3Nlci5qcwpAQCAtNTAs NiArNTAsMTYgQEAgV2ViSW5zcGVjdG9yLlRhYkJyb3dzZXIgPSBjbGFzcyBUYWJCcm93c2VyIGV4 dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogICAgICAgICB0aGlzLl9jb250ZW50Vmlld0NvbnRh aW5lciA9IG5ldyBXZWJJbnNwZWN0b3IuQ29udGVudFZpZXdDb250YWluZXI7CiAgICAgICAgIHRo aXMuX2VsZW1lbnQuYXBwZW5kQ2hpbGQodGhpcy5fY29udGVudFZpZXdDb250YWluZXIuZWxlbWVu dCk7CiAKKyAgICAgICAgdmFyIHNob3dOZXh0VGFiID0gdGhpcy5fc2hvd05leHRUYWIuYmluZCh0 aGlzKTsKKyAgICAgICAgdmFyIHNob3dQcmV2aW91c1RhYiA9IHRoaXMuX3Nob3dQcmV2aW91c1Rh Yi5iaW5kKHRoaXMpOworCisgICAgICAgIHRoaXMuX3Nob3dOZXh0VGFiS2V5Ym9hcmRTaG9ydGN1 dDEgPSBuZXcgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQoV2ViSW5zcGVjdG9yLktleWJv YXJkU2hvcnRjdXQuTW9kaWZpZXIuQ29tbWFuZE9yQ29udHJvbCB8IFdlYkluc3BlY3Rvci5LZXli b2FyZFNob3J0Y3V0Lk1vZGlmaWVyLlNoaWZ0LCBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1 dC5LZXkuUmlnaHRDdXJseUJyYWNlLCBzaG93TmV4dFRhYik7CisgICAgICAgIHRoaXMuX3Nob3dQ cmV2aW91c1RhYktleWJvYXJkU2hvcnRjdXQxID0gbmV3IFdlYkluc3BlY3Rvci5LZXlib2FyZFNo b3J0Y3V0KFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLkNvbW1hbmRPckNv bnRyb2wgfCBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5TaGlmdCwgV2Vi SW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuS2V5LkxlZnRDdXJseUJyYWNlLCBzaG93UHJldmlv dXNUYWIpOworICAgICAgICB0aGlzLl9zaG93TmV4dFRhYktleWJvYXJkU2hvcnRjdXQyID0gbmV3 IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0KFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0 Y3V0Lk1vZGlmaWVyLkNvbnRyb2wsIFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0LktleS5U YWIsIHNob3dOZXh0VGFiKTsKKyAgICAgICAgdGhpcy5fc2hvd1ByZXZpb3VzVGFiS2V5Ym9hcmRT aG9ydGN1dDIgPSBuZXcgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQoV2ViSW5zcGVjdG9y LktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXIuQ29udHJvbCB8IFdlYkluc3BlY3Rvci5LZXlib2Fy ZFNob3J0Y3V0Lk1vZGlmaWVyLlNoaWZ0LCBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5L ZXkuVGFiLCBzaG93UHJldmlvdXNUYWIpOworICAgICAgICB0aGlzLl9zaG93TmV4dFRhYktleWJv YXJkU2hvcnRjdXQzID0gbmV3IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0KFdlYkluc3Bl Y3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLkNvbW1hbmRPckNvbnRyb2wgfCBXZWJJbnNw ZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5TaGlmdCwgV2ViSW5zcGVjdG9yLktleWJv YXJkU2hvcnRjdXQuS2V5LlJpZ2h0LCBzaG93TmV4dFRhYik7CisgICAgICAgIHRoaXMuX3Nob3dQ cmV2aW91c1RhYktleWJvYXJkU2hvcnRjdXQzID0gbmV3IFdlYkluc3BlY3Rvci5LZXlib2FyZFNo b3J0Y3V0KFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLkNvbW1hbmRPckNv bnRyb2wgfCBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5TaGlmdCwgV2Vi SW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuS2V5LkxlZnQsIHNob3dQcmV2aW91c1RhYik7CisK ICAgICAgICAgdGhpcy5fdGFiQmFyLm5ld1RhYkl0ZW0gPSBuZXcgV2ViSW5zcGVjdG9yLlRhYkJh ckl0ZW0oIkltYWdlcy9OZXdUYWJQbHVzLnN2ZyIsIFdlYkluc3BlY3Rvci5VSVN0cmluZygiQ3Jl YXRlIGEgbmV3IHRhYiIpLCB0cnVlKTsKIAogICAgICAgICB0aGlzLl90YWJCYXIuYWRkRXZlbnRM aXN0ZW5lcihXZWJJbnNwZWN0b3IuVGFiQmFyLkV2ZW50LlRhYkJhckl0ZW1TZWxlY3RlZCwgdGhp cy5fdGFiQmFySXRlbVNlbGVjdGVkLCB0aGlzKTsKQEAgLTMzMSw2ICszNDEsMTYgQEAgV2ViSW5z cGVjdG9yLlRhYkJyb3dzZXIgPSBjbGFzcyBUYWJCcm93c2VyIGV4dGVuZHMgV2ViSW5zcGVjdG9y Lk9iamVjdAogCiAgICAgICAgIHRoaXMuX2lnbm9yZVNpZGViYXJFdmVudHMgPSBmYWxzZTsKICAg ICB9CisKKyAgICBfc2hvd1ByZXZpb3VzVGFiKGV2ZW50KQorICAgIHsKKyAgICAgICAgdGhpcy5f dGFiQmFyLnNlbGVjdFByZXZpb3VzVGFiKCk7CisgICAgfQorCisgICAgX3Nob3dOZXh0VGFiKGV2 ZW50KQorICAgIHsKKyAgICAgICAgdGhpcy5fdGFiQmFyLnNlbGVjdE5leHRUYWIoKTsKKyAgICB9 CiB9OwogCiBXZWJJbnNwZWN0b3IuVGFiQnJvd3Nlci5FdmVudCA9IHsK