144203 2015-04-25 18:10:15 -0700 Web Inspector: Make JSContext debugging work with Tabs UI 2015-04-25 18:36:07 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 timothy timothy graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1088625 0 timothy 2015-04-25 18:10:15 -0700 Add some sanity checks to not show UI that JSContexts don't support. 1088626 1 251659 timothy 2015-04-25 18:11:09 -0700 Created attachment 251659 Patch 1088627 2 251659 joepeck 2015-04-25 18:13:43 -0700 Comment on attachment 251659 Patch r=me 1088638 3 timothy 2015-04-25 18:36:07 -0700 r183322 – r183342 http://trac.webkit.org/log/?revs=183322-183342 251659 2015-04-25 18:11:09 -0700 2015-04-25 18:13:43 -0700 Patch bug-144203-20150425181002.patch text/plain 4448 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzMzExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBi MTBhMzUyNmM1ZTYzYWJhYjM3ODhlZTE4MGNjNDZkNmJjNjk2NjVhLi4zM2Y0ZTliYTdiZjBkYTAz OTlhYzMyNWM1ODAyM2RlMGE2NDU4N2M0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxOSBAQAogMjAxNS0wNC0yNSAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTWFrZSBKU0NvbnRleHQgZGVidWdnaW5nIHdv cmsgd2l0aCBUYWJzIFVJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDQyMDMKKworICAgICAgICBSZXZpZXdlZCBieSBKb3NlcGggUGVjb3Jhcm8uCisK KyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qczoKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5jb250ZW50TG9hZGVkKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5faXNUYWJUeXBlQWxs b3dlZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuYWN0aXZhdGVFeHRyYURvbWFpbnMpOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLl91cGRhdGVSZWxvYWRUb29sYmFyQnV0dG9uKToKKyAgICAgICAg KFdlYkluc3BlY3Rvci5fdXBkYXRlRG93bmxvYWRUb29sYmFyQnV0dG9uKToKKworMjAxNS0wNC0y NSAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CisKICAgICAgICAgV2ViIElu c3BlY3RvcjogU2F2ZSBhbmQgcmVzdG9yZSB0YWIgc3RhdGUgb24gcmVsb2FkIGFuZCBiZXR3ZWVu IHNlc3Npb25zCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDQyMDIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvQmFzZS9NYWluLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFz ZS9NYWluLmpzCmluZGV4IDk0YzQyZDZlNDNkYjliYWE0NjUzYmM1MjA2Yzg3MTU2OWRiNWQxODku LmJmZTU0ZGRkY2Q4OTMwNDM3Y2I4M2JlNTJmMGY4MWMwZWM2YWNlNzQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcworKysgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKQEAgLTI3NCw2ICsy NzQsNyBAQCBXZWJJbnNwZWN0b3IuY29udGVudExvYWRlZCA9IGZ1bmN0aW9uKCkKICAgICB0aGlz Ll9kb3dubG9hZFRvb2xiYXJCdXR0b24gPSBuZXcgV2ViSW5zcGVjdG9yLkJ1dHRvblRvb2xiYXJJ dGVtKCJkb3dubG9hZCIsIFdlYkluc3BlY3Rvci5VSVN0cmluZygiRG93bmxvYWQgV2ViIEFyY2hp dmUiKSwgbnVsbCwgIkltYWdlcy9Eb3dubG9hZEFycm93LnN2ZyIpOwogICAgIHRoaXMuX2Rvd25s b2FkVG9vbGJhckJ1dHRvbi5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5CdXR0b25OYXZp Z2F0aW9uSXRlbS5FdmVudC5DbGlja2VkLCB0aGlzLl9kb3dubG9hZFdlYkFyY2hpdmUsIHRoaXMp OwogCisgICAgdGhpcy5fdXBkYXRlUmVsb2FkVG9vbGJhckJ1dHRvbigpOwogICAgIHRoaXMuX3Vw ZGF0ZURvd25sb2FkVG9vbGJhckJ1dHRvbigpOwogCiAgICAgLy8gVGhlIHRvb2xiYXIgYnV0dG9u IGZvciBub2RlIGluc3BlY3Rpb24uCkBAIC0zMjUsNyArMzI2LDE0IEBAIFdlYkluc3BlY3Rvci5j b250ZW50TG9hZGVkID0gZnVuY3Rpb24oKQogICAgIHRoaXMuX3VwZGF0ZURvY2tOYXZpZ2F0aW9u SXRlbXMoKTsKICAgICB0aGlzLl91cGRhdGVUb29sYmFySGVpZ2h0KCk7CiAKKyAgICB0aGlzLl9w ZW5kaW5nT3BlblRhYlR5cGVzID0gW107CisKICAgICBmb3IgKHZhciB0YWJUeXBlIG9mIHRoaXMu X29wZW5UYWJzU2V0dGluZy52YWx1ZSkgeworICAgICAgICBpZiAoIXRoaXMuX2lzVGFiVHlwZUFs bG93ZWQodGFiVHlwZSkpIHsKKyAgICAgICAgICAgIHRoaXMuX3BlbmRpbmdPcGVuVGFiVHlwZXMu cHVzaCh0YWJUeXBlKTsKKyAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICB9CisKICAgICAg ICAgdmFyIHRhYkNvbnRlbnRWaWV3ID0gdGhpcy5fdGFiQ29udGVudFZpZXdGb3JUeXBlKHRhYlR5 cGUpOwogICAgICAgICBpZiAoIXRhYkNvbnRlbnRWaWV3KQogICAgICAgICAgICAgY29udGludWU7 CkBAIC0zNjEsNiArMzY5LDE4IEBAIFdlYkluc3BlY3Rvci5jb250ZW50TG9hZGVkID0gZnVuY3Rp b24oKQogICAgIHRoaXMucnVuQm9vdHN0cmFwT3BlcmF0aW9ucygpOwogfTsKIAorV2ViSW5zcGVj dG9yLl9pc1RhYlR5cGVBbGxvd2VkID0gZnVuY3Rpb24odGFiVHlwZSkKK3sKKyAgICBzd2l0Y2gg KHRhYlR5cGUpIHsKKyAgICBjYXNlIFdlYkluc3BlY3Rvci5FbGVtZW50c1RhYkNvbnRlbnRWaWV3 LlR5cGU6CisgICAgICAgIHJldHVybiAhIXdpbmRvdy5ET01BZ2VudDsKKyAgICBjYXNlIFdlYklu c3BlY3Rvci5UaW1lbGluZVRhYkNvbnRlbnRWaWV3LlR5cGU6CisgICAgICAgIHJldHVybiAhIXdp bmRvdy5UaW1lbGluZUFnZW50OworICAgIH0KKworICAgIHJldHVybiB0cnVlOworfTsKKwogV2Vi SW5zcGVjdG9yLl90YWJDb250ZW50Vmlld0ZvclR5cGUgPSBmdW5jdGlvbih0YWJUeXBlKQogewog ICAgIHN3aXRjaCAodGFiVHlwZSkgewpAQCAtNDExLDYgKzQzMSwyNyBAQCBXZWJJbnNwZWN0b3Iu YWN0aXZhdGVFeHRyYURvbWFpbnMgPSBmdW5jdGlvbihkb21haW5zKQogICAgIHRoaXMubm90aWZp Y2F0aW9ucy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV2ViSW5zcGVjdG9yLk5vdGlmaWNhdGlv bi5FeHRyYURvbWFpbnNBY3RpdmF0ZWQsIHsiZG9tYWlucyI6IGRvbWFpbnN9KTsKIAogICAgIFdl Ykluc3BlY3Rvci5DU1NDb21wbGV0aW9ucy5yZXF1ZXN0Q1NTTmFtZUNvbXBsZXRpb25zKCk7CisK KyAgICB0aGlzLl91cGRhdGVSZWxvYWRUb29sYmFyQnV0dG9uKCk7CisgICAgdGhpcy5fdXBkYXRl RG93bmxvYWRUb29sYmFyQnV0dG9uKCk7CisKKyAgICB2YXIgc3RpbGxQZW5kaW5nT3BlblRhYlR5 cGVzID0gW107CisgICAgZm9yICh2YXIgdGFiVHlwZSBvZiB0aGlzLl9wZW5kaW5nT3BlblRhYlR5 cGVzKSB7CisgICAgICAgIGlmICghdGhpcy5faXNUYWJUeXBlQWxsb3dlZCh0YWJUeXBlKSkgewor ICAgICAgICAgICAgc3RpbGxQZW5kaW5nT3BlblRhYlR5cGVzLnB1c2godGFiVHlwZSk7CisgICAg ICAgICAgICBjb250aW51ZTsKKyAgICAgICAgfQorCisgICAgICAgIHZhciB0YWJDb250ZW50Vmll dyA9IHRoaXMuX3RhYkNvbnRlbnRWaWV3Rm9yVHlwZSh0YWJUeXBlKTsKKyAgICAgICAgaWYgKCF0 YWJDb250ZW50VmlldykKKyAgICAgICAgICAgIGNvbnRpbnVlOworCisgICAgICAgIHRoaXMudGFi QnJvd3Nlci5hZGRUYWJGb3JDb250ZW50Vmlldyh0YWJDb250ZW50VmlldywgdHJ1ZSk7CisKKyAg ICAgICAgdGFiQ29udGVudFZpZXcucmVzdG9yZVN0YXRlRnJvbUNvb2tpZSgpOworICAgIH0KKwor ICAgIHRoaXMuX3BlbmRpbmdPcGVuVGFiVHlwZXMgPSBzdGlsbFBlbmRpbmdPcGVuVGFiVHlwZXM7 CiB9OwogCiBXZWJJbnNwZWN0b3IuY29udGVudEJyb3dzZXJUcmVlRWxlbWVudEZvclJlcHJlc2Vu dGVkT2JqZWN0ID0gZnVuY3Rpb24oY29udGVudEJyb3dzZXIsIHJlcHJlc2VudGVkT2JqZWN0KQpA QCAtMTM4Nyw5ICsxNDI4LDE5IEBAIFdlYkluc3BlY3Rvci5fcmVsb2FkUGFnZUlnbm9yaW5nQ2Fj aGUgPSBmdW5jdGlvbihldmVudCkKICAgICBQYWdlQWdlbnQucmVsb2FkKHRydWUpOwogfTsKIAor V2ViSW5zcGVjdG9yLl91cGRhdGVSZWxvYWRUb29sYmFyQnV0dG9uID0gZnVuY3Rpb24oKQorewor ICAgIGlmICghd2luZG93LlBhZ2VBZ2VudCB8fCAhUGFnZUFnZW50LnJlbG9hZCkgeworICAgICAg ICB0aGlzLl9yZWxvYWRUb29sYmFyQnV0dG9uLmhpZGRlbiA9IHRydWU7CisgICAgICAgIHJldHVy bjsKKyAgICB9CisKKyAgICB0aGlzLl9yZWxvYWRUb29sYmFyQnV0dG9uLmhpZGRlbiA9IGZhbHNl OworfTsKKwogV2ViSW5zcGVjdG9yLl91cGRhdGVEb3dubG9hZFRvb2xiYXJCdXR0b24gPSBmdW5j dGlvbigpCiB7Ci0gICAgaWYgKCFQYWdlQWdlbnQuYXJjaGl2ZSB8fCB0aGlzLmRlYnVnZ2FibGVU eXBlICE9PSBXZWJJbnNwZWN0b3IuRGVidWdnYWJsZVR5cGUuV2ViKSB7CisgICAgaWYgKCF3aW5k b3cuUGFnZUFnZW50IHx8ICFQYWdlQWdlbnQuYXJjaGl2ZSB8fCB0aGlzLmRlYnVnZ2FibGVUeXBl ICE9PSBXZWJJbnNwZWN0b3IuRGVidWdnYWJsZVR5cGUuV2ViKSB7CiAgICAgICAgIHRoaXMuX2Rv d25sb2FkVG9vbGJhckJ1dHRvbi5oaWRkZW4gPSB0cnVlOwogICAgICAgICByZXR1cm47CiAgICAg fQo=