144202 2015-04-25 17:39:08 -0700 Web Inspector: Save and restore tab state on reload and between sessions 2015-09-14 10:54:02 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 timothy timothy graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1088615 0 timothy 2015-04-25 17:39:08 -0700 Hook up the existing NavigationSidebar cookie save and restore for tabs. Each tab has a cookie. 1088616 1 251656 timothy 2015-04-25 17:41:52 -0700 Created attachment 251656 Patch 1088639 2 timothy 2015-04-25 18:36:08 -0700 r183322 – r183342 http://trac.webkit.org/log/?revs=183322-183342 1125627 3 251656 ossy 2015-09-14 10:54:02 -0700 Comment on attachment 251656 Patch Cleared review? from attachment 251656 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 251656 2015-04-25 17:41:52 -0700 2015-09-14 10:54:02 -0700 Patch bug-144202-20150425174045.patch text/plain 4955 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzMzExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAz MTVhZmE3ZDA2ZWJhNWIzMzZlNGEwZmQxYmU0ZGJjODE4ZjYyMjcyLi5lZjdhNWY1ZjQ5OWViMDI1 MmQ1MmEyZmJkMDg4NzVjMzAzODc4NTE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyNCBAQAogMjAxNS0wNC0yNSAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogU2F2ZSBhbmQgcmVzdG9yZSB0YWIgc3RhdGUg b24gcmVsb2FkIGFuZCBiZXR3ZWVuIHNlc3Npb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQyMDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLmNvbnRlbnRMb2FkZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9y Ll9tYWluUmVzb3VyY2VEaWRDaGFuZ2UpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLl9wcm92aXNp b25hbExvYWRTdGFydGVkKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5fcmVzdG9yZUNvb2tpZUZv ck9wZW5UYWJzKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5fc2F2ZUNvb2tpZUZvck9wZW5UYWJz KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5fcGFnZUhpZGRlbik6CisgICAgICAgICogVXNlcklu dGVyZmFjZS9WaWV3cy9UYWJDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5U YWJDb250ZW50Vmlldyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGFiQ29udGVudFZpZXcucHJv dG90eXBlLnJlc3RvcmVTdGF0ZUZyb21Db29raWUpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRh YkNvbnRlbnRWaWV3LnByb3RvdHlwZS5zYXZlU3RhdGVUb0Nvb2tpZSk6CisKKzIwMTUtMDQtMjUg IFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFNwbGl0IHNlYXJjaCBmcm9tIFJlc291cmNlU2lkZWJhclBhbmVsIGludG8gYSBTZWFy Y2ggdGFiIGFuZCBzaWRlYmFyCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDQxOTcKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvQmFzZS9NYWluLmpzCmluZGV4IDQ4YTEwNDMzZjhlYjQ0ZTU2MWUxMGM3Yzg5OTJmZTA3 ZWJhODc4YmUuLjk0YzQyZDZlNDNkYjliYWE0NjUzYmM1MjA2Yzg3MTU2OWRiNWQxODkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwor KysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKQEAg LTMzMiw2ICszMzIsOCBAQCBXZWJJbnNwZWN0b3IuY29udGVudExvYWRlZCA9IGZ1bmN0aW9uKCkK ICAgICAgICAgdGhpcy50YWJCcm93c2VyLmFkZFRhYkZvckNvbnRlbnRWaWV3KHRhYkNvbnRlbnRW aWV3LCB0cnVlKTsKICAgICB9CiAKKyAgICB0aGlzLl9yZXN0b3JlQ29va2llRm9yT3BlblRhYnMo KTsKKwogICAgIHRoaXMudGFiQmFyLnNlbGVjdGVkVGFiQmFySXRlbSA9IHRoaXMuX3NlbGVjdGVk VGFiSW5kZXhTZXR0aW5nLnZhbHVlOwogCiAgICAgaWYgKCF0aGlzLnRhYkJhci5zZWxlY3RlZFRh YkJhckl0ZW0pCkBAIC05OTcsNiArOTk5LDggQEAgV2ViSW5zcGVjdG9yLl9tYWluUmVzb3VyY2VE aWRDaGFuZ2UgPSBmdW5jdGlvbihldmVudCkKIAogICAgIHRoaXMuX2luUHJvdmlzaW9uYWxMb2Fk ID0gZmFsc2U7CiAKKyAgICB0aGlzLl9yZXN0b3JlQ29va2llRm9yT3BlblRhYnMoKTsKKwogICAg IHRoaXMuX3VwZGF0ZURvd25sb2FkVG9vbGJhckJ1dHRvbigpOwogCiAgICAgdGhpcy51cGRhdGVX aW5kb3dUaXRsZSgpOwpAQCAtMTAwNyw5ICsxMDExLDI3IEBAIFdlYkluc3BlY3Rvci5fcHJvdmlz aW9uYWxMb2FkU3RhcnRlZCA9IGZ1bmN0aW9uKGV2ZW50KQogICAgIGlmICghZXZlbnQudGFyZ2V0 LmlzTWFpbkZyYW1lKCkpCiAgICAgICAgIHJldHVybjsKIAorICAgIHRoaXMuX3NhdmVDb29raWVG b3JPcGVuVGFicygpOworCiAgICAgdGhpcy5faW5Qcm92aXNpb25hbExvYWQgPSB0cnVlOwogfTsK IAorV2ViSW5zcGVjdG9yLl9yZXN0b3JlQ29va2llRm9yT3BlblRhYnMgPSBmdW5jdGlvbihjYXVz ZWRCeVJlbG9hZCkKK3sKKyAgICBmb3IgKHZhciB0YWJCYXJJdGVtIG9mIHRoaXMudGFiQmFyLnRh YkJhckl0ZW1zKSB7CisgICAgICAgIHZhciB0YWJDb250ZW50VmlldyA9IHRhYkJhckl0ZW0ucmVw cmVzZW50ZWRPYmplY3Q7CisgICAgICAgIHRhYkNvbnRlbnRWaWV3LnJlc3RvcmVTdGF0ZUZyb21D b29raWUoY2F1c2VkQnlSZWxvYWQpOworICAgIH0KK307CisKK1dlYkluc3BlY3Rvci5fc2F2ZUNv b2tpZUZvck9wZW5UYWJzID0gZnVuY3Rpb24oKQoreworICAgIGZvciAodmFyIHRhYkJhckl0ZW0g b2YgdGhpcy50YWJCYXIudGFiQmFySXRlbXMpIHsKKyAgICAgICAgdmFyIHRhYkNvbnRlbnRWaWV3 ID0gdGFiQmFySXRlbS5yZXByZXNlbnRlZE9iamVjdDsKKyAgICAgICAgdGFiQ29udGVudFZpZXcu c2F2ZVN0YXRlVG9Db29raWUoKTsKKyAgICB9Cit9OworCiBXZWJJbnNwZWN0b3IuX3dpbmRvd0Zv Y3VzZWQgPSBmdW5jdGlvbihldmVudCkKIHsKICAgICBpZiAoZXZlbnQudGFyZ2V0LmRvY3VtZW50 Lm5vZGVUeXBlICE9PSBOb2RlLkRPQ1VNRU5UX05PREUgfHwgdGhpcy5kb2NrZWQpCkBAIC0xMDY1 LDcgKzEwODcsNyBAQCBXZWJJbnNwZWN0b3IuX21vdXNlTW92ZWQgPSBmdW5jdGlvbihldmVudCkK IAogV2ViSW5zcGVjdG9yLl9wYWdlSGlkZGVuID0gZnVuY3Rpb24oZXZlbnQpCiB7Ci0gICAgLy8g RklYTUU6IFNhdmUgaW5zcGVjdG9yIHN0YXRlLgorICAgIHRoaXMuX3NhdmVDb29raWVGb3JPcGVu VGFicygpOwogfTsKIAogV2ViSW5zcGVjdG9yLl91bmRvY2sgPSBmdW5jdGlvbihldmVudCkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYkNv bnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv VGFiQ29udGVudFZpZXcuanMKaW5kZXggYjlmNDAwMmU0M2Q0MGQ0NTEyOTg5OWVmYzE4NmFjYjRm ZDIyNzMxZS4uMmQ4ZGYxNzM3Mjk5NjdiM2QyNDk5ODhhYzJiZTdkN2JhMGVjNGJiMiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFiQ29udGVu dFZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv VGFiQ29udGVudFZpZXcuanMKQEAgLTQ5LDYgKzQ5LDggQEAgV2ViSW5zcGVjdG9yLlRhYkNvbnRl bnRWaWV3ID0gZnVuY3Rpb24oaWRlbnRpZmllciwgc3R5bGVDbGFzc05hbWVzLCB0YWJCYXJJdGVt LAogCiAgICAgdGhpcy5fZGV0YWlsc1NpZGViYXJDb2xsYXBzZWRTZXR0aW5nID0gbmV3IFdlYklu c3BlY3Rvci5TZXR0aW5nKGlkZW50aWZpZXIgKyAiLWRldGFpbHMtc2lkZWJhci1jb2xsYXBzZWQi LCB0cnVlKTsKICAgICB0aGlzLl9kZXRhaWxzU2lkZWJhclNlbGVjdGVkUGFuZWxTZXR0aW5nID0g bmV3IFdlYkluc3BlY3Rvci5TZXR0aW5nKGlkZW50aWZpZXIgKyAiLWRldGFpbHMtc2lkZWJhci1z ZWxlY3RlZC1wYW5lbCIsIG51bGwpOworCisgICAgdGhpcy5fY29va2llU2V0dGluZyA9IG5ldyBX ZWJJbnNwZWN0b3IuU2V0dGluZyhpZGVudGlmaWVyICsgIi10YWItY29va2llIiwge30pOwogfTsK IAogV2ViSW5zcGVjdG9yLlRhYkNvbnRlbnRWaWV3LnByb3RvdHlwZSA9IHsKQEAgLTEwNSw2ICsx MDcsMjggQEAgV2ViSW5zcGVjdG9yLlRhYkNvbnRlbnRWaWV3LnByb3RvdHlwZSA9IHsKICAgICAg ICAgcmV0dXJuIGZhbHNlOwogICAgIH0sCiAKKyAgICByZXN0b3JlU3RhdGVGcm9tQ29va2llOiBm dW5jdGlvbihjYXVzZWRCeVJlbG9hZCkKKyAgICB7CisgICAgICAgIGlmICghdGhpcy5uYXZpZ2F0 aW9uU2lkZWJhclBhbmVsKQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIHZhciBtYXRj aFR5cGVPbmx5RGVsYXlGb3JSZWxvYWQgPSAyMDAwOworICAgICAgICB2YXIgbWF0Y2hUeXBlT25s eURlbGF5Rm9yUmVvcGVuID0gMTAwMDsKKworICAgICAgICB2YXIgcmVsYXhNYXRjaERlbGF5ID0g Y2F1c2VkQnlSZWxvYWQgPyBtYXRjaFR5cGVPbmx5RGVsYXlGb3JSZWxvYWQgOiBtYXRjaFR5cGVP bmx5RGVsYXlGb3JSZW9wZW47CisgICAgICAgIHRoaXMubmF2aWdhdGlvblNpZGViYXJQYW5lbC5y ZXN0b3JlU3RhdGVGcm9tQ29va2llKHRoaXMuX2Nvb2tpZVNldHRpbmcudmFsdWUgfHwge30sIHJl bGF4TWF0Y2hEZWxheSk7CisgICAgfSwKKworICAgIHNhdmVTdGF0ZVRvQ29va2llOiBmdW5jdGlv bigpCisgICAgeworICAgICAgICBpZiAoIXRoaXMubmF2aWdhdGlvblNpZGViYXJQYW5lbCkKKyAg ICAgICAgICAgIHJldHVybjsKKworICAgICAgICB2YXIgY29va2llID0gdGhpcy5fY29va2llU2V0 dGluZy52YWx1ZSB8fCB7fTsKKyAgICAgICAgdGhpcy5uYXZpZ2F0aW9uU2lkZWJhclBhbmVsLnNh dmVTdGF0ZVRvQ29va2llKGNvb2tpZSk7CisgICAgICAgIHRoaXMuX2Nvb2tpZVNldHRpbmcudmFs dWUgPSBjb29raWU7CisgICAgfSwKKwogICAgIGdldCBuYXZpZ2F0aW9uU2lkZWJhclBhbmVsKCkK ICAgICB7CiAgICAgICAgIHJldHVybiB0aGlzLl9uYXZpZ2F0aW9uU2lkZWJhclBhbmVsOwo=