144201 2015-04-25 17:38:31 -0700 Avoid using TBD as an argument to NS_AVAILABLE 2015-04-25 23:08:10 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mitz mitz commit-queue oldest_to_newest 1088614 0 mitz 2015-04-25 17:38:31 -0700 <rdar://problem/20697966> CFAvailability.h tells us // Do not use TBD as an argument to NS_AVAILABLE but some of our generated bindings headers do it anyway. 1088631 1 251661 mitz 2015-04-25 18:35:33 -0700 Created attachment 251661 Use a version number instead of TBD 1088653 2 commit-queue 2015-04-25 18:37:41 -0700 Attachment 251661 did not pass style-queue: ERROR: Source/WebCore/bindings/objc/WebKitAvailability.h:35: Missing spaces around = [whitespace/operators] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1088654 3 mitz 2015-04-25 18:39:59 -0700 Committed <http://trac.webkit.org/r183343>. 1088706 4 ap 2015-04-25 23:00:42 -0700 This broke bindings generation tests on all bots, e.g.: -WEBKIT_CLASS_AVAILABLE_MAC(TBD) +WEBKIT_CLASS_AVAILABLE_MAC(9876_5) Is this the new expected behavior? 1088707 5 mitz 2015-04-25 23:01:39 -0700 (In reply to comment #4) > This broke bindings generation tests on all bots, e.g.: > > -WEBKIT_CLASS_AVAILABLE_MAC(TBD) > +WEBKIT_CLASS_AVAILABLE_MAC(9876_5) > > Is this the new expected behavior? I’m sorry, yes, it is expected. 1088709 6 mitz 2015-04-25 23:08:10 -0700 Updated the expected test results in <http://trac.webkit.org/r183350>. 251661 2015-04-25 18:35:33 -0700 2015-04-25 18:38:13 -0700 Use a version number instead of TBD bug-144201-20150425183427.patch text/plain 5004 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MzMzOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA0LTI1ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViQ29yZSBwYXJ0IG9mIDxyZGFy Oi8vcHJvYmxlbS8yMDY5Nzk2Nj4gQXZvaWQgdXNpbmcgVEJEIGFzIGFuIGFyZ3VtZW50IHRvIE5T X0FWQUlMQUJMRQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQ0MjAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgSW5zdGVhZCBvZiBUQkQsIHVzZSB0aGUgaGlnaCB2ZXJzaW9uIG51bWJlciB0byB3aGljaCBp dCBjb3JyZXNwb25kcyBpbiBDRkF2YWlsYWJpbGl0eS5oLAorICAgICAgICA5ODc2LjUuCisKKyAg ICAgICAgKiBiaW5kaW5ncy9vYmpjL1dlYktpdEF2YWlsYWJpbGl0eS5oOiBBZGRlZCBhIGRlZmlu aXRpb24gb2YgX19OU2lfOTg3Nl81LCBzbyB0aGF0IHdlIGNhbgorICAgICAgICB1c2UgOTg3Nl81 IGluIGF2YWlsYWJpbGl0eSBtYWNyb3MuIFJlbW92ZWQgdGhlIGRlZmluaXRpb24gb2YKKyAgICAg ICAgX19BVkFJTEFCSUxJVFlfSU5URVJOQUxfX01BQ19UQkQsIHdoaWNoIHdpbGwgbm8gbG9uZ2Vy IGJlIHVzZWQuCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JPYmpD LnBtOgorICAgICAgICAoUmVhZFB1YmxpY0ludGVyZmFjZXMpOiBVc2UgOTg3Nl81IGluc3RlYWQg b2YgVEJELgorCiAyMDE1LTA0LTI1ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAog ICAgICAgICBDcmFzaCBpZiBJREJUcmFuc2FjdGlvbiBpcyBhYm9ydGVkIHJpZ2h0IGFmdGVyIGl0 J3MgY3JlYXRlZApJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvb2JqYy9XZWJLaXRBdmFp bGFiaWxpdHkuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9vYmpjL1dl YktpdEF2YWlsYWJpbGl0eS5oCShyZXZpc2lvbiAxODMzMDMpCisrKyBTb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9vYmpjL1dlYktpdEF2YWlsYWJpbGl0eS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMSwx MyArMzEsMTUgQEAKICNpZiAhVEFSR0VUX09TX0lQSE9ORQogI2ltcG9ydCA8Rm91bmRhdGlvbi9G b3VuZGF0aW9uLmg+CiAKKyNpZm5kZWYgX19OU2lfOTg3Nl81CisjZGVmaW5lIF9fTlNpXzk4NzZf NSBpbnRyb2R1Y2VkPTk4NzYuNQorI2VuZGlmCisKICNkZWZpbmUgV0VCS0lUX0FWQUlMQUJMRV9N QUMoaW50cm9kdWNlZCkgTlNfQVZBSUxBQkxFX01BQyhpbnRyb2R1Y2VkKQogI2RlZmluZSBXRUJL SVRfQ0xBU1NfQVZBSUxBQkxFX01BQyhpbnRyb2R1Y2VkKSBOU19DTEFTU19BVkFJTEFCTEVfTUFD KGludHJvZHVjZWQpCiAjZGVmaW5lIFdFQktJVF9FTlVNX0FWQUlMQUJMRV9NQUMoaW50cm9kdWNl ZCkgTlNfRU5VTV9BVkFJTEFCTEVfTUFDKGludHJvZHVjZWQpCiAjZGVmaW5lIFdFQktJVF9ERVBS RUNBVEVEX01BQyhpbnRyb2R1Y2VkLCBkZXByZWNhdGVkKSBOU19ERVBSRUNBVEVEX01BQyhpbnRy b2R1Y2VkLCBkZXByZWNhdGVkKQogCi0jZGVmaW5lIF9fQVZBSUxBQklMSVRZX0lOVEVSTkFMX19N QUNfVEJEIF9fYXR0cmlidXRlX18oKGF2YWlsYWJpbGl0eShtYWNvc3gsaW50cm9kdWNlZD05ODc2 LjUpKSkKLQogI2lmbmRlZiBBVkFJTEFCTEVfTUFDX09TX1hfVkVSU0lPTl8xMF8wX0FORF9MQVRF Ul9CVVRfREVQUkVDQVRFRF9JTl9NQUNfT1NfWF9WRVJTSU9OXzEwXzAKICNkZWZpbmUgQVZBSUxB QkxFX01BQ19PU19YX1ZFUlNJT05fMTBfMF9BTkRfTEFURVJfQlVUX0RFUFJFQ0FURURfSU5fTUFD X09TX1hfVkVSU0lPTl8xMF8wIERFUFJFQ0FURURfSU5fTUFDX09TX1hfVkVSU0lPTl8xMF8wX0FO RF9MQVRFUgogI2RlZmluZSBBVkFJTEFCTEVfTUFDX09TX1hfVkVSU0lPTl8xMF8xX0FORF9MQVRF Ul9CVVRfREVQUkVDQVRFRF9JTl9NQUNfT1NfWF9WRVJTSU9OXzEwXzEgREVQUkVDQVRFRF9JTl9N QUNfT1NfWF9WRVJTSU9OXzEwXzFfQU5EX0xBVEVSCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JPYmpDLnBtCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvck9iakMucG0JKHJldmlzaW9uIDE4 MzMwMykKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvck9i akMucG0JKHdvcmtpbmcgY29weSkKQEAgLTIxNyw2ICsyMTcsOCBAQCBteSAkaW1wbGVtZW50YXRp b25MaWNlbnNlVGVtcGxhdGUgPSA8PCAiCiAgKi8KIEVPRgogCitteSAkVEJEQXZhaWxhYmlsaXR5 VmVyc2lvbiA9ICI5ODc2XzUiOworCiAjIERlZmF1bHQgY29uc3RydWN0b3IKIHN1YiBuZXcKIHsK QEAgLTI5Nyw3ICsyOTksNyBAQCBzdWIgUmVhZFB1YmxpY0ludGVyZmFjZXMKIAogICAgICMgSWYg dGhpcyBjbGFzcyB3YXMgbm90IGZvdW5kIGluIFB1YmxpY0RPTUludGVyZmFjZXMuaCB0aGVuIGl0 IHNob3VsZCBiZSBjb25zaWRlcmVkIGFzIGFuIGVudGlyZWx5IG5ldyBwdWJsaWMgY2xhc3MuCiAg ICAgJG5ld1B1YmxpY0NsYXNzID0gISRmb3VuZDsKLSAgICAkaW50ZXJmYWNlQXZhaWxhYmlsaXR5 VmVyc2lvbiA9ICJUQkQiIGlmICRuZXdQdWJsaWNDbGFzczsKKyAgICAkaW50ZXJmYWNlQXZhaWxh YmlsaXR5VmVyc2lvbiA9ICRUQkRBdmFpbGFiaWxpdHlWZXJzaW9uIGlmICRuZXdQdWJsaWNDbGFz czsKIH0KIAogc3ViIEFkZE1ldGhvZHNDb25zdGFudHNBbmRBdHRyaWJ1dGVzRnJvbVBhcmVudElu dGVyZmFjZXMKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MzMzOCkKKysrIFNvdXJjZS9XZWJL aXQyL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA0LTI1 ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViS2l0MiBwYXJ0 IG9mIDxyZGFyOi8vcHJvYmxlbS8yMDY5Nzk2Nj4gQXZvaWQgdXNpbmcgVEJEIGFzIGFuIGFyZ3Vt ZW50IHRvIE5TX0FWQUlMQUJMRQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQ0MjAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgSW5zdGVhZCBvZiBUQkQsIHdlIHVzZSB0aGUgaGlnaCB2ZXJzaW9uIG51bWJl ciB0byB3aGljaCBpdCBjb3JyZXNwb25kcyBpbiBDRkF2YWlsYWJpbGl0eS5oLAorICAgICAgICA5 ODc2LjUuCisKKyAgICAgICAgKiBtYWMvTWlncmF0ZUhlYWRlcnNGcm9tV2ViS2l0TGVnYWN5Lm1h a2U6IFRvIGRldGVjdCBub3QteWV0LWF2YWlsYWJsZSBkZWNsYXJhdGlvbnMgaW4KKyAgICAgICAg aGVhZGVycywgbG9vayBmb3IgIjk4NzZfNSIgcmF0aGVyIHRoYW4gIlRCQSIuCisKIDIwMTUtMDQt MjQgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IFJlbW92ZSBuYXRpdmUgd2luZG93IGRvY2sgY29udHJvbHMKSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL21hYy9NaWdyYXRlSGVhZGVyc0Zyb21XZWJLaXRMZWdhY3kubWFrZQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9tYWMvTWlncmF0ZUhlYWRlcnNGcm9tV2ViS2l0TGVnYWN5 Lm1ha2UJKHJldmlzaW9uIDE4MzMwMykKKysrIFNvdXJjZS9XZWJLaXQyL21hYy9NaWdyYXRlSGVh ZGVyc0Zyb21XZWJLaXRMZWdhY3kubWFrZQkod29ya2luZyBjb3B5KQpAQCAtMjAyLDcgKzIwMiw3 IEBAIFdFQktJVF9MRUdBQ1lfUFJJVkFURV9IRUFERVJTID0gJChhZGRwcmUKIFdFQktJVF9MRUdB Q1lfSEVBREVSX1JFUExBQ0VfUlVMRVMgPSAtZSBzL1w8V2ViS2l0TGVnYWN5L1w8V2ViS2l0Lwog V0VCS0lUX0xFR0FDWV9IRUFERVJfTUlHUkFURV9DTUQgPSBzZWQgJChXRUJLSVRfTEVHQUNZX0hF QURFUl9SRVBMQUNFX1JVTEVTKSAkPCA+ICRACiAKLVBVQkxJQ19IRUFERVJfQ0hFQ0tfQ01EID0g QGlmIGdyZXAgLXEgIkFWQUlMQUJMRS4qVEJEIiAiJDwiOyB0aGVuIGxpbmU9JCQoYXdrICIvQVZB SUxBQkxFLipUQkQvIHsgcHJpbnQgRk5SOyBleGl0IH0iICIkPCIgKTsgZWNobyAiJDw6JCRsaW5l OiBlcnJvcjogQSBjbGFzcyB3aXRoaW4gYSBwdWJsaWMgaGVhZGVyIGhhcyB1bnNwZWNpZmllZCBh dmFpbGFiaWxpdHkuIjsgZmFsc2U7IGZpCitQVUJMSUNfSEVBREVSX0NIRUNLX0NNRCA9IEBpZiBn cmVwIC1xICJBVkFJTEFCTEUuKjk4NzZfNSIgIiQ8IjsgdGhlbiBsaW5lPSQkKGF3ayAiL0FWQUlM QUJMRS4qOTg3Nl81LyB7IHByaW50IEZOUjsgZXhpdCB9IiAiJDwiICk7IGVjaG8gIiQ8OiQkbGlu ZTogZXJyb3I6IEEgY2xhc3Mgd2l0aGluIGEgcHVibGljIGhlYWRlciBoYXMgdW5zcGVjaWZpZWQg YXZhaWxhYmlsaXR5LiI7IGZhbHNlOyBmaQogCiAkKFBVQkxJQ19IRUFERVJTX0RJUikvJSA6ICQo V0VCS0lUX0xFR0FDWV9QUklWQVRFX0hFQURFUlNfRElSKS8lIE1pZ3JhdGVIZWFkZXJzRnJvbVdl YktpdExlZ2FjeS5tYWtlCiAJJChQVUJMSUNfSEVBREVSX0NIRUNLX0NNRCkK