<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>144176</bug_id>
          
          <creation_ts>2015-04-24 17:42:52 -0700</creation_ts>
          <short_desc>Function allocation sinking works for wrong reasons</short_desc>
          <delta_ts>2015-04-27 13:43:45 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Basile Clement">basile_clement</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>fpizlo</cc>
    
    <cc>ggaren</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1088433</commentid>
    <comment_count>0</comment_count>
    <who name="Basile Clement">basile_clement</who>
    <bug_when>2015-04-24 17:42:52 -0700</bug_when>
    <thetext>It is by design that we don&apos;t support sinking of function allocation through any related operations.
Object allocation, however, does sink through field assignment (PutByOffset etc.), so we have a check that is supposed to prevent function allocations from sinking through these.

However that check is misguided and (a) do not prevent function allocation sinking through field assignment and (b) ensures that if a function allocation ever sinks through a PutByOffset, very bad things happen instead.
Fortunately, PutByOffset (and their relatives) require first allocating a custom structure for the JSFunction object, thus the PutByOffset will always be preceded by an AllocatePropertyStorage through which no allocation can sink, and materialization would always be triggered before the PutByOffset - so this works by chance.

Anyway, this should be done the proper way, and I will submit a patch soon to prevent properly have checks preventing function allocation sinking through PutByOffset et al.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1088445</commentid>
    <comment_count>1</comment_count>
      <attachid>251602</attachid>
    <who name="Basile Clement">basile_clement</who>
    <bug_when>2015-04-24 18:01:54 -0700</bug_when>
    <thetext>Created attachment 251602
Should do the right thing

Compiles, but untested - will check my understanding of the nodes is correct and does not prevent valid object allocation sinking and add a ChangeLog entry on Monday.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1089116</commentid>
    <comment_count>2</comment_count>
      <attachid>251763</attachid>
    <who name="Basile Clement">basile_clement</who>
    <bug_when>2015-04-27 11:57:32 -0700</bug_when>
    <thetext>Created attachment 251763
Seems to be doing the right thing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1089118</commentid>
    <comment_count>3</comment_count>
      <attachid>251764</attachid>
    <who name="Basile Clement">basile_clement</who>
    <bug_when>2015-04-27 12:06:42 -0700</bug_when>
    <thetext>Created attachment 251764
Seems to be doing the right thing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1089119</commentid>
    <comment_count>4</comment_count>
      <attachid>251764</attachid>
    <who name="Basile Clement">basile_clement</who>
    <bug_when>2015-04-27 12:08:50 -0700</bug_when>
    <thetext>Comment on attachment 251764
Seems to be doing the right thing

View in context: https://bugs.webkit.org/attachment.cgi?id=251764&amp;action=review

&gt; Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp:812
&gt; +            if (target-&gt;op() != NewObject)

Unsure if I should add a helper function in DFG::Node for that...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1089120</commentid>
    <comment_count>5</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2015-04-27 12:10:00 -0700</bug_when>
    <thetext>You should rebase :-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1089121</commentid>
    <comment_count>6</comment_count>
      <attachid>251764</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2015-04-27 12:11:57 -0700</bug_when>
    <thetext>Comment on attachment 251764
Seems to be doing the right thing

View in context: https://bugs.webkit.org/attachment.cgi?id=251764&amp;action=review

&gt;&gt; Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp:812
&gt;&gt; +            if (target-&gt;op() != NewObject)
&gt; 
&gt; Unsure if I should add a helper function in DFG::Node for that...

Seems wrong - MaterializeNewObject is also a sink candidate.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1089127</commentid>
    <comment_count>7</comment_count>
    <who name="Basile Clement">basile_clement</who>
    <bug_when>2015-04-27 12:17:05 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; Comment on attachment 251764 [details]
&gt; Seems to be doing the right thing
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=251764&amp;action=review
&gt; 
&gt; &gt;&gt; Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp:812
&gt; &gt;&gt; +            if (target-&gt;op() != NewObject)
&gt; &gt; 
&gt; &gt; Unsure if I should add a helper function in DFG::Node for that...
&gt; 
&gt; Seems wrong - MaterializeNewObject is also a sink candidate.

Oh, duh, indeed. Fixing that, w/ a helper function then.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1089130</commentid>
    <comment_count>8</comment_count>
      <attachid>251768</attachid>
    <who name="Basile Clement">basile_clement</who>
    <bug_when>2015-04-27 12:29:31 -0700</bug_when>
    <thetext>Created attachment 251768
MaterializeNewObject is also sinkable...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1089138</commentid>
    <comment_count>9</comment_count>
    <who name="Basile Clement">basile_clement</who>
    <bug_when>2015-04-27 12:40:07 -0700</bug_when>
    <thetext>Sorry, should have tried a clean build.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1089140</commentid>
    <comment_count>10</comment_count>
      <attachid>251771</attachid>
    <who name="Basile Clement">basile_clement</who>
    <bug_when>2015-04-27 12:47:34 -0700</bug_when>
    <thetext>Created attachment 251771
Remove spurious MustGenerate</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1089167</commentid>
    <comment_count>11</comment_count>
      <attachid>251771</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-04-27 13:43:41 -0700</bug_when>
    <thetext>Comment on attachment 251771
Remove spurious MustGenerate

Clearing flags on attachment: 251771

Committed r183419: &lt;http://trac.webkit.org/changeset/183419&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1089168</commentid>
    <comment_count>12</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-04-27 13:43:45 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>251602</attachid>
            <date>2015-04-24 18:01:54 -0700</date>
            <delta_ts>2015-04-27 11:57:32 -0700</delta_ts>
            <desc>Should do the right thing</desc>
            <filename>fix_newfun_escape.patch</filename>
            <type>text/plain</type>
            <size>3307</size>
            <attacher name="Basile Clement">basile_clement</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT2JqZWN0QWxsb2NhdGlv
blNpbmtpbmdQaGFzZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09iamVjdEFs
bG9jYXRpb25TaW5raW5nUGhhc2UuY3BwCmluZGV4IGM5OGE4MmQuLmEyZjQyM2MgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT2JqZWN0QWxsb2NhdGlvblNpbmtpbmdQ
aGFzZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPYmplY3RBbGxvY2F0
aW9uU2lua2luZ1BoYXNlLmNwcApAQCAtNTExLDE0ICs1MTEsMTcgQEAgcHJpdmF0ZToKICAgICAg
ICAgICAgICAgICBzd2l0Y2ggKG5vZGUtPm9wKCkpIHsKICAgICAgICAgICAgICAgICBjYXNlIFB1
dEJ5T2Zmc2V0OiB7CiAgICAgICAgICAgICAgICAgICAgIE5vZGUqIHRhcmdldCA9IG5vZGUtPmNo
aWxkMigpLm5vZGUoKTsKLSAgICAgICAgICAgICAgICAgICAgaWYgKHRhcmdldC0+aXNQaGFudG9t
T2JqZWN0QWxsb2NhdGlvbigpICYmIG1fc2lua0NhbmRpZGF0ZXMuY29udGFpbnModGFyZ2V0KSkK
KyAgICAgICAgICAgICAgICAgICAgaWYgKG1fc2lua0NhbmRpZGF0ZXMuY29udGFpbnModGFyZ2V0
KSkgeworICAgICAgICAgICAgICAgICAgICAgICAgQVNTRVJUKHRhcmdldC0+aXNQaGFudG9tT2Jq
ZWN0QWxsb2NhdGlvbigpKTsKICAgICAgICAgICAgICAgICAgICAgICAgIG5vZGUtPmNvbnZlcnRU
b1B1dEJ5T2Zmc2V0SGludCgpOworICAgICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAg
ICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICAgICAgCiAg
ICAgICAgICAgICAgICAgY2FzZSBQdXRTdHJ1Y3R1cmU6IHsKICAgICAgICAgICAgICAgICAgICAg
Tm9kZSogdGFyZ2V0ID0gbm9kZS0+Y2hpbGQxKCkubm9kZSgpOwotICAgICAgICAgICAgICAgICAg
ICBpZiAodGFyZ2V0LT5pc1BoYW50b21PYmplY3RBbGxvY2F0aW9uKCkgJiYgbV9zaW5rQ2FuZGlk
YXRlcy5jb250YWlucyh0YXJnZXQpKSB7CisgICAgICAgICAgICAgICAgICAgIGlmIChtX3NpbmtD
YW5kaWRhdGVzLmNvbnRhaW5zKHRhcmdldCkpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIEFT
U0VSVCh0YXJnZXQtPmlzUGhhbnRvbU9iamVjdEFsbG9jYXRpb24oKSk7CiAgICAgICAgICAgICAg
ICAgICAgICAgICBOb2RlKiBzdHJ1Y3R1cmUgPSBtX2luc2VydGlvblNldC5pbnNlcnRDb25zdGFu
dCgKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBub2RlSW5kZXgsIG5vZGUtPm9yaWdpbiwg
SlNWYWx1ZShub2RlLT50cmFuc2l0aW9uKCktPm5leHQpKTsKICAgICAgICAgICAgICAgICAgICAg
ICAgIG5vZGUtPmNvbnZlcnRUb1B1dFN0cnVjdHVyZUhpbnQoc3RydWN0dXJlKTsKQEAgLTU4MCw4
ICs1ODMsMTAgQEAgcHJpdmF0ZToKICAgICAgICAgICAgICAgICBjYXNlIFN0b3JlQmFycmllcjoK
ICAgICAgICAgICAgICAgICBjYXNlIFN0b3JlQmFycmllcldpdGhOdWxsQ2hlY2s6IHsKICAgICAg
ICAgICAgICAgICAgICAgTm9kZSogdGFyZ2V0ID0gbm9kZS0+Y2hpbGQxKCkubm9kZSgpOwotICAg
ICAgICAgICAgICAgICAgICBpZiAodGFyZ2V0LT5pc1BoYW50b21PYmplY3RBbGxvY2F0aW9uKCkg
JiYgbV9zaW5rQ2FuZGlkYXRlcy5jb250YWlucyh0YXJnZXQpKQorICAgICAgICAgICAgICAgICAg
ICBpZiAobV9zaW5rQ2FuZGlkYXRlcy5jb250YWlucyh0YXJnZXQpKSB7CisgICAgICAgICAgICAg
ICAgICAgICAgICBBU1NFUlQodGFyZ2V0LT5pc1BoYW50b21PYmplY3RBbGxvY2F0aW9uKCkpOwog
ICAgICAgICAgICAgICAgICAgICAgICAgbm9kZS0+Y29udmVydFRvUGhhbnRvbSgpOworICAgICAg
ICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAg
ICAgIH0KICAgICAgICAgICAgICAgICAgICAgCkBAIC03ODksMjMgKzc5NCwzNiBAQCBwcml2YXRl
OgogICAgICAgICAgICAgICAgIH0pOwogICAgICAgICAgICAgYnJlYWs7CiAKLSAgICAgICAgY2Fz
ZSBDaGVja1N0cnVjdHVyZToKLSAgICAgICAgY2FzZSBHZXRCeU9mZnNldDoKLSAgICAgICAgY2Fz
ZSBNdWx0aUdldEJ5T2Zmc2V0OgotICAgICAgICBjYXNlIFB1dFN0cnVjdHVyZToKLSAgICAgICAg
Y2FzZSBHZXRHZXR0ZXJTZXR0ZXJCeU9mZnNldDoKICAgICAgICAgY2FzZSBNb3ZIaW50OgogICAg
ICAgICBjYXNlIFBoYW50b206CiAgICAgICAgIGNhc2UgQ2hlY2s6CiAgICAgICAgIGNhc2UgTXVz
dEdlbmVyYXRlOgotICAgICAgICBjYXNlIFN0b3JlQmFycmllcjoKLSAgICAgICAgY2FzZSBTdG9y
ZUJhcnJpZXJXaXRoTnVsbENoZWNrOgogICAgICAgICBjYXNlIFB1dEhpbnQ6CiAgICAgICAgICAg
ICBicmVhazsKKworICAgICAgICBjYXNlIFB1dFN0cnVjdHVyZToKKyAgICAgICAgY2FzZSBDaGVj
a1N0cnVjdHVyZToKKyAgICAgICAgY2FzZSBHZXRCeU9mZnNldDoKKyAgICAgICAgY2FzZSBNdWx0
aUdldEJ5T2Zmc2V0OgorICAgICAgICBjYXNlIEdldEdldHRlclNldHRlckJ5T2Zmc2V0OgorICAg
ICAgICBjYXNlIFN0b3JlQmFycmllcjoKKyAgICAgICAgY2FzZSBTdG9yZUJhcnJpZXJXaXRoTnVs
bENoZWNrOiB7CisgICAgICAgICAgICBOb2RlKiB0YXJnZXQgPSBub2RlLT5jaGlsZDEoKS5ub2Rl
KCk7CisgICAgICAgICAgICBpZiAoIXRhcmdldC0+aXNQaGFudG9tT2JqZWN0QWxsb2NhdGlvbigp
KSB7CisgICAgICAgICAgICAgICAgZXNjYXBlKHRhcmdldCk7CisgICAgICAgICAgICB9CisgICAg
ICAgICAgICBicmVhazsKKyAgICAgICAgfQogICAgICAgICAgICAgCi0gICAgICAgIGNhc2UgUHV0
QnlPZmZzZXQ6CisgICAgICAgIGNhc2UgUHV0QnlPZmZzZXQ6IHsKKyAgICAgICAgICAgIE5vZGUq
IHRhcmdldCA9IG5vZGUtPmNoaWxkMigpLm5vZGUoKTsKKyAgICAgICAgICAgIGlmICghdGFyZ2V0
LT5pc1BoYW50b21PYmplY3RBbGxvY2F0aW9uKCkpIHsKKyAgICAgICAgICAgICAgICBlc2NhcGUo
dGFyZ2V0KTsKKyAgICAgICAgICAgICAgICBlc2NhcGUobm9kZS0+Y2hpbGQxKCkubm9kZSgpKTsK
KyAgICAgICAgICAgIH0KICAgICAgICAgICAgIGVzY2FwZShub2RlLT5jaGlsZDMoKS5ub2RlKCkp
OwogICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0KICAgICAgICAgICAgIAogICAgICAgICBj
YXNlIE11bHRpUHV0QnlPZmZzZXQ6CiAgICAgICAgICAgICAvLyBGSVhNRTogSW4gdGhlIGZ1dHVy
ZSB3ZSBzaG91bGQgYmUgYWJsZSB0byBoYW5kbGUgdGhpcy4gSXQncyBqdXN0IGEgbWF0dGVyIG9m
Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>251763</attachid>
            <date>2015-04-27 11:57:32 -0700</date>
            <delta_ts>2015-04-27 12:06:42 -0700</delta_ts>
            <desc>Seems to be doing the right thing</desc>
            <filename>fix_fun_alloc.patch</filename>
            <type>text/plain</type>
            <size>4763</size>
            <attacher name="Basile Clement">basile_clement</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDlkYjUxMmQuLjNjMDZjMzcgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD
b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE1LTA0LTI3ICBCYXNpbGUgQ2xlbWVu
dCAgPGJhc2lsZV9jbGVtZW50QGFwcGxlLmNvbT4KKworICAgICAgICBGdW5jdGlvbiBhbGxvY2F0
aW9ucyBzaG91bGRuJ3Qgc2luayB0aHJvdWdoIFB1dCBvcGVyYXRpb25zCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQxNzYKKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCeSBkZXNpZ24sIHdlIGRvbid0IHN1
cHBvcnQgZnVuY3Rpb24gYWxsb2NhdGlvbiBzaW5raW5nIHRocm91Z2ggYW55CisgICAgICAgIHJl
bGF0ZWQgb3BlcmF0aW9uIDsgaG93ZXZlciBvYmplY3QgYWxsb2NhdGlvbiBjYW4gc2luayB0aHJv
dWdoIFB1dEJ5T2Zmc2V0IGV0CisgICAgICAgIGFsLgorCisgICAgICAgIEN1cnJlbnRseSwgdGhl
IGNoZWNrcyB0byBwcmV2ZW50IGZ1bmN0aW9uIGFsbG9jYXRpb24gdG8gc2luayB0aHJvdWdoCisg
ICAgICAgIHRoZXNlIGFyZSBtaXNndWlkZWQgYW5kIGRvIG5vdCBwcmV2ZW50IGFueXRoaW5nIDsg
ZnVuY3Rpb24gYWxsb2NhdGlvbiBzaW5raW5nCisgICAgICAgIHRocm91Z2ggdGhlc2Ugb3BlcmF0
aW9ucyBpcyBwcmV2ZW50ZWQgYXMgYSBzaWRlIGVmZmVjdCBvZiByZXF1aXJpbmcgYW4KKyAgICAg
ICAgQWxsb2NhdGVQcm9wZXJ0eVN0b3JhZ2UgdGhyb3VnaCB3aGljaCB0aGUgZnVuY3Rpb24gYWxs
b2NhdGlvbiBpcyBzZWVuIGFzCisgICAgICAgIGVzY2FwaW5nLgorCisgICAgICAgIFRoaXMgY2hh
bmdlcyBpdCBzbyB0aGF0IE9iamVjdEFsbG9jYXRpb25TaW5raW5nUGhhc2U6OmhhbmRsZU5vZGUo
KQorICAgICAgICBjaGVja3MgcHJvcGVybHkgdGhhdCBvbmx5IG9iamVjdCBhbGxvY2F0aW9ucyBz
aW5rIHRocm91Z2ggcmVsYXRlZCB3cml0ZQorICAgICAgICBvcGVyYXRpb25zLgorCisgICAgICAg
ICogZGZnL0RGR09iamVjdEFsbG9jYXRpb25TaW5raW5nUGhhc2UuY3BwOgorICAgICAgICAoSlND
OjpERkc6Ok9iamVjdEFsbG9jYXRpb25TaW5raW5nUGhhc2U6Omxvd2VyTm9uUmVhZGluZ09wZXJh
dGlvbnNPblBoYW50b21BbGxvY2F0aW9ucyk6CisgICAgICAgIChKU0M6OkRGRzo6T2JqZWN0QWxs
b2NhdGlvblNpbmtpbmdQaGFzZTo6aGFuZGxlTm9kZSk6CisKIDIwMTUtMDQtMjMgIEJlbmphbWlu
IFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGEgdXNlbGVz
cyBicmFuY2ggb24gREZHR3JhcGg6OmFkZFNob3VsZFNwZWN1bGF0ZU1hY2hpbmVJbnQoKQpkaWZm
IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPYmplY3RBbGxvY2F0aW9uU2lu
a2luZ1BoYXNlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT2JqZWN0QWxsb2Nh
dGlvblNpbmtpbmdQaGFzZS5jcHAKaW5kZXggYzk4YTgyZC4uYTY1ZWY3OSAxMDA2NDQKLS0tIGEv
U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPYmplY3RBbGxvY2F0aW9uU2lua2luZ1BoYXNl
LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09iamVjdEFsbG9jYXRpb25T
aW5raW5nUGhhc2UuY3BwCkBAIC01MTEsMTQgKzUxMSwxNyBAQCBwcml2YXRlOgogICAgICAgICAg
ICAgICAgIHN3aXRjaCAobm9kZS0+b3AoKSkgewogICAgICAgICAgICAgICAgIGNhc2UgUHV0QnlP
ZmZzZXQ6IHsKICAgICAgICAgICAgICAgICAgICAgTm9kZSogdGFyZ2V0ID0gbm9kZS0+Y2hpbGQy
KCkubm9kZSgpOwotICAgICAgICAgICAgICAgICAgICBpZiAodGFyZ2V0LT5pc1BoYW50b21PYmpl
Y3RBbGxvY2F0aW9uKCkgJiYgbV9zaW5rQ2FuZGlkYXRlcy5jb250YWlucyh0YXJnZXQpKQorICAg
ICAgICAgICAgICAgICAgICBpZiAobV9zaW5rQ2FuZGlkYXRlcy5jb250YWlucyh0YXJnZXQpKSB7
CisgICAgICAgICAgICAgICAgICAgICAgICBBU1NFUlQodGFyZ2V0LT5pc1BoYW50b21PYmplY3RB
bGxvY2F0aW9uKCkpOwogICAgICAgICAgICAgICAgICAgICAgICAgbm9kZS0+Y29udmVydFRvUHV0
QnlPZmZzZXRIaW50KCk7CisgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICAg
ICAgYnJlYWs7CiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgICAgICAKICAgICAg
ICAgICAgICAgICBjYXNlIFB1dFN0cnVjdHVyZTogewogICAgICAgICAgICAgICAgICAgICBOb2Rl
KiB0YXJnZXQgPSBub2RlLT5jaGlsZDEoKS5ub2RlKCk7Ci0gICAgICAgICAgICAgICAgICAgIGlm
ICh0YXJnZXQtPmlzUGhhbnRvbU9iamVjdEFsbG9jYXRpb24oKSAmJiBtX3NpbmtDYW5kaWRhdGVz
LmNvbnRhaW5zKHRhcmdldCkpIHsKKyAgICAgICAgICAgICAgICAgICAgaWYgKG1fc2lua0NhbmRp
ZGF0ZXMuY29udGFpbnModGFyZ2V0KSkgeworICAgICAgICAgICAgICAgICAgICAgICAgQVNTRVJU
KHRhcmdldC0+aXNQaGFudG9tT2JqZWN0QWxsb2NhdGlvbigpKTsKICAgICAgICAgICAgICAgICAg
ICAgICAgIE5vZGUqIHN0cnVjdHVyZSA9IG1faW5zZXJ0aW9uU2V0Lmluc2VydENvbnN0YW50KAog
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIG5vZGVJbmRleCwgbm9kZS0+b3JpZ2luLCBKU1Zh
bHVlKG5vZGUtPnRyYW5zaXRpb24oKS0+bmV4dCkpOwogICAgICAgICAgICAgICAgICAgICAgICAg
bm9kZS0+Y29udmVydFRvUHV0U3RydWN0dXJlSGludChzdHJ1Y3R1cmUpOwpAQCAtNTgwLDggKzU4
MywxMCBAQCBwcml2YXRlOgogICAgICAgICAgICAgICAgIGNhc2UgU3RvcmVCYXJyaWVyOgogICAg
ICAgICAgICAgICAgIGNhc2UgU3RvcmVCYXJyaWVyV2l0aE51bGxDaGVjazogewogICAgICAgICAg
ICAgICAgICAgICBOb2RlKiB0YXJnZXQgPSBub2RlLT5jaGlsZDEoKS5ub2RlKCk7Ci0gICAgICAg
ICAgICAgICAgICAgIGlmICh0YXJnZXQtPmlzUGhhbnRvbU9iamVjdEFsbG9jYXRpb24oKSAmJiBt
X3NpbmtDYW5kaWRhdGVzLmNvbnRhaW5zKHRhcmdldCkpCisgICAgICAgICAgICAgICAgICAgIGlm
IChtX3NpbmtDYW5kaWRhdGVzLmNvbnRhaW5zKHRhcmdldCkpIHsKKyAgICAgICAgICAgICAgICAg
ICAgICAgIEFTU0VSVCh0YXJnZXQtPmlzUGhhbnRvbU9iamVjdEFsbG9jYXRpb24oKSk7CiAgICAg
ICAgICAgICAgICAgICAgICAgICBub2RlLT5jb252ZXJ0VG9QaGFudG9tKCk7CisgICAgICAgICAg
ICAgICAgICAgIH0KICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICAgICAg
fQogICAgICAgICAgICAgICAgICAgICAKQEAgLTc4OSwyMyArNzk0LDM2IEBAIHByaXZhdGU6CiAg
ICAgICAgICAgICAgICAgfSk7CiAgICAgICAgICAgICBicmVhazsKIAotICAgICAgICBjYXNlIENo
ZWNrU3RydWN0dXJlOgotICAgICAgICBjYXNlIEdldEJ5T2Zmc2V0OgotICAgICAgICBjYXNlIE11
bHRpR2V0QnlPZmZzZXQ6Ci0gICAgICAgIGNhc2UgUHV0U3RydWN0dXJlOgotICAgICAgICBjYXNl
IEdldEdldHRlclNldHRlckJ5T2Zmc2V0OgogICAgICAgICBjYXNlIE1vdkhpbnQ6CiAgICAgICAg
IGNhc2UgUGhhbnRvbToKICAgICAgICAgY2FzZSBDaGVjazoKICAgICAgICAgY2FzZSBNdXN0R2Vu
ZXJhdGU6Ci0gICAgICAgIGNhc2UgU3RvcmVCYXJyaWVyOgotICAgICAgICBjYXNlIFN0b3JlQmFy
cmllcldpdGhOdWxsQ2hlY2s6CiAgICAgICAgIGNhc2UgUHV0SGludDoKICAgICAgICAgICAgIGJy
ZWFrOworCisgICAgICAgIGNhc2UgUHV0U3RydWN0dXJlOgorICAgICAgICBjYXNlIENoZWNrU3Ry
dWN0dXJlOgorICAgICAgICBjYXNlIEdldEJ5T2Zmc2V0OgorICAgICAgICBjYXNlIE11bHRpR2V0
QnlPZmZzZXQ6CisgICAgICAgIGNhc2UgR2V0R2V0dGVyU2V0dGVyQnlPZmZzZXQ6CisgICAgICAg
IGNhc2UgU3RvcmVCYXJyaWVyOgorICAgICAgICBjYXNlIFN0b3JlQmFycmllcldpdGhOdWxsQ2hl
Y2s6IHsKKyAgICAgICAgICAgIE5vZGUqIHRhcmdldCA9IG5vZGUtPmNoaWxkMSgpLm5vZGUoKTsK
KyAgICAgICAgICAgIGlmICh0YXJnZXQtPm9wKCkgIT0gTmV3T2JqZWN0KSB7CisgICAgICAgICAg
ICAgICAgZXNjYXBlKHRhcmdldCk7CisgICAgICAgICAgICB9CisgICAgICAgICAgICBicmVhazsK
KyAgICAgICAgfQogICAgICAgICAgICAgCi0gICAgICAgIGNhc2UgUHV0QnlPZmZzZXQ6CisgICAg
ICAgIGNhc2UgUHV0QnlPZmZzZXQ6IHsKKyAgICAgICAgICAgIE5vZGUqIHRhcmdldCA9IG5vZGUt
PmNoaWxkMigpLm5vZGUoKTsKKyAgICAgICAgICAgIGlmICh0YXJnZXQtPm9wKCkgIT0gTmV3T2Jq
ZWN0KSB7CisgICAgICAgICAgICAgICAgZXNjYXBlKHRhcmdldCk7CisgICAgICAgICAgICAgICAg
ZXNjYXBlKG5vZGUtPmNoaWxkMSgpLm5vZGUoKSk7CisgICAgICAgICAgICB9CiAgICAgICAgICAg
ICBlc2NhcGUobm9kZS0+Y2hpbGQzKCkubm9kZSgpKTsKICAgICAgICAgICAgIGJyZWFrOworICAg
ICAgICB9CiAgICAgICAgICAgICAKICAgICAgICAgY2FzZSBNdWx0aVB1dEJ5T2Zmc2V0OgogICAg
ICAgICAgICAgLy8gRklYTUU6IEluIHRoZSBmdXR1cmUgd2Ugc2hvdWxkIGJlIGFibGUgdG8gaGFu
ZGxlIHRoaXMuIEl0J3MganVzdCBhIG1hdHRlciBvZgo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>251764</attachid>
            <date>2015-04-27 12:06:42 -0700</date>
            <delta_ts>2015-04-27 12:29:31 -0700</delta_ts>
            <desc>Seems to be doing the right thing</desc>
            <filename>fix_fun_alloc.patch</filename>
            <type>text/plain</type>
            <size>4728</size>
            <attacher name="Basile Clement">basile_clement</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDVmMWJiMjAuLmQxNTkyMzkgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD
b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE1LTA0LTI3ICBCYXNpbGUgQ2xlbWVu
dCAgPGJhc2lsZV9jbGVtZW50QGFwcGxlLmNvbT4KKworICAgICAgICBGdW5jdGlvbiBhbGxvY2F0
aW9ucyBzaG91bGRuJ3Qgc2luayB0aHJvdWdoIFB1dCBvcGVyYXRpb25zCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQxNzYKKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCeSBkZXNpZ24sIHdlIGRvbid0IHN1
cHBvcnQgZnVuY3Rpb24gYWxsb2NhdGlvbiBzaW5raW5nIHRocm91Z2ggYW55CisgICAgICAgIHJl
bGF0ZWQgb3BlcmF0aW9uIDsgaG93ZXZlciBvYmplY3QgYWxsb2NhdGlvbiBjYW4gc2luayB0aHJv
dWdoIFB1dEJ5T2Zmc2V0IGV0CisgICAgICAgIGFsLgorCisgICAgICAgIEN1cnJlbnRseSwgdGhl
IGNoZWNrcyB0byBwcmV2ZW50IGZ1bmN0aW9uIGFsbG9jYXRpb24gdG8gc2luayB0aHJvdWdoCisg
ICAgICAgIHRoZXNlIGFyZSBtaXNndWlkZWQgYW5kIGRvIG5vdCBwcmV2ZW50IGFueXRoaW5nIDsg
ZnVuY3Rpb24gYWxsb2NhdGlvbiBzaW5raW5nCisgICAgICAgIHRocm91Z2ggdGhlc2Ugb3BlcmF0
aW9ucyBpcyBwcmV2ZW50ZWQgYXMgYSBzaWRlIGVmZmVjdCBvZiByZXF1aXJpbmcgYW4KKyAgICAg
ICAgQWxsb2NhdGVQcm9wZXJ0eVN0b3JhZ2UgdGhyb3VnaCB3aGljaCB0aGUgZnVuY3Rpb24gYWxs
b2NhdGlvbiBpcyBzZWVuIGFzCisgICAgICAgIGVzY2FwaW5nLgorCisgICAgICAgIFRoaXMgY2hh
bmdlcyBpdCBzbyB0aGF0IE9iamVjdEFsbG9jYXRpb25TaW5raW5nUGhhc2U6OmhhbmRsZU5vZGUo
KQorICAgICAgICBjaGVja3MgcHJvcGVybHkgdGhhdCBvbmx5IG9iamVjdCBhbGxvY2F0aW9ucyBz
aW5rIHRocm91Z2ggcmVsYXRlZCB3cml0ZQorICAgICAgICBvcGVyYXRpb25zLgorCisgICAgICAg
ICogZGZnL0RGR09iamVjdEFsbG9jYXRpb25TaW5raW5nUGhhc2UuY3BwOgorICAgICAgICAoSlND
OjpERkc6Ok9iamVjdEFsbG9jYXRpb25TaW5raW5nUGhhc2U6Omxvd2VyTm9uUmVhZGluZ09wZXJh
dGlvbnNPblBoYW50b21BbGxvY2F0aW9ucyk6CisgICAgICAgIChKU0M6OkRGRzo6T2JqZWN0QWxs
b2NhdGlvblNpbmtpbmdQaGFzZTo6aGFuZGxlTm9kZSk6CisKIDIwMTUtMDQtMjYgIFJ5b3N1a2Ug
Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQ2xhc3MgYm9keSBlbmRpbmcgd2l0
aCBhIHNlbWljb2xvbiB0aHJvd3MgYSBTeW50YXhFcnJvcgpkaWZmIC0tZ2l0IGEvU291cmNlL0ph
dmFTY3JpcHRDb3JlL2RmZy9ERkdPYmplY3RBbGxvY2F0aW9uU2lua2luZ1BoYXNlLmNwcCBiL1Nv
dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT2JqZWN0QWxsb2NhdGlvblNpbmtpbmdQaGFzZS5j
cHAKaW5kZXggYzk4YTgyZC4uNWFiZTdiNSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD
b3JlL2RmZy9ERkdPYmplY3RBbGxvY2F0aW9uU2lua2luZ1BoYXNlLmNwcAorKysgYi9Tb3VyY2Uv
SmF2YVNjcmlwdENvcmUvZGZnL0RGR09iamVjdEFsbG9jYXRpb25TaW5raW5nUGhhc2UuY3BwCkBA
IC01MTEsMTQgKzUxMSwxNyBAQCBwcml2YXRlOgogICAgICAgICAgICAgICAgIHN3aXRjaCAobm9k
ZS0+b3AoKSkgewogICAgICAgICAgICAgICAgIGNhc2UgUHV0QnlPZmZzZXQ6IHsKICAgICAgICAg
ICAgICAgICAgICAgTm9kZSogdGFyZ2V0ID0gbm9kZS0+Y2hpbGQyKCkubm9kZSgpOwotICAgICAg
ICAgICAgICAgICAgICBpZiAodGFyZ2V0LT5pc1BoYW50b21PYmplY3RBbGxvY2F0aW9uKCkgJiYg
bV9zaW5rQ2FuZGlkYXRlcy5jb250YWlucyh0YXJnZXQpKQorICAgICAgICAgICAgICAgICAgICBp
ZiAobV9zaW5rQ2FuZGlkYXRlcy5jb250YWlucyh0YXJnZXQpKSB7CisgICAgICAgICAgICAgICAg
ICAgICAgICBBU1NFUlQodGFyZ2V0LT5pc1BoYW50b21PYmplY3RBbGxvY2F0aW9uKCkpOwogICAg
ICAgICAgICAgICAgICAgICAgICAgbm9kZS0+Y29udmVydFRvUHV0QnlPZmZzZXRIaW50KCk7Cisg
ICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg
ICAgICAgICAgfQogICAgICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICBjYXNlIFB1
dFN0cnVjdHVyZTogewogICAgICAgICAgICAgICAgICAgICBOb2RlKiB0YXJnZXQgPSBub2RlLT5j
aGlsZDEoKS5ub2RlKCk7Ci0gICAgICAgICAgICAgICAgICAgIGlmICh0YXJnZXQtPmlzUGhhbnRv
bU9iamVjdEFsbG9jYXRpb24oKSAmJiBtX3NpbmtDYW5kaWRhdGVzLmNvbnRhaW5zKHRhcmdldCkp
IHsKKyAgICAgICAgICAgICAgICAgICAgaWYgKG1fc2lua0NhbmRpZGF0ZXMuY29udGFpbnModGFy
Z2V0KSkgeworICAgICAgICAgICAgICAgICAgICAgICAgQVNTRVJUKHRhcmdldC0+aXNQaGFudG9t
T2JqZWN0QWxsb2NhdGlvbigpKTsKICAgICAgICAgICAgICAgICAgICAgICAgIE5vZGUqIHN0cnVj
dHVyZSA9IG1faW5zZXJ0aW9uU2V0Lmluc2VydENvbnN0YW50KAogICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIG5vZGVJbmRleCwgbm9kZS0+b3JpZ2luLCBKU1ZhbHVlKG5vZGUtPnRyYW5zaXRp
b24oKS0+bmV4dCkpOwogICAgICAgICAgICAgICAgICAgICAgICAgbm9kZS0+Y29udmVydFRvUHV0
U3RydWN0dXJlSGludChzdHJ1Y3R1cmUpOwpAQCAtNTgwLDggKzU4MywxMCBAQCBwcml2YXRlOgog
ICAgICAgICAgICAgICAgIGNhc2UgU3RvcmVCYXJyaWVyOgogICAgICAgICAgICAgICAgIGNhc2Ug
U3RvcmVCYXJyaWVyV2l0aE51bGxDaGVjazogewogICAgICAgICAgICAgICAgICAgICBOb2RlKiB0
YXJnZXQgPSBub2RlLT5jaGlsZDEoKS5ub2RlKCk7Ci0gICAgICAgICAgICAgICAgICAgIGlmICh0
YXJnZXQtPmlzUGhhbnRvbU9iamVjdEFsbG9jYXRpb24oKSAmJiBtX3NpbmtDYW5kaWRhdGVzLmNv
bnRhaW5zKHRhcmdldCkpCisgICAgICAgICAgICAgICAgICAgIGlmIChtX3NpbmtDYW5kaWRhdGVz
LmNvbnRhaW5zKHRhcmdldCkpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIEFTU0VSVCh0YXJn
ZXQtPmlzUGhhbnRvbU9iamVjdEFsbG9jYXRpb24oKSk7CiAgICAgICAgICAgICAgICAgICAgICAg
ICBub2RlLT5jb252ZXJ0VG9QaGFudG9tKCk7CisgICAgICAgICAgICAgICAgICAgIH0KICAgICAg
ICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAg
ICAgICAKQEAgLTc4OSwyMyArNzk0LDM1IEBAIHByaXZhdGU6CiAgICAgICAgICAgICAgICAgfSk7
CiAgICAgICAgICAgICBicmVhazsKIAotICAgICAgICBjYXNlIENoZWNrU3RydWN0dXJlOgotICAg
ICAgICBjYXNlIEdldEJ5T2Zmc2V0OgotICAgICAgICBjYXNlIE11bHRpR2V0QnlPZmZzZXQ6Ci0g
ICAgICAgIGNhc2UgUHV0U3RydWN0dXJlOgotICAgICAgICBjYXNlIEdldEdldHRlclNldHRlckJ5
T2Zmc2V0OgogICAgICAgICBjYXNlIE1vdkhpbnQ6CiAgICAgICAgIGNhc2UgUGhhbnRvbToKICAg
ICAgICAgY2FzZSBDaGVjazoKICAgICAgICAgY2FzZSBNdXN0R2VuZXJhdGU6Ci0gICAgICAgIGNh
c2UgU3RvcmVCYXJyaWVyOgotICAgICAgICBjYXNlIFN0b3JlQmFycmllcldpdGhOdWxsQ2hlY2s6
CiAgICAgICAgIGNhc2UgUHV0SGludDoKICAgICAgICAgICAgIGJyZWFrOworCisgICAgICAgIGNh
c2UgUHV0U3RydWN0dXJlOgorICAgICAgICBjYXNlIENoZWNrU3RydWN0dXJlOgorICAgICAgICBj
YXNlIEdldEJ5T2Zmc2V0OgorICAgICAgICBjYXNlIE11bHRpR2V0QnlPZmZzZXQ6CisgICAgICAg
IGNhc2UgR2V0R2V0dGVyU2V0dGVyQnlPZmZzZXQ6CisgICAgICAgIGNhc2UgU3RvcmVCYXJyaWVy
OgorICAgICAgICBjYXNlIFN0b3JlQmFycmllcldpdGhOdWxsQ2hlY2s6IHsKKyAgICAgICAgICAg
IE5vZGUqIHRhcmdldCA9IG5vZGUtPmNoaWxkMSgpLm5vZGUoKTsKKyAgICAgICAgICAgIGlmICh0
YXJnZXQtPm9wKCkgIT0gTmV3T2JqZWN0KQorICAgICAgICAgICAgICAgIGVzY2FwZSh0YXJnZXQp
OworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0KICAgICAgICAgICAgIAotICAgICAgICBj
YXNlIFB1dEJ5T2Zmc2V0OgorICAgICAgICBjYXNlIFB1dEJ5T2Zmc2V0OiB7CisgICAgICAgICAg
ICBOb2RlKiB0YXJnZXQgPSBub2RlLT5jaGlsZDIoKS5ub2RlKCk7CisgICAgICAgICAgICBpZiAo
dGFyZ2V0LT5vcCgpICE9IE5ld09iamVjdCkgeworICAgICAgICAgICAgICAgIGVzY2FwZSh0YXJn
ZXQpOworICAgICAgICAgICAgICAgIGVzY2FwZShub2RlLT5jaGlsZDEoKS5ub2RlKCkpOworICAg
ICAgICAgICAgfQogICAgICAgICAgICAgZXNjYXBlKG5vZGUtPmNoaWxkMygpLm5vZGUoKSk7CiAg
ICAgICAgICAgICBicmVhazsKKyAgICAgICAgfQogICAgICAgICAgICAgCiAgICAgICAgIGNhc2Ug
TXVsdGlQdXRCeU9mZnNldDoKICAgICAgICAgICAgIC8vIEZJWE1FOiBJbiB0aGUgZnV0dXJlIHdl
IHNob3VsZCBiZSBhYmxlIHRvIGhhbmRsZSB0aGlzLiBJdCdzIGp1c3QgYSBtYXR0ZXIgb2YK
</data>
<flag name="review"
          id="276553"
          type_id="1"
          status="-"
          setter="fpizlo"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>251768</attachid>
            <date>2015-04-27 12:29:31 -0700</date>
            <delta_ts>2015-04-27 12:47:34 -0700</delta_ts>
            <desc>MaterializeNewObject is also sinkable...</desc>
            <filename>fix_fun_alloc.patch</filename>
            <type>text/plain</type>
            <size>5377</size>
            <attacher name="Basile Clement">basile_clement</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGY5ODRjNDUuLmFkMzJlY2UgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD
b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE1LTA0LTI3ICBCYXNpbGUgQ2xlbWVu
dCAgPGJhc2lsZV9jbGVtZW50QGFwcGxlLmNvbT4KKworICAgICAgICBGdW5jdGlvbiBhbGxvY2F0
aW9ucyBzaG91bGRuJ3Qgc2luayB0aHJvdWdoIFB1dCBvcGVyYXRpb25zCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQxNzYKKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCeSBkZXNpZ24sIHdlIGRvbid0IHN1
cHBvcnQgZnVuY3Rpb24gYWxsb2NhdGlvbiBzaW5raW5nIHRocm91Z2ggYW55CisgICAgICAgIHJl
bGF0ZWQgb3BlcmF0aW9uIDsgaG93ZXZlciBvYmplY3QgYWxsb2NhdGlvbiBjYW4gc2luayB0aHJv
dWdoIFB1dEJ5T2Zmc2V0IGV0CisgICAgICAgIGFsLgorCisgICAgICAgIEN1cnJlbnRseSwgdGhl
IGNoZWNrcyB0byBwcmV2ZW50IGZ1bmN0aW9uIGFsbG9jYXRpb24gdG8gc2luayB0aHJvdWdoCisg
ICAgICAgIHRoZXNlIGFyZSBtaXNndWlkZWQgYW5kIGRvIG5vdCBwcmV2ZW50IGFueXRoaW5nIDsg
ZnVuY3Rpb24gYWxsb2NhdGlvbiBzaW5raW5nCisgICAgICAgIHRocm91Z2ggdGhlc2Ugb3BlcmF0
aW9ucyBpcyBwcmV2ZW50ZWQgYXMgYSBzaWRlIGVmZmVjdCBvZiByZXF1aXJpbmcgYW4KKyAgICAg
ICAgQWxsb2NhdGVQcm9wZXJ0eVN0b3JhZ2UgdGhyb3VnaCB3aGljaCB0aGUgZnVuY3Rpb24gYWxs
b2NhdGlvbiBpcyBzZWVuIGFzCisgICAgICAgIGVzY2FwaW5nLgorCisgICAgICAgIFRoaXMgY2hh
bmdlcyBpdCBzbyB0aGF0IE9iamVjdEFsbG9jYXRpb25TaW5raW5nUGhhc2U6OmhhbmRsZU5vZGUo
KQorICAgICAgICBjaGVja3MgcHJvcGVybHkgdGhhdCBvbmx5IG9iamVjdCBhbGxvY2F0aW9ucyBz
aW5rIHRocm91Z2ggcmVsYXRlZCB3cml0ZQorICAgICAgICBvcGVyYXRpb25zLgorCisgICAgICAg
ICogZGZnL0RGR09iamVjdEFsbG9jYXRpb25TaW5raW5nUGhhc2UuY3BwOgorICAgICAgICAoSlND
OjpERkc6Ok9iamVjdEFsbG9jYXRpb25TaW5raW5nUGhhc2U6Omxvd2VyTm9uUmVhZGluZ09wZXJh
dGlvbnNPblBoYW50b21BbGxvY2F0aW9ucyk6CisgICAgICAgIChKU0M6OkRGRzo6T2JqZWN0QWxs
b2NhdGlvblNpbmtpbmdQaGFzZTo6aGFuZGxlTm9kZSk6CisKIDIwMTUtMDQtMjUgIEZpbGlwIFBp
emxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBWYXJhcmdzRm9yd2FyZGluZ1BoYXNl
IHNob3VsZCB1c2UgYnl0ZWNvZGUgbGl2ZW5lc3MgaW4gYWRkaXRpb24gdG8gb3RoZXIgdXNlcyB0
byBkZXRlcm1pbmUgdGhlIGxhc3QgcG9pbnQgdGhhdCBhIGNhbmRpZGF0ZSBpcyB1c2VkCmRpZmYg
LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR05vZGUuaCBiL1NvdXJjZS9KYXZh
U2NyaXB0Q29yZS9kZmcvREZHTm9kZS5oCmluZGV4IGRlN2RkNTguLjY1NmZkNWYgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9kZS5oCisrKyBiL1NvdXJjZS9KYXZh
U2NyaXB0Q29yZS9kZmcvREZHTm9kZS5oCkBAIC0xNDIwLDYgKzE0MjAsMTcgQEAgc3RydWN0IE5v
ZGUgewogICAgICAgICBBU1NFUlQoaGFzT2JqZWN0TWF0ZXJpYWxpemF0aW9uRGF0YSgpKTsKICAg
ICAgICAgcmV0dXJuICpyZWludGVycHJldF9jYXN0PE9iamVjdE1hdGVyaWFsaXphdGlvbkRhdGEq
PihtX29wSW5mbyk7CiAgICAgfQorCisgICAgYm9vbCBpc09iamVjdEFsbG9jYXRpb24oKQorICAg
IHsKKyAgICAgICAgc3dpdGNoIChvcCgpKSB7CisgICAgICAgIGNhc2UgTmV3T2JqZWN0OgorICAg
ICAgICBjYXNlIE1hdGVyaWFsaXplTmV3T2JqZWN0OgorICAgICAgICAgICAgcmV0dXJuIHRydWU7
CisgICAgICAgIGRlZmF1bHQ6CisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIH0K
KyAgICB9CiAgICAgCiAgICAgYm9vbCBpc1BoYW50b21PYmplY3RBbGxvY2F0aW9uKCkKICAgICB7
CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09iamVjdEFsbG9jYXRp
b25TaW5raW5nUGhhc2UuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPYmplY3RB
bGxvY2F0aW9uU2lua2luZ1BoYXNlLmNwcAppbmRleCA0YmMyYzBkLi41YWFhZDZiIDEwMDY0NAot
LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09iamVjdEFsbG9jYXRpb25TaW5raW5n
UGhhc2UuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT2JqZWN0QWxsb2Nh
dGlvblNpbmtpbmdQaGFzZS5jcHAKQEAgLTUxMSwxNCArNTExLDE3IEBAIHByaXZhdGU6CiAgICAg
ICAgICAgICAgICAgc3dpdGNoIChub2RlLT5vcCgpKSB7CiAgICAgICAgICAgICAgICAgY2FzZSBQ
dXRCeU9mZnNldDogewogICAgICAgICAgICAgICAgICAgICBOb2RlKiB0YXJnZXQgPSBub2RlLT5j
aGlsZDIoKS5ub2RlKCk7Ci0gICAgICAgICAgICAgICAgICAgIGlmICh0YXJnZXQtPmlzUGhhbnRv
bU9iamVjdEFsbG9jYXRpb24oKSAmJiBtX3NpbmtDYW5kaWRhdGVzLmNvbnRhaW5zKHRhcmdldCkp
CisgICAgICAgICAgICAgICAgICAgIGlmIChtX3NpbmtDYW5kaWRhdGVzLmNvbnRhaW5zKHRhcmdl
dCkpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIEFTU0VSVCh0YXJnZXQtPmlzUGhhbnRvbU9i
amVjdEFsbG9jYXRpb24oKSk7CiAgICAgICAgICAgICAgICAgICAgICAgICBub2RlLT5jb252ZXJ0
VG9QdXRCeU9mZnNldEhpbnQoKTsKKyAgICAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAg
ICAgICAgICBicmVhazsKICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgICAgIAog
ICAgICAgICAgICAgICAgIGNhc2UgUHV0U3RydWN0dXJlOiB7CiAgICAgICAgICAgICAgICAgICAg
IE5vZGUqIHRhcmdldCA9IG5vZGUtPmNoaWxkMSgpLm5vZGUoKTsKLSAgICAgICAgICAgICAgICAg
ICAgaWYgKHRhcmdldC0+aXNQaGFudG9tT2JqZWN0QWxsb2NhdGlvbigpICYmIG1fc2lua0NhbmRp
ZGF0ZXMuY29udGFpbnModGFyZ2V0KSkgeworICAgICAgICAgICAgICAgICAgICBpZiAobV9zaW5r
Q2FuZGlkYXRlcy5jb250YWlucyh0YXJnZXQpKSB7CisgICAgICAgICAgICAgICAgICAgICAgICBB
U1NFUlQodGFyZ2V0LT5pc1BoYW50b21PYmplY3RBbGxvY2F0aW9uKCkpOwogICAgICAgICAgICAg
ICAgICAgICAgICAgTm9kZSogc3RydWN0dXJlID0gbV9pbnNlcnRpb25TZXQuaW5zZXJ0Q29uc3Rh
bnQoCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbm9kZUluZGV4LCBub2RlLT5vcmlnaW4s
IEpTVmFsdWUobm9kZS0+dHJhbnNpdGlvbigpLT5uZXh0KSk7CiAgICAgICAgICAgICAgICAgICAg
ICAgICBub2RlLT5jb252ZXJ0VG9QdXRTdHJ1Y3R1cmVIaW50KHN0cnVjdHVyZSk7CkBAIC01ODAs
OCArNTgzLDEwIEBAIHByaXZhdGU6CiAgICAgICAgICAgICAgICAgY2FzZSBTdG9yZUJhcnJpZXI6
CiAgICAgICAgICAgICAgICAgY2FzZSBTdG9yZUJhcnJpZXJXaXRoTnVsbENoZWNrOiB7CiAgICAg
ICAgICAgICAgICAgICAgIE5vZGUqIHRhcmdldCA9IG5vZGUtPmNoaWxkMSgpLm5vZGUoKTsKLSAg
ICAgICAgICAgICAgICAgICAgaWYgKHRhcmdldC0+aXNQaGFudG9tT2JqZWN0QWxsb2NhdGlvbigp
ICYmIG1fc2lua0NhbmRpZGF0ZXMuY29udGFpbnModGFyZ2V0KSkKKyAgICAgICAgICAgICAgICAg
ICAgaWYgKG1fc2lua0NhbmRpZGF0ZXMuY29udGFpbnModGFyZ2V0KSkgeworICAgICAgICAgICAg
ICAgICAgICAgICAgQVNTRVJUKHRhcmdldC0+aXNQaGFudG9tT2JqZWN0QWxsb2NhdGlvbigpKTsK
ICAgICAgICAgICAgICAgICAgICAgICAgIG5vZGUtPmNvbnZlcnRUb1BoYW50b20oKTsKKyAgICAg
ICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAg
ICAgICB9CiAgICAgICAgICAgICAgICAgICAgIApAQCAtNzg5LDIyICs3OTQsMzUgQEAgcHJpdmF0
ZToKICAgICAgICAgICAgICAgICB9KTsKICAgICAgICAgICAgIGJyZWFrOwogCisgICAgICAgIGNh
c2UgTW92SGludDoKKyAgICAgICAgY2FzZSBQaGFudG9tOgorICAgICAgICBjYXNlIENoZWNrOgor
ICAgICAgICBjYXNlIE11c3RHZW5lcmF0ZToKKyAgICAgICAgY2FzZSBQdXRIaW50OgorICAgICAg
ICAgICAgYnJlYWs7CisKKyAgICAgICAgY2FzZSBQdXRTdHJ1Y3R1cmU6CiAgICAgICAgIGNhc2Ug
Q2hlY2tTdHJ1Y3R1cmU6CiAgICAgICAgIGNhc2UgR2V0QnlPZmZzZXQ6CiAgICAgICAgIGNhc2Ug
TXVsdGlHZXRCeU9mZnNldDoKLSAgICAgICAgY2FzZSBQdXRTdHJ1Y3R1cmU6CiAgICAgICAgIGNh
c2UgR2V0R2V0dGVyU2V0dGVyQnlPZmZzZXQ6Ci0gICAgICAgIGNhc2UgTW92SGludDoKLSAgICAg
ICAgY2FzZSBQaGFudG9tOgotICAgICAgICBjYXNlIENoZWNrOgogICAgICAgICBjYXNlIFN0b3Jl
QmFycmllcjoKLSAgICAgICAgY2FzZSBTdG9yZUJhcnJpZXJXaXRoTnVsbENoZWNrOgotICAgICAg
ICBjYXNlIFB1dEhpbnQ6CisgICAgICAgIGNhc2UgU3RvcmVCYXJyaWVyV2l0aE51bGxDaGVjazog
eworICAgICAgICAgICAgTm9kZSogdGFyZ2V0ID0gbm9kZS0+Y2hpbGQxKCkubm9kZSgpOworICAg
ICAgICAgICAgaWYgKCF0YXJnZXQtPmlzT2JqZWN0QWxsb2NhdGlvbigpKQorICAgICAgICAgICAg
ICAgIGVzY2FwZSh0YXJnZXQpOwogICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0KICAgICAg
ICAgICAgIAotICAgICAgICBjYXNlIFB1dEJ5T2Zmc2V0OgorICAgICAgICBjYXNlIFB1dEJ5T2Zm
c2V0OiB7CisgICAgICAgICAgICBOb2RlKiB0YXJnZXQgPSBub2RlLT5jaGlsZDIoKS5ub2RlKCk7
CisgICAgICAgICAgICBpZiAoIXRhcmdldC0+aXNPYmplY3RBbGxvY2F0aW9uKCkpIHsKKyAgICAg
ICAgICAgICAgICBlc2NhcGUodGFyZ2V0KTsKKyAgICAgICAgICAgICAgICBlc2NhcGUobm9kZS0+
Y2hpbGQxKCkubm9kZSgpKTsKKyAgICAgICAgICAgIH0KICAgICAgICAgICAgIGVzY2FwZShub2Rl
LT5jaGlsZDMoKS5ub2RlKCkpOwogICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0KICAgICAg
ICAgICAgIAogICAgICAgICBjYXNlIE11bHRpUHV0QnlPZmZzZXQ6CiAgICAgICAgICAgICAvLyBG
SVhNRTogSW4gdGhlIGZ1dHVyZSB3ZSBzaG91bGQgYmUgYWJsZSB0byBoYW5kbGUgdGhpcy4gSXQn
cyBqdXN0IGEgbWF0dGVyIG9mCg==
</data>
<flag name="review"
          id="276557"
          type_id="1"
          status="+"
          setter="fpizlo"
    />
    <flag name="commit-queue"
          id="276558"
          type_id="3"
          status="+"
          setter="fpizlo"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>251771</attachid>
            <date>2015-04-27 12:47:34 -0700</date>
            <delta_ts>2015-04-27 13:43:41 -0700</delta_ts>
            <desc>Remove spurious MustGenerate</desc>
            <filename>fix_fun_alloc.patch</filename>
            <type>text/plain</type>
            <size>5349</size>
            <attacher name="Basile Clement">basile_clement</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGY5ODRjNDUuLmFkMzJlY2UgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD
b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE1LTA0LTI3ICBCYXNpbGUgQ2xlbWVu
dCAgPGJhc2lsZV9jbGVtZW50QGFwcGxlLmNvbT4KKworICAgICAgICBGdW5jdGlvbiBhbGxvY2F0
aW9ucyBzaG91bGRuJ3Qgc2luayB0aHJvdWdoIFB1dCBvcGVyYXRpb25zCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQxNzYKKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCeSBkZXNpZ24sIHdlIGRvbid0IHN1
cHBvcnQgZnVuY3Rpb24gYWxsb2NhdGlvbiBzaW5raW5nIHRocm91Z2ggYW55CisgICAgICAgIHJl
bGF0ZWQgb3BlcmF0aW9uIDsgaG93ZXZlciBvYmplY3QgYWxsb2NhdGlvbiBjYW4gc2luayB0aHJv
dWdoIFB1dEJ5T2Zmc2V0IGV0CisgICAgICAgIGFsLgorCisgICAgICAgIEN1cnJlbnRseSwgdGhl
IGNoZWNrcyB0byBwcmV2ZW50IGZ1bmN0aW9uIGFsbG9jYXRpb24gdG8gc2luayB0aHJvdWdoCisg
ICAgICAgIHRoZXNlIGFyZSBtaXNndWlkZWQgYW5kIGRvIG5vdCBwcmV2ZW50IGFueXRoaW5nIDsg
ZnVuY3Rpb24gYWxsb2NhdGlvbiBzaW5raW5nCisgICAgICAgIHRocm91Z2ggdGhlc2Ugb3BlcmF0
aW9ucyBpcyBwcmV2ZW50ZWQgYXMgYSBzaWRlIGVmZmVjdCBvZiByZXF1aXJpbmcgYW4KKyAgICAg
ICAgQWxsb2NhdGVQcm9wZXJ0eVN0b3JhZ2UgdGhyb3VnaCB3aGljaCB0aGUgZnVuY3Rpb24gYWxs
b2NhdGlvbiBpcyBzZWVuIGFzCisgICAgICAgIGVzY2FwaW5nLgorCisgICAgICAgIFRoaXMgY2hh
bmdlcyBpdCBzbyB0aGF0IE9iamVjdEFsbG9jYXRpb25TaW5raW5nUGhhc2U6OmhhbmRsZU5vZGUo
KQorICAgICAgICBjaGVja3MgcHJvcGVybHkgdGhhdCBvbmx5IG9iamVjdCBhbGxvY2F0aW9ucyBz
aW5rIHRocm91Z2ggcmVsYXRlZCB3cml0ZQorICAgICAgICBvcGVyYXRpb25zLgorCisgICAgICAg
ICogZGZnL0RGR09iamVjdEFsbG9jYXRpb25TaW5raW5nUGhhc2UuY3BwOgorICAgICAgICAoSlND
OjpERkc6Ok9iamVjdEFsbG9jYXRpb25TaW5raW5nUGhhc2U6Omxvd2VyTm9uUmVhZGluZ09wZXJh
dGlvbnNPblBoYW50b21BbGxvY2F0aW9ucyk6CisgICAgICAgIChKU0M6OkRGRzo6T2JqZWN0QWxs
b2NhdGlvblNpbmtpbmdQaGFzZTo6aGFuZGxlTm9kZSk6CisKIDIwMTUtMDQtMjUgIEZpbGlwIFBp
emxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBWYXJhcmdzRm9yd2FyZGluZ1BoYXNl
IHNob3VsZCB1c2UgYnl0ZWNvZGUgbGl2ZW5lc3MgaW4gYWRkaXRpb24gdG8gb3RoZXIgdXNlcyB0
byBkZXRlcm1pbmUgdGhlIGxhc3QgcG9pbnQgdGhhdCBhIGNhbmRpZGF0ZSBpcyB1c2VkCmRpZmYg
LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR05vZGUuaCBiL1NvdXJjZS9KYXZh
U2NyaXB0Q29yZS9kZmcvREZHTm9kZS5oCmluZGV4IGRlN2RkNTguLjY1NmZkNWYgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9kZS5oCisrKyBiL1NvdXJjZS9KYXZh
U2NyaXB0Q29yZS9kZmcvREZHTm9kZS5oCkBAIC0xNDIwLDYgKzE0MjAsMTcgQEAgc3RydWN0IE5v
ZGUgewogICAgICAgICBBU1NFUlQoaGFzT2JqZWN0TWF0ZXJpYWxpemF0aW9uRGF0YSgpKTsKICAg
ICAgICAgcmV0dXJuICpyZWludGVycHJldF9jYXN0PE9iamVjdE1hdGVyaWFsaXphdGlvbkRhdGEq
PihtX29wSW5mbyk7CiAgICAgfQorCisgICAgYm9vbCBpc09iamVjdEFsbG9jYXRpb24oKQorICAg
IHsKKyAgICAgICAgc3dpdGNoIChvcCgpKSB7CisgICAgICAgIGNhc2UgTmV3T2JqZWN0OgorICAg
ICAgICBjYXNlIE1hdGVyaWFsaXplTmV3T2JqZWN0OgorICAgICAgICAgICAgcmV0dXJuIHRydWU7
CisgICAgICAgIGRlZmF1bHQ6CisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIH0K
KyAgICB9CiAgICAgCiAgICAgYm9vbCBpc1BoYW50b21PYmplY3RBbGxvY2F0aW9uKCkKICAgICB7
CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09iamVjdEFsbG9jYXRp
b25TaW5raW5nUGhhc2UuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPYmplY3RB
bGxvY2F0aW9uU2lua2luZ1BoYXNlLmNwcAppbmRleCA0YmMyYzBkLi5kMGJmZTE0IDEwMDY0NAot
LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09iamVjdEFsbG9jYXRpb25TaW5raW5n
UGhhc2UuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT2JqZWN0QWxsb2Nh
dGlvblNpbmtpbmdQaGFzZS5jcHAKQEAgLTUxMSwxNCArNTExLDE3IEBAIHByaXZhdGU6CiAgICAg
ICAgICAgICAgICAgc3dpdGNoIChub2RlLT5vcCgpKSB7CiAgICAgICAgICAgICAgICAgY2FzZSBQ
dXRCeU9mZnNldDogewogICAgICAgICAgICAgICAgICAgICBOb2RlKiB0YXJnZXQgPSBub2RlLT5j
aGlsZDIoKS5ub2RlKCk7Ci0gICAgICAgICAgICAgICAgICAgIGlmICh0YXJnZXQtPmlzUGhhbnRv
bU9iamVjdEFsbG9jYXRpb24oKSAmJiBtX3NpbmtDYW5kaWRhdGVzLmNvbnRhaW5zKHRhcmdldCkp
CisgICAgICAgICAgICAgICAgICAgIGlmIChtX3NpbmtDYW5kaWRhdGVzLmNvbnRhaW5zKHRhcmdl
dCkpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIEFTU0VSVCh0YXJnZXQtPmlzUGhhbnRvbU9i
amVjdEFsbG9jYXRpb24oKSk7CiAgICAgICAgICAgICAgICAgICAgICAgICBub2RlLT5jb252ZXJ0
VG9QdXRCeU9mZnNldEhpbnQoKTsKKyAgICAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAg
ICAgICAgICBicmVhazsKICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgICAgIAog
ICAgICAgICAgICAgICAgIGNhc2UgUHV0U3RydWN0dXJlOiB7CiAgICAgICAgICAgICAgICAgICAg
IE5vZGUqIHRhcmdldCA9IG5vZGUtPmNoaWxkMSgpLm5vZGUoKTsKLSAgICAgICAgICAgICAgICAg
ICAgaWYgKHRhcmdldC0+aXNQaGFudG9tT2JqZWN0QWxsb2NhdGlvbigpICYmIG1fc2lua0NhbmRp
ZGF0ZXMuY29udGFpbnModGFyZ2V0KSkgeworICAgICAgICAgICAgICAgICAgICBpZiAobV9zaW5r
Q2FuZGlkYXRlcy5jb250YWlucyh0YXJnZXQpKSB7CisgICAgICAgICAgICAgICAgICAgICAgICBB
U1NFUlQodGFyZ2V0LT5pc1BoYW50b21PYmplY3RBbGxvY2F0aW9uKCkpOwogICAgICAgICAgICAg
ICAgICAgICAgICAgTm9kZSogc3RydWN0dXJlID0gbV9pbnNlcnRpb25TZXQuaW5zZXJ0Q29uc3Rh
bnQoCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbm9kZUluZGV4LCBub2RlLT5vcmlnaW4s
IEpTVmFsdWUobm9kZS0+dHJhbnNpdGlvbigpLT5uZXh0KSk7CiAgICAgICAgICAgICAgICAgICAg
ICAgICBub2RlLT5jb252ZXJ0VG9QdXRTdHJ1Y3R1cmVIaW50KHN0cnVjdHVyZSk7CkBAIC01ODAs
OCArNTgzLDEwIEBAIHByaXZhdGU6CiAgICAgICAgICAgICAgICAgY2FzZSBTdG9yZUJhcnJpZXI6
CiAgICAgICAgICAgICAgICAgY2FzZSBTdG9yZUJhcnJpZXJXaXRoTnVsbENoZWNrOiB7CiAgICAg
ICAgICAgICAgICAgICAgIE5vZGUqIHRhcmdldCA9IG5vZGUtPmNoaWxkMSgpLm5vZGUoKTsKLSAg
ICAgICAgICAgICAgICAgICAgaWYgKHRhcmdldC0+aXNQaGFudG9tT2JqZWN0QWxsb2NhdGlvbigp
ICYmIG1fc2lua0NhbmRpZGF0ZXMuY29udGFpbnModGFyZ2V0KSkKKyAgICAgICAgICAgICAgICAg
ICAgaWYgKG1fc2lua0NhbmRpZGF0ZXMuY29udGFpbnModGFyZ2V0KSkgeworICAgICAgICAgICAg
ICAgICAgICAgICAgQVNTRVJUKHRhcmdldC0+aXNQaGFudG9tT2JqZWN0QWxsb2NhdGlvbigpKTsK
ICAgICAgICAgICAgICAgICAgICAgICAgIG5vZGUtPmNvbnZlcnRUb1BoYW50b20oKTsKKyAgICAg
ICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAg
ICAgICB9CiAgICAgICAgICAgICAgICAgICAgIApAQCAtNzg5LDIyICs3OTQsMzQgQEAgcHJpdmF0
ZToKICAgICAgICAgICAgICAgICB9KTsKICAgICAgICAgICAgIGJyZWFrOwogCisgICAgICAgIGNh
c2UgTW92SGludDoKKyAgICAgICAgY2FzZSBQaGFudG9tOgorICAgICAgICBjYXNlIENoZWNrOgor
ICAgICAgICBjYXNlIFB1dEhpbnQ6CisgICAgICAgICAgICBicmVhazsKKworICAgICAgICBjYXNl
IFB1dFN0cnVjdHVyZToKICAgICAgICAgY2FzZSBDaGVja1N0cnVjdHVyZToKICAgICAgICAgY2Fz
ZSBHZXRCeU9mZnNldDoKICAgICAgICAgY2FzZSBNdWx0aUdldEJ5T2Zmc2V0OgotICAgICAgICBj
YXNlIFB1dFN0cnVjdHVyZToKICAgICAgICAgY2FzZSBHZXRHZXR0ZXJTZXR0ZXJCeU9mZnNldDoK
LSAgICAgICAgY2FzZSBNb3ZIaW50OgotICAgICAgICBjYXNlIFBoYW50b206Ci0gICAgICAgIGNh
c2UgQ2hlY2s6CiAgICAgICAgIGNhc2UgU3RvcmVCYXJyaWVyOgotICAgICAgICBjYXNlIFN0b3Jl
QmFycmllcldpdGhOdWxsQ2hlY2s6Ci0gICAgICAgIGNhc2UgUHV0SGludDoKKyAgICAgICAgY2Fz
ZSBTdG9yZUJhcnJpZXJXaXRoTnVsbENoZWNrOiB7CisgICAgICAgICAgICBOb2RlKiB0YXJnZXQg
PSBub2RlLT5jaGlsZDEoKS5ub2RlKCk7CisgICAgICAgICAgICBpZiAoIXRhcmdldC0+aXNPYmpl
Y3RBbGxvY2F0aW9uKCkpCisgICAgICAgICAgICAgICAgZXNjYXBlKHRhcmdldCk7CiAgICAgICAg
ICAgICBicmVhazsKKyAgICAgICAgfQogICAgICAgICAgICAgCi0gICAgICAgIGNhc2UgUHV0QnlP
ZmZzZXQ6CisgICAgICAgIGNhc2UgUHV0QnlPZmZzZXQ6IHsKKyAgICAgICAgICAgIE5vZGUqIHRh
cmdldCA9IG5vZGUtPmNoaWxkMigpLm5vZGUoKTsKKyAgICAgICAgICAgIGlmICghdGFyZ2V0LT5p
c09iamVjdEFsbG9jYXRpb24oKSkgeworICAgICAgICAgICAgICAgIGVzY2FwZSh0YXJnZXQpOwor
ICAgICAgICAgICAgICAgIGVzY2FwZShub2RlLT5jaGlsZDEoKS5ub2RlKCkpOworICAgICAgICAg
ICAgfQogICAgICAgICAgICAgZXNjYXBlKG5vZGUtPmNoaWxkMygpLm5vZGUoKSk7CiAgICAgICAg
ICAgICBicmVhazsKKyAgICAgICAgfQogICAgICAgICAgICAgCiAgICAgICAgIGNhc2UgTXVsdGlQ
dXRCeU9mZnNldDoKICAgICAgICAgICAgIC8vIEZJWE1FOiBJbiB0aGUgZnV0dXJlIHdlIHNob3Vs
ZCBiZSBhYmxlIHRvIGhhbmRsZSB0aGlzLiBJdCdzIGp1c3QgYSBtYXR0ZXIgb2YK
</data>

          </attachment>
      

    </bug>

</bugzilla>