144175 2015-04-24 16:57:55 -0700 theverge.com burning 100% CPU on iPad (due to window.screenX/Y) 2015-04-24 17:26:49 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Performance P2 Normal --- 1 kling kling kling oldest_to_newest 1088414 0 kling 2015-04-24 16:57:55 -0700 <rdar://problem/20694585> theverge.com is burning up my iPad CPU asking for the screen dimensions over and over. Since they are always going to be 0,0/0x0 on iOS, let's just add a short-circuit and get rid of the expensive synchronous IPC. 1088416 1 251595 kling 2015-04-24 17:00:21 -0700 Created attachment 251595 Patch 1088417 2 251595 andersca 2015-04-24 17:01:31 -0700 Comment on attachment 251595 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251595&action=review > Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:135 > #if PLATFORM(COCOA) Shouldn't this be #elif PLATFORM(MAC) then? 1088428 3 kling 2015-04-24 17:26:49 -0700 Committed r183299: <http://trac.webkit.org/changeset/183299> 251595 2015-04-24 17:00:21 -0700 2015-04-24 17:01:31 -0700 Patch bug-144175.diff text/plain 1717 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA0MjdiYmQwLi5kNWYwZTk1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTUtMDQtMjQgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIHRoZXZlcmdlLmNvbSBidXJuaW5nIDEwMCUgQ1BVIG9uIGlQYWQgKGR1ZSB0byB3aW5kb3cu c2NyZWVuWC9ZKQorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTQ0MTc1PgorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMjA2OTQ1ODU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUmV0dXJuIGFuIGVtcHR5IHdpbmRvdyByZWN0IG9uIGlPUyBX SzIgYnVpbGRzLiBUaGlzIGF2b2lkcyBzZW5kaW5nIGEgc3luY2hyb25vdXMKKyAgICAgICAgSVBD IHJlcXVlc3QgdG8gdGhlIFVJIHByb2Nlc3MgdGhhdCB3b3VsZCBnaXZlIHRoZSBzYW1lIHJlc3Vs dCwgYnV0IHNwZW5kIHdheQorICAgICAgICBtb3JlIHRpbWUgYW5kIENQVSBjeWNsZXMgdG8gZG8g c28uCisKKyAgICAgICAgV2l0aCB0aGlzIGNoYW5nZSwgdGhldmVyZ2UuY29tIENQVSB1c2FnZSBn b2VzIGZyb20gMTAwJSB0byB+MjAlIHdoZW4gaWRsZS4KKworICAgICAgICAqIFdlYlByb2Nlc3Mv V2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi Q2hyb21lQ2xpZW50Ojp3aW5kb3dSZWN0KToKKwogMjAxNS0wNC0yNCAgQW5kZXJzIENhcmxzc29u ICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZHJlc3MgYSByZXZpZXcgY29tbWVu dCBmcm9tIEpvZSBQZWNvcmFyby4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmNwcAppbmRleCBiNTE1ZjEx Li43YjZhZWY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVT dXBwb3J0L1dlYkNocm9tZUNsaWVudC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQuY3BwCkBAIC0xMjksNiArMTI5LDkgQEAg dm9pZCBXZWJDaHJvbWVDbGllbnQ6OnNldFdpbmRvd1JlY3QoY29uc3QgRmxvYXRSZWN0JiB3aW5k b3dGcmFtZSkKIAogRmxvYXRSZWN0IFdlYkNocm9tZUNsaWVudDo6d2luZG93UmVjdCgpCiB7Cisj aWYgUExBVEZPUk0oSU9TKQorICAgIHJldHVybiBGbG9hdFJlY3QoKTsKKyNlbHNlCiAjaWYgUExB VEZPUk0oQ09DT0EpCiAgICAgaWYgKG1fcGFnZS0+aGFzQ2FjaGVkV2luZG93RnJhbWUoKSkKICAg ICAgICAgcmV0dXJuIG1fcGFnZS0+d2luZG93RnJhbWVJblVuZmxpcHBlZFNjcmVlbkNvb3JkaW5h dGVzKCk7CkBAIC0xNDAsNiArMTQzLDcgQEAgRmxvYXRSZWN0IFdlYkNocm9tZUNsaWVudDo6d2lu ZG93UmVjdCgpCiAgICAgICAgIHJldHVybiBGbG9hdFJlY3QoKTsKIAogICAgIHJldHVybiBuZXdX aW5kb3dGcmFtZTsKKyNlbmRpZgogfQogCiBGbG9hdFJlY3QgV2ViQ2hyb21lQ2xpZW50OjpwYWdl UmVjdCgpCg==