144172 2015-04-24 16:36:51 -0700 TextIndicator for embedded PDFs is slightly offset 2015-04-24 17:18:00 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham thorton webkit-bug-importer oldest_to_newest 1088398 0 bfulgham 2015-04-24 16:36:51 -0700 The Yellow Highlights (TextIndicators) around the word/phrase selected for dictionary lookup, etc., is slightly offset from the layout in PDF. 1088399 1 bfulgham 2015-04-24 16:37:24 -0700 <rdar://problem/20691304> 1088415 2 251594 bfulgham 2015-04-24 16:59:49 -0700 Created attachment 251594 Patch 1088418 3 251594 thorton 2015-04-24 17:01:37 -0700 Comment on attachment 251594 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251594&action=review > Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:596 > This function maybe should get a name that isn't about PluginView since it doesn't take one of those anymore. 1088419 4 251594 bfulgham 2015-04-24 17:03:20 -0700 Comment on attachment 251594 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251594&action=review >> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:596 >> > > This function maybe should get a name that isn't about PluginView since it doesn't take one of those anymore. Well, it takes a PDFPlugin. Maybe I should just drop "PluginView" entirely, since the PDFSelection signifies it's PDF-related. 1088426 5 bfulgham 2015-04-24 17:18:00 -0700 Committed r183297: <http://trac.webkit.org/changeset/183297> 251594 2015-04-24 16:59:49 -0700 2015-04-24 17:01:37 -0700 Patch bug-144172-20150424165844.patch text/plain 5383 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MzI5MSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDE1LTA0LTI0ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFRleHRJbmRpY2F0b3IgZm9y IGVtYmVkZGVkIFBERnMgaXMgc2xpZ2h0bHkgb2Zmc2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQxNzIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzIwNjkxMzA0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdoZW4gSSBjb252ZXJ0ZWQgdGhlIGV4aXN0aW5nIERPTSBSYW5nZSBsb2dpYyB0byB3b3Jr IHdpdGggUERGU2VsZWN0aW9ucywgSSBvbWl0dGVkIHRoZQorICAgICAgICBzdGVwIHdoZXJlIHRo ZSBmb250IGFzY2VudCB3YXMgdXNlZCB0byBhZGp1c3QgdGhlIG9yaWdpbiB1c2VkIGZvciB0aGUg VGV4dEluZGljYXRvci4gVGhpcworICAgICAgICBwYXRjaCBkZXRlcm1pbmVzIHRoZSBjb3JyZWN0 IGFzY2VudCBmb3IgdGhlIHJhbmdlIG9mIGNoYXJhY3RlcnMgaW4gdGhlIHNlbGVjdGlvbiwgYW5k CisgICAgICAgIGFkanVzdHMgdGhlIG9mZnNldCBieSB0aGUgZGlmZmVyZW5jZSBiZXR3ZWVuIHRo ZSBhc2NlbnQgYW5kIHRoZSBoZWlnaHQgb2YgdGhlIHNlbGVjdGlvbiByZWN0LgorICAgICAgICAK KyAgICAgICAgQWxzbywgc2luY2UgdGhlIFBERlNlbGVjdGlvbiBvbmx5IHN1cHBsaWVzIHRoZSBi b3VuZGluZyByZWN0IGZvciB0aGUgc2VsZWN0aW9uLCBJIGNhbGN1bGF0ZQorICAgICAgICBhbiBl cXVpdmFsZW50IHRleHQgYm91bmRpbmcgYm94IGJ5IGluc2V0dGluZyB0aGUgcmVjdCBieSBoYWxm IHRoZSBzaXplIG9mIHRoZSBhc2NlbnQuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMv UERGL1BERlBsdWdpbi5tbToKKyAgICAgICAgKFdlYktpdDo6UERGUGx1Z2luOjpzY2FsZUZhY3Rv cik6IEFkZCBhY2Nlc3NvciBmb3IgUERGIHNjYWxlIGZhY3Rvci4KKyAgICAgICAgKiBXZWJQcm9j ZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5oOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFn ZS9tYWMvV2ViUGFnZU1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6ZGljdGlvbmFy eVBvcHVwSW5mb0ZvclBERlNlbGVjdGlvbkluUGx1Z2luVmlldyk6IEFkanVzdGVkIHRvIHRha2Ug dGhlCisgICAgICAgIGZvbnQgYXNjZW50IGFuZCBzY2FsZSBmYWN0b3IgaW50byBhY2NvdW50Lgor CiAyMDE1LTA0LTI0ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAog ICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTgzMjY2LgpJbmRleDogU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQbHVnaW4uaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5oCShyZXZpc2lv biAxODMyODEpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBs dWdpbi5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMDcsNiArMTA3LDggQEAgcHVibGljOgogICAgIFN0 cmluZyBsb29rdXBUZXh0QXRMb2NhdGlvbihjb25zdCBXZWJDb3JlOjpGbG9hdFBvaW50JiwgV2Vi SGl0VGVzdFJlc3VsdDo6RGF0YSYsIFBERlNlbGVjdGlvbiAqKiwgTlNEaWN0aW9uYXJ5ICoqKSBj b25zdDsKICAgICBXZWJDb3JlOjpGbG9hdFJlY3Qgdmlld1JlY3RGb3JTZWxlY3Rpb24oUERGU2Vs ZWN0aW9uICopIGNvbnN0OwogCisgICAgQ0dGbG9hdCBzY2FsZUZhY3RvcigpIGNvbnN0OworCiBw cml2YXRlOgogICAgIGV4cGxpY2l0IFBERlBsdWdpbihXZWJGcmFtZSopOwogCkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5tbQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5tbQko cmV2aXNpb24gMTgzMjgyKQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BE Ri9QREZQbHVnaW4ubW0JKHdvcmtpbmcgY29weSkKQEAgLTE5NjcsNiArMTk2NywxMSBAQCBXZWJD b3JlOjpGbG9hdFJlY3QgUERGUGx1Z2luOjp2aWV3UmVjdEZvCiAgICAgcmV0dXJuIFdlYkNvcmU6 OkZsb2F0UmVjdChyZWN0SW5WaWV3KTsKIH0KIAorQ0dGbG9hdCBQREZQbHVnaW46OnNjYWxlRmFj dG9yKCkgY29uc3QKK3sKKyAgICByZXR1cm4gW21fcGRmTGF5ZXJDb250cm9sbGVyIGNvbnRlbnRT Y2FsZUZhY3Rvcl07Cit9CisKIHZvaWQgUERGUGx1Z2luOjpwZXJmb3JtV2ViU2VhcmNoKE5TU3Ry aW5nICpzdHJpbmcpCiB7CiAgICAgd2ViRnJhbWUoKS0+cGFnZSgpLT5zZW5kKE1lc3NhZ2VzOjpX ZWJQYWdlUHJveHk6OlNlYXJjaFRoZVdlYihzdHJpbmcpKTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvV2ViUGFnZU1hYy5tbQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1dlYlBhZ2VNYWMubW0JKHJldmlzaW9u IDE4MzI4MikKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvV2ViUGFn ZU1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtNTk2LDMzICs1OTYsNDEgQEAgRGljdGlvbmFyeVBv cHVwSW5mbyBXZWJQYWdlOjpkaWN0aW9uYXJ5UAogCiAgICAgTlNSZWN0IHJhbmdlUmVjdCA9IHBk ZlBsdWdpbi52aWV3UmVjdEZvclNlbGVjdGlvbihzZWxlY3Rpb24pOwogCi0gICAgZGljdGlvbmFy eVBvcHVwSW5mby5vcmlnaW4gPSByYW5nZVJlY3Qub3JpZ2luOwotICAgIGRpY3Rpb25hcnlQb3B1 cEluZm8ub3B0aW9ucyA9IChDRkRpY3Rpb25hcnlSZWYpKm9wdGlvbnM7Ci0gICAgCiAgICAgTlNB dHRyaWJ1dGVkU3RyaW5nICpuc0F0dHJpYnV0ZWRTdHJpbmcgPSBzZWxlY3Rpb24uYXR0cmlidXRl ZFN0cmluZzsKICAgICAKICAgICBSZXRhaW5QdHI8TlNNdXRhYmxlQXR0cmlidXRlZFN0cmluZz4g c2NhbGVkTlNBdHRyaWJ1dGVkU3RyaW5nID0gYWRvcHROUyhbW05TTXV0YWJsZUF0dHJpYnV0ZWRT dHJpbmcgYWxsb2NdIGluaXRXaXRoU3RyaW5nOltuc0F0dHJpYnV0ZWRTdHJpbmcgc3RyaW5nXV0p OwogICAgIAogICAgIE5TRm9udE1hbmFnZXIgKmZvbnRNYW5hZ2VyID0gW05TRm9udE1hbmFnZXIg c2hhcmVkRm9udE1hbmFnZXJdOwotICAgIAorCisgICAgQ0dGbG9hdCBzY2FsZUZhY3RvciA9IHBk ZlBsdWdpbi5zY2FsZUZhY3RvcigpOworCisgICAgX19ibG9jayBDR0Zsb2F0IG1heEFzY2VuZGVy ID0gMDsKICAgICBbbnNBdHRyaWJ1dGVkU3RyaW5nIGVudW1lcmF0ZUF0dHJpYnV0ZXNJblJhbmdl Ok5TTWFrZVJhbmdlKDAsIFtuc0F0dHJpYnV0ZWRTdHJpbmcgbGVuZ3RoXSkgb3B0aW9uczowIHVz aW5nQmxvY2s6XihOU0RpY3Rpb25hcnkgKmF0dHJpYnV0ZXMsIE5TUmFuZ2UgcmFuZ2UsIEJPT0wg KnN0b3ApIHsKICAgICAgICAgUmV0YWluUHRyPE5TTXV0YWJsZURpY3Rpb25hcnk+IHNjYWxlZEF0 dHJpYnV0ZXMgPSBhZG9wdE5TKFthdHRyaWJ1dGVzIG11dGFibGVDb3B5XSk7CiAgICAgICAgIAog ICAgICAgICBOU0ZvbnQgKmZvbnQgPSBbc2NhbGVkQXR0cmlidXRlcyBvYmplY3RGb3JLZXk6TlNG b250QXR0cmlidXRlTmFtZV07CiAgICAgICAgIGlmIChmb250KSB7Ci0gICAgICAgICAgICBmb250 ID0gW2ZvbnRNYW5hZ2VyIGNvbnZlcnRGb250OmZvbnQgdG9TaXplOltmb250IHBvaW50U2l6ZV0g KiBwYWdlU2NhbGVGYWN0b3IoKV07CisgICAgICAgICAgICBtYXhBc2NlbmRlciA9IHN0ZDo6bWF4 KG1heEFzY2VuZGVyLCBmb250LmFzY2VuZGVyICogc2NhbGVGYWN0b3IpOworICAgICAgICAgICAg Zm9udCA9IFtmb250TWFuYWdlciBjb252ZXJ0Rm9udDpmb250IHRvU2l6ZTpbZm9udCBwb2ludFNp emVdICogc2NhbGVGYWN0b3JdOwogICAgICAgICAgICAgW3NjYWxlZEF0dHJpYnV0ZXMgc2V0T2Jq ZWN0OmZvbnQgZm9yS2V5Ok5TRm9udEF0dHJpYnV0ZU5hbWVdOwogICAgICAgICB9CiAgICAgICAg IAogICAgICAgICBbc2NhbGVkTlNBdHRyaWJ1dGVkU3RyaW5nIGFkZEF0dHJpYnV0ZXM6c2NhbGVk QXR0cmlidXRlcy5nZXQoKSByYW5nZTpyYW5nZV07CiAgICAgfV07CiAKKyAgICBDR0Zsb2F0IHRl eHRJbnNldCA9IHJhbmdlUmVjdC5zaXplLmhlaWdodCAtIG1heEFzY2VuZGVyOworICAgIHJhbmdl UmVjdC5vcmlnaW4ueSAtPSB0ZXh0SW5zZXQ7CisgICAgCiAgICAgVGV4dEluZGljYXRvckRhdGEg ZGF0YUZvclNlbGVjdGlvbjsKICAgICBkYXRhRm9yU2VsZWN0aW9uLnNlbGVjdGlvblJlY3RJblJv b3RWaWV3Q29vcmRpbmF0ZXMgPSByYW5nZVJlY3Q7Ci0gICAgZGF0YUZvclNlbGVjdGlvbi50ZXh0 Qm91bmRpbmdSZWN0SW5Sb290Vmlld0Nvb3JkaW5hdGVzID0gcmFuZ2VSZWN0OwotICAgIGRhdGFG b3JTZWxlY3Rpb24uY29udGVudEltYWdlU2NhbGVGYWN0b3IgPSAxLjA7CisKKyAgICBDR0Zsb2F0 IGluc2V0QW1vdW50ID0gMC41ICogdGV4dEluc2V0OworICAgIGRhdGFGb3JTZWxlY3Rpb24udGV4 dEJvdW5kaW5nUmVjdEluUm9vdFZpZXdDb29yZGluYXRlcyA9IE5TSW5zZXRSZWN0KHJhbmdlUmVj dCwgaW5zZXRBbW91bnQsIGluc2V0QW1vdW50KTsKKyAgICBkYXRhRm9yU2VsZWN0aW9uLmNvbnRl bnRJbWFnZVNjYWxlRmFjdG9yID0gc2NhbGVGYWN0b3I7CiAgICAgZGF0YUZvclNlbGVjdGlvbi5w cmVzZW50YXRpb25UcmFuc2l0aW9uID0gcHJlc2VudGF0aW9uVHJhbnNpdGlvbjsKICAgICAKKyAg ICBkaWN0aW9uYXJ5UG9wdXBJbmZvLm9yaWdpbiA9IHJhbmdlUmVjdC5vcmlnaW47CisgICAgZGlj dGlvbmFyeVBvcHVwSW5mby5vcHRpb25zID0gKENGRGljdGlvbmFyeVJlZikqb3B0aW9uczsKICAg ICBkaWN0aW9uYXJ5UG9wdXBJbmZvLnRleHRJbmRpY2F0b3IgPSBkYXRhRm9yU2VsZWN0aW9uOwog ICAgIGRpY3Rpb25hcnlQb3B1cEluZm8uYXR0cmlidXRlZFN0cmluZy5zdHJpbmcgPSBzY2FsZWRO U0F0dHJpYnV0ZWRTdHJpbmc7CiAgICAgCg==