144166 2015-04-24 15:42:55 -0700 Function allocation sinking shouldn't be performed on singleton functions 2015-05-01 15:34:53 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 basile_clement basile_clement commit-queue fpizlo ggaren mark.lam msaboff oldest_to_newest 1088362 0 basile_clement 2015-04-24 15:42:55 -0700 Patch forthcoming. 1088382 1 251586 basile_clement 2015-04-24 16:21:11 -0700 Created attachment 251586 Patch 1088385 2 251586 ggaren 2015-04-24 16:23:31 -0700 Comment on attachment 251586 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251586&action=review r=me cq- for some ChangeLog edits. > Source/JavaScriptCore/ChangeLog:8 > + Function allocation usually are free of any other side effects, but allocation => allocations > Source/JavaScriptCore/ChangeLog:18 > + to worry about its watchpoint, allowing to use allowing to use => allowing us to use 1088386 3 251587 basile_clement 2015-04-24 16:25:22 -0700 Created attachment 251587 Fix ChangeLog typos 1088387 4 basile_clement 2015-04-24 16:26:35 -0700 (In reply to comment #2) > Comment on attachment 251586 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=251586&action=review > > r=me Thanks! > > cq- for some ChangeLog edits. > > > Source/JavaScriptCore/ChangeLog:8 > > + Function allocation usually are free of any other side effects, but > > allocation => allocations > > > Source/JavaScriptCore/ChangeLog:18 > > + to worry about its watchpoint, allowing to use > > allowing to use => allowing us to use Fixed those in a new patch. 1089129 5 251587 fpizlo 2015-04-27 12:28:42 -0700 Comment on attachment 251587 Fix ChangeLog typos View in context: https://bugs.webkit.org/attachment.cgi?id=251587&action=review Holding off cq because the ChangeLog comment could be refined. > Source/JavaScriptCore/ChangeLog:14 > + watchpoints invalidating code that depends on it being a singleton). According > + to fpizlo, this happens to be sinkable right now, but things may not stay that > + way in the future (e.g. it would not be the case for CreateActivation), and > + fixing this now would help prevent hard-to-find bugs later in that case. What won't stay that way in the future? That singleton function allocations are sinkable? I think it's enough to say that we don't want to sink code that has effects if we haven't done the work to prove that the effect wasn't observed. Object allocation sinking phase does no such analysis because it assumes that the act of allocating is not effectful. 1089139 6 basile_clement 2015-04-27 12:41:45 -0700 (In reply to comment #5) > Comment on attachment 251587 [details] > Fix ChangeLog typos > > View in context: > https://bugs.webkit.org/attachment.cgi?id=251587&action=review > > Holding off cq because the ChangeLog comment could be refined. > > > Source/JavaScriptCore/ChangeLog:14 > > + watchpoints invalidating code that depends on it being a singleton). According > > + to fpizlo, this happens to be sinkable right now, but things may not stay that > > + way in the future (e.g. it would not be the case for CreateActivation), and > > + fixing this now would help prevent hard-to-find bugs later in that case. > > What won't stay that way in the future? That singleton function allocations > are sinkable? > > I think it's enough to say that we don't want to sink code that has effects > if we haven't done the work to prove that the effect wasn't observed. > Object allocation sinking phase does no such analysis because it assumes > that the act of allocating is not effectful. OK, will simplify that. 1089145 7 251772 basile_clement 2015-04-27 12:54:35 -0700 Created attachment 251772 Simplify ChangeLog entry 1090887 8 252172 basile_clement 2015-05-01 14:46:05 -0700 Created attachment 252172 Patch for landing 1090913 9 252172 commit-queue 2015-05-01 15:34:49 -0700 Comment on attachment 252172 Patch for landing Clearing flags on attachment: 252172 Committed r183691: <http://trac.webkit.org/changeset/183691> 1090914 10 commit-queue 2015-05-01 15:34:53 -0700 All reviewed patches have been landed. Closing bug. 251586 2015-04-24 16:21:11 -0700 2015-04-24 16:25:22 -0700 Patch sink_newfun_singleton.patch text/plain 2928 basile_clement ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDlkYjUxMmQuLjQzZTRjYzcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDE1LTA0LTI0ICBCYXNpbGUgQ2xlbWVu dCAgPGJhc2lsZV9jbGVtZW50QGFwcGxlLmNvbT4KKworICAgICAgICBGdW5jdGlvbiBhbGxvY2F0 aW9uIHNpbmtpbmcgc2hvdWxkbid0IGJlIHBlcmZvcm1lZCBvbiBzaW5nbGV0b24gZnVuY3Rpb25z CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQxNjYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGdW5jdGlv biBhbGxvY2F0aW9uIHVzdWFsbHkgYXJlIGZyZWUgb2YgYW55IG90aGVyIHNpZGUgZWZmZWN0cywg YnV0CisgICAgICAgIHRoaXMgaXMgbm90IHRoZSBjYXNlIGZvciBhbGxvY2F0aW9ucyBwZXJmb3Jt ZWQgd2hpbGUgdGhlIHVuZGVybHlpbmcKKyAgICAgICAgRnVuY3Rpb25FeGVjdXRhYmxlIGlzIHN0 aWxsIGEgc2luZ2xldG9uIChhcyB0aGlzIGFsbG9nYXRpb24gd2lsbCBmaXJlCisgICAgICAgIHdh dGNocG9pbnRzIGludmFsaWRhdGluZyBjb2RlIHRoYXQgZGVwZW5kcyBvbiBpdCBiZWluZyBhIHNp bmdsZXRvbikuICBBY2NvcmRpbmcKKyAgICAgICAgdG8gZnBpemxvLCB0aGlzIGhhcHBlbnMgdG8g YmUgc2lua2FibGUgcmlnaHQgbm93LCBidXQgdGhpbmdzIG1heSBub3Qgc3RheSB0aGF0CisgICAg ICAgIHdheSBpbiB0aGUgZnV0dXJlIChlLmcuIGl0IHdvdWxkIG5vdCBiZSB0aGUgY2FzZSBmb3Ig Q3JlYXRlQWN0aXZhdGlvbiksIGFuZAorICAgICAgICBmaXhpbmcgdGhpcyBub3cgd291bGQgaGVs cCBwcmV2ZW50IGhhcmQtdG8tZmluZCBidWdzIGxhdGVyIGluIHRoYXQgY2FzZS4KKworICAgICAg ICBUaGlzIGFsc28gbWVhbnMgdGhhdCB3aGVuIG1hdGVyaWFsaXppbmcgYSBmdW5jdGlvbiBhbGxv Y2F0aW9uIG9uIE9TUgorICAgICAgICBleGl0LCB0aGF0IGZ1bmN0aW9uJ3MgZXhlY3V0YWJsZSB3 aWxsIG5ldmVyIGJlIGEgc2luZ2xldG9uLCBhbmQgd2UgZG9uJ3QgaGF2ZQorICAgICAgICB0byB3 b3JyeSBhYm91dCBpdHMgd2F0Y2hwb2ludCwgYWxsb3dpbmcgdG8gdXNlCisgICAgICAgIEpTRnVu Y3Rpb246OmNyZWF0ZVdpdGhJbnZhbGlkYXRlZFJlbGxvY2F0aW9uV2F0Y2hwb2ludCBpbnN0ZWFk IG9mCisgICAgICAgIEpTRnVuY3Rpb246OmNyZWF0ZS4KKworICAgICAgICAqIGRmZy9ERkdPYmpl Y3RBbGxvY2F0aW9uU2lua2luZ1BoYXNlLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpPYmplY3RB bGxvY2F0aW9uU2lua2luZ1BoYXNlOjpoYW5kbGVOb2RlKToKKyAgICAgICAgKiBmdGwvRlRMT3Bl cmF0aW9ucy5jcHA6CisgICAgICAgIChKU0M6OkZUTDo6b3BlcmF0aW9uTWF0ZXJpYWxpemVPYmpl Y3RJbk9TUik6CisKIDIwMTUtMDQtMjMgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBs ZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGEgdXNlbGVzcyBicmFuY2ggb24gREZHR3JhcGg6OmFk ZFNob3VsZFNwZWN1bGF0ZU1hY2hpbmVJbnQoKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdPYmplY3RBbGxvY2F0aW9uU2lua2luZ1BoYXNlLmNwcCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHT2JqZWN0QWxsb2NhdGlvblNpbmtpbmdQaGFzZS5jcHAKaW5k ZXggYzk4YTgyZC4uOTdjMmUwNSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdPYmplY3RBbGxvY2F0aW9uU2lua2luZ1BoYXNlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR09iamVjdEFsbG9jYXRpb25TaW5raW5nUGhhc2UuY3BwCkBAIC03ODEs NyArNzgxLDggQEAgcHJpdmF0ZToKICAgICAgICAgICAgIGJyZWFrOwogCiAgICAgICAgIGNhc2Ug TmV3RnVuY3Rpb246Ci0gICAgICAgICAgICBzaW5rQ2FuZGlkYXRlKCk7CisgICAgICAgICAgICBp ZiAoIW5vZGUtPmNhc3RPcGVyYW5kPEZ1bmN0aW9uRXhlY3V0YWJsZSo+KCktPnNpbmdsZXRvbkZ1 bmN0aW9uKCktPmlzU3RpbGxWYWxpZCgpKQorICAgICAgICAgICAgICAgIHNpbmtDYW5kaWRhdGUo KTsKICAgICAgICAgICAgIG1fZ3JhcGguZG9Ub0NoaWxkcmVuKAogICAgICAgICAgICAgICAgIG5v ZGUsCiAgICAgICAgICAgICAgICAgWyZdIChFZGdlIGVkZ2UpIHsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMT3BlcmF0aW9ucy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvZnRsL0ZUTE9wZXJhdGlvbnMuY3BwCmluZGV4IGFmNTdmMjcuLmZiNzE0YjggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMT3BlcmF0aW9ucy5jcHAKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExPcGVyYXRpb25zLmNwcApAQCAtMTA2LDcgKzEw Niw3IEBAIGV4dGVybiAiQyIgSlNDZWxsKiBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvbk1hdGVyaWFs aXplT2JqZWN0SW5PU1IoCiAgICAgICAgIH0KICAgICAgICAgUkVMRUFTRV9BU1NFUlQoZXhlY3V0 YWJsZSAmJiBhY3RpdmF0aW9uKTsKIAotICAgICAgICBKU0Z1bmN0aW9uKiByZXN1bHQgPSBKU0Z1 bmN0aW9uOjpjcmVhdGUodm0sIGV4ZWN1dGFibGUsIGFjdGl2YXRpb24pOworICAgICAgICBKU0Z1 bmN0aW9uKiByZXN1bHQgPSBKU0Z1bmN0aW9uOjpjcmVhdGVXaXRoSW52YWxpZGF0ZWRSZWFsbG9j YXRpb25XYXRjaHBvaW50KHZtLCBleGVjdXRhYmxlLCBhY3RpdmF0aW9uKTsKIAogICAgICAgICBy ZXR1cm4gcmVzdWx0OwogICAgIH0K 251587 2015-04-24 16:25:22 -0700 2015-04-27 12:54:35 -0700 Fix ChangeLog typos sink_newfun_singleton.patch text/plain 2932 basile_clement ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDlkYjUxMmQuLjQzZTRjYzcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDE1LTA0LTI0ICBCYXNpbGUgQ2xlbWVu dCAgPGJhc2lsZV9jbGVtZW50QGFwcGxlLmNvbT4KKworICAgICAgICBGdW5jdGlvbiBhbGxvY2F0 aW9uIHNpbmtpbmcgc2hvdWxkbid0IGJlIHBlcmZvcm1lZCBvbiBzaW5nbGV0b24gZnVuY3Rpb25z CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQxNjYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGdW5jdGlv biBhbGxvY2F0aW9ucyB1c3VhbGx5IGFyZSBmcmVlIG9mIGFueSBvdGhlciBzaWRlIGVmZmVjdHMs IGJ1dAorICAgICAgICB0aGlzIGlzIG5vdCB0aGUgY2FzZSBmb3IgYWxsb2NhdGlvbnMgcGVyZm9y bWVkIHdoaWxlIHRoZSB1bmRlcmx5aW5nCisgICAgICAgIEZ1bmN0aW9uRXhlY3V0YWJsZSBpcyBz dGlsbCBhIHNpbmdsZXRvbiAoYXMgdGhpcyBhbGxvZ2F0aW9uIHdpbGwgZmlyZQorICAgICAgICB3 YXRjaHBvaW50cyBpbnZhbGlkYXRpbmcgY29kZSB0aGF0IGRlcGVuZHMgb24gaXQgYmVpbmcgYSBz aW5nbGV0b24pLiAgQWNjb3JkaW5nCisgICAgICAgIHRvIGZwaXpsbywgdGhpcyBoYXBwZW5zIHRv IGJlIHNpbmthYmxlIHJpZ2h0IG5vdywgYnV0IHRoaW5ncyBtYXkgbm90IHN0YXkgdGhhdAorICAg ICAgICB3YXkgaW4gdGhlIGZ1dHVyZSAoZS5nLiBpdCB3b3VsZCBub3QgYmUgdGhlIGNhc2UgZm9y IENyZWF0ZUFjdGl2YXRpb24pLCBhbmQKKyAgICAgICAgZml4aW5nIHRoaXMgbm93IHdvdWxkIGhl bHAgcHJldmVudCBoYXJkLXRvLWZpbmQgYnVncyBsYXRlciBpbiB0aGF0IGNhc2UuCisKKyAgICAg ICAgVGhpcyBhbHNvIG1lYW5zIHRoYXQgd2hlbiBtYXRlcmlhbGl6aW5nIGEgZnVuY3Rpb24gYWxs b2NhdGlvbiBvbiBPU1IKKyAgICAgICAgZXhpdCwgdGhhdCBmdW5jdGlvbidzIGV4ZWN1dGFibGUg d2lsbCBuZXZlciBiZSBhIHNpbmdsZXRvbiwgYW5kIHdlIGRvbid0IGhhdmUKKyAgICAgICAgdG8g d29ycnkgYWJvdXQgaXRzIHdhdGNocG9pbnQsIGFsbG93aW5nIHVzIHRvIHVzZQorICAgICAgICBK U0Z1bmN0aW9uOjpjcmVhdGVXaXRoSW52YWxpZGF0ZWRSZWxsb2NhdGlvbldhdGNocG9pbnQgaW5z dGVhZCBvZgorICAgICAgICBKU0Z1bmN0aW9uOjpjcmVhdGUuCisKKyAgICAgICAgKiBkZmcvREZH T2JqZWN0QWxsb2NhdGlvblNpbmtpbmdQaGFzZS5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6T2Jq ZWN0QWxsb2NhdGlvblNpbmtpbmdQaGFzZTo6aGFuZGxlTm9kZSk6CisgICAgICAgICogZnRsL0ZU TE9wZXJhdGlvbnMuY3BwOgorICAgICAgICAoSlNDOjpGVEw6Om9wZXJhdGlvbk1hdGVyaWFsaXpl T2JqZWN0SW5PU1IpOgorCiAyMDE1LTA0LTIzICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5A YXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBhIHVzZWxlc3MgYnJhbmNoIG9uIERGR0dyYXBo OjphZGRTaG91bGRTcGVjdWxhdGVNYWNoaW5lSW50KCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHT2JqZWN0QWxsb2NhdGlvblNpbmtpbmdQaGFzZS5jcHAgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09iamVjdEFsbG9jYXRpb25TaW5raW5nUGhhc2UuY3Bw CmluZGV4IGM5OGE4MmQuLjk3YzJlMDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHT2JqZWN0QWxsb2NhdGlvblNpbmtpbmdQaGFzZS5jcHAKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdPYmplY3RBbGxvY2F0aW9uU2lua2luZ1BoYXNlLmNwcApAQCAt NzgxLDcgKzc4MSw4IEBAIHByaXZhdGU6CiAgICAgICAgICAgICBicmVhazsKIAogICAgICAgICBj YXNlIE5ld0Z1bmN0aW9uOgotICAgICAgICAgICAgc2lua0NhbmRpZGF0ZSgpOworICAgICAgICAg ICAgaWYgKCFub2RlLT5jYXN0T3BlcmFuZDxGdW5jdGlvbkV4ZWN1dGFibGUqPigpLT5zaW5nbGV0 b25GdW5jdGlvbigpLT5pc1N0aWxsVmFsaWQoKSkKKyAgICAgICAgICAgICAgICBzaW5rQ2FuZGlk YXRlKCk7CiAgICAgICAgICAgICBtX2dyYXBoLmRvVG9DaGlsZHJlbigKICAgICAgICAgICAgICAg ICBub2RlLAogICAgICAgICAgICAgICAgIFsmXSAoRWRnZSBlZGdlKSB7CmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTE9wZXJhdGlvbnMuY3BwIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2Z0bC9GVExPcGVyYXRpb25zLmNwcAppbmRleCBhZjU3ZjI3Li5mYjcxNGI4IDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTE9wZXJhdGlvbnMuY3BwCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMT3BlcmF0aW9ucy5jcHAKQEAgLTEwNiw3 ICsxMDYsNyBAQCBleHRlcm4gIkMiIEpTQ2VsbCogSklUX09QRVJBVElPTiBvcGVyYXRpb25NYXRl cmlhbGl6ZU9iamVjdEluT1NSKAogICAgICAgICB9CiAgICAgICAgIFJFTEVBU0VfQVNTRVJUKGV4 ZWN1dGFibGUgJiYgYWN0aXZhdGlvbik7CiAKLSAgICAgICAgSlNGdW5jdGlvbiogcmVzdWx0ID0g SlNGdW5jdGlvbjo6Y3JlYXRlKHZtLCBleGVjdXRhYmxlLCBhY3RpdmF0aW9uKTsKKyAgICAgICAg SlNGdW5jdGlvbiogcmVzdWx0ID0gSlNGdW5jdGlvbjo6Y3JlYXRlV2l0aEludmFsaWRhdGVkUmVh bGxvY2F0aW9uV2F0Y2hwb2ludCh2bSwgZXhlY3V0YWJsZSwgYWN0aXZhdGlvbik7CiAKICAgICAg ICAgcmV0dXJuIHJlc3VsdDsKICAgICB9Cg== 251772 2015-04-27 12:54:35 -0700 2015-05-01 14:45:58 -0700 Simplify ChangeLog entry fix_singleton.patch text/plain 2872 basile_clement ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGY5ODRjNDUuLjYwNjVmYzUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE1LTA0LTI0ICBCYXNpbGUgQ2xlbWVu dCAgPGJhc2lsZV9jbGVtZW50QGFwcGxlLmNvbT4KKworICAgICAgICBGdW5jdGlvbiBhbGxvY2F0 aW9uIHNpbmtpbmcgc2hvdWxkbid0IGJlIHBlcmZvcm1lZCBvbiBzaW5nbGV0b24gZnVuY3Rpb25z CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQxNjYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGdW5jdGlv biBhbGxvY2F0aW9ucyB1c3VhbGx5IGFyZSBmcmVlIG9mIGFueSBvdGhlciBzaWRlIGVmZmVjdHMs IGJ1dAorICAgICAgICB0aGlzIGlzIG5vdCB0aGUgY2FzZSBmb3IgYWxsb2NhdGlvbnMgcGVyZm9y bWVkIHdoaWxlIHRoZSB1bmRlcmx5aW5nCisgICAgICAgIEZ1bmN0aW9uRXhlY3V0YWJsZSBpcyBz dGlsbCBhIHNpbmdsZXRvbiAoYXMgdGhpcyBhbGxvZ2F0aW9uIHdpbGwgZmlyZQorICAgICAgICB3 YXRjaHBvaW50cyBpbnZhbGlkYXRpbmcgY29kZSB0aGF0IGRlcGVuZHMgb24gaXQgYmVpbmcgYSBz aW5nbGV0b24pLgorICAgICAgICBBcyB0aGUgb2JqZWN0IGFsbG9jYXRpb24gc2lua2luZyBwaGFz ZSBhc3N1bWVzIG9iamVjdCBhbGxvY2F0aW9uIGlzCisgICAgICAgIGZyZWUgb2Ygc2lkZS1lZmZl Y3RzLCBzaW5raW5nIHRoZXNlIGFsbG9jYXRpb25zIGlzIG5vdCBjb3JyZWN0LgorCisgICAgICAg IFRoaXMgYWxzbyBtZWFucyB0aGF0IHdoZW4gbWF0ZXJpYWxpemluZyBhIGZ1bmN0aW9uIGFsbG9j YXRpb24gb24gT1NSCisgICAgICAgIGV4aXQsIHRoYXQgZnVuY3Rpb24ncyBleGVjdXRhYmxlIHdp bGwgbmV2ZXIgYmUgYSBzaW5nbGV0b24sIGFuZCB3ZSBkb24ndCBoYXZlCisgICAgICAgIHRvIHdv cnJ5IGFib3V0IGl0cyB3YXRjaHBvaW50LCBhbGxvd2luZyB1cyB0byB1c2UKKyAgICAgICAgSlNG dW5jdGlvbjo6Y3JlYXRlV2l0aEludmFsaWRhdGVkUmVsbG9jYXRpb25XYXRjaHBvaW50IGluc3Rl YWQgb2YKKyAgICAgICAgSlNGdW5jdGlvbjo6Y3JlYXRlLgorCisgICAgICAgICogZGZnL0RGR09i amVjdEFsbG9jYXRpb25TaW5raW5nUGhhc2UuY3BwOgorICAgICAgICAoSlNDOjpERkc6Ok9iamVj dEFsbG9jYXRpb25TaW5raW5nUGhhc2U6OmhhbmRsZU5vZGUpOgorICAgICAgICAqIGZ0bC9GVExP cGVyYXRpb25zLmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpvcGVyYXRpb25NYXRlcmlhbGl6ZU9i amVjdEluT1NSKToKKwogMjAxNS0wNC0yNSAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29t PgogCiAgICAgICAgIFZhcmFyZ3NGb3J3YXJkaW5nUGhhc2Ugc2hvdWxkIHVzZSBieXRlY29kZSBs aXZlbmVzcyBpbiBhZGRpdGlvbiB0byBvdGhlciB1c2VzIHRvIGRldGVybWluZSB0aGUgbGFzdCBw b2ludCB0aGF0IGEgY2FuZGlkYXRlIGlzIHVzZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHT2JqZWN0QWxsb2NhdGlvblNpbmtpbmdQaGFzZS5jcHAgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR09iamVjdEFsbG9jYXRpb25TaW5raW5nUGhhc2UuY3BwCmlu ZGV4IDRiYzJjMGQuLmU4NzQ3ZDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHT2JqZWN0QWxsb2NhdGlvblNpbmtpbmdQaGFzZS5jcHAKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdPYmplY3RBbGxvY2F0aW9uU2lua2luZ1BoYXNlLmNwcApAQCAtNzgx LDcgKzc4MSw4IEBAIHByaXZhdGU6CiAgICAgICAgICAgICBicmVhazsKIAogICAgICAgICBjYXNl IE5ld0Z1bmN0aW9uOgotICAgICAgICAgICAgc2lua0NhbmRpZGF0ZSgpOworICAgICAgICAgICAg aWYgKCFub2RlLT5jYXN0T3BlcmFuZDxGdW5jdGlvbkV4ZWN1dGFibGUqPigpLT5zaW5nbGV0b25G dW5jdGlvbigpLT5pc1N0aWxsVmFsaWQoKSkKKyAgICAgICAgICAgICAgICBzaW5rQ2FuZGlkYXRl KCk7CiAgICAgICAgICAgICBtX2dyYXBoLmRvVG9DaGlsZHJlbigKICAgICAgICAgICAgICAgICBu b2RlLAogICAgICAgICAgICAgICAgIFsmXSAoRWRnZSBlZGdlKSB7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTE9wZXJhdGlvbnMuY3BwIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2Z0bC9GVExPcGVyYXRpb25zLmNwcAppbmRleCBhZjU3ZjI3Li5mYjcxNGI4IDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTE9wZXJhdGlvbnMuY3BwCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMT3BlcmF0aW9ucy5jcHAKQEAgLTEwNiw3ICsx MDYsNyBAQCBleHRlcm4gIkMiIEpTQ2VsbCogSklUX09QRVJBVElPTiBvcGVyYXRpb25NYXRlcmlh bGl6ZU9iamVjdEluT1NSKAogICAgICAgICB9CiAgICAgICAgIFJFTEVBU0VfQVNTRVJUKGV4ZWN1 dGFibGUgJiYgYWN0aXZhdGlvbik7CiAKLSAgICAgICAgSlNGdW5jdGlvbiogcmVzdWx0ID0gSlNG dW5jdGlvbjo6Y3JlYXRlKHZtLCBleGVjdXRhYmxlLCBhY3RpdmF0aW9uKTsKKyAgICAgICAgSlNG dW5jdGlvbiogcmVzdWx0ID0gSlNGdW5jdGlvbjo6Y3JlYXRlV2l0aEludmFsaWRhdGVkUmVhbGxv Y2F0aW9uV2F0Y2hwb2ludCh2bSwgZXhlY3V0YWJsZSwgYWN0aXZhdGlvbik7CiAKICAgICAgICAg cmV0dXJuIHJlc3VsdDsKICAgICB9Cg== 252172 2015-05-01 14:46:05 -0700 2015-05-01 15:34:49 -0700 Patch for landing bug-144166-20150501144453.patch text/plain 3034 basile_clement U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzNjkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 MDhiNzJhNWI5ZTFhZGQ4NjU2ODQ0NjYyNjdmNDUzYzA4ZDdlNzc3Li5hNmY5OWZiYzQ1MGVkNzU0 YzA1NTI5OWM0ODU3MTc1OTk3N2JhODg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyOCBAQAorMjAxNS0wNS0wMSAgQmFzaWxlIENsZW1lbnQgIDxiYXNpbGVfY2xlbWVudEBh cHBsZS5jb20+CisKKyAgICAgICAgRnVuY3Rpb24gYWxsb2NhdGlvbiBzaW5raW5nIHNob3VsZG4n dCBiZSBwZXJmb3JtZWQgb24gc2luZ2xldG9uIGZ1bmN0aW9ucworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0MTY2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgR2VvZmZyZXkgR2FyZW4uCisKKyAgICAgICAgRnVuY3Rpb24gYWxsb2NhdGlvbnMgdXN1YWxs eSBhcmUgZnJlZSBvZiBhbnkgb3RoZXIgc2lkZSBlZmZlY3RzLCBidXQKKyAgICAgICAgdGhpcyBp cyBub3QgdGhlIGNhc2UgZm9yIGFsbG9jYXRpb25zIHBlcmZvcm1lZCB3aGlsZSB0aGUgdW5kZXJs eWluZworICAgICAgICBGdW5jdGlvbkV4ZWN1dGFibGUgaXMgc3RpbGwgYSBzaW5nbGV0b24gKGFz IHRoaXMgYWxsb2dhdGlvbiB3aWxsIGZpcmUKKyAgICAgICAgd2F0Y2hwb2ludHMgaW52YWxpZGF0 aW5nIGNvZGUgdGhhdCBkZXBlbmRzIG9uIGl0IGJlaW5nIGEgc2luZ2xldG9uKS4KKyAgICAgICAg QXMgdGhlIG9iamVjdCBhbGxvY2F0aW9uIHNpbmtpbmcgcGhhc2UgYXNzdW1lcyBvYmplY3QgYWxs b2NhdGlvbiBpcworICAgICAgICBmcmVlIG9mIHNpZGUtZWZmZWN0cywgc2lua2luZyB0aGVzZSBh bGxvY2F0aW9ucyBpcyBub3QgY29ycmVjdC4KKworICAgICAgICBUaGlzIGFsc28gbWVhbnMgdGhh dCB3aGVuIG1hdGVyaWFsaXppbmcgYSBmdW5jdGlvbiBhbGxvY2F0aW9uIG9uIE9TUgorICAgICAg ICBleGl0LCB0aGF0IGZ1bmN0aW9uJ3MgZXhlY3V0YWJsZSB3aWxsIG5ldmVyIGJlIGEgc2luZ2xl dG9uLCBhbmQgd2UgZG9uJ3QgaGF2ZQorICAgICAgICB0byB3b3JyeSBhYm91dCBpdHMgd2F0Y2hw b2ludCwgYWxsb3dpbmcgdXMgdG8gdXNlCisgICAgICAgIEpTRnVuY3Rpb246OmNyZWF0ZVdpdGhJ bnZhbGlkYXRlZFJlbGxvY2F0aW9uV2F0Y2hwb2ludCBpbnN0ZWFkIG9mCisgICAgICAgIEpTRnVu Y3Rpb246OmNyZWF0ZS4KKworICAgICAgICAqIGRmZy9ERkdPYmplY3RBbGxvY2F0aW9uU2lua2lu Z1BoYXNlLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpPYmplY3RBbGxvY2F0aW9uU2lua2luZ1Bo YXNlOjpoYW5kbGVOb2RlKToKKyAgICAgICAgKiBmdGwvRlRMT3BlcmF0aW9ucy5jcHA6CisgICAg ICAgIChKU0M6OkZUTDo6b3BlcmF0aW9uTWF0ZXJpYWxpemVPYmplY3RJbk9TUik6CisKIDIwMTUt MDQtMzAgIEpvbiBEYXZpcyAgPGpvbmRAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGNvbnNvbGUgc2hvdWxkIHNob3cgYW4gaWNvbiBmb3IgY29uc29sZS5pbmZvKCkgbWVzc2Fn ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT2JqZWN0QWxsb2Nh dGlvblNpbmtpbmdQaGFzZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09iamVj dEFsbG9jYXRpb25TaW5raW5nUGhhc2UuY3BwCmluZGV4IDI5ZDk3NDBjMzMxNjI0ZDY1Mjg4ZjE2 NTc4MmQ0NmI3ODI4MDkxOWMuLjhmODczNDJhYWEzOWRhMzM4NWIwN2NmNDNiNjdmNWVjMGU2ZmQ5 N2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT2JqZWN0QWxsb2Nh dGlvblNpbmtpbmdQaGFzZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdP YmplY3RBbGxvY2F0aW9uU2lua2luZ1BoYXNlLmNwcApAQCAtNzg2LDcgKzc4Niw4IEBAIHByaXZh dGU6CiAgICAgICAgICAgICBicmVhazsKIAogICAgICAgICBjYXNlIE5ld0Z1bmN0aW9uOgotICAg ICAgICAgICAgc2lua0NhbmRpZGF0ZSgpOworICAgICAgICAgICAgaWYgKCFub2RlLT5jYXN0T3Bl cmFuZDxGdW5jdGlvbkV4ZWN1dGFibGUqPigpLT5zaW5nbGV0b25GdW5jdGlvbigpLT5pc1N0aWxs VmFsaWQoKSkKKyAgICAgICAgICAgICAgICBzaW5rQ2FuZGlkYXRlKCk7CiAgICAgICAgICAgICBt X2dyYXBoLmRvVG9DaGlsZHJlbigKICAgICAgICAgICAgICAgICBub2RlLAogICAgICAgICAgICAg ICAgIFsmXSAoRWRnZSBlZGdlKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv ZnRsL0ZUTE9wZXJhdGlvbnMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExPcGVy YXRpb25zLmNwcAppbmRleCBhZjU3ZjI3OGZjOGIwNjk4NzliMWU3YTYyOWI0ODlhMjAwMjQ2OTM1 Li5mYjcxNGI4MmE1Yjg3ZTE2MzEzNDM4MzMyNmYyODRmMGFkNjRiNjMzIDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTE9wZXJhdGlvbnMuY3BwCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9mdGwvRlRMT3BlcmF0aW9ucy5jcHAKQEAgLTEwNiw3ICsxMDYsNyBAQCBl eHRlcm4gIkMiIEpTQ2VsbCogSklUX09QRVJBVElPTiBvcGVyYXRpb25NYXRlcmlhbGl6ZU9iamVj dEluT1NSKAogICAgICAgICB9CiAgICAgICAgIFJFTEVBU0VfQVNTRVJUKGV4ZWN1dGFibGUgJiYg YWN0aXZhdGlvbik7CiAKLSAgICAgICAgSlNGdW5jdGlvbiogcmVzdWx0ID0gSlNGdW5jdGlvbjo6 Y3JlYXRlKHZtLCBleGVjdXRhYmxlLCBhY3RpdmF0aW9uKTsKKyAgICAgICAgSlNGdW5jdGlvbiog cmVzdWx0ID0gSlNGdW5jdGlvbjo6Y3JlYXRlV2l0aEludmFsaWRhdGVkUmVhbGxvY2F0aW9uV2F0 Y2hwb2ludCh2bSwgZXhlY3V0YWJsZSwgYWN0aXZhdGlvbik7CiAKICAgICAgICAgcmV0dXJuIHJl c3VsdDsKICAgICB9Cg==