144150 2015-04-24 09:36:45 -0700 REGRESSION: Web Inspector: Start Timeline Recording in Develop menu broken 2015-04-24 11:45:14 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1088235 0 timothy 2015-04-24 09:36:45 -0700 There are two issues with this one in WebKit2 and one in InspectorFrontendAPI.js. 1088236 1 webkit-bug-importer 2015-04-24 09:37:05 -0700 <rdar://problem/20685861> 1088238 2 251555 timothy 2015-04-24 09:39:40 -0700 Created attachment 251555 Patch 1088242 3 251555 burg 2015-04-24 10:16:02 -0700 Comment on attachment 251555 Patch r=me It would be great to simplify this code a little, some day. 1088264 4 251555 commit-queue 2015-04-24 11:03:42 -0700 Comment on attachment 251555 Patch Clearing flags on attachment: 251555 Committed r183268: <http://trac.webkit.org/changeset/183268> 1088265 5 commit-queue 2015-04-24 11:03:47 -0700 All reviewed patches have been landed. Closing bug. 1088280 6 251555 joepeck 2015-04-24 11:45:14 -0700 Comment on attachment 251555 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251555&action=review > Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp:259 > + evaluateExpressionOnLoad(makeString("InspectorFrontendAPI.dispatch([\"", command, "\", ", ASCIILiteral(argument ? "true" : "false"), "])")); The ASCIILiteral is not needed here now that we are using makeString(...). 251555 2015-04-24 09:39:40 -0700 2015-04-24 11:03:42 -0700 Patch bug-144150-20150424093834.patch text/plain 3140 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNzk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBl NWYxNGExMDdhZGVjNmEzOTQxM2QwM2I5YTZiN2JkMTg5NzA2YjMzLi44OGE1NWVlOGZiZTZmN2Jj YjMyYjdlNjgxY2Q1ODM4OTc4YjZmZGE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNS0wNC0yNCAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgUkVHUkVTU0lPTjogV2ViIEluc3BlY3RvcjogU3RhcnQgVGltZWxpbmUg UmVjb3JkaW5nIGluIERldmVsb3AgbWVudSBicm9rZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDE1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Qcm90b2NvbC9JbnNwZWN0 b3JGcm9udGVuZEFQSS5qczoKKyAgICAgICAgKEluc3BlY3RvckZyb250ZW5kQVBJLnNldFRpbWVs aW5lUHJvZmlsaW5nRW5hYmxlZCk6IENoYW5nZSAhPT0gdG8gPT09IHdoZW4KKyAgICAgICAgY2hl Y2tpbmcgZW5hYmxlZCB0byBpc0NhcHR1cmluZygpLgorCiAyMDE1LTA0LTIzICBUaW1vdGh5IEhh dGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZW1v dmUgTWFpbi5qcyBjb2RlIHdlIGRvbid0IG5lZWQgZm9yIFRhYnMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA0M2Mz YzI3OTY5MTRjN2I2NGEyZjk2OWUxNjU1OGU0OWE1YjI0OTM1Li5hNDdjNjU4NDdmNjg4MjljY2Fj YzgyZTY4OWQwNTk3OGU5ZmQ2NjVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTUt MDQtMjQgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIFJF R1JFU1NJT046IFdlYiBJbnNwZWN0b3I6IFN0YXJ0IFRpbWVsaW5lIFJlY29yZGluZyBpbiBEZXZl bG9wIG1lbnUgYnJva2VuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDQxNTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJJbnNwZWN0b3JVSS5jcHA6CisgICAgICAg IChXZWJLaXQ6OldlYkluc3BlY3RvclVJOjpldmFsdWF0ZUNvbW1hbmRPbkxvYWQpOiBQcm9wZXJs eSB0cmVhdCBib29scyBhcyBsaXRlcmFscworICAgICAgICBpbnN0ZWFkIG9mIHN0cmluZ3MgYnkg bm90IHVzaW5nIHRoZSBzdHJpbmcgdmVyc2lvbiBvZiBldmFsdWF0ZUNvbW1hbmRPbkxvYWQuCisK IDIwMTUtMDQtMTMgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAg ICAgQnVpbGQgZml4ZXMgYWZ0ZXIgcjE4Mjc3Mi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL0luc3BlY3RvckZyb250ZW5kQVBJLmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvSW5zcGVjdG9yRnJv bnRlbmRBUEkuanMKaW5kZXggYjkwYWM4MGYxNWYxYjE0MWE2NzE0N2JlZThkMDgyOGExYmRhNzFl MS4uYjIxMzI5MGU2NTU5YTIyNTJlN2Y4M2MyMDRhMzI0NjFmMTNkOTdkNSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvSW5zcGVjdG9yRnJv bnRlbmRBUEkuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUHJv dG9jb2wvSW5zcGVjdG9yRnJvbnRlbmRBUEkuanMKQEAgLTQ0LDcgKzQ0LDcgQEAgSW5zcGVjdG9y RnJvbnRlbmRBUEkgPSB7CiAKICAgICBzZXRUaW1lbGluZVByb2ZpbGluZ0VuYWJsZWQ6IGZ1bmN0 aW9uKGVuYWJsZWQpCiAgICAgewotICAgICAgICBpZiAoV2ViSW5zcGVjdG9yLnRpbWVsaW5lTWFu YWdlci5pc0NhcHR1cmluZygpICE9PSBlbmFibGVkKQorICAgICAgICBpZiAoV2ViSW5zcGVjdG9y LnRpbWVsaW5lTWFuYWdlci5pc0NhcHR1cmluZygpID09PSBlbmFibGVkKQogICAgICAgICAgICAg cmV0dXJuOwogCiAgICAgICAgIGlmIChlbmFibGVkKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViSW5zcGVjdG9yVUkuY3BwIGIvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkluc3BlY3RvclVJLmNwcAppbmRleCBkZWQzNjk5YmM0 MjVhZWNiNGVhNGFhM2Y5MmI0MTMwMDUwNDg2ZDYxLi41NTBkZjcyNmRjZDRhOTQ0M2U1Y2Q1ODdl ZTIzODFjNjRjYjJlZWIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvV2ViSW5zcGVjdG9yVUkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9XZWJJbnNwZWN0b3JVSS5jcHAKQEAgLTI1Niw3ICsyNTYsNyBAQCB2b2lkIFdlYklu c3BlY3RvclVJOjpldmFsdWF0ZUNvbW1hbmRPbkxvYWQoY29uc3QgU3RyaW5nJiBjb21tYW5kLCBj b25zdCBTdHJpbmcmCiAKIHZvaWQgV2ViSW5zcGVjdG9yVUk6OmV2YWx1YXRlQ29tbWFuZE9uTG9h ZChjb25zdCBTdHJpbmcmIGNvbW1hbmQsIGJvb2wgYXJndW1lbnQpCiB7Ci0gICAgZXZhbHVhdGVD b21tYW5kT25Mb2FkKGNvbW1hbmQsIEFTQ0lJTGl0ZXJhbChhcmd1bWVudCA/ICJ0cnVlIiA6ICJm YWxzZSIpKTsKKyAgICBldmFsdWF0ZUV4cHJlc3Npb25PbkxvYWQobWFrZVN0cmluZygiSW5zcGVj dG9yRnJvbnRlbmRBUEkuZGlzcGF0Y2goW1wiIiwgY29tbWFuZCwgIlwiLCAiLCBBU0NJSUxpdGVy YWwoYXJndW1lbnQgPyAidHJ1ZSIgOiAiZmFsc2UiKSwgIl0pIikpOwogfQogCiB2b2lkIFdlYklu c3BlY3RvclVJOjpldmFsdWF0ZUV4cHJlc3Npb25PbkxvYWQoY29uc3QgU3RyaW5nJiBleHByZXNz aW9uKQo=