144134 2015-04-23 17:55:50 -0700 Web Inspector: Speculative fix for non-main thread auto-attach failures 2015-04-23 21:02:28 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1088113 0 joepeck 2015-04-23 17:55:50 -0700 * SUMMARY Speculative fix for non-main thread auto-attach failures. I had suggested we may want to do this in the last patch, but I couldn't come up with a case where it was failing. Though I have heard some reports, so lets just do it anyways. 1088114 1 webkit-bug-importer 2015-04-23 17:56:23 -0700 <rdar://problem/20678509> 1088115 2 251517 joepeck 2015-04-23 17:56:56 -0700 Created attachment 251517 [PATCH] Proposed Fix 1088120 3 joepeck 2015-04-23 18:08:57 -0700 I believe I just confirmed it with a sample project. Sorry we don't have testing infrastructure for JSContext inspection yet. 1088168 4 251517 commit-queue 2015-04-23 21:02:23 -0700 Comment on attachment 251517 [PATCH] Proposed Fix Clearing flags on attachment: 251517 Committed r183240: <http://trac.webkit.org/changeset/183240> 1088169 5 commit-queue 2015-04-23 21:02:28 -0700 All reviewed patches have been landed. Closing bug. 251517 2015-04-23 17:56:56 -0700 2015-04-23 21:02:23 -0700 [PATCH] Proposed Fix non-main-thread.patch text/plain 1237 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDM4ODFkYTMuLjcyYzRkNjcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA0LTIzICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogU3BlY3Vs YXRpdmUgZml4IGZvciBub24tbWFpbiB0aHJlYWQgYXV0by1hdHRhY2ggZmFpbHVyZXMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDEzNAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL3Jl bW90ZS9SZW1vdGVJbnNwZWN0b3IubW06CisgICAgICAgIChJbnNwZWN0b3I6OlJlbW90ZUluc3Bl Y3Rvcjo6c2luZ2xldG9uKToKKwogMjAxNS0wNC0yMiAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmph bWluQHdlYmtpdC5vcmc+CiAKICAgICAgICAgSW1wbGVtZW50IFN0cmluZy5jb2RlUG9pbnRBdCgp CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9SZW1v dGVJbnNwZWN0b3IubW0gYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9S ZW1vdGVJbnNwZWN0b3IubW0KaW5kZXggZjYxNjk4NC4uZmM5YWQ4YSAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yLm1tCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90ZUluc3BlY3Rv ci5tbQpAQCAtOTQsNyArOTQsNyBAQCBSZW1vdGVJbnNwZWN0b3ImIFJlbW90ZUluc3BlY3Rvcjo6 c2luZ2xldG9uKCkKICAgICAgICAgICAgIGlmIChbTlNUaHJlYWQgaXNNYWluVGhyZWFkXSkKICAg ICAgICAgICAgICAgICBpbml0aWFsaXplKCk7CiAgICAgICAgICAgICBlbHNlCi0gICAgICAgICAg ICAgICAgZGlzcGF0Y2hfYXN5bmMoZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUoKSwgaW5pdGlhbGl6 ZSk7CisgICAgICAgICAgICAgICAgZGlzcGF0Y2hfc3luYyhkaXNwYXRjaF9nZXRfbWFpbl9xdWV1 ZSgpLCBpbml0aWFsaXplKTsKICAgICAgICAgfQogICAgIH0pOwogCg==