144122 2015-04-23 14:40:24 -0700 Update media timeline controls when video is paused. 2015-04-23 16:02:44 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned commit-queue dino roger_fong oldest_to_newest 1088006 0 roger_fong 2015-04-23 14:40:24 -0700 We don't show or update our controls when the video is paused. This is normally not an issue if you pause via the controls because the timeline is already active and being shown but if paused programmatically, (like when the video ends) the controls do not appear. 1088007 1 roger_fong 2015-04-23 14:40:56 -0700 rdar://problem/19823121 1088008 2 roger_fong 2015-04-23 14:42:49 -0700 Note that this now matches our behavior on iOS. 1088010 3 251493 roger_fong 2015-04-23 14:45:11 -0700 Created attachment 251493 patchh 1088012 4 251493 jonlee 2015-04-23 14:48:11 -0700 Comment on attachment 251493 patchh View in context: https://bugs.webkit.org/attachment.cgi?id=251493&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1310 > + this.showControls(); This will keep the controls hidden if the <video> does not specify the "controls" attribute? 1088036 5 roger_fong 2015-04-23 15:21:30 -0700 (In reply to comment #4) > Comment on attachment 251493 [details] > patchh > > View in context: > https://bugs.webkit.org/attachment.cgi?id=251493&action=review > > > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1310 > > + this.showControls(); > > This will keep the controls hidden if the <video> does not specify the > "controls" attribute? The controls won't be created at all if the we don't specify the controls attribute, (at least they don't show up in the shadow DOM, so they could be getting display: none'd). Either this won't effect the "controls" attribute. 1088072 6 251493 commit-queue 2015-04-23 16:02:40 -0700 Comment on attachment 251493 patchh Clearing flags on attachment: 251493 Committed r183225: <http://trac.webkit.org/changeset/183225> 1088073 7 commit-queue 2015-04-23 16:02:44 -0700 All reviewed patches have been landed. Closing bug. 251493 2015-04-23 14:45:11 -0700 2015-04-23 16:02:40 -0700 patchh patch.patch text/plain 2503 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MzIxMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA0LTIzICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgVXBkYXRlIG1lZGlhIHRpbWVs aW5lIGNvbnRyb2xzIHdoZW4gdmlkZW8gaXMgcGF1c2VkLi4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDEyMi4KKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzIwNDIyOTI3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5qczoKKyAg ICAgICAgKENvbnRyb2xsZXIucHJvdG90eXBlLmRyYXdUaW1lbGluZUJhY2tncm91bmQpOiBVc2Ug dGltZWxpbmVXaWR0aCBiZWNhdXNlIG9mZnNldFdpZHRoIGlzIDAgd2hlbiBkaXNwbGF5OiBub25l LgorICAgICAgICAoQ29udHJvbGxlci5wcm90b3R5cGUuc2V0UGxheWluZyk6IFNob3cgY29udHJv bHMgd2hlbiBwYXVzaW5nLgorICAgICAgICAoQ29udHJvbGxlci5wcm90b3R5cGUuc2hvd0NvbnRy b2xzKTogVXBkYXRlIHRpbWUgYW5kIHRpbWVsaW5lIHdoZW4gdW5oaWRpbmcgY29udHJvbHMuCisK IDIwMTUtMDQtMjMgIFJvZ2VyIEZvbmcgIDxyb2dlcl9mb25nQGFwcGxlLmNvbT4KIAogICAgICAg ICBVbnJldmlld2VkLiBNaXNzZWQgYSBidXR0b24gaW4gcjE4MjkwMC4KSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanMKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJv bHNBcHBsZS5qcwkocmV2aXNpb24gMTgzMTY4KQorKysgU291cmNlL1dlYkNvcmUvTW9kdWxlcy9t ZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5qcwkod29ya2luZyBjb3B5KQpAQCAtMTEz MSw4ICsxMTMxLDggQEAgQ29udHJvbGxlci5wcm90b3R5cGUgPSB7CiAKICAgICBkcmF3VGltZWxp bmVCYWNrZ3JvdW5kOiBmdW5jdGlvbigpIHsKICAgICAgICAgdmFyIGRwciA9IHdpbmRvdy5kZXZp Y2VQaXhlbFJhdGlvOwotICAgICAgICB2YXIgd2lkdGggPSB0aGlzLmNvbnRyb2xzLnRpbWVsaW5l Lm9mZnNldFdpZHRoICogZHByOwotICAgICAgICB2YXIgaGVpZ2h0ID0gdGhpcy5jb250cm9scy50 aW1lbGluZS5vZmZzZXRIZWlnaHQgKiBkcHI7CisgICAgICAgIHZhciB3aWR0aCA9IHRoaXMudGlt ZWxpbmVXaWR0aCAqIGRwcjsKKyAgICAgICAgdmFyIGhlaWdodCA9IHRoaXMudGltZWxpbmVIZWln aHQgKiBkcHI7CiAgICAgICAgIAogICAgICAgICBpZiAoIXdpZHRoIHx8ICFoZWlnaHQpCiAgICAg ICAgICAgICByZXR1cm47CkBAIC0xMzA3LDYgKzEzMDcsNyBAQCBDb250cm9sbGVyLnByb3RvdHlw ZSA9IHsKICAgICAgICAgICAgICAgICB0aGlzLmNvbnRyb2xzLnBhbmVsQmFja2dyb3VuZC5jbGFz c0xpc3QuYWRkKHRoaXMuQ2xhc3NOYW1lcy5wYXVzZWQpOwogICAgICAgICAgICAgdGhpcy5jb250 cm9scy5wbGF5QnV0dG9uLmNsYXNzTGlzdC5hZGQodGhpcy5DbGFzc05hbWVzLnBhdXNlZCk7CiAg ICAgICAgICAgICB0aGlzLmNvbnRyb2xzLnBsYXlCdXR0b24uc2V0QXR0cmlidXRlKCdhcmlhLWxh YmVsJywgdGhpcy5VSVN0cmluZygnUGxheScpKTsKKyAgICAgICAgICAgIHRoaXMuc2hvd0NvbnRy b2xzKCk7CiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICB0aGlzLmNvbnRyb2xzLnBhbmVs LmNsYXNzTGlzdC5yZW1vdmUodGhpcy5DbGFzc05hbWVzLnBhdXNlZCk7CiAgICAgICAgICAgICBp ZiAodGhpcy5jb250cm9scy5wYW5lbEJhY2tncm91bmQpCkBAIC0xMzIxLDkgKzEzMjIsMTAgQEAg Q29udHJvbGxlci5wcm90b3R5cGUgPSB7CiAgICAgewogICAgICAgICB0aGlzLnNldE5lZWRzVGlt ZWxpbmVNZXRyaWNzVXBkYXRlKCk7CiAKLSAgICAgICAgdGhpcy51cGRhdGVUaW1lKCk7CisgICAg ICAgIHRoaXMudXBkYXRlVGltZSh0cnVlKTsKICAgICAgICAgdGhpcy51cGRhdGVQcm9ncmVzcyh0 cnVlKTsKICAgICAgICAgdGhpcy5kcmF3Vm9sdW1lQmFja2dyb3VuZCgpOworICAgICAgICB0aGlz LmRyYXdUaW1lbGluZUJhY2tncm91bmQoKTsKIAogICAgICAgICB0aGlzLmNvbnRyb2xzLnBhbmVs LmNsYXNzTGlzdC5hZGQodGhpcy5DbGFzc05hbWVzLnNob3cpOwogICAgICAgICB0aGlzLmNvbnRy b2xzLnBhbmVsLmNsYXNzTGlzdC5yZW1vdmUodGhpcy5DbGFzc05hbWVzLmhpZGRlbik7Cg==