144113 2015-04-23 12:27:56 -0700 Web Inspector: Fix layering issues with ApplicationCacheFrameTreeElement 2015-04-23 15:01:32 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 timothy timothy commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1087925 0 timothy 2015-04-23 12:27:56 -0700 There is a FIXME in ApplicationCacheFrameTreeElement. We need to fix it for tabs to work. 1087926 1 251467 timothy 2015-04-23 12:28:43 -0700 Created attachment 251467 Patch 1087992 2 251467 joepeck 2015-04-23 14:10:50 -0700 Comment on attachment 251467 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251467&action=review r=me > Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameTreeElement.js:53 > + while (currentAncestor && !currentAncestor.root) { > + if (currentAncestor instanceof WebInspector.ApplicationCacheManifestTreeElement) { And maybe we should just have a helper for this. TreeElement.prototype.firstAncestorOfType(class). I think this is not the first time we've walked up to find an ancestor via instanceof. 1088019 3 251467 commit-queue 2015-04-23 15:01:21 -0700 Comment on attachment 251467 Patch Clearing flags on attachment: 251467 Committed r183214: <http://trac.webkit.org/changeset/183214> 1088020 4 commit-queue 2015-04-23 15:01:32 -0700 All reviewed patches have been landed. Closing bug. 251467 2015-04-23 12:28:43 -0700 2015-04-23 15:01:21 -0700 Patch bug-144113-20150423122739.patch text/plain 2523 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNzk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBh M2U2YTk3OTBjNzAzNzcwNDQ1NTQ0NmI2ZTUwNzM0NjFjYTQ1MDVkLi43N2M2ZDc1MDE0M2RjN2My MDhjMzRmZGRmNWIyNGVmYWU2ZmZiZDJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNiBAQAogMjAxNS0wNC0yMyAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRml4IGxheWVyaW5nIGlzc3VlcyB3aXRoIEFw cGxpY2F0aW9uQ2FjaGVGcmFtZVRyZWVFbGVtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQxMTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQXBwbGljYXRpb25D YWNoZUZyYW1lVHJlZUVsZW1lbnQuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQXBwbGljYXRp b25DYWNoZUZyYW1lVHJlZUVsZW1lbnQucHJvdG90eXBlLnVwZGF0ZVRpdGxlcyk6CisgICAgICAg IChXZWJJbnNwZWN0b3IuQXBwbGljYXRpb25DYWNoZUZyYW1lVHJlZUVsZW1lbnQpOgorCisyMDE1 LTA0LTIzICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKwogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBNYWtlIENvbnNvbGUgd29yayBpbiBhIHRhYiB3b3JsZAogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0MTEyCiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0FwcGxpY2F0aW9u Q2FjaGVGcmFtZVRyZWVFbGVtZW50LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvQXBwbGljYXRpb25DYWNoZUZyYW1lVHJlZUVsZW1lbnQuanMKaW5kZXggYmRk NTU4YTdjZDI1MmYxNzhkOWM0MTI0N2M1YmJkMzY2MjVhY2Q5My4uNTJhNDgwZDlhMjhhYTFkNzNk M2Q0MmUwNGE4YTg0MDE5ZWM0YjhkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvQXBwbGljYXRpb25DYWNoZUZyYW1lVHJlZUVsZW1lbnQuanMK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQXBwbGljYXRp b25DYWNoZUZyYW1lVHJlZUVsZW1lbnQuanMKQEAgLTQ3LDEwICs0NywxOCBAQCBXZWJJbnNwZWN0 b3IuQXBwbGljYXRpb25DYWNoZUZyYW1lVHJlZUVsZW1lbnQgPSBjbGFzcyBBcHBsaWNhdGlvbkNh Y2hlRnJhbWVUcmVlRQogICAgICAgICAvLyBhbmQgaXQgZG9lc24ndCBtYXRjaCB0aGUgbWFpblRp dGxlLgogICAgICAgICB2YXIgc3VidGl0bGUgPSBXZWJJbnNwZWN0b3IuZGlzcGxheU5hbWVGb3JI b3N0KHBhcnNlZFVSTC5ob3N0KTsKIAotICAgICAgICAvLyBGSVhNRTogVGhpcyBpcyBiYWQgbGF5 ZXJpbmcuIFdlIHNob3VsZCBub3QgYmUgY2FsbGluZyBhIGdsb2JhbCBvYmplY3QgdG8gZ2V0IHRo aXMuCi0gICAgICAgIHZhciBtYW5pZmVzdFRyZWVFbGVtZW50ID0gV2ViSW5zcGVjdG9yLnJlc291 cmNlU2lkZWJhclBhbmVsLnRyZWVFbGVtZW50Rm9yUmVwcmVzZW50ZWRPYmplY3QodGhpcy5yZXBy ZXNlbnRlZE9iamVjdC5tYW5pZmVzdCk7CisgICAgICAgIHZhciBtYW5pZmVzdFRyZWVFbGVtZW50 ID0gbnVsbDsKKyAgICAgICAgdmFyIGN1cnJlbnRBbmNlc3RvciA9IHRoaXMucGFyZW50OworICAg ICAgICB3aGlsZSAoY3VycmVudEFuY2VzdG9yICYmICFjdXJyZW50QW5jZXN0b3Iucm9vdCkgewor ICAgICAgICAgICAgaWYgKGN1cnJlbnRBbmNlc3RvciBpbnN0YW5jZW9mIFdlYkluc3BlY3Rvci5B cHBsaWNhdGlvbkNhY2hlTWFuaWZlc3RUcmVlRWxlbWVudCkgeworICAgICAgICAgICAgICAgIG1h bmlmZXN0VHJlZUVsZW1lbnQgPSBjdXJyZW50QW5jZXN0b3I7CisgICAgICAgICAgICAgICAgYnJl YWs7CisgICAgICAgICAgICB9CiAKLSAgICAgICAgdmFyIHN1YnRpdGxlSXNEdXBsaWNhdGUgPSBz dWJ0aXRsZSA9PT0gdGhpcy5fbWFpblRpdGxlIHx8IHN1YnRpdGxlID09PSBtYW5pZmVzdFRyZWVF bGVtZW50LnN1YnRpdGxlOworICAgICAgICAgICAgY3VycmVudEFuY2VzdG9yID0gY3VycmVudEFu Y2VzdG9yLnBhcmVudDsKKyAgICAgICAgfQorCisgICAgICAgIHZhciBzdWJ0aXRsZUlzRHVwbGlj YXRlID0gc3VidGl0bGUgPT09IHRoaXMuX21haW5UaXRsZSB8fCBtYW5pZmVzdFRyZWVFbGVtZW50 ID8gc3VidGl0bGUgPT09IG1hbmlmZXN0VHJlZUVsZW1lbnQuc3VidGl0bGUgOiBmYWxzZTsKICAg ICAgICAgdGhpcy5zdWJ0aXRsZSA9IHN1YnRpdGxlSXNEdXBsaWNhdGUgPyBudWxsIDogc3VidGl0 bGU7CiAgICAgfQogfTsK