14411 2007-06-26 07:35:34 -0700 Regression: WebNetscapePluginPackage overagressively sets CurApRefNum, causes BBEdit to malfunction 2007-06-26 20:14:22 -0700 1 1 1 Unclassified WebKit New Bugs 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED InRadar P2 Major --- 1 jim.correia webkit-unassigned jim.correia mrowe oldest_to_newest 6221 0 jim.correia 2007-06-26 07:35:34 -0700 +[WebNetscapePluginPackage initialize], if invoked early enough in application startup, can result in CurApRefNum pointing at the system resource file instead of the application's bundle resource map. The attached patch addresses this issue. This affects all shipping versions of BBEdit, which rely on CurApRefNum pointing at the application's bundle resource map. This is a new problem/regression in WebKit (vs. 10.4.x shipped versions) because the startup dependency order appears to have changed. (Creating an HIWebView/WebView results in the plug-in database getting initialized in trunk versions, which invokes the problematic code. This is a problem because, for historic reasons, BBEdit creates an HIWebView very early in the startup process, before the Resource Manager has been lazy initialized and has opened the resource map.) 6220 1 15246 jim.correia 2007-06-26 07:37:54 -0700 Created attachment 15246 Proposed patch for bug. 6169 2 15246 darin 2007-06-26 13:43:15 -0700 Comment on attachment 15246 Proposed patch for bug. Good change. Tab in the ChangeLog will need ot be removed to check in. Also I'd like the comment to mention the name and brief description of the bug, not just the ID. Also, the (void) cast, while a common way to indicate that a function value is ignored, is not something we generally do in WebKit/Core code. I'd prefer to leave it out unless we have a tool that complains about ignored return values. I think the emphasis on the fact that the function is being used for its side effect is a good thing, but I think the comment already makes that clear and the ugly syntax is only really worthwhile in code where it's consistently used. 6164 3 15259 jim.correia 2007-06-26 13:51:09 -0700 Created attachment 15259 Revised patch. Updated ChangeLog comment, removed tabs. Removed cast to (void) in (+[WebNetscapePluginPackage initialize]). 6165 4 15259 jim.correia 2007-06-26 13:53:13 -0700 Comment on attachment 15259 Revised patch. Updated ChangeLog comment, removed tabs. Removed cast to (void) in (+[WebNetscapePluginPackage initialize]). Updated ChangeLog comment, removed tabs. Removed cast to (void) in (+[WebNetscapePluginPackage initialize]). 6161 5 15259 darin 2007-06-26 13:54:13 -0700 Comment on attachment 15259 Revised patch. Updated ChangeLog comment, removed tabs. Removed cast to (void) in (+[WebNetscapePluginPackage initialize]). r=me 6137 6 mrowe 2007-06-26 20:13:08 -0700 <rdar://problem/5297268> 6138 7 mrowe 2007-06-26 20:14:22 -0700 Landed in r23805. Thanks for the patch! 15246 2007-06-26 07:37:54 -0700 2007-06-26 13:51:09 -0700 Proposed patch for bug. 14411.patch text/plain 1781 jim.correia SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gMjM3OTApCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTMgQEAKKzIwMDctMDYtMjYgIEppbSBDb3JyZWlhICA8amltLmNvcnJlaWFAcG9ib3gu Y29tPgorCisJCVRoaXMgZml4ZXMgYnVnIGlkIDE0NDExLgorCisgICAgICAgICogUGx1Z2lucy9X ZWJOZXRzY2FwZVBsdWdpblBhY2thZ2UubToKKyAgICAgICAgKCtbV2ViTmV0c2NhcGVQbHVnaW5Q YWNrYWdlIGluaXRpYWxpemVdKTogRm9yY2UgdGhlIFJlc291cmNlIE1hbmFnZXIgdG8KKyAgICAg ICAgbGF6eSBpbml0aWFsaXplLCBhbmQgb25seSBzZXQgQ3VyQXBSZWZOdW0gdG8gdGhlIHN5c3Rl bSBmaWxlIGlmCisgICAgICAgIEN1ckFwUmVmTnVtIGlzIHN0aWxsIC0xIGFmdGVyIHRoYXQgZm9y Y2VkIGxhenkgaW5pdGlhbGl6YXRpb24uICAgICAgICAKKyAgICAgICAgCisKIDIwMDctMDYtMjUg IEtldmluIERlY2tlciAgPGtkZWNrZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERhcmluLgpJbmRleDogV2ViS2l0L1BsdWdpbnMvV2ViTmV0c2NhcGVQbHVnaW5QYWNrYWdlLm0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0L1BsdWdpbnMvV2ViTmV0c2NhcGVQbHVnaW5QYWNrYWdlLm0J KHJldmlzaW9uIDIzNzY5KQorKysgV2ViS2l0L1BsdWdpbnMvV2ViTmV0c2NhcGVQbHVnaW5QYWNr YWdlLm0JKHdvcmtpbmcgY29weSkKQEAgLTYxLDYgKzYxLDE2IEBAIHN0YXRpYyBUcmFuc2l0aW9u VmVjdG9yIHRWZWN0b3JGb3JGdW5jdGkKICAgICAvLyBCdXQgaXQgZG9lc24ndCBzZWVtIHRvIG1h dHRlciB3aGF0IGZpbGUgaXQgaXMuCiAgICAgLy8gSWYgd2UncmUgY2FsbGVkIGluc2lkZSBhIENv Y29hIGFwcGxpY2F0aW9uIHdoaWNoIHdvbid0IGhhdmUgYQogICAgIC8vIEN1ckFwUmVmTnVtLCB3 ZSBzZXQgaXQgdG8gcG9pbnQgdG8gdGhlIHN5c3RlbSByZXNvdXJjZSBmaWxlLgorCisgICAgLy8g Q2FsbCBDdXJSZXNGaWxlIGJlZm9yZSB0ZXN0aW5nIHRoZSByZXN1bHQgb2YgV2ViTE1HZXRDdXJB cFJlZk51bS4KKyAgICAvLyBJZiB3ZSBhcmUgY2FsbGVkIGJlZm9yZSB0aGUgYnVuZGxlIHJlc291 cmNlIG1hcCBoYXMgYmVlbiBvcGVuZWQKKyAgICAvLyBmb3IgYSBDYXJib24gYXBwbGljYXRpb24g KG9yIGEgQ29jb2EgYXBwIHdpdGggUmVzb3VyY2UgTWFuYWdlcgorICAgIC8vIHJlc291cmNlcykg d2UgKmRvIG5vdCogd2FudCB0byBzZXQgQ3VyQXBSZWZOdW0gdG8gcG9pbnQgYXQgdGhlCisgICAg Ly8gc3lzdGVtIHJlc291cmNlIGZpbGUuIEN1clJlc0ZpbGUgdHJpZ2dlcnMgUmVzb3VyY2UgTWFu YWdlciBsYXp5CisgICAgLy8gaW5pdGlhbGl6YXRpb24sIGFuZCB3aWxsIG9wZW4gdGhlIGJ1bmRs ZSByZXNvdXJjZSBtYXAgYXMgbmVjZXNzYXJ5LgorCisgICAgKHZvaWQpQ3VyUmVzRmlsZSgpOwor CiAgICAgaWYgKFdlYkxNR2V0Q3VyQXBSZWZOdW0oKSA9PSAtMSkgewogICAgICAgICAvLyBUbyBn ZXQgdGhlIHJlZk51bSBmb3IgdGhlIHN5c3RlbSByZXNvdXJjZSBmaWxlLCB3ZSBoYXZlIHRvIGRv CiAgICAgICAgIC8vIFVzZVJlc0ZpbGUoa1N5c3RlbVJlc0ZpbGUpIGFuZCB0aGVuIGxvb2sgYXQg Q3VyUmVzRmlsZSgpLgo= 15259 2007-06-26 13:51:09 -0700 2007-06-26 13:54:13 -0700 Revised patch. Updated ChangeLog comment, removed tabs. Removed cast to (void) in (+[WebNetscapePluginPackage initialize]). 14411.patch text/plain 1876 jim.correia SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gMjM3OTgpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTMgQEAKKzIwMDctMDYtMjYgIEppbSBDb3JyZWlhICA8amltLmNvcnJlaWFAcG9ib3gu Y29tPgorCisgICAgICAgIFRoaXMgZml4ZXMgYnVnIGlkIDE0NDExIC0gV2ViTmV0c2NhcGVQbHVn aW5QYWNrYWdlIG92ZXJhZ3Jlc3NpdmVseSBzZXRzCisgICAgICAgIEN1ckFwUmVmTnVtIC0gd2hp Y2ggYWZmZWN0cyBzaGlwcGluZyB2ZXJzaW9ucyBvZiBCQkVkaXQuCisKKyAgICAgICAgKiBQbHVn aW5zL1dlYk5ldHNjYXBlUGx1Z2luUGFja2FnZS5tOgorICAgICAgICAoK1tXZWJOZXRzY2FwZVBs dWdpblBhY2thZ2UgaW5pdGlhbGl6ZV0pOiBGb3JjZSB0aGUgUmVzb3VyY2UgTWFuYWdlciB0bwor ICAgICAgICBsYXp5IGluaXRpYWxpemUsIGFuZCBvbmx5IHNldCBDdXJBcFJlZk51bSB0byB0aGUg c3lzdGVtIGZpbGUgaWYKKyAgICAgICAgQ3VyQXBSZWZOdW0gaXMgc3RpbGwgLTEgYWZ0ZXIgdGhh dCBmb3JjZWQgbGF6eSBpbml0aWFsaXphdGlvbi4KKwogMjAwNy0wNi0yNSAgS2V2aW4gRGVja2Vy ICA8a2RlY2tlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4uCkluZGV4 OiBXZWJLaXQvUGx1Z2lucy9XZWJOZXRzY2FwZVBsdWdpblBhY2thZ2UubQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJLaXQvUGx1Z2lucy9XZWJOZXRzY2FwZVBsdWdpblBhY2thZ2UubQkocmV2aXNpb24gMjM3 OTgpCisrKyBXZWJLaXQvUGx1Z2lucy9XZWJOZXRzY2FwZVBsdWdpblBhY2thZ2UubQkod29ya2lu ZyBjb3B5KQpAQCAtNjEsNiArNjEsMTYgQEAgc3RhdGljIFRyYW5zaXRpb25WZWN0b3IgdFZlY3Rv ckZvckZ1bmN0aQogICAgIC8vIEJ1dCBpdCBkb2Vzbid0IHNlZW0gdG8gbWF0dGVyIHdoYXQgZmls ZSBpdCBpcy4KICAgICAvLyBJZiB3ZSdyZSBjYWxsZWQgaW5zaWRlIGEgQ29jb2EgYXBwbGljYXRp b24gd2hpY2ggd29uJ3QgaGF2ZSBhCiAgICAgLy8gQ3VyQXBSZWZOdW0sIHdlIHNldCBpdCB0byBw b2ludCB0byB0aGUgc3lzdGVtIHJlc291cmNlIGZpbGUuCisKKyAgICAvLyBDYWxsIEN1clJlc0Zp bGUgYmVmb3JlIHRlc3RpbmcgdGhlIHJlc3VsdCBvZiBXZWJMTUdldEN1ckFwUmVmTnVtLgorICAg IC8vIElmIHdlIGFyZSBjYWxsZWQgYmVmb3JlIHRoZSBidW5kbGUgcmVzb3VyY2UgbWFwIGhhcyBi ZWVuIG9wZW5lZAorICAgIC8vIGZvciBhIENhcmJvbiBhcHBsaWNhdGlvbiAob3IgYSBDb2NvYSBh cHAgd2l0aCBSZXNvdXJjZSBNYW5hZ2VyCisgICAgLy8gcmVzb3VyY2VzKSB3ZSAqZG8gbm90KiB3 YW50IHRvIHNldCBDdXJBcFJlZk51bSB0byBwb2ludCBhdCB0aGUKKyAgICAvLyBzeXN0ZW0gcmVz b3VyY2UgZmlsZS4gQ3VyUmVzRmlsZSB0cmlnZ2VycyBSZXNvdXJjZSBNYW5hZ2VyIGxhenkKKyAg ICAvLyBpbml0aWFsaXphdGlvbiwgYW5kIHdpbGwgb3BlbiB0aGUgYnVuZGxlIHJlc291cmNlIG1h cCBhcyBuZWNlc3NhcnkuCisKKyAgICBDdXJSZXNGaWxlKCk7CisKICAgICBpZiAoV2ViTE1HZXRD dXJBcFJlZk51bSgpID09IC0xKSB7CiAgICAgICAgIC8vIFRvIGdldCB0aGUgcmVmTnVtIGZvciB0 aGUgc3lzdGVtIHJlc291cmNlIGZpbGUsIHdlIGhhdmUgdG8gZG8KICAgICAgICAgLy8gVXNlUmVz RmlsZShrU3lzdGVtUmVzRmlsZSkgYW5kIHRoZW4gbG9vayBhdCBDdXJSZXNGaWxlKCkuCg==