144106 2015-04-23 10:21:14 -0700 [GTK] Make all options actually options 2015-04-28 11:03:16 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Minor --- 144105 143546 1 mcatanzaro mcatanzaro mcatanzaro mrobinson oldest_to_newest 1087868 0 mcatanzaro 2015-04-23 10:21:14 -0700 We have several options in PlatformGTK.cmake that are not actually options right now: set(ENABLE_GTKDOC OFF CACHE BOOL "Whether or not to use generate gtkdoc.") set(ENABLE_X11_TARGET ON CACHE BOOL "Whether to enable support for the X11 windowing target.") set(ENABLE_WAYLAND_TARGET OFF CACHE BOOL "Whether to enable support for the Wayland windowing target.") set(ENABLE_INTROSPECTION ON CACHE BOOL "Whether to enable GObject introspection.") set(ENABLE_GLES2 OFF CACHE BOOL "Whether to enable OpenGL ES 2.0.") These should all be defined with WEBKIT_OPTION_DEFINE so that they are printed in the features list. 1089536 1 mcatanzaro 2015-04-28 08:57:32 -0700 Turns out this is really easy now that bug #144105 is closed. 1089541 2 251849 mcatanzaro 2015-04-28 08:59:33 -0700 Created attachment 251849 Patch 1089543 3 mcatanzaro 2015-04-28 09:02:49 -0700 Martin: another quick review here would be dandy. After this, only bug #143546 is left! 1089621 4 251849 mcatanzaro 2015-04-28 11:03:11 -0700 Comment on attachment 251849 Patch Clearing flags on attachment: 251849 Committed r183491: <http://trac.webkit.org/changeset/183491> 1089622 5 mcatanzaro 2015-04-28 11:03:16 -0700 All reviewed patches have been landed. Closing bug. 251849 2015-04-28 08:59:33 -0700 2015-04-28 11:03:11 -0700 Patch bug-144106-20150428105824.patch text/plain 4790 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzNDU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGY1NGUz YzdhZmUxYmMzZDE4ZWFhNjMwMWJlYzdhOWY4NmZlN2Y3ODEuLmE4M2ViNjA2ZGIxM2E4YmVjNTIz NGExNmQyYTc1NTNiOTQ1NDA2ODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0xMiwxMSArMTIs NiBAQCBzZXQoV0VCS0lUR1RLX0FQSV9WRVJTSU9OIDQuMCkKIENBTENVTEFURV9MSUJSQVJZX1ZF UlNJT05TX0ZST01fTElCVE9PTF9UUklQTEUoV0VCS0lUMiA0MiAwIDUpCiBDQUxDVUxBVEVfTElC UkFSWV9WRVJTSU9OU19GUk9NX0xJQlRPT0xfVFJJUExFKEpBVkFTQ1JJUFRDT1JFIDE5IDMgMSkK IAotc2V0KEVOQUJMRV9HVEtET0MgT0ZGIENBQ0hFIEJPT0wgIldoZXRoZXIgb3Igbm90IHRvIHVz ZSBnZW5lcmF0ZSBndGtkb2MuIikKLXNldChFTkFCTEVfWDExX1RBUkdFVCBPTiBDQUNIRSBCT09M ICJXaGV0aGVyIHRvIGVuYWJsZSBzdXBwb3J0IGZvciB0aGUgWDExIHdpbmRvd2luZyB0YXJnZXQu IikKLXNldChFTkFCTEVfV0FZTEFORF9UQVJHRVQgT0ZGIENBQ0hFIEJPT0wgIldoZXRoZXIgdG8g ZW5hYmxlIHN1cHBvcnQgZm9yIHRoZSBXYXlsYW5kIHdpbmRvd2luZyB0YXJnZXQuIikKLXNldChF TkFCTEVfSU5UUk9TUEVDVElPTiBPTiBDQUNIRSBCT09MICJXaGV0aGVyIHRvIGVuYWJsZSBHT2Jq ZWN0IGludHJvc3BlY3Rpb24uIikKLQogIyBUaGVzZSBhcmUgc2hhcmVkIHZhcmlhYmxlcywgYnV0 IHdlIHNwZWNpYWwgY2FzZSB0aGVpciBkZWZpbml0aW9uIHNvIHRoYXQgd2UgY2FuIHVzZSB0aGUK ICMgQ01BS0VfSU5TVEFMTF8qIHZhcmlhYmxlcyB0aGF0IGFyZSBwb3B1bGF0ZWQgYnkgdGhlIEdO VUluc3RhbGxEaXJzIG1hY3JvLgogc2V0KExJQl9JTlNUQUxMX0RJUiAiJHtDTUFLRV9JTlNUQUxM X0ZVTExfTElCRElSfSIgQ0FDSEUgUEFUSCAiQWJzb2x1dGUgcGF0aCB0byBsaWJyYXJ5IGluc3Rh bGxhdGlvbiBkaXJlY3RvcnkiKQpAQCAtNTYsMjIgKzUxLDE1IEBAIGlmIChOT1QgR0VPQ0xVRTJf Rk9VTkQpCiAgICAgZmluZF9wYWNrYWdlKEdlb0NsdWUpCiBlbmRpZiAoKQogCi1pZiAoRU5BQkxF X1gxMV9UQVJHRVQpCi0gICAgIyBXaXRoIGNtYWtlIDMuMi54IHdlIGhhdmUgdG8gZXhwbGljaXRs eSBhc2sgZm9yIFgxMSBvdGhlcndpc2UgdGhlIFgxMV9YMTFfTElCCi0gICAgIyB2YXJpYWJsZSB3 b24ndCBiZSBzZXQgdGh1cyB0aGUgWDExIGxpbmtlciBmbGFncyB3b24ndCBiZSBhZGRlZCBhbmQg dGhlIGJ1aWxkCi0gICAgIyB3aWxsIGZhaWwuCi0gICAgZmluZF9wYWNrYWdlKFgxMSBSRVFVSVJF RCkKLWVuZGlmICgpCi0KLWlmIChFTkFCTEVfV0FZTEFORF9UQVJHRVQpCi0gICAgZmluZF9wYWNr YWdlKFdheWxhbmQgUkVRVUlSRUQpCi1lbmRpZiAoKQotCiBXRUJLSVRfT1BUSU9OX0JFR0lOKCkK IAogV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0dMRVMyICJXaGV0aGVyIHRvIGVuYWJsZSBP cGVuR0wgRVMgMi4wLiIgUFVCTElDIE9GRikKK1dFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9H VEtET0MgIldoZXRoZXIgb3Igbm90IHRvIHVzZSBnZW5lcmF0ZSBndGtkb2MuIiBQVUJMSUMgT0ZG KQorV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0lOVFJPU1BFQ1RJT04gIldoZXRoZXIgdG8g ZW5hYmxlIEdPYmplY3QgaW50cm9zcGVjdGlvbi4iIFBVQkxJQyBPTikKIFdFQktJVF9PUFRJT05f REVGSU5FKEVOQUJMRV9PUEVOR0wgIldoZXRoZXIgdG8gdXNlIE9wZW5HTC4iIFBVQkxJQyBPTikK IFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9QTFVHSU5fUFJPQ0VTU19HVEsyICJXaGV0aGVy IHRvIGJ1aWxkIFdlYktpdFBsdWdpblByb2Nlc3MyIHRvIGxvYWQgR1RLMiBiYXNlZCBwbHVnaW5z LiIgUFVCTElDIE9OKQorV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1gxMV9UQVJHRVQgIldo ZXRoZXIgdG8gZW5hYmxlIHN1cHBvcnQgZm9yIHRoZSBYMTEgd2luZG93aW5nIHRhcmdldC4iIFBV QkxJQyBPTikKK1dFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9XQVlMQU5EX1RBUkdFVCAiV2hl dGhlciB0byBlbmFibGUgc3VwcG9ydCBmb3IgdGhlIFdheWxhbmQgd2luZG93aW5nIHRhcmdldC4i IFBVQkxJQyBPRkYpCiAKIFdFQktJVF9PUFRJT05fREVGSU5FKFVTRV9HU1RSRUFNRVJfR0wgIldo ZXRoZXIgdG8gZW5hYmxlIHN1cHBvcnQgZm9yIEdTdHJlYW1lciBHTCIgUFJJVkFURSBPRkYpCiBX RUJLSVRfT1BUSU9OX0RFRklORShVU0VfUkVESVJFQ1RFRF9YQ09NUE9TSVRFX1dJTkRPVyAiV2hl dGhlciB0byB1c2UgYSBSZWRpcmVjdGVkIFhDb21wb3NpdGUgV2luZG93IGZvciBhY2NlbGVyYXRl ZCBjb21wb3NpdGluZyBpbiBYMTEuIiBQUklWQVRFIE9OKQpAQCAtNzksNiArNjcsOSBAQCBXRUJL SVRfT1BUSU9OX0RFRklORShVU0VfUkVESVJFQ1RFRF9YQ09NUE9TSVRFX1dJTkRPVyAiV2hldGhl ciB0byB1c2UgYSBSZWRpcmVjdAogIyBGSVhNRTogQ2FuIHdlIHVzZSBjYWlyby1nbGVzdjIgdG8g YXZvaWQgdGhpcyBjb25mbGljdD8KIFdFQktJVF9PUFRJT05fQ09ORkxJQ1QoRU5BQkxFX0FDQ0VM RVJBVEVEXzJEX0NBTlZBUyBFTkFCTEVfR0xFUzIpCiAKKyMgRklYTUU6IFNob3VsZCBiZSBwb3Nz aWJsZSB0byBidWlsZCB3aXRoIHN1cHBvcnQgZm9yIGJvdGggWDExIGFuZCBXYXlsYW5kLgorV0VC S0lUX09QVElPTl9DT05GTElDVChFTkFCTEVfV0FZTEFORF9UQVJHRVQgRU5BQkxFX1gxMV9UQVJH RVQpCisKIFdFQktJVF9PUFRJT05fREVQRU5EKEVOQUJMRV8zRF9UUkFOU0ZPUk1TIEVOQUJMRV9P UEVOR0wpCiBXRUJLSVRfT1BUSU9OX0RFUEVORChFTkFCTEVfQUNDRUxFUkFURURfMkRfQ0FOVkFT IEVOQUJMRV9PUEVOR0wpCiBXRUJLSVRfT1BUSU9OX0RFUEVORChFTkFCTEVfR0xFUzIgRU5BQkxF X09QRU5HTCkKQEAgLTE0OSw4ICsxNDAsNiBAQCBlbmRpZiAoKQogIyBFR0wgaXMgbm90LCBhbmQg RU5BQkxFX1gxMV9UQVJHRVQgaXMgT0ZGLCB0aGlzIGd1ZXNzIGlzIHdyb25nIGFuZCB0aGUgdXNl ciBtdXN0IG92ZXJyaWRlIGl0LiBXZQogIyBjYW4ndCBjaGVjayBFTkFCTEVfWDExX1RBUkdFVCBh dCB0aGlzIHBvaW50IGJlY2F1c2Ugd2UgZG9uJ3Qga25vdyB3aGV0aGVyIGl0J3MgZW5hYmxlZCB1 bnRpbAogIyBXRUJLSVRfT1BUSU9OX0VORCBoYXMgYmVlbiBjYWxsZWQsIGFuZCBhdCB0aGF0IHBv aW50IGl0J3MgdG9vIGxhdGUgdG8gY2hhbmdlIGRlZmF1bHQgdmFsdWVzLgotIwotIyBGSVhNRSBU aGUgYWJvdmUgaXMgbm90IHF1aXRlIHRydWUgeWV0IGJlY2F1c2UgRU5BQkxFX1gxMV9UQVJHRVQg aXMgbm90IHlldCBhbiBvcHRpb24sIGJ1ZyAjMTQ0MTA2LgogV0VCS0lUX09QVElPTl9ERUZBVUxU X1BPUlRfVkFMVUUoRU5BQkxFX0FDQ0VMRVJBVEVEXzJEX0NBTlZBUyBQVUJMSUMgJHtDQUlST19H TF9GT1VORH0pCiAKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9DUkVE RU5USUFMX1NUT1JBR0UgUFVCTElDIE9OKQpAQCAtMjU3LDYgKzI0NiwxNCBAQCBhZGRfZGVmaW5p dGlvbnMoLURVU0VSX0FHRU5UX0dUS19NQUpPUl9WRVJTSU9OPTYwMSkKIGFkZF9kZWZpbml0aW9u cygtRFVTRVJfQUdFTlRfR1RLX01JTk9SX1ZFUlNJT049MSkKIGFkZF9kZWZpbml0aW9ucygtRFdF QktJVEdUS19BUElfVkVSU0lPTl9TVFJJTkc9IiR7V0VCS0lUR1RLX0FQSV9WRVJTSU9OfSIpCiAK K2lmIChFTkFCTEVfWDExX1RBUkdFVCkKKyAgICBmaW5kX3BhY2thZ2UoWDExIFJFUVVJUkVEKQor ZW5kaWYgKCkKKworaWYgKEVOQUJMRV9XQVlMQU5EX1RBUkdFVCkKKyAgICBmaW5kX3BhY2thZ2Uo V2F5bGFuZCBSRVFVSVJFRCkKK2VuZGlmICgpCisKIGlmIChFTkFCTEVfT1BFTkdMKQogICAgICMg RU5BQkxFX09QRU5HTCBpcyB0cnVlIGlmIGVpdGhlciBXVEZfVVNFX09QRU5HTCBvciBFTkFCTEVf R0xFUzIgaXMgdHJ1ZS4KICAgICAjIEJ1dCBXVEZfVVNFX09QRU5HTCBpcyB0aGUgb3Bwb3NpdGUg b2YgRU5BQkxFX0dMRVMyLgpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4 IGVmZTU0YmFjMjhhYTgxMDY0MGE2M2ZkZmYzNDIyZGM1MzMxOGRmZjcuLjgwMzZiMmEwYzdjMzA3 NzkxZWQyOGRiOWM3ZWI1YmViZDVhOTc0ZTkgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNS0wNC0yOCAgTWljaGFlbCBDYXRhbnphcm8g IDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gTWFrZSBhbGwgb3B0aW9u cyBhY3R1YWxseSBvcHRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDQxMDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBVc2UgV0VCS0lUX09QVElPTl9ERUZJTkUgdG8gc2V0IEVOQUJMRV9HVEtET0Ms IEVOQUJMRV9JTlRST1NQRUNUSU9OLCBFTkFCTEVfWDExX1RBUkdFVCwgYW5kCisgICAgICAgIEVO QUJMRV9XQVlMQU5EX1RBUkdFVC4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlOgorCiAyMDE1LTA0LTI4ICBNaWNoYWVsIENhdGFuemFybyA8bWNhdGFuemFyb0BpZ2Fs aWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGZpeCBHVEsgYnVpbGQgYWZ0ZXIgcjE4MzQ1 Mgo=