144102 2015-04-23 09:26:03 -0700 [GTK] Fixups for ENABLE_CREDENTIAL_STORAGE 2015-04-23 10:30:46 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro commit-queue mcatanzaro oldest_to_newest 1087850 0 mcatanzaro 2015-04-23 09:26:03 -0700 ENABLE_CREDENTIAL_STORAGE became a WebKit option in r182996 so we shouldn't set it manually anymore. Also, if ENABLE_CREDENTIAL_STORAGE is set but libsecret is not present, the build needs to fail. (We can consider giving it a nicer error message in bug #143546.) 1087851 1 251447 mcatanzaro 2015-04-23 09:28:49 -0700 Created attachment 251447 Patch 1087873 2 251447 commit-queue 2015-04-23 10:30:43 -0700 Comment on attachment 251447 Patch Clearing flags on attachment: 251447 Committed r183192: <http://trac.webkit.org/changeset/183192> 1087874 3 commit-queue 2015-04-23 10:30:46 -0700 All reviewed patches have been landed. Closing bug. 251447 2015-04-23 09:28:49 -0700 2015-04-23 10:30:43 -0700 Patch bug-144102-20150423112745.patch text/plain 2453 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzMTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IDQ5NzQ3 ZmViNjc4ZTI0Y2VjMTMwMzMwYTQwN2M5OWJjODg4ZDhlNzkuLmI2NjQ4MTNjM2JjMTA0ZTVhYTcx ODI4MmVhZmEzZDE1MzA4ODgxMWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0xMSw3ICsxMSw2 IEBAIHNldChXRUJLSVRHVEtfQVBJX1ZFUlNJT04gNC4wKQogQ0FMQ1VMQVRFX0xJQlJBUllfVkVS U0lPTlNfRlJPTV9MSUJUT09MX1RSSVBMRShXRUJLSVQyIDQyIDAgNSkKIENBTENVTEFURV9MSUJS QVJZX1ZFUlNJT05TX0ZST01fTElCVE9PTF9UUklQTEUoSkFWQVNDUklQVENPUkUgMTkgMyAxKQog Ci1zZXQoRU5BQkxFX0NSRURFTlRJQUxfU1RPUkFHRSBPTiBDQUNIRSBCT09MICJXaGV0aGVyIG9y IG5vdCB0byBlbmFibGUgc3VwcG9ydCBmb3IgY3JlZGVudGlhbCBzdG9yYWdlIHVzaW5nIGxpYnNl Y3JldC4iKQogc2V0KEVOQUJMRV9HVEtET0MgT0ZGIENBQ0hFIEJPT0wgIldoZXRoZXIgb3Igbm90 IHRvIHVzZSBnZW5lcmF0ZSBndGtkb2MuIikKIHNldChFTkFCTEVfWDExX1RBUkdFVCBPTiBDQUNI RSBCT09MICJXaGV0aGVyIHRvIGVuYWJsZSBzdXBwb3J0IGZvciB0aGUgWDExIHdpbmRvd2luZyB0 YXJnZXQuIikKIHNldChFTkFCTEVfV0FZTEFORF9UQVJHRVQgT0ZGIENBQ0hFIEJPT0wgIldoZXRo ZXIgdG8gZW5hYmxlIHN1cHBvcnQgZm9yIHRoZSBXYXlsYW5kIHdpbmRvd2luZyB0YXJnZXQuIikK QEAgLTE1Nyw2ICsxNTYsNyBAQCBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFC TEVfQUNDRVNTSUJJTElUWSBQVUJMSUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9W QUxVRShFTkFCTEVfQVRUQUNITUVOVF9FTEVNRU5UIFBVQkxJQyBPRkYpCiBXRUJLSVRfT1BUSU9O X0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfQkFUVEVSWV9TVEFUVVMgUFVCTElDIE9GRikKIFdF QktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9DQU5WQVNfUEFUSCBQVUJMSUMg T0ZGKQorV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0NSRURFTlRJQUxf U1RPUkFHRSBQVUJMSUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFC TEVfQ1NTM19URVhUIFBVQkxJQyBPRkYpCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxV RShFTkFCTEVfQ1NTX0RFVklDRV9BREFQVEFUSU9OIFBVQkxJQyBPRkYpCiBXRUJLSVRfT1BUSU9O X0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfQ1NTX0dSSURfTEFZT1VUIFBVQkxJQyBPRkYpCkBA IC0zMjQsOCArMzI0LDcgQEAgaWYgKEdUS19VTklYX1BSSU5UX0ZPVU5EKQogZW5kaWYgKCkKIAog aWYgKEVOQUJMRV9DUkVERU5USUFMX1NUT1JBR0UpCi0gICAgZmluZF9wYWNrYWdlKExpYnNlY3Jl dCkKLSAgICBzZXQoRU5BQkxFX0NSRURFTlRJQUxfU1RPUkFHRSAxKQorICAgIGZpbmRfcGFja2Fn ZShMaWJzZWNyZXQgUkVRVUlSRUQpCiBlbmRpZiAoKQogCiBpZiAoR1RLX1NVUFBPUlRTX0dFU1RV UkVTKQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IGJlNzJkZjg0MDM2 ZjYzMWI5NWVkMjg3MjMxMDRhNDAyZGNhNmFjYzEuLjU3ZmFhYTkyNjRjMGM1NzMwYjJhMjYxNWYx ZjNjYjQwMDRlY2ViMjAgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAxNS0wNC0yMyAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJv QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gRml4dXBzIGZvciBFTkFCTEVfQ1JFREVOVElB TF9TVE9SQUdFCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDQxMDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBVc2UgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUgdG8gc2V0IEVOQUJMRV9DUkVE RU5USUFMX1NUT1JBR0UgaW5zdGVhZCBvZiBkb2luZyBzbworICAgICAgICBtYW51YWxseS4gRmFp bCB0aGUgYnVpbGQgaWYgbGlic2VjcmV0IGlzIG5vdCBmb3VuZCBidXQgRU5BQkxFX0NSRURFTlRJ QUxfU1RPUkFHRSBpcyBzZXQuCisgICAgICAgIEFsc28sIGRvIG5vdCBzZXQgRU5BQkxFX0NSRURF TlRJQUxfU1RPUkFHRSByZWR1bmRhbnRseS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRp b25zR1RLLmNtYWtlOgorCiAyMDE1LTA0LTIyICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnph cm9AaWdhbGlhLmNvbT4KIAogICAgICAgICBbQ01ha2VdIENsZWFuIHVwIEpTQyBKSVQgb3B0aW9u cwo=