144100 2015-04-23 08:53:59 -0700 [EFL] Build failure, linker does not find libXext. 2015-05-20 03:12:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 scimmia22 hyungwook.lee commit-queue gyuyoung.kim hyungwook.lee scimmia22 oldest_to_newest 1087834 0 scimmia22 2015-04-23 08:53:59 -0700 Currently the build process fails for me in Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp because of the call to XSetExtensionErrorHandler. The problem is in Source/WebKit2/PlatformEfl.cmake, currently lines 342-350: if (ENABLE_ECORE_X) list(APPEND WebProcess_LIBRARIES ${ECORE_X_LIBRARIES} ${X11_Xext_LIB} ) list(APPEND WebKit2_LIBRARIES ${ECORE_X_LIBRARIES} ) endif () The Xext libraries get added to WebProcess_LIBRARIES, but the source file is in WebKit2_SOURCES (line 212). Either WebProcessMainEfl needs to be in WebProcess_SOURCES or the Xext libraries need to be added to WebKit2_LIBRARIES. 1096156 1 253424 hyungwook.lee 2015-05-19 21:28:21 -0700 Created attachment 253424 patch 1096157 2 gyuyoung.kim 2015-05-19 21:33:42 -0700 One question, I wonder if we need to keep ${X11_Xext_LIB} in WebProcess_LIBRARIES. if (ENABLE_ECORE_X) list(APPEND WebProcess_LIBRARIES ${ECORE_X_LIBRARIES} ${X11_Xext_LIB} endif () 1096171 3 hyungwook.lee 2015-05-19 22:06:57 -0700 WebProcessMainEfl.cpp is listed in WebKit2_SOURCES. So I think we need to put X11_Xext_LIB into WebKit2_LIBRARIES to fix "undefined reference to 'XSetExtensionErrorHandler'" linking error. We need to move WebProcessMainEfl.cpp from WebKit2_SOURCES list to WebProcess_SOURCES list if we want to keep X11_Xext_LIB in WebProcess_LIBRARIES. I think to keep WebProcessMainEfl.cpp in WebKit2_SOURCES list is looks better. 1096177 4 gyuyoung.kim 2015-05-19 22:32:49 -0700 (In reply to comment #3) > I think to keep WebProcessMainEfl.cpp in WebKit2_SOURCES list is looks > better. I agree with it. As you know, *WebKit2_SOURCES* was originated only for WebProcess executable file as our MiniBrowser executable. So when WebProcessMainEfl.cpp is only used for WebProcess executable, I also think we can move it to WebProcess_SOURCES. If we don't need to keep to ${X11_Xext_LIB} in WebProcess_LIBRARIES anymore, let's remove it there. Do you agree ? if (ENABLE_ECORE_X) list(APPEND WebProcess_LIBRARIES ${ECORE_X_LIBRARIES} ${X11_Xext_LIB} endif () 1096178 5 gyuyoung.kim 2015-05-19 22:38:39 -0700 (In reply to comment #4) > (In reply to comment #3) > > > I think to keep WebProcessMainEfl.cpp in WebKit2_SOURCES list is looks > > better. > > I agree with it. As you know, *WebKit2_SOURCES* was originated only for > WebProcess executable file as our MiniBrowser executable. s/WebKit2_SOURCES/WebProcess_SOURCES/g 1096213 6 253435 hyungwook.lee 2015-05-20 02:18:32 -0700 Created attachment 253435 Patch 1096214 7 253435 gyuyoung.kim 2015-05-20 02:21:58 -0700 Comment on attachment 253435 Patch Thanks Hyungwook ! 1096217 8 253435 commit-queue 2015-05-20 03:12:15 -0700 Comment on attachment 253435 Patch Clearing flags on attachment: 253435 Committed r184632: <http://trac.webkit.org/changeset/184632> 1096218 9 commit-queue 2015-05-20 03:12:20 -0700 All reviewed patches have been landed. Closing bug. 253424 2015-05-19 21:28:21 -0700 2015-05-20 02:18:27 -0700 patch patch text/plain 1002 hyungwook.lee SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NDYxMCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA1LTE5ICBIeXVuZ3dv b2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtFRkxdIEZp eCBidWlsZCBmYWlsdXJlLCBsaW5rZXIgZG9lcyBub3QgZmluZCBsaWJYZXh0LgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0MTAwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXBwZW5kIFhleHQgbGlicmFy eSBpbnRvIFdlYktpdDJfTElCUkFSSUVTIGxpc3QuCisKKyAgICAgICAgKiBQbGF0Zm9ybUVmbC5j bWFrZToKKwogMjAxNS0wNS0xOSAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4K IAogICAgICAgICBSRUdSRVNTSU9OKDE4Mzc4Nyk6IEpJVCBpcyBlbmFibGVkIGZvciBhbGwgYnVp bGRzCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUVmbC5jbWFrZQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUVmbC5jbWFrZQkocmV2aXNpb24gMTg0NjA2KQorKysg U291cmNlL1dlYktpdDIvUGxhdGZvcm1FZmwuY21ha2UJKHdvcmtpbmcgY29weSkKQEAgLTM0OSw2 ICszNDksNyBAQCBpZiAoRU5BQkxFX0VDT1JFX1gpCiAgICAgKQogICAgIGxpc3QoQVBQRU5EIFdl YktpdDJfTElCUkFSSUVTCiAgICAgICAgICR7RUNPUkVfWF9MSUJSQVJJRVN9CisgICAgICAgICR7 WDExX1hleHRfTElCfQogICAgICkKIGVuZGlmICgpCiAK 253435 2015-05-20 02:18:32 -0700 2015-05-20 03:12:15 -0700 Patch bug-144100-20150520181828.patch text/plain 1171 hyungwook.lee SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NDYzMCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA1LTIwICBIeXVuZ3dv b2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtFRkxdIEZp eCBidWlsZCBmYWlsdXJlLCBsaW5rZXIgZG9lcyBub3QgZmluZCBsaWJYZXh0LgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0MTAwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW92ZSBYZXh0IGxpYnJhcnkg ZnJvbSBXZWJQcm9jZXNzX0xJQlJBUklFUyB0byBXZWJLaXQyX0xJQlJBUklFUy4KKworICAgICAg ICAqIFBsYXRmb3JtRWZsLmNtYWtlOgorCiAyMDE1LTA1LTE5ICBDYXJsb3MgR2FyY2lhIENhbXBv cyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbU09VUF0gTmV0d29yayBDYWNoZTog SW1wbGVtZW50IFNoYXJlYWJsZVJlc291cmNlIGZvciBTb3VwIGFuZCBlbmFibGUgaXQgZm9yIEdU SyBwbGF0Zm9ybQpJbmRleDogU291cmNlL1dlYktpdDIvUGxhdGZvcm1FZmwuY21ha2UKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdDIvUGxhdGZvcm1FZmwuY21ha2UJKHJldmlzaW9uIDE4NDYw NikKKysrIFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtRWZsLmNtYWtlCSh3b3JraW5nIGNvcHkpCkBA IC0zNDUsMTAgKzM0NSwxMCBAQCBlbmRpZiAoKQogaWYgKEVOQUJMRV9FQ09SRV9YKQogICAgIGxp c3QoQVBQRU5EIFdlYlByb2Nlc3NfTElCUkFSSUVTCiAgICAgICAgICR7RUNPUkVfWF9MSUJSQVJJ RVN9Ci0gICAgICAgICR7WDExX1hleHRfTElCfQogICAgICkKICAgICBsaXN0KEFQUEVORCBXZWJL aXQyX0xJQlJBUklFUwogICAgICAgICAke0VDT1JFX1hfTElCUkFSSUVTfQorICAgICAgICAke1gx MV9YZXh0X0xJQn0KICAgICApCiBlbmRpZiAoKQogCg==