144098 2015-04-23 06:33:19 -0700 Some media tests assert after r183096 2015-04-29 14:45:35 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson ap commit-queue esprehn+autocc kangil.han webkit-bug-importer oldest_to_newest 1087803 0 eric.carlson 2015-04-23 06:33:19 -0700 The assertion added to Document::removePlaybackTargetPickerClient in r183096 is too aggressive, it it not an error for it to be called more than once. 1087805 1 eric.carlson 2015-04-23 06:34:06 -0700 <rdar://problem/20661179> 1087807 2 251431 eric.carlson 2015-04-23 06:58:23 -0700 Created attachment 251431 Proposed patch. 1087819 3 251431 darin 2015-04-23 08:10:50 -0700 Comment on attachment 251431 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=251431&action=review > Source/WebCore/dom/Document.cpp:6553 > + const auto& it = m_clientToIDMap.find(&client); Best type to use here is probably auto rather than const auto&. Same thing below. > Source/WebCore/dom/Document.cpp:6559 > m_clientToIDMap.remove(&client); This should be remove(it), not remove(&client); passing &client results in a second hash table lookup. 1087839 4 eric.carlson 2015-04-23 09:00:23 -0700 Committed r183187 and r183187 - https://trac.webkit.org/r183185, https://trac.webkit.org/r183187 1087840 5 eric.carlson 2015-04-23 09:01:01 -0700 By which I meant r183185 and r183187 of course. 1090095 6 eric.carlson 2015-04-29 11:57:44 -0700 Reopened, test still occasionally crash. 1090104 7 251974 eric.carlson 2015-04-29 12:07:08 -0700 Created attachment 251974 Another patch. 1090148 8 251974 bfulgham 2015-04-29 13:52:19 -0700 Comment on attachment 251974 Another patch. r=me 1090161 9 251974 commit-queue 2015-04-29 14:45:29 -0700 Comment on attachment 251974 Another patch. Clearing flags on attachment: 251974 Committed r183578: <http://trac.webkit.org/changeset/183578> 1090162 10 commit-queue 2015-04-29 14:45:35 -0700 All reviewed patches have been landed. Closing bug. 251431 2015-04-23 06:58:23 -0700 2015-04-29 12:39:02 -0700 Proposed patch. remove_client_assert_patch.txt text/plain 5375 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MzE4NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE1LTA0LTIzICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFNvbWUgbWVkaWEgdGVz dHMgYXNzZXJ0IGFmdGVyIHIxODMwOTYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0NDA5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRv Y3VtZW50OjpyZW1vdmVQbGF5YmFja1RhcmdldFBpY2tlckNsaWVudCk6IERvbid0IGFzc2VydCBp ZiB0aGUgY2xpZW50IGhhcyBhbHJlYWR5CisgICAgICAgICAgICBiZWVuIHJlbW92ZWQgZnJvbSB0 aGUgbWFwLiBUaGlzIGhhcHBlbnMgd2hlbiBhIG1lZGlhIGVsZW1lbnQgaXMgcmVtb3ZlZCBmcm9t IHRoZSBkb2N1bWVudAorICAgICAgICAgICAgYmVmb3JlIGl0cyBkZXN0cnVjdG9yIHJ1bnMgYW5k IGlzIG5vdCBhbiBlcnJvci4KKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpzaG93UGxheWJh Y2tUYXJnZXRQaWNrZXIpOiBJdCBpcyBhbiBlcnJvciB0byBjYWxsIHRoaXMgYWZ0ZXIgdGhlIGNs aWVudCAKKyAgICAgICAgICAgIGhhcyBiZWVuIHJlbW92ZWQgZnJvbSB0aGUgbWFwIHNvIGxlYXZl IHRoZSBhc3NlcnQgaW4gYSBkZWJ1ZyBidWlsZCwgYnV0IHJldHVybiBlYXJseQorICAgICAgICAg ICAgc28gYSByZWxlYXNlIGJ1aWxkIGRvZXNuJ3QgY3Jhc2guCisgICAgICAgIChXZWJDb3JlOjpE b2N1bWVudDo6cGxheWJhY2tUYXJnZXRQaWNrZXJDbGllbnRTdGF0ZURpZENoYW5nZSk6IERpdHRv LgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnBsYXliYWNrVGFyZ2V0QXZhaWxhYmlsaXR5 RGlkQ2hhbmdlKTogVXNlICJhdXRvIiBmb3IgdGhlIG1hcCBpdGVyYXRvciB2YXJpYWJsZS4KKyAg ICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpzZXRQbGF5YmFja1RhcmdldCk6IERpdHRvLgorICAg ICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnNldFNob3VsZFBsYXlUb1BsYXliYWNrVGFyZ2V0KTog RGl0dG8uCisgICAgICAgICogZG9tL0RvY3VtZW50Lmg6IEZpeCB0aGUgbWFwIHR5cGVkZWYgbmFt ZXMuCisKIDIwMTUtMDQtMjMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAg ICAgICAgIERPTSBub2RlcyBzaG91bGQgYmUgYWxsb2NhdGVkIHdpdGggZmFzdE1hbGxvYygpLgpJ bmRleDogU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCShyZXZpc2lvbiAxODMxMDIpCisrKyBTb3VyY2Uv V2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NTUwLDE1ICs2NTUw LDE4IEBAIHZvaWQgRG9jdW1lbnQ6OmFkZFBsYXliYWNrVGFyZ2V0UGlja2VyQ2wKIAogdm9pZCBE b2N1bWVudDo6cmVtb3ZlUGxheWJhY2tUYXJnZXRQaWNrZXJDbGllbnQoTWVkaWFQbGF5YmFja1Rh cmdldENsaWVudCYgY2xpZW50KQogewotICAgIEFTU0VSVChtX2NsaWVudFRvSURNYXAuY29udGFp bnMoJmNsaWVudCkpOwotICAgIHVpbnQ2NF90IGNvbnRleHRJZCA9IG1fY2xpZW50VG9JRE1hcC5n ZXQoJmNsaWVudCk7Ci0gICAgbV9pZFRvQ2xpZW50TWFwLnJlbW92ZShjb250ZXh0SWQpOworICAg IGNvbnN0IGF1dG8mIGl0ID0gbV9jbGllbnRUb0lETWFwLmZpbmQoJmNsaWVudCk7CisgICAgaWYg KGl0ID09IG1fY2xpZW50VG9JRE1hcC5lbmQoKSkKKyAgICAgICAgcmV0dXJuOworCisgICAgdWlu dDY0X3QgY2xpZW50SWQgPSBpdC0+dmFsdWU7CisgICAgbV9pZFRvQ2xpZW50TWFwLnJlbW92ZShj bGllbnRJZCk7CiAgICAgbV9jbGllbnRUb0lETWFwLnJlbW92ZSgmY2xpZW50KTsKIAogICAgIFBh Z2UqIHBhZ2UgPSB0aGlzLT5wYWdlKCk7CiAgICAgaWYgKCFwYWdlKQogICAgICAgICByZXR1cm47 Ci0gICAgcGFnZS0+cmVtb3ZlUGxheWJhY2tUYXJnZXRQaWNrZXJDbGllbnQoY29udGV4dElkKTsK KyAgICBwYWdlLT5yZW1vdmVQbGF5YmFja1RhcmdldFBpY2tlckNsaWVudChjbGllbnRJZCk7CiB9 CiAKIHZvaWQgRG9jdW1lbnQ6OnNob3dQbGF5YmFja1RhcmdldFBpY2tlcihNZWRpYVBsYXliYWNr VGFyZ2V0Q2xpZW50JiBjbGllbnQsIGJvb2wgaXNWaWRlbykKQEAgLTY1NjcsOCArNjU3MCwxMiBA QCB2b2lkIERvY3VtZW50OjpzaG93UGxheWJhY2tUYXJnZXRQaWNrZXIoCiAgICAgaWYgKCFwYWdl KQogICAgICAgICByZXR1cm47CiAKLSAgICBBU1NFUlQobV9jbGllbnRUb0lETWFwLmNvbnRhaW5z KCZjbGllbnQpKTsKLSAgICBwYWdlLT5zaG93UGxheWJhY2tUYXJnZXRQaWNrZXIobV9jbGllbnRU b0lETWFwLmdldCgmY2xpZW50KSwgdmlldygpLT5sYXN0S25vd25Nb3VzZVBvc2l0aW9uKCksIGlz VmlkZW8pOworICAgIGNvbnN0IGF1dG8mIGl0ID0gbV9jbGllbnRUb0lETWFwLmZpbmQoJmNsaWVu dCk7CisgICAgQVNTRVJUKGl0ICE9IG1fY2xpZW50VG9JRE1hcC5lbmQoKSk7CisgICAgaWYgKGl0 ID09IG1fY2xpZW50VG9JRE1hcC5lbmQoKSkKKyAgICAgICAgcmV0dXJuOworCisgICAgcGFnZS0+ c2hvd1BsYXliYWNrVGFyZ2V0UGlja2VyKGl0LT52YWx1ZSwgdmlldygpLT5sYXN0S25vd25Nb3Vz ZVBvc2l0aW9uKCksIGlzVmlkZW8pOwogfQogCiB2b2lkIERvY3VtZW50OjpwbGF5YmFja1Rhcmdl dFBpY2tlckNsaWVudFN0YXRlRGlkQ2hhbmdlKE1lZGlhUGxheWJhY2tUYXJnZXRDbGllbnQmIGNs aWVudCwgTWVkaWFQcm9kdWNlcjo6TWVkaWFTdGF0ZUZsYWdzIHN0YXRlKQpAQCAtNjU3NywxMyAr NjU4NCwxNyBAQCB2b2lkIERvY3VtZW50OjpwbGF5YmFja1RhcmdldFBpY2tlckNsaWVuCiAgICAg aWYgKCFwYWdlKQogICAgICAgICByZXR1cm47CiAKLSAgICBBU1NFUlQobV9jbGllbnRUb0lETWFw LmNvbnRhaW5zKCZjbGllbnQpKTsKLSAgICBwYWdlLT5wbGF5YmFja1RhcmdldFBpY2tlckNsaWVu dFN0YXRlRGlkQ2hhbmdlKG1fY2xpZW50VG9JRE1hcC5nZXQoJmNsaWVudCksIHN0YXRlKTsKKyAg ICBjb25zdCBhdXRvJiBpdCA9IG1fY2xpZW50VG9JRE1hcC5maW5kKCZjbGllbnQpOworICAgIEFT U0VSVChpdCAhPSBtX2NsaWVudFRvSURNYXAuZW5kKCkpOworICAgIGlmIChpdCA9PSBtX2NsaWVu dFRvSURNYXAuZW5kKCkpCisgICAgICAgIHJldHVybjsKKworICAgIHBhZ2UtPnBsYXliYWNrVGFy Z2V0UGlja2VyQ2xpZW50U3RhdGVEaWRDaGFuZ2UoaXQtPnZhbHVlLCBzdGF0ZSk7CiB9CiAKIHZv aWQgRG9jdW1lbnQ6OnBsYXliYWNrVGFyZ2V0QXZhaWxhYmlsaXR5RGlkQ2hhbmdlKHVpbnQ2NF90 IGNsaWVudElkLCBib29sIGF2YWlsYWJsZSkKIHsKLSAgICBUYXJnZXRDbGllbnRUb0lkTWFwOjpp dGVyYXRvciBpdCA9IG1faWRUb0NsaWVudE1hcC5maW5kKGNsaWVudElkKTsKKyAgICBjb25zdCBh dXRvJiBpdCA9IG1faWRUb0NsaWVudE1hcC5maW5kKGNsaWVudElkKTsKICAgICBpZiAoaXQgPT0g bV9pZFRvQ2xpZW50TWFwLmVuZCgpKQogICAgICAgICByZXR1cm47CiAKQEAgLTY1OTIsNyArNjYw Myw3IEBAIHZvaWQgRG9jdW1lbnQ6OnBsYXliYWNrVGFyZ2V0QXZhaWxhYmlsaXQKIAogdm9pZCBE b2N1bWVudDo6c2V0UGxheWJhY2tUYXJnZXQodWludDY0X3QgY2xpZW50SWQsIFJlZjxNZWRpYVBs YXliYWNrVGFyZ2V0PiYmIHRhcmdldCkKIHsKLSAgICBUYXJnZXRDbGllbnRUb0lkTWFwOjppdGVy YXRvciBpdCA9IG1faWRUb0NsaWVudE1hcC5maW5kKGNsaWVudElkKTsKKyAgICBjb25zdCBhdXRv JiBpdCA9IG1faWRUb0NsaWVudE1hcC5maW5kKGNsaWVudElkKTsKICAgICBpZiAoaXQgPT0gbV9p ZFRvQ2xpZW50TWFwLmVuZCgpKQogICAgICAgICByZXR1cm47CiAKQEAgLTY2MDEsNyArNjYxMiw3 IEBAIHZvaWQgRG9jdW1lbnQ6OnNldFBsYXliYWNrVGFyZ2V0KHVpbnQ2NF8KIAogdm9pZCBEb2N1 bWVudDo6c2V0U2hvdWxkUGxheVRvUGxheWJhY2tUYXJnZXQodWludDY0X3QgY2xpZW50SWQsIGJv b2wgc2hvdWxkUGxheSkKIHsKLSAgICBUYXJnZXRDbGllbnRUb0lkTWFwOjppdGVyYXRvciBpdCA9 IG1faWRUb0NsaWVudE1hcC5maW5kKGNsaWVudElkKTsKKyAgICBjb25zdCBhdXRvJiBpdCA9IG1f aWRUb0NsaWVudE1hcC5maW5kKGNsaWVudElkKTsKICAgICBpZiAoaXQgPT0gbV9pZFRvQ2xpZW50 TWFwLmVuZCgpKQogICAgICAgICByZXR1cm47CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9E b2N1bWVudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCShy ZXZpc2lvbiAxODMxMDIpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaAkod29ya2lu ZyBjb3B5KQpAQCAtMTY4OSwxMCArMTY4OSwxMCBAQCBwcml2YXRlOgogICAgIE1lZGlhUHJvZHVj ZXI6Ok1lZGlhU3RhdGVGbGFncyBtX21lZGlhU3RhdGUgeyBNZWRpYVByb2R1Y2VyOjpJc05vdFBs YXlpbmcgfTsKIAogI2lmIEVOQUJMRShXSVJFTEVTU19QTEFZQkFDS19UQVJHRVQpCi0gICAgdHlw ZWRlZiBIYXNoTWFwPHVpbnQ2NF90LCBXZWJDb3JlOjpNZWRpYVBsYXliYWNrVGFyZ2V0Q2xpZW50 Kj4gVGFyZ2V0Q2xpZW50VG9JZE1hcDsKLSAgICBUYXJnZXRDbGllbnRUb0lkTWFwIG1faWRUb0Ns aWVudE1hcDsKLSAgICB0eXBlZGVmIEhhc2hNYXA8V2ViQ29yZTo6TWVkaWFQbGF5YmFja1Rhcmdl dENsaWVudCosIHVpbnQ2NF90PiBUYXJnZXRJZFRvQ2xpZW50TWFwOwotICAgIFRhcmdldElkVG9D bGllbnRNYXAgbV9jbGllbnRUb0lETWFwOworICAgIHR5cGVkZWYgSGFzaE1hcDx1aW50NjRfdCwg V2ViQ29yZTo6TWVkaWFQbGF5YmFja1RhcmdldENsaWVudCo+IFRhcmdldElkVG9DbGllbnRNYXA7 CisgICAgVGFyZ2V0SWRUb0NsaWVudE1hcCBtX2lkVG9DbGllbnRNYXA7CisgICAgdHlwZWRlZiBI YXNoTWFwPFdlYkNvcmU6Ok1lZGlhUGxheWJhY2tUYXJnZXRDbGllbnQqLCB1aW50NjRfdD4gVGFy Z2V0Q2xpZW50VG9JZE1hcDsKKyAgICBUYXJnZXRDbGllbnRUb0lkTWFwIG1fY2xpZW50VG9JRE1h cDsKICNlbmRpZgogfTsKIAo= 251974 2015-04-29 12:07:08 -0700 2015-04-29 14:45:29 -0700 Another patch. remove_asserts_patch.txt text/plain 1830 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MzU2MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA0LTI5ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFNvbWUgbWVkaWEgdGVz dHMgYXNzZXJ0IGFmdGVyIHIxODMwOTYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0NDA5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5ldmVyIGFzc2VydCB3aGVuIGEgTWVkaWFQbGF5YmFja1RhcmdldENs aWVudCBjbGllbnQgY2FsbHMgb25lIG9mIHRoZSBtZXRob2RzIG9uIERvY3VtZW50CisgICAgICAg IGFmdGVyIGl0IGhhcyBiZWVuIHVucmVnaXN0ZXJlZC4gQSBtZWRpYSBlbGVtZW50IHVucmVnaXN0 ZXJzIGl0c2VsZiB3aGVuIGl0IGlzIHJlbW92ZWQgZnJvbSB0aGUgCisgICAgICAgIGRvY3VtZW50 LCBidXQgc2NyaXB0cyBjYW4gc3RpbGwgcnVuIGFuZCBtb2RpZnkgc3RhdGUgdGhhdCByZXN1bHRz IGluIGEgY2FsbCB0bworICAgICAgICBwbGF5YmFja1RhcmdldFBpY2tlckNsaWVudFN0YXRlRGlk Q2hhbmdlLiBSZW1vdmUgdGhlIGFzc2VydHMgaW5zdGVhZCBvZiBhZGRpbmcgY2hlY2tzIHRvCisg ICAgICAgIHRoZSB2YXJpb3VzIGNhbGwgc2l0ZXMuCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnNob3dQbGF5YmFja1RhcmdldFBpY2tl cik6IERvbid0IGFzc2VydCBpZiB0aGUgY2xpZW50IGhhcyBhbHJlYWR5CisgICAgICAgIGJlZW4g dW5yZWdpc3RlcmVkLgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnBsYXliYWNrVGFyZ2V0 UGlja2VyQ2xpZW50U3RhdGVEaWRDaGFuZ2UpOiBEaXR0by4KKwogMjAxNS0wNC0yOSAgQW50dGkg S29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVzb3VyY2VMb2FkUHJpb3Jp dHkgc2hvdWxkIGJlIGVudW0gY2xhc3MKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVu dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAkocmV2 aXNpb24gMTgzNTU0KQorKysgU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNjU3MSw3ICs2NTcxLDYgQEAgdm9pZCBEb2N1bWVudDo6c2hvd1BsYXliYWNr VGFyZ2V0UGlja2VyKAogICAgICAgICByZXR1cm47CiAKICAgICBhdXRvIGl0ID0gbV9jbGllbnRU b0lETWFwLmZpbmQoJmNsaWVudCk7Ci0gICAgQVNTRVJUKGl0ICE9IG1fY2xpZW50VG9JRE1hcC5l bmQoKSk7CiAgICAgaWYgKGl0ID09IG1fY2xpZW50VG9JRE1hcC5lbmQoKSkKICAgICAgICAgcmV0 dXJuOwogCkBAIC02NTg1LDcgKzY1ODQsNiBAQCB2b2lkIERvY3VtZW50OjpwbGF5YmFja1Rhcmdl dFBpY2tlckNsaWVuCiAgICAgICAgIHJldHVybjsKIAogICAgIGF1dG8gaXQgPSBtX2NsaWVudFRv SURNYXAuZmluZCgmY2xpZW50KTsKLSAgICBBU1NFUlQoaXQgIT0gbV9jbGllbnRUb0lETWFwLmVu ZCgpKTsKICAgICBpZiAoaXQgPT0gbV9jbGllbnRUb0lETWFwLmVuZCgpKQogICAgICAgICByZXR1 cm47CiAK