144094 2015-04-23 03:37:42 -0700 [cmake] Fix generate-js-builtins related incremental build issue 2015-05-04 01:23:48 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=143980 P2 Normal --- 1 ossy ossy benjamin gyuyoung.kim ljharb msaboff oliver ossy oldest_to_newest 1087788 0 ossy 2015-04-23 03:37:42 -0700 See https://bugs.webkit.org/show_bug.cgi?id=143980#c14 for details. The root of the problem that cmake finds the input of generate-js-builtins with *.js search. But the make/ninja doesn't know when the input list should be regenerated and adding a new js can cause incremantal build fail. I think we should teach generate-js-builtins to accept not only js files as input, but an input directory where it can collects all of the js files and we will be able remove *.js from cmake build system. 1087789 1 251426 ossy 2015-04-23 03:52:28 -0700 Created attachment 251426 Patch 1087791 2 ossy 2015-04-23 04:03:10 -0700 cc-ed Oliver and Michael as the original author and reviewer of the generate-js-builtins script - http://trac.webkit.org/changeset/163195 I added the new --input-directory option to be able get rid of *.js from cmake and let the python script to collect js files. But I didn't remove the actual behaviour of the script, maybe somebody wants to generate builtins for a couple of js not for all js in a directory. Do you think if this change is acceptable to avoid incremental build issues in the future? 1089458 3 ossy 2015-04-28 03:53:56 -0700 ping? 1089591 4 251426 msaboff 2015-04-28 10:19:48 -0700 Comment on attachment 251426 Patch r=me 1091326 5 251426 ossy 2015-05-04 01:23:41 -0700 Comment on attachment 251426 Patch Clearing flags on attachment: 251426 Committed r183738: <http://trac.webkit.org/changeset/183738> 1091327 6 ossy 2015-05-04 01:23:48 -0700 All reviewed patches have been landed. Closing bug. 251426 2015-04-23 03:52:28 -0700 2015-05-04 01:23:41 -0700 Patch bug-144094-20150423035123.patch text/plain 4732 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzMTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz NGQxNDk0ZmQ1OTJmYTE0MWUzMzA2ODA1ZTZlMmI2ODQwYzRhNDM5Li40ZTgxNjJhNTgzN2IxN2Fk MDBlNzM5MjlkOTAxNTk2N2Q1ZjZkMWQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNS0wNC0yMyAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIFtjbWFrZV0gRml4IGdlbmVyYXRlLWpzLWJ1aWx0aW5zIHJlbGF0ZWQg aW5jcmVtZW50YWwgYnVpbGQgaXNzdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0NDA5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6IEdlbmVyYXRlZCBKU0NCdWlsdGlucy48 Y3BwfGg+IHNob3VsZCBkZXBlbmQgb24gU291cmNlL0phdmFTY3JpcHRDb3JlL2J1aWx0aW5zIGRp cmVjdG9yeS4KKyAgICAgICAgUGFzcyBpbnB1dCBkaXJlY3RvcnkgdG8gZ2VuZXJhdGUtanMtYnVp bHRpbnMgaW5zdGVhZCBvZiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvKi5qcy4KKyAg ICAgICAgKiBEZXJpdmVkU291cmNlcy5tYWtlOgorICAgICAgICBQYXNzIGlucHV0IGRpcmVjdG9y eSB0byBnZW5lcmF0ZS1qcy1idWlsdGlucyBpbnN0ZWFkIG9mIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9idWlsdGlucy8qLmpzLgorICAgICAgICAqIGdlbmVyYXRlLWpzLWJ1aWx0aW5zOiBBY2NlcHQg aW5wdXQgZmlsZXMgYW5kIGlucHV0IGRpcmVjdG9yeSB0b28uCisKIDIwMTUtMDQtMjIgIEZpbGlw IFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBmaXggZGVi dWcgYnVpbGQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50 eHQgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggNTNiYmQ2ZDc1 NGQ0MzExYTkxOTc5Yzk3Zjg5M2ZkMWE1MGI5M2FlZS4uMWUwMGU3MDM3OTg0N2IzN2M4MzNmNzEy NmE3OTUzODhmMmVmNjYwYSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtl TGlzdHMudHh0CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dApAQCAt MTEwNCwxMiArMTEwNCwxMSBAQCBhZGRfY3VzdG9tX2NvbW1hbmQoCiAgICAgVkVSQkFUSU0pCiAK ICMgSlNDQnVpbHRpbnMKLWZpbGUoR0xPQiBKU0NCdWlsdGluc19qc19maWxlcyAiJHtDTUFLRV9D VVJSRU5UX1NPVVJDRV9ESVJ9L2J1aWx0aW5zLyouanMiKQogYWRkX2N1c3RvbV9jb21tYW5kKAog ICAgT1VUUFVUICR7REVSSVZFRF9TT1VSQ0VTX0pBVkFTQ1JJUFRDT1JFX0RJUn0vSlNDQnVpbHRp bnMuY3BwICR7REVSSVZFRF9TT1VSQ0VTX0pBVkFTQ1JJUFRDT1JFX0RJUn0vSlNDQnVpbHRpbnMu aAogICAgTUFJTl9ERVBFTkRFTkNZICR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS9nZW5lcmF0 ZS1qcy1idWlsdGlucwotICAgREVQRU5EUyAke0pTQ0J1aWx0aW5zX2pzX2ZpbGVzfQotICAgQ09N TUFORCAke1BZVEhPTl9FWEVDVVRBQkxFfSAke0NNQUtFX0NVUlJFTlRfU09VUkNFX0RJUn0vZ2Vu ZXJhdGUtanMtYnVpbHRpbnMgJHtKU0NCdWlsdGluc19qc19maWxlc30gJHtERVJJVkVEX1NPVVJD RVNfSkFWQVNDUklQVENPUkVfRElSfS9KU0NCdWlsdGlucy5oICR7REVSSVZFRF9TT1VSQ0VTX0pB VkFTQ1JJUFRDT1JFX0RJUn0vSlNDQnVpbHRpbnMuY3BwCisgICBERVBFTkRTICR7Q01BS0VfQ1VS UkVOVF9TT1VSQ0VfRElSfS9idWlsdGlucworICAgQ09NTUFORCAke1BZVEhPTl9FWEVDVVRBQkxF fSAke0NNQUtFX0NVUlJFTlRfU09VUkNFX0RJUn0vZ2VuZXJhdGUtanMtYnVpbHRpbnMgLS1pbnB1 dC1kaXJlY3RvcnkgJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L2J1aWx0aW5zIC0tb3V0cHV0 ICR7REVSSVZFRF9TT1VSQ0VTX0pBVkFTQ1JJUFRDT1JFX0RJUn0vSlNDQnVpbHRpbnMuY3BwCiAg ICBWRVJCQVRJTSkKIAogbGlzdChBUFBFTkQgSmF2YVNjcmlwdENvcmVfU09VUkNFUwpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0Rlcml2ZWRTb3VyY2VzLm1ha2UgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvRGVyaXZlZFNvdXJjZXMubWFrZQppbmRleCAxODVkYzdlMzFkMDdjZDhk NzQzOTY4MGYxNzI5ZTc2MWRmMzIyZGVjLi5iOGJjMjVjN2JiZGY1NzhlZTRiZGU2MDUwZGM5YjE1 YzEzOWQ2NTI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvRGVyaXZlZFNvdXJj ZXMubWFrZQorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvRGVyaXZlZFNvdXJjZXMubWFrZQpA QCAtODAsOCArODAsOCBAQCBlbmRpZgogIyAtLS0tLS0tLQogCiBKU0NCdWlsdGluczogJChKYXZh U2NyaXB0Q29yZSkvZ2VuZXJhdGUtanMtYnVpbHRpbnMgSlNDQnVpbHRpbnMuaCBKU0NCdWlsdGlu cy5jcHAKLUpTQ0J1aWx0aW5zLmg6ICQoSmF2YVNjcmlwdENvcmUpL2dlbmVyYXRlLWpzLWJ1aWx0 aW5zICQoSmF2YVNjcmlwdENvcmUpL2J1aWx0aW5zLyouanMKLQkkKFBZVEhPTikgJF4gJEAKK0pT Q0J1aWx0aW5zLmg6ICQoSmF2YVNjcmlwdENvcmUpL2dlbmVyYXRlLWpzLWJ1aWx0aW5zICQoSmF2 YVNjcmlwdENvcmUpL2J1aWx0aW5zCisJJChQWVRIT04pICQoSmF2YVNjcmlwdENvcmUpL2dlbmVy YXRlLWpzLWJ1aWx0aW5zIC0taW5wdXQtZGlyZWN0b3J5ICQoSmF2YVNjcmlwdENvcmUpL2J1aWx0 aW5zIC0tb3V0cHV0ICRACiAJCQkJCQkJCQkJCQkJCQkJCQkJCSAKIEpTQ0J1aWx0aW5zLmNwcDog SlNDQnVpbHRpbnMuaAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZ2VuZXJh dGUtanMtYnVpbHRpbnMgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZ2VuZXJhdGUtanMtYnVpbHRp bnMKaW5kZXggN2Y5ZWJhNjg1MjQyNDg1ODIzYTRlNzcyZmZiYzBhYzY3ZjVkZDljNi4uYjZhZWM0 NzQwODNiN2E4YmE5NTYwMDAwNTk4MzMyYzU4N2Y2ZjBjYyAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2dlbmVyYXRlLWpzLWJ1aWx0aW5zCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9nZW5lcmF0ZS1qcy1idWlsdGlucwpAQCAtMjIsNiArMjIsNyBAQAogIyAoSU5DTFVESU5H IE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBV U0UKICMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElU WSBPRiBTVUNIIERBTUFHRS4KIAoraW1wb3J0IGFyZ3BhcnNlCiBpbXBvcnQgZmlsZWNtcAogaW1w b3J0IGZubWF0Y2gKIGltcG9ydCBvcwpAQCAtMzEsNiArMzIsMTIgQEAgaW1wb3J0IHN5cwogaW1w b3J0IGRhdGV0aW1lCiBpbXBvcnQganNvbgogCitwYXJzZXIgPSBhcmdwYXJzZS5Bcmd1bWVudFBh cnNlcigpCitwYXJzZXIuYWRkX2FyZ3VtZW50KCdpbnB1dF9maWxlJywgbmFyZ3M9JyonLCBoZWxw PSdJbnB1dCBKUyBmaWxlcyB3aGljaCBidWlsdGlucyBnZW5lcmF0ZWQgZnJvbScpCitwYXJzZXIu YWRkX2FyZ3VtZW50KCctLWlucHV0LWRpcmVjdG9yeScsIGhlbHA9J0FsbCBKUyBmaWxlcyB3aWxs IGJlIHVzZWQgYXMgaW5wdXQgZnJvbSB0aGlzIGRpcmVjdG9yeS4nKQorcGFyc2VyLmFkZF9hcmd1 bWVudCgnLS1vdXRwdXQnLCBoZWxwPSdwYXRoIHRvIG91dHB1dCBjcHAgb3IgaCBmaWxlJykKK2Fy Z3MgPSBwYXJzZXIucGFyc2VfYXJncygpCisKIGNvcHlyaWdodFRleHQgPSAiIiIgKgogICogUmVk aXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3 aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUg Zm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTE1MSwxMyArMTU4LDE0IEBAIGRlZiBtYW5nbGVOYW1l KG9iamVjdCwgbmFtZSk6CiAgICAgcmV0dXJuIG1hbmdsZWROYW1lCiAKIGJ1aWx0aW5zID0gW10K K2NvcHlyaWdodHMgPSBbXQorKG91dHB1dF9iYXNlLCBfKSA9IG9zLnBhdGguc3BsaXRleHQoYXJn cy5vdXRwdXQpCiAKLWJhc2VOYW1lID0gc3lzLmFyZ3ZbLTFdCi1idWlsdGluX2RlZmluaXRpb25z ID0gc3lzLmFyZ3ZbMTotMV0KLShvdXRwdXRfYmFzZSwgXykgPSBvcy5wYXRoLnNwbGl0ZXh0KHN5 cy5hcmd2Wy0xXSkKK2lmIGFyZ3MuaW5wdXRfZGlyZWN0b3J5OgorICAgIGZvciBmaWxlIGluIG9z Lmxpc3RkaXIoYXJncy5pbnB1dF9kaXJlY3RvcnkpOgorICAgICAgICBhcmdzLmlucHV0X2ZpbGUu YXBwZW5kKG9zLnBhdGguam9pbihhcmdzLmlucHV0X2RpcmVjdG9yeSwgZmlsZSkpCiAKLWNvcHly aWdodHMgPSBbXQotZm9yIGZpbGUgaW4gYnVpbHRpbl9kZWZpbml0aW9uczoKK2ZvciBmaWxlIGlu IGFyZ3MuaW5wdXRfZmlsZToKICAgICBpZiBmbm1hdGNoLmZubWF0Y2goZmlsZSwgJyouanMnKToK ICAgICAgICAgKGJhc2VOYW1lLCBmdW5jdGlvbnMsIG9iamVjdENvcHlyaWdodHMpID0gZ2VuZXJh dGVDb2RlKGZpbGUpCiAgICAgICAgIGNvcHlyaWdodHMuZXh0ZW5kKG9iamVjdENvcHlyaWdodHMp Cg==