144089 2015-04-22 22:36:15 -0700 [WK2] WebDiagnosticLoggingClient is leaking 2015-04-23 01:13:45 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez andersca barraclough commit-queue japhet kling sam oldest_to_newest 1087737 0 cdumez 2015-04-22 22:36:15 -0700 WebDiagnosticLoggingClient is leaking. It is constructed inside the WebPage constructor but there is no code destroying it. We should add a new xxxDestroyed() virtual function that calls "delete this" in WebDiagnosticLoggingClient, similarly to what is done for other WK2 clients. Radar: <rdar://problem/19706214> 1087745 1 251410 cdumez 2015-04-22 23:18:15 -0700 Created attachment 251410 Patch 1087767 2 251410 commit-queue 2015-04-23 01:13:40 -0700 Comment on attachment 251410 Patch Clearing flags on attachment: 251410 Committed r183179: <http://trac.webkit.org/changeset/183179> 1087768 3 commit-queue 2015-04-23 01:13:45 -0700 All reviewed patches have been landed. Closing bug. 251410 2015-04-22 23:18:15 -0700 2015-04-23 01:13:40 -0700 Patch bug-144089-20150422231715.patch text/plain 6188 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzMTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTM2NzI3NzJjMzg5OTYx YTJkMTUzNDZmNmYyZTVmYTY5NWNlZGQ5MS4uZWQ0ZTIwYmU0OTJlNTMyYmY1MWVhODRhYmE1Mzhk MWRhNzZlNDNiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE1LTA0LTIyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW1dLMl0gV2ViRGlhZ25vc3Rp Y0xvZ2dpbmdDbGllbnQgaXMgbGVha2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0MDg5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xOTcwNjIx ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJE aWFnbm9zdGljTG9nZ2luZ0NsaWVudCBpcyBsZWFraW5nLiBJdCBpcyBjb25zdHJ1Y3RlZCBpbnNp ZGUgV2ViUGFnZQorICAgICAgICBjb25zdHJ1Y3RvciBidXQgdGhlcmUgaXMgbm8gY29kZSBkZXN0 cm95aW5nIGl0LgorCisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyBhIG5ldyB4eHhEZXN0cm95ZWQo KSB2aXJ0dWFsIGZ1bmN0aW9uIHRvCisgICAgICAgIERpYWdub3N0aWNMb2dnaW5nQ2xpZW50IGFu ZCB0aGF0IGlzIG92ZXJyaWRlbiBpbgorICAgICAgICBXZWJEaWFnbm9zdGljTG9nZ2luZ0NsaWVu dCB0byBjYWxsICJkZWxldGUgdGhpcyIuIFRoaXMgaXMgdGhlIHNhbWUKKyAgICAgICAgcGF0dGVy biBhcyBmb3Igb3RoZXIgV0syIGNsaWVudHMgKGUuZy4gV2ViRnJhbWVMb2FkZXJDbGllbnQsCisg ICAgICAgIFdlYlByb2dyZXNzVHJhY2tlckNsaWVudCkuCisKKyAgICAgICAgKiBsb2FkZXIvRW1w dHlDbGllbnRzLmg6CisgICAgICAgICogcGFnZS9EaWFnbm9zdGljTG9nZ2luZ0NsaWVudC5oOgor ICAgICAgICAqIHBhZ2UvTWFpbkZyYW1lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1haW5GcmFt ZTo6fk1haW5GcmFtZSk6CisKIDIwMTUtMDQtMjIgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxl LmNvbT4KIAogICAgICAgICBDcmVhdGUgUmVuZGVyUnVieVRleHQgZm9yIDxydD4gb25seSB3aGVu IHRoZSBwYXJlbnQgcmVuZGVyZXIgaXMgYSBSZW5kZXJSdWJ5LgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDJlZTg4 NjU0NzYwYjE5N2IwMTY2NzU1MzgyNzVkOWM2YWRiZWUwNGIuLmIyZTFlNWVhMjlhOTgwYzk2OTU5 OTkwNmFlZTBjOGNjZTQ1ZGM1MmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAxNS0w NC0yMiAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdIFdl YkRpYWdub3N0aWNMb2dnaW5nQ2xpZW50IGlzIGxlYWtpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDA4OQorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vMTk3MDYyMTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgV2ViRGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQgaXMgbGVha2luZy4gSXQgaXMgY29uc3Ry dWN0ZWQgaW5zaWRlIFdlYlBhZ2UKKyAgICAgICAgY29uc3RydWN0b3IgYnV0IHRoZXJlIGlzIG5v IGNvZGUgZGVzdHJveWluZyBpdC4KKworICAgICAgICBUaGlzIHBhdGNoIGFkZHMgYSBuZXcgeHh4 RGVzdHJveWVkKCkgdmlydHVhbCBmdW5jdGlvbiB0bworICAgICAgICBEaWFnbm9zdGljTG9nZ2lu Z0NsaWVudCBhbmQgdGhhdCBpcyBvdmVycmlkZW4gaW4KKyAgICAgICAgV2ViRGlhZ25vc3RpY0xv Z2dpbmdDbGllbnQgdG8gY2FsbCAiZGVsZXRlIHRoaXMiLiBUaGlzIGlzIHRoZSBzYW1lCisgICAg ICAgIHBhdHRlcm4gYXMgZm9yIG90aGVyIFdLMiBjbGllbnRzIChlLmcuIFdlYkZyYW1lTG9hZGVy Q2xpZW50LAorICAgICAgICBXZWJQcm9ncmVzc1RyYWNrZXJDbGllbnQpLgorCisgICAgICAgICog V2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJEaWFnbm9zdGljTG9nZ2luZ0NsaWVudC5jcHA6 CisgICAgICAgIChXZWJLaXQ6OldlYkRpYWdub3N0aWNMb2dnaW5nQ2xpZW50OjptYWluRnJhbWVE ZXN0cm95ZWQpOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRGlhZ25v c3RpY0xvZ2dpbmdDbGllbnQuaDoKKwogMjAxNS0wNC0yMiAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxn aGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBWaXNpYmxlU2VsZWN0aW9uIHNob3VsZCBvbmx5IGFj Y2VwdCBSYW5nZSBieSByZWZlcmVuY2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRl ci9FbXB0eUNsaWVudHMuaCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9FbXB0eUNsaWVudHMuaApp bmRleCA5ZmQxMWRkMGIyYWVjYjA3YmUyYmRkN2NkY2ZmZjE0MzUxYzBlNmUyLi4xZGZlMmEyODI5 NTY5ZTY4ODljYTk2ZmUxN2NjMDgwNTM4ZmMwNDJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9sb2FkZXIvRW1wdHlDbGllbnRzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0VtcHR5 Q2xpZW50cy5oCkBAIC02MzQsNiArNjM0LDggQEAgY2xhc3MgRW1wdHlEaWFnbm9zdGljTG9nZ2lu Z0NsaWVudCBmaW5hbCA6IHB1YmxpYyBEaWFnbm9zdGljTG9nZ2luZ0NsaWVudCB7CiAgICAgdmly dHVhbCB2b2lkIGxvZ0RpYWdub3N0aWNNZXNzYWdlKGNvbnN0IFN0cmluZyYsIGNvbnN0IFN0cmlu ZyYsIFNob3VsZFNhbXBsZSkgb3ZlcnJpZGUgeyB9CiAgICAgdmlydHVhbCB2b2lkIGxvZ0RpYWdu b3N0aWNNZXNzYWdlV2l0aFJlc3VsdChjb25zdCBTdHJpbmcmLCBjb25zdCBTdHJpbmcmLCBEaWFn bm9zdGljTG9nZ2luZ1Jlc3VsdFR5cGUsIFNob3VsZFNhbXBsZSkgb3ZlcnJpZGUgeyB9CiAgICAg dmlydHVhbCB2b2lkIGxvZ0RpYWdub3N0aWNNZXNzYWdlV2l0aFZhbHVlKGNvbnN0IFN0cmluZyYs IGNvbnN0IFN0cmluZyYsIGNvbnN0IFN0cmluZyYsIFNob3VsZFNhbXBsZSkgb3ZlcnJpZGUgeyB9 CisKKyAgICB2aXJ0dWFsIHZvaWQgbWFpbkZyYW1lRGVzdHJveWVkKCkgb3ZlcnJpZGUgeyB9CiB9 OwogCiB2b2lkIGZpbGxXaXRoRW1wdHlDbGllbnRzKFBhZ2VDb25maWd1cmF0aW9uJik7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RpYWdub3N0aWNMb2dnaW5nQ2xpZW50LmggYi9T b3VyY2UvV2ViQ29yZS9wYWdlL0RpYWdub3N0aWNMb2dnaW5nQ2xpZW50LmgKaW5kZXggYmM1YTFl ZGY0MjhlYzBmYjExNzI0YjQzNmNkMzE5YzRlNzAyOGQzMi4uYjRmZjVkNDIxZmQzZjBlNzc2MzFk NDhkYTI1N2QzYjU5ZmU0ZTk2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9EaWFn bm9zdGljTG9nZ2luZ0NsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRGlhZ25vc3Rp Y0xvZ2dpbmdDbGllbnQuaApAQCAtMzksNiArMzksOCBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2 b2lkIGxvZ0RpYWdub3N0aWNNZXNzYWdlV2l0aFJlc3VsdChjb25zdCBTdHJpbmcmIG1lc3NhZ2Us IGNvbnN0IFN0cmluZyYgZGVzY3JpcHRpb24sIERpYWdub3N0aWNMb2dnaW5nUmVzdWx0VHlwZSwg U2hvdWxkU2FtcGxlKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIGxvZ0RpYWdub3N0aWNNZXNzYWdl V2l0aFZhbHVlKGNvbnN0IFN0cmluZyYgbWVzc2FnZSwgY29uc3QgU3RyaW5nJiBkZXNjcmlwdGlv biwgY29uc3QgU3RyaW5nJiB2YWx1ZSwgU2hvdWxkU2FtcGxlKSA9IDA7CiAKKyAgICB2aXJ0dWFs IHZvaWQgbWFpbkZyYW1lRGVzdHJveWVkKCkgPSAwOworCiBwcm90ZWN0ZWQ6CiAgICAgdmlydHVh bCB+RGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQoKSB7IH0KIH07CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL01haW5GcmFtZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL01haW5GcmFt ZS5jcHAKaW5kZXggODY2ZDViMzI4YTEwNzdjMzFiZGFlMDJjNTgzMmJmZmZkOWM1YTdmOC4uNGRk MmFkNTllYzRmYTk2YTFkYTE3ZTE0NGE3NmRiMTY4M2I1ZjRkOCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGFnZS9NYWluRnJhbWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvTWFp bkZyYW1lLmNwcApAQCAtNTgsNiArNTgsOCBAQCBpbmxpbmUgTWFpbkZyYW1lOjpNYWluRnJhbWUo UGFnZSYgcGFnZSwgUGFnZUNvbmZpZ3VyYXRpb24mIGNvbmZpZ3VyYXRpb24pCiAKIE1haW5GcmFt ZTo6fk1haW5GcmFtZSgpCiB7CisgICAgaWYgKG1fZGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQpCisg ICAgICAgIG1fZGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQtPm1haW5GcmFtZURlc3Ryb3llZCgpOwog fQogCiBSZWZQdHI8TWFpbkZyYW1lPiBNYWluRnJhbWU6OmNyZWF0ZShQYWdlJiBwYWdlLCBQYWdl Q29uZmlndXJhdGlvbiYgY29uZmlndXJhdGlvbikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQuY3Bw IGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJEaWFnbm9zdGlj TG9nZ2luZ0NsaWVudC5jcHAKaW5kZXggNWFhNDhiMDQ5ZWY3MWJhZGVmYzdmZmEwYmMzZmI3ODU4 MDVmMDU1Ni4uNmMwMDZmZWExNjEwNGM3MzdjYWJiOTMyNzU1NDVmNjQzZTI5NzhhMyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJEaWFnbm9z dGljTG9nZ2luZ0NsaWVudC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJD b3JlU3VwcG9ydC9XZWJEaWFnbm9zdGljTG9nZ2luZ0NsaWVudC5jcHAKQEAgLTcxLDQgKzcxLDkg QEAgdm9pZCBXZWJEaWFnbm9zdGljTG9nZ2luZ0NsaWVudDo6bG9nRGlhZ25vc3RpY01lc3NhZ2VX aXRoVmFsdWUoY29uc3QgU3RyaW5nJiBtZXMKICAgICBtX3BhZ2Uuc2VuZChNZXNzYWdlczo6V2Vi UGFnZVByb3h5OjpMb2dEaWFnbm9zdGljTWVzc2FnZVdpdGhWYWx1ZShtZXNzYWdlLCBkZXNjcmlw dGlvbiwgdmFsdWUsIHNob3VsZFNhbXBsZSA9PSBXZWJDb3JlOjpTaG91bGRTYW1wbGU6Olllcykp OwogfQogCit2b2lkIFdlYkRpYWdub3N0aWNMb2dnaW5nQ2xpZW50OjptYWluRnJhbWVEZXN0cm95 ZWQoKQoreworICAgIGRlbGV0ZSB0aGlzOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRGlh Z25vc3RpY0xvZ2dpbmdDbGllbnQuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29y ZVN1cHBvcnQvV2ViRGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQuaAppbmRleCAzNjg3Y2M4MGFiOGI3 ZTUyYjlkMDUzOGY4NDAxYmMxODk0ZGQ0MzRjLi5lNWExMzQxYTZjNDBjYTEyYzliODBlMzc5NGU3 M2Y3NTg1NjU1MDM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNv cmVTdXBwb3J0L1dlYkRpYWdub3N0aWNMb2dnaW5nQ2xpZW50LmgKKysrIGIvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJEaWFnbm9zdGljTG9nZ2luZ0NsaWVudC5o CkBAIC00Myw2ICs0Myw4IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIGxvZ0RpYWdub3N0 aWNNZXNzYWdlV2l0aFJlc3VsdChjb25zdCBTdHJpbmcmIG1lc3NhZ2UsIGNvbnN0IFN0cmluZyYg ZGVzY3JpcHRpb24sIFdlYkNvcmU6OkRpYWdub3N0aWNMb2dnaW5nUmVzdWx0VHlwZSwgV2ViQ29y ZTo6U2hvdWxkU2FtcGxlKSBvdmVycmlkZTsKICAgICB2aXJ0dWFsIHZvaWQgbG9nRGlhZ25vc3Rp Y01lc3NhZ2VXaXRoVmFsdWUoY29uc3QgU3RyaW5nJiBtZXNzYWdlLCBjb25zdCBTdHJpbmcmIGRl c2NyaXB0aW9uLCBjb25zdCBTdHJpbmcmIHZhbHVlLCBXZWJDb3JlOjpTaG91bGRTYW1wbGUpIG92 ZXJyaWRlOwogCisgICAgdmlydHVhbCB2b2lkIG1haW5GcmFtZURlc3Ryb3llZCgpIG92ZXJyaWRl OworCiAgICAgV2ViUGFnZSYgbV9wYWdlOwogfTsKIAo=