144083 2015-04-22 18:09:19 -0700 [EFL] Build failure to find gio-unix 2015-04-29 07:36:16 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 scimmia22 ryuan.choi commit-queue lucas.de.marchi ryuan.choi scimmia22 oldest_to_newest 1087669 0 251392 scimmia22 2015-04-22 18:09:19 -0700 Created attachment 251392 Move geoclue block before find_package(GLIB...) Currently the gio-unix headers do not get included, leading to a build failure when building geoclue support. Patch attached fixes it. 1089819 1 ryuan.choi 2015-04-28 18:08:27 -0700 Can you update the patch with ChangeLog? You should touch ChangeLog in root directory. http://www.webkit.org/coding/contributing.html 1089843 2 scimmia22 2015-04-28 19:06:05 -0700 Unfortunately, not very well. The scripts you pointed me to aren't running for me. The repo layout is kind of ridiculous, so I only have a partial checkouts. 1089961 3 251945 ryuan.choi 2015-04-29 04:52:08 -0700 Created attachment 251945 Patch 1089962 4 ryuan.choi 2015-04-29 04:52:53 -0700 (In reply to comment #2) > Unfortunately, not very well. The scripts you pointed me to aren't running > for me. The repo layout is kind of ridiculous, so I only have a partial > checkouts. OK, I uploaded the patch with changelog instead of you. 1089971 5 251945 gyuyoung.kim 2015-04-29 05:23:45 -0700 Comment on attachment 251945 Patch Thank you for fixing. 1089983 6 251945 commit-queue 2015-04-29 07:36:10 -0700 Comment on attachment 251945 Patch Clearing flags on attachment: 251945 Committed r183545: <http://trac.webkit.org/changeset/183545> 1089984 7 commit-queue 2015-04-29 07:36:16 -0700 All reviewed patches have been landed. Closing bug. 251392 2015-04-22 18:09:19 -0700 2015-04-29 04:51:57 -0700 Move geoclue block before find_package(GLIB...) fix_gio-unix.patch text/plain 1138 scimmia22 SW5kZXg6IGNtYWtlL09wdGlvbnNFZmwuY21ha2UKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL2NtYWtl L09wdGlvbnNFZmwuY21ha2UJKHJldmlzaW9uIDE4MzE1NSkKKysrIFNvdXJjZS9jbWFrZS9PcHRp b25zRWZsLmNtYWtlCSh3b3JraW5nIGNvcHkpCkBAIC0xNzYsMTUgKzE3Niw2IEBACiBmaW5kX3Bh Y2thZ2UoRW8gJHtFRkxfUkVRVUlSRURfVkVSU0lPTn0gUkVRVUlSRUQgQ09ORklHKQogZmluZF9w YWNrYWdlKEV2YXMgJHtFRkxfUkVRVUlSRURfVkVSU0lPTn0gUkVRVUlSRUQgQ09ORklHKQogCi1m aW5kX3BhY2thZ2UoRnJlZXR5cGUyIDIuNC4yIFJFUVVJUkVEKQotZmluZF9wYWNrYWdlKEdMSUIg Mi4zOC4wIFJFUVVJUkVEIENPTVBPTkVOVFMgJHtHTElCX0NPTVBPTkVOVFN9KQotZmluZF9wYWNr YWdlKEhhcmZCdXp6IDAuOS4yIFJFUVVJUkVEKQotZmluZF9wYWNrYWdlKExpYlNvdXAgMi40Mi4w IFJFUVVJUkVEKQotCi1pZiAoRU5BQkxFX0JBVFRFUllfU1RBVFVTKQotICAgIGZpbmRfcGFja2Fn ZShFbGRidXMgJHtFRkxfUkVRVUlSRURfVkVSU0lPTn0gQ09ORklHKQotZW5kaWYgKCkKLQogaWYg KEVOQUJMRV9HRU9MT0NBVElPTikKICAgICBsaXN0KEFQUEVORCBHTElCX0NPTVBPTkVOVFMgZ2lv LXVuaXgpCiAgICAgZmluZF9wYWNrYWdlKEdlb0NsdWUyIDIuMS41KQpAQCAtMTk2LDYgKzE4Nywx NSBAQAogICAgIGVuZGlmICgpCiBlbmRpZiAoKQogCitmaW5kX3BhY2thZ2UoRnJlZXR5cGUyIDIu NC4yIFJFUVVJUkVEKQorZmluZF9wYWNrYWdlKEdMSUIgMi4zOC4wIFJFUVVJUkVEIENPTVBPTkVO VFMgJHtHTElCX0NPTVBPTkVOVFN9KQorZmluZF9wYWNrYWdlKEhhcmZCdXp6IDAuOS4yIFJFUVVJ UkVEKQorZmluZF9wYWNrYWdlKExpYlNvdXAgMi40Mi4wIFJFUVVJUkVEKQorCitpZiAoRU5BQkxF X0JBVFRFUllfU1RBVFVTKQorICAgIGZpbmRfcGFja2FnZShFbGRidXMgJHtFRkxfUkVRVUlSRURf VkVSU0lPTn0gQ09ORklHKQorZW5kaWYgKCkKKwogaWYgKEVOQUJMRV9NRURJQV9TVFJFQU0pCiAg ICAgZmluZF9wYWNrYWdlKE9wZW5XZWJSVEMpCiAgICAgaWYgKE9QRU5XRUJSVENfRk9VTkQpCg== 251945 2015-04-29 04:52:08 -0700 2015-04-29 07:36:10 -0700 Patch bug-144083-20150429205055.patch text/plain 1971 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzNTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IDA2MmM5 ZTg5MjBjZGIxNzQ2YjNiMGViOTRhODljZWRlNDAzZWJhMDEuLjA1Njk1MThjM2JjYTkzNjhiZTJi MWY3OTliZGIyYjFiZGJjY2ZhOTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZs LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC0xNjksMTUgKzE2 OSw2IEBAIGZpbmRfcGFja2FnZShFaW5hICR7RUZMX1JFUVVJUkVEX1ZFUlNJT059IFJFUVVJUkVE IENPTkZJRykKIGZpbmRfcGFja2FnZShFbyAke0VGTF9SRVFVSVJFRF9WRVJTSU9OfSBSRVFVSVJF RCBDT05GSUcpCiBmaW5kX3BhY2thZ2UoRXZhcyAke0VGTF9SRVFVSVJFRF9WRVJTSU9OfSBSRVFV SVJFRCBDT05GSUcpCiAKLWZpbmRfcGFja2FnZShGcmVldHlwZTIgMi40LjIgUkVRVUlSRUQpCi1m aW5kX3BhY2thZ2UoR0xJQiAyLjM4LjAgUkVRVUlSRUQgQ09NUE9ORU5UUyAke0dMSUJfQ09NUE9O RU5UU30pCi1maW5kX3BhY2thZ2UoSGFyZkJ1enogMC45LjIgUkVRVUlSRUQpCi1maW5kX3BhY2th Z2UoTGliU291cCAyLjQyLjAgUkVRVUlSRUQpCi0KLWlmIChFTkFCTEVfQkFUVEVSWV9TVEFUVVMp Ci0gICAgZmluZF9wYWNrYWdlKEVsZGJ1cyAke0VGTF9SRVFVSVJFRF9WRVJTSU9OfSBDT05GSUcp Ci1lbmRpZiAoKQotCiBpZiAoRU5BQkxFX0dFT0xPQ0FUSU9OKQogICAgIGxpc3QoQVBQRU5EIEdM SUJfQ09NUE9ORU5UUyBnaW8tdW5peCkKICAgICBmaW5kX3BhY2thZ2UoR2VvQ2x1ZTIgMi4xLjUp CkBAIC0xODksNiArMTgwLDE1IEBAIGlmIChFTkFCTEVfR0VPTE9DQVRJT04pCiAgICAgZW5kaWYg KCkKIGVuZGlmICgpCiAKK2ZpbmRfcGFja2FnZShGcmVldHlwZTIgMi40LjIgUkVRVUlSRUQpCitm aW5kX3BhY2thZ2UoR0xJQiAyLjM4LjAgUkVRVUlSRUQgQ09NUE9ORU5UUyAke0dMSUJfQ09NUE9O RU5UU30pCitmaW5kX3BhY2thZ2UoSGFyZkJ1enogMC45LjIgUkVRVUlSRUQpCitmaW5kX3BhY2th Z2UoTGliU291cCAyLjQyLjAgUkVRVUlSRUQpCisKK2lmIChFTkFCTEVfQkFUVEVSWV9TVEFUVVMp CisgICAgZmluZF9wYWNrYWdlKEVsZGJ1cyAke0VGTF9SRVFVSVJFRF9WRVJTSU9OfSBDT05GSUcp CitlbmRpZiAoKQorCiBpZiAoRU5BQkxFX01FRElBX1NUUkVBTSkKICAgICBmaW5kX3BhY2thZ2Uo T3BlbldlYlJUQykKICAgICBpZiAoT1BFTldFQlJUQ19GT1VORCkKZGlmZiAtLWdpdCBhL0NoYW5n ZUxvZyBiL0NoYW5nZUxvZwppbmRleCBkM2M0ZTUxOTIxZWM1ODljM2RkZDNmN2E4MDFkNmUwMWY4 YTM1NjRlLi5lNGE2ODY5NGU5NzQyOTFlNmU5ZjAwNzAwNDJjMDE3M2I0MGIxY2ViIDEwMDY0NAot LS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTUtMDQt MjkgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQG5hdmVyY29ycC5jb20+CisKKyAgICAgICAgW0VG TF0gQnVpbGQgZmFpbHVyZSB0byBmaW5kIGdpby11bml4CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQwODMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPcmlnaW5hbCBwYXRjaCBieSBEb3VnIE5ld2dhcmQg PHNjaW1tYTIyQG91dGxvb2suY29tPgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNF ZmwuY21ha2U6IE1vdmVkIGdlb2NsdWUgYmxvY2sgYmVmb3JlIGZpbmRfcGFja2FnZShHTElCLi4u KQorCiAyMDE1LTA0LTI4ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBuYXZlcmNvcnAuY29tPgog CiAgICAgICAgIFtDb29yZGluYXRlZEdyYXBoaWNzXSBNZXJnZSBUSUxFRF9CQUNLSU5HX1NUT1JF IGd1YXJkIHdpdGggQ09PUkRJTkFURURfR1JBUEhJQ1MK