144080 2015-04-22 16:31:28 -0700 [iOS] Disable live rendering during zoom on low-memory devices. 2015-09-02 17:45:08 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX InRadar, Performance P2 Normal --- 1 kling kling barraclough benjamin kling simon.fraser thorton oldest_to_newest 1087642 0 kling 2015-04-22 16:31:28 -0700 <rdar://problem/19872709> To avoid IOSurface explosion on low-memory (512MB) devices, we should disable live tile rendering during zooming. 1087647 1 251386 kling 2015-04-22 17:04:57 -0700 Created attachment 251386 Patch idea 1087650 2 251386 simon.fraser 2015-04-22 17:11:21 -0700 Comment on attachment 251386 Patch idea View in context: https://bugs.webkit.org/attachment.cgi?id=251386&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:158 > +static uint64_t memorySize() > +{ > + static host_basic_info_data_t hostInfo; > + > + static dispatch_once_t once; > + dispatch_once(&once, ^() { > + mach_port_t host = mach_host_self(); > + mach_msg_type_number_t count = HOST_BASIC_INFO_COUNT; > + kern_return_t r = host_info(host, HOST_BASIC_INFO, (host_info_t)&hostInfo, &count); > + mach_port_deallocate(mach_task_self(), host); > + > + if (r != KERN_SUCCESS) > + LOG_ERROR("%s : host_info(%d) : %s.\n", __FUNCTION__, r, mach_error_string(r)); > + }); > + > + return hostInfo.max_mem; > +} There are already 3 copies of this code. Please don't add another one. 1087651 3 251386 thorton 2015-04-22 17:15:38 -0700 Comment on attachment 251386 Patch idea View in context: https://bugs.webkit.org/attachment.cgi?id=251386&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:142 > +static uint64_t memorySize() Put this somewhere we can share it. Probably in WTF. Certainly does not belong in WKWebView. > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1382 > + drawingArea->setLayerTreeStateIsFrozen(true); This is kind of a weird way to do this. I feel like the Web process should be able to do this without help (?). Also, isn't there lots of wasted work happening in the Web process in your case, because you're only cutting off the layer tree flush, but not other things? Maybe Ben has an idea. 1087653 4 kling 2015-04-22 17:25:15 -0700 (In reply to comment #3) > Comment on attachment 251386 [details] > Patch idea > > View in context: > https://bugs.webkit.org/attachment.cgi?id=251386&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:142 > > +static uint64_t memorySize() > > Put this somewhere we can share it. Probably in WTF. Certainly does not > belong in WKWebView. Sure. I'll consolidate all the existing ones in a separate patch. Filed this: <https://webkit.org/b/144081> WTF should have a way to get the system memory size. > > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1382 > > + drawingArea->setLayerTreeStateIsFrozen(true); > > This is kind of a weird way to do this. I feel like the Web process should > be able to do this without help (?). Also, isn't there lots of wasted work > happening in the Web process in your case, because you're only cutting off > the layer tree flush, but not other things? Maybe Ben has an idea. This approach came out of a discussion with Ben. We wanted something that still behaves the same, as far as the web content is concerned (scroll events still get sent, and such) and just looks different. Would you like it better if the IPC messages were something like "WillBeginZooming/DidEndZooming" instead, and the biz logic for what to do about it would sit in the web process? 1087658 5 thorton 2015-04-22 17:36:25 -0700 (In reply to comment #4) > (In reply to comment #3) > > Comment on attachment 251386 [details] > > Patch idea > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=251386&action=review > > > > > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:142 > > > +static uint64_t memorySize() > > > > Put this somewhere we can share it. Probably in WTF. Certainly does not > > belong in WKWebView. > > Sure. I'll consolidate all the existing ones in a separate patch. Filed this: > <https://webkit.org/b/144081> WTF should have a way to get the system memory > size. ramSize() already exists, as mentioned on IRC. > > > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1382 > > > + drawingArea->setLayerTreeStateIsFrozen(true); > > > > This is kind of a weird way to do this. I feel like the Web process should > > be able to do this without help (?). Also, isn't there lots of wasted work > > happening in the Web process in your case, because you're only cutting off > > the layer tree flush, but not other things? Maybe Ben has an idea. > > This approach came out of a discussion with Ben. We wanted something that > still behaves the same, as far as the web content is concerned (scroll > events still get sent, and such) and just looks different. Ah! So the weird behavior is intentional :D OK. > Would you like it better if the IPC messages were something like > "WillBeginZooming/DidEndZooming" instead, and the biz logic for what to do > about it would sit in the web process? That does sound better. I'm still sort of surprised that the Web process can't already tell when live zooming starts and ends, but perhaps it cannot. Discussing on IRC why setLayerTreeStateIsFrozen is scary. 251386 2015-04-22 17:04:57 -0700 2015-04-22 17:31:02 -0700 Patch idea bug-144080.diff text/plain 5456 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5NTQxMTgzLi5kNThkNTY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzAg QEAKKzIwMTUtMDQtMjIgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFtpT1NdIERpc2FibGUgbGl2ZSByZW5kZXJpbmcgZHVyaW5nIHpvb20gb24gbG93LW1lbW9y eSBkZXZpY2VzLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTQ0MDgwPgorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMTk4NzI3MDk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVHVybiBvZmYgbGl2ZSB0aWxlIHJlbmRlcmluZyBkdXJpbmcg em9vbSAodGhlIHBpbmNoLXpvb21pbmcgZ2VzdHVyZSwgYW5kIHRoZSB6b29tIGFuaW1hdGlvbgor ICAgICAgICB3aGVuIGZvY3VzaW5nIGEgZm9ybSBlbGVtZW50KSBvbiBsb3ctbWVtb3J5ICg8MUdC KSBkZXZpY2VzLgorCisgICAgICAgIFRoaXMgYXZvaWRzIHRoZSBJT1N1cmZhY2UgZXhwbG9zaW9u IHRoYXQgY291bGQgc29tZXRpbWVzIGNhdXNlIGJhY2tncm91bmQgcHJvY2Vzc2VzIHRvIGdldAor ICAgICAgICBwdXNoZWQgb3V0IGJ5IHRoZSBrZXJuZWwgdG8gbWFrZSBzcGFjZSBmb3IgdXMuCisK KyAgICAgICAgSXQncyBpbXBsZW1lbnRlZCBieSBleHBvc2luZyBEcmF3aW5nQXJlYTo6c2V0TGF5 ZXJUcmVlU3RhdGVJc0Zyb3plbigpIGFzIGFzeW5jaHJvbm91cyBJUEMKKyAgICAgICAgbWVzc2Fn ZXMsIGFuZCBoYXZpbmcgdGhlIFdLV2ViVmlldyBmcmVlemUvdW5mcmVlemUgdGhlIGxheWVyIHRy ZWUgYXQgdGhlIHN0YXJ0L2VuZCBvZiBhIHpvb20uCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L0NvY29hL1dLV2ViVmlldy5tbToKKyAgICAgICAgKG1lbW9yeVNpemUpOgorICAgICAgICAoc2hv dWxkUmVuZGVyV2hpbGVab29taW5nKToKKyAgICAgICAgKC1bV0tXZWJWaWV3IHNjcm9sbFZpZXdX aWxsQmVnaW5ab29taW5nOndpdGhWaWV3Ol0pOgorICAgICAgICAoLVtXS1dlYlZpZXcgc2Nyb2xs Vmlld0RpZEVuZFpvb21pbmc6d2l0aFZpZXc6YXRTY2FsZTpdKToKKyAgICAgICAgKiBVSVByb2Nl c3MvRHJhd2luZ0FyZWFQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OkRyYXdpbmdBcmVhUHJv eHk6OnNldExheWVyVHJlZVN0YXRlSXNGcm96ZW4pOgorICAgICAgICAqIFVJUHJvY2Vzcy9EcmF3 aW5nQXJlYVByb3h5Lmg6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVh Lm1lc3NhZ2VzLmluOgorCiAyMDE1LTA0LTIxICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25A YXBwbGUuY29tPgogCiAgICAgICAgIFtNYWNdIFVzZSBvbmUgcGxheWJhY2sgdGFyZ2V0IGZvciBh bGwgd2ViIHByb2Nlc3NlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9Db2NvYS9XS1dlYlZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29h L1dLV2ViVmlldy5tbQppbmRleCA3MWY4OTA1Li4wOTQ1YTAwMSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KKysrIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KQEAgLTEzOCw2ICsxMzgsMzUg QEAgZW51bSBjbGFzcyBEeW5hbWljVmlld3BvcnRVcGRhdGVNb2RlIHsKICNpbXBvcnQgPFdlYkNv cmUvQ29sb3JNYWMuaD4KICNlbmRpZgogCisjaWYgUExBVEZPUk0oSU9TKSAmJiAhUExBVEZPUk0o SU9TX1NJTVVMQVRPUikKK3N0YXRpYyB1aW50NjRfdCBtZW1vcnlTaXplKCkKK3sKKyAgICBzdGF0 aWMgaG9zdF9iYXNpY19pbmZvX2RhdGFfdCBob3N0SW5mbzsKKworICAgIHN0YXRpYyBkaXNwYXRj aF9vbmNlX3Qgb25jZTsKKyAgICBkaXNwYXRjaF9vbmNlKCZvbmNlLCBeKCkgeworICAgICAgICBt YWNoX3BvcnRfdCBob3N0ID0gbWFjaF9ob3N0X3NlbGYoKTsKKyAgICAgICAgbWFjaF9tc2dfdHlw ZV9udW1iZXJfdCBjb3VudCA9IEhPU1RfQkFTSUNfSU5GT19DT1VOVDsKKyAgICAgICAga2Vybl9y ZXR1cm5fdCByID0gaG9zdF9pbmZvKGhvc3QsIEhPU1RfQkFTSUNfSU5GTywgKGhvc3RfaW5mb190 KSZob3N0SW5mbywgJmNvdW50KTsKKyAgICAgICAgbWFjaF9wb3J0X2RlYWxsb2NhdGUobWFjaF90 YXNrX3NlbGYoKSwgaG9zdCk7CisKKyAgICAgICAgaWYgKHIgIT0gS0VSTl9TVUNDRVNTKQorICAg ICAgICAgICAgTE9HX0VSUk9SKCIlcyA6IGhvc3RfaW5mbyglZCkgOiAlcy5cbiIsIF9fRlVOQ1RJ T05fXywgciwgbWFjaF9lcnJvcl9zdHJpbmcocikpOworICAgIH0pOworCisgICAgcmV0dXJuIGhv c3RJbmZvLm1heF9tZW07Cit9CisjZW5kaWYKKworc3RhdGljIGJvb2wgc2hvdWxkUmVuZGVyV2hp bGVab29taW5nKCkKK3sKKyNpZiBQTEFURk9STShJT1MpICYmICFQTEFURk9STShJT1NfU0lNVUxB VE9SKQorICAgIHN0YXRpYyBjb25zdCBzaXplX3QgR0IgPSAxMDI0ICogMTAyNDsKKyAgICByZXR1 cm4gbWVtb3J5U2l6ZSgpID49IDEgKiBHQjsKKyNlbHNlCisgICAgcmV0dXJuIHRydWU7CisjZW5k aWYKK30KIAogc3RhdGljIEhhc2hNYXA8V2ViS2l0OjpXZWJQYWdlUHJveHkqLCBXS1dlYlZpZXcg Kj4mIHBhZ2VUb1ZpZXdNYXAoKQogewpAQCAtMTM0OCw2ICsxMzc3LDExIEBAIHN0YXRpYyBXZWJD b3JlOjpGbG9hdFBvaW50IGNvbnN0cmFpbkNvbnRlbnRPZmZzZXQoV2ViQ29yZTo6RmxvYXRQb2lu dCBjb250ZW50T2ZmCiAgICAgaWYgKCFbc2VsZiB1c2VzU3RhbmRhcmRDb250ZW50Vmlld10pCiAg ICAgICAgIHJldHVybjsKIAorICAgIGlmICghc2hvdWxkUmVuZGVyV2hpbGVab29taW5nKCkpIHsK KyAgICAgICAgaWYgKFdlYktpdDo6RHJhd2luZ0FyZWFQcm94eSogZHJhd2luZ0FyZWEgPSBfcGFn ZS0+ZHJhd2luZ0FyZWEoKSkKKyAgICAgICAgICAgIGRyYXdpbmdBcmVhLT5zZXRMYXllclRyZWVT dGF0ZUlzRnJvemVuKHRydWUpOworICAgIH0KKwogICAgIGlmIChzY3JvbGxWaWV3LnBpbmNoR2Vz dHVyZVJlY29nbml6ZXIuc3RhdGUgPT0gVUlHZXN0dXJlUmVjb2duaXplclN0YXRlQmVnYW4pIHsK ICAgICAgICAgX3BhZ2UtPndpbGxTdGFydFVzZXJUcmlnZ2VyZWRab29taW5nKCk7CiAgICAgICAg IFtfY29udGVudFZpZXcgc2Nyb2xsVmlld1dpbGxTdGFydFBhbk9yUGluY2hHZXN0dXJlXTsKQEAg LTE0MzMsNiArMTQ2NywxNSBAQCBzdGF0aWMgV2ViQ29yZTo6RmxvYXRQb2ludCBjb25zdHJhaW5D b250ZW50T2Zmc2V0KFdlYkNvcmU6OkZsb2F0UG9pbnQgY29udGVudE9mZgogLSAodm9pZClzY3Jv bGxWaWV3RGlkRW5kWm9vbWluZzooVUlTY3JvbGxWaWV3ICopc2Nyb2xsVmlldyB3aXRoVmlldzoo VUlWaWV3ICopdmlldyBhdFNjYWxlOihDR0Zsb2F0KXNjYWxlCiB7CiAgICAgQVNTRVJUKHNjcm9s bFZpZXcgPT0gX3Njcm9sbFZpZXcpOworCisgICAgaWYgKCFbc2VsZiB1c2VzU3RhbmRhcmRDb250 ZW50Vmlld10pCisgICAgICAgIHJldHVybjsKKworICAgIGlmICghc2hvdWxkUmVuZGVyV2hpbGVa b29taW5nKCkpIHsKKyAgICAgICAgaWYgKFdlYktpdDo6RHJhd2luZ0FyZWFQcm94eSogZHJhd2lu Z0FyZWEgPSBfcGFnZS0+ZHJhd2luZ0FyZWEoKSkKKyAgICAgICAgICAgIGRyYXdpbmdBcmVhLT5z ZXRMYXllclRyZWVTdGF0ZUlzRnJvemVuKGZhbHNlKTsKKyAgICB9CisKICAgICBbc2VsZiBfdXBk YXRlVmlzaWJsZUNvbnRlbnRSZWN0c107CiAgICAgW19jb250ZW50VmlldyBkaWRab29tVG9TY2Fs ZTpzY2FsZV07CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2lu Z0FyZWFQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94 eS5jcHAKaW5kZXggM2Q1YjllMi4uNTdmZTIyOTA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0RyYXdpbmdBcmVhUHJveHkuY3BwCkBAIC04Nyw0ICs4NywxMiBAQCB2b2lkIERyYXdp bmdBcmVhUHJveHk6OmV4cG9zZWRSZWN0Q2hhbmdlZFRpbWVyRmlyZWQoKQogfQogI2VuZGlmIC8v IFBMQVRGT1JNKE1BQykKIAordm9pZCBEcmF3aW5nQXJlYVByb3h5OjpzZXRMYXllclRyZWVTdGF0 ZUlzRnJvemVuKGJvb2wgZnJvemVuKQoreworICAgIGlmICghbV93ZWJQYWdlUHJveHkuaXNWYWxp ZCgpKQorICAgICAgICByZXR1cm47CisKKyAgICBtX3dlYlBhZ2VQcm94eS5wcm9jZXNzKCkuc2Vu ZChNZXNzYWdlczo6RHJhd2luZ0FyZWE6OlNldExheWVyVHJlZVN0YXRlSXNGcm96ZW4oZnJvemVu KSwgbV93ZWJQYWdlUHJveHkucGFnZUlEKCkpOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5Lmgg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94eS5oCmluZGV4IGExYTZk MjYuLmU3NGNmYjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9EcmF3aW5n QXJlYVByb3h5LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJv eHkuaApAQCAtOTEsNiArOTEsOCBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIHZvaWQgaGlkZUNv bnRlbnRVbnRpbE5leHRVcGRhdGUoKSB7IEFTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9CiAKKyAgICB2 b2lkIHNldExheWVyVHJlZVN0YXRlSXNGcm96ZW4oYm9vbCk7CisKIHByb3RlY3RlZDoKICAgICBl eHBsaWNpdCBEcmF3aW5nQXJlYVByb3h5KERyYXdpbmdBcmVhVHlwZSwgV2ViUGFnZVByb3h5Jik7 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9EcmF3aW5n QXJlYS5tZXNzYWdlcy5pbiBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9EcmF3 aW5nQXJlYS5tZXNzYWdlcy5pbgppbmRleCA5ODQ0ZTdjLi4xNmVmNDE4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWEubWVzc2FnZXMuaW4K KysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhLm1lc3Nh Z2VzLmluCkBAIC00Myw0ICs0Myw2IEBAIG1lc3NhZ2VzIC0+IERyYXdpbmdBcmVhIHsKICNpZiBV U0UoVEVYVFVSRV9NQVBQRVJfR0wpICYmIFBMQVRGT1JNKEdUSykKICAgICBTZXROYXRpdmVTdXJm YWNlSGFuZGxlRm9yQ29tcG9zaXRpbmcodWludDY0X3QgaGFuZGxlKQogI2VuZGlmCisKKyAgICBT ZXRMYXllclRyZWVTdGF0ZUlzRnJvemVuKGJvb2wgZnJvemVuKQogfQo=