144072 2015-04-22 15:48:07 -0700 Volume slider appears/doesn't appear at the wrong times 2015-04-22 21:43:13 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned dino roger_fong oldest_to_newest 1087617 0 roger_fong 2015-04-22 15:48:07 -0700 rdar://problem/20576145 2 things here: a) set pointer-events: none of background divs for volume slider so the box doesn't appear randomly b) call drawVolumeBackground on the over event for the mute box. 1087621 1 251375 roger_fong 2015-04-22 16:00:30 -0700 Created attachment 251375 patch 1087673 2 roger_fong 2015-04-22 18:35:59 -0700 Note that the slider drew for <video> elements before because we drew it as a result of calling showControls(). However, we don't call showControls() for <audio> elements because the controls are always visible anyways. 1087680 3 251375 dino 2015-04-22 18:48:32 -0700 Comment on attachment 251375 patch View in context: https://bugs.webkit.org/attachment.cgi?id=251375&action=review > Source/WebCore/ChangeLog:12 > + Don't allow mouse interaction with the background divs. > + * Modules/mediacontrols/mediaControlsApple.css: > + (audio::-webkit-media-controls-volume-slider-container-background): > + (audio::-webkit-media-controls-volume-slider-container-tint): I'm not sure why you needed to do this. As long as the backgrounds are behind the controls, wouldn't the control get the event? 1087681 4 roger_fong 2015-04-22 18:53:48 -0700 (In reply to comment #3) > Comment on attachment 251375 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=251375&action=review > > > Source/WebCore/ChangeLog:12 > > + Don't allow mouse interaction with the background divs. > > + * Modules/mediacontrols/mediaControlsApple.css: > > + (audio::-webkit-media-controls-volume-slider-container-background): > > + (audio::-webkit-media-controls-volume-slider-container-tint): > > I'm not sure why you needed to do this. As long as the backgrounds are > behind the controls, wouldn't the control get the event? In this situation, when the volume box is hidden, the controls have a width of 0, so the background, while hidden, are above the controls. Maybe a better way to do this is to make the widths of the background divs 0 as well while hidden. 1087723 5 roger_fong 2015-04-22 21:43:13 -0700 http://trac.webkit.org/changeset/183168 251375 2015-04-22 16:00:30 -0700 2015-04-22 18:48:32 -0700 patch patch.patch text/plain 2928 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MzE0OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA0LTIyICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgVm9sdW1lIHNsaWRlciBhcHBl YXJzL2RvZXNuJ3QgYXBwZWFyIGF0IHRoZSB3cm9uZyB0aW1lcy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDA3Mi4KKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzIwNTc2MTQ1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIERvbid0IGFsbG93IG1vdXNlIGludGVyYWN0aW9uIHdpdGggdGhlIGJhY2tncm91 bmQgZGl2cy4KKyAgICAgICAgKiBNb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0Fw cGxlLmNzczoKKyAgICAgICAgKGF1ZGlvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLXZvbHVtZS1z bGlkZXItY29udGFpbmVyLWJhY2tncm91bmQpOgorICAgICAgICAoYXVkaW86Oi13ZWJraXQtbWVk aWEtY29udHJvbHMtdm9sdW1lLXNsaWRlci1jb250YWluZXItdGludCk6CisKKyAgICAgICAgRHJh dyB0aGUgdm9sdW1lIHNsaWRlciBpbW1lZGlhdGVseSBvbiBtb3VzaW5nIG92ZXIgdGhlIG11dGUg Ym94LgorICAgICAgICAqIE1vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUu anM6CisgICAgICAgIChDb250cm9sbGVyLnByb3RvdHlwZS5jcmVhdGVDb250cm9scyk6CisgICAg ICAgIChDb250cm9sbGVyLnByb3RvdHlwZS5oYW5kbGVNdXRlQm94T3Zlcik6CisKIDIwMTUtMDQt MjIgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgQ29udGV4 dCBtZW51IGRvZXNuJ3QgYWNjb3VudCBmb3Igc2VsZWN0aW9uIHNlbWFudGljcwpJbmRleDogU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5jc3MK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlh Q29udHJvbHNBcHBsZS5jc3MJKHJldmlzaW9uIDE4MzExNCkKKysrIFNvdXJjZS9XZWJDb3JlL01v ZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuY3NzCSh3b3JraW5nIGNvcHkp CkBAIC0yMzgsNiArMjM4LDcgQEAgYXVkaW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtdm9sdW1l LXNsaQogICAgIGJvcmRlci10b3AtcmlnaHQtcmFkaXVzOiA0cHg7CiAgICAgYmFja2dyb3VuZC1j b2xvcjogcmdiYSgzMCwgMzAsIDMwLCAwLjQ1KTsKICAgICAtd2Via2l0LWJhY2tkcm9wLWZpbHRl cjogc2F0dXJhdGUoMTgwJSkgYmx1cigyMHB4KTsKKyAgICBwb2ludGVyLWV2ZW50czogbm9uZTsK IH0KIAogdmlkZW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtdm9sdW1lLXNsaWRlci1jb250YWlu ZXItdGludCwKQEAgLTI1MSw2ICsyNTIsNyBAQCBhdWRpbzo6LXdlYmtpdC1tZWRpYS1jb250cm9s cy12b2x1bWUtc2xpCiAgICAgYm9yZGVyLXRvcC1yaWdodC1yYWRpdXM6IDRweDsKICAgICBiYWNr Z3JvdW5kLWNvbG9yOiByZ2IoNDEsIDQxLCA0MSk7CiAgICAgbWl4LWJsZW5kLW1vZGU6IGxpZ2h0 ZW47CisgICAgcG9pbnRlci1ldmVudHM6IG5vbmU7CiB9CiAKIC8qIEZJWE1FOiBuZWVkcyBDU1M0 ICFzdWJqZWN0IHNlbGVjdG9yIHRvIHNob3cgd2hlbiBzbGlkZXIgaW5zaWRlIC52b2x1bWUtYm94 IGlzIGZvY3VzZWQgKi8KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9s cy9tZWRpYUNvbnRyb2xzQXBwbGUuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvTW9k dWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5qcwkocmV2aXNpb24gMTgzMTE1 KQorKysgU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNB cHBsZS5qcwkod29ya2luZyBjb3B5KQpAQCAtMzk2LDYgKzM5Niw3IEBAIENvbnRyb2xsZXIucHJv dG90eXBlID0gewogCiAgICAgICAgIHZhciBtdXRlQm94ID0gdGhpcy5jb250cm9scy5tdXRlQm94 ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnZGl2Jyk7CiAgICAgICAgIG11dGVCb3guY2xhc3NM aXN0LmFkZCh0aGlzLkNsYXNzTmFtZXMubXV0ZUJveCk7CisgICAgICAgIHRoaXMubGlzdGVuRm9y KG11dGVCb3gsICdtb3VzZW92ZXInLCB0aGlzLmhhbmRsZU11dGVCb3hPdmVyKTsKIAogICAgICAg ICB2YXIgbXV0ZUJ1dHRvbiA9IHRoaXMuY29udHJvbHMubXV0ZUJ1dHRvbiA9IGRvY3VtZW50LmNy ZWF0ZUVsZW1lbnQoJ2J1dHRvbicpOwogICAgICAgICBtdXRlQnV0dG9uLnNldEF0dHJpYnV0ZSgn cHNldWRvJywgJy13ZWJraXQtbWVkaWEtY29udHJvbHMtbXV0ZS1idXR0b24nKTsKQEAgLTkyNiw2 ICs5MjcsMTEgQEAgQ29udHJvbGxlci5wcm90b3R5cGUgPSB7CiAgICAgICAgIHJldHVybiB0cnVl OwogICAgIH0sCiAKKyAgICBoYW5kbGVNdXRlQm94T3ZlcjogZnVuY3Rpb24oZXZlbnQpCisgICAg eworICAgICAgICB0aGlzLmRyYXdWb2x1bWVCYWNrZ3JvdW5kKCk7CisgICAgfSwKKwogICAgIGhh bmRsZU1pbkJ1dHRvbkNsaWNrZWQ6IGZ1bmN0aW9uKGV2ZW50KQogICAgIHsKICAgICAgICAgaWYg KHRoaXMudmlkZW8ubXV0ZWQpIHsK