144064 2015-04-22 12:15:43 -0700 Web Inspector: Remove Reload and Download Web Archive buttons from FrameTreeElement 2015-04-25 18:36:06 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 timothy timothy graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1087519 0 timothy 2015-04-22 12:15:43 -0700 They should be global toolbar items. 1087520 1 251356 timothy 2015-04-22 12:16:44 -0700 Created attachment 251356 Patch 1087548 2 251356 joepeck 2015-04-22 13:01:42 -0700 Comment on attachment 251356 Patch r=me 1088637 3 timothy 2015-04-25 18:36:06 -0700 r183322 – r183342 http://trac.webkit.org/log/?revs=183322-183342 251356 2015-04-22 12:16:44 -0700 2015-04-22 13:01:42 -0700 Patch bug-144064-20150422121539.patch text/plain 4921 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNzk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm ZDZjZGMzOTJmYWQ1Yzk3NWZiNjg3NGNjYzNjZTg5OTc5NWY4ZGQxLi40ZDc5NjY3ODUxMzFhZjc0 YWUxMGI1OGJmOTQ5MDZjMDM3OWY3MTkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxOCBAQAogMjAxNS0wNC0yMiAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3ZlIFJlbG9hZCBhbmQgRG93bmxvYWQg V2ViIEFyY2hpdmUgYnV0dG9ucyBmcm9tIEZyYW1lVHJlZUVsZW1lbnQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDA2NAorCisgICAgICAgIFRoZSB3 aWxsIGJlIGdsb2JhbCB0b29sYmFyIGl0ZW1zIHNvb24uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0ZyYW1lVHJl ZUVsZW1lbnQuanM6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZVRyZWVF bGVtZW50LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJlc291cmNlVHJlZUVsZW1lbnQucHJv dG90eXBlLl91cGRhdGVTdGF0dXMpOgorCisyMDE1LTA0LTIyICBUaW1vdGh5IEhhdGNoZXIgIDx0 aW1vdGh5QGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZW1vdmUgdGltZSBh bmQgd2VpZ2h0IGZyb20gdGhlIGRhc2hib2FyZAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0MDYzCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0ZyYW1lVHJlZUVsZW1lbnQuanMgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9GcmFtZVRyZWVFbGVtZW50LmpzCmlu ZGV4IGFlMmJhNzk3NjhkM2FiOGEzZTdjYmFhYmY4OWVhMWUwZjMyNzc1NjAuLjNkY2Q2OGEzMTk0 MzRjY2ExM2MwNjVmZjVlMzZjMmEzY2ZmOTNjNDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0ZyYW1lVHJlZUVsZW1lbnQuanMKKysrIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRnJhbWVUcmVlRWxlbWVudC5q cwpAQCAtMTc1LDUyICsxNzUsNiBAQCBXZWJJbnNwZWN0b3IuRnJhbWVUcmVlRWxlbWVudCA9IGNs YXNzIEZyYW1lVHJlZUVsZW1lbnQgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuUmVzbwogICAgICAgICBy ZXR1cm4gYUlzUmVzb3VyY2UgPyAxIDogLTE7CiAgICAgfQogCi0gICAgLy8gQ2FsbGVkIGZyb20g UmVzb3VyY2VUcmVlRWxlbWVudC4KLQotICAgIHVwZGF0ZVN0YXR1c0Zvck1haW5GcmFtZSgpCi0g ICAgewotICAgICAgICBmdW5jdGlvbiBsb2FkZWRJbWFnZXMoKQotICAgICAgICB7Ci0gICAgICAg ICAgICBpZiAoIXRoaXMuX3JlbG9hZEJ1dHRvbiB8fCAhdGhpcy5fZG93bmxvYWRCdXR0b24pCi0g ICAgICAgICAgICAgICAgcmV0dXJuOwotCi0gICAgICAgICAgICB2YXIgZnJhZ21lbnQgPSBkb2N1 bWVudC5jcmVhdGVEb2N1bWVudEZyYWdtZW50KCJkaXYiKTsKLSAgICAgICAgICAgIGZyYWdtZW50 LmFwcGVuZENoaWxkKHRoaXMuX2Rvd25sb2FkQnV0dG9uLmVsZW1lbnQpOwotICAgICAgICAgICAg ZnJhZ21lbnQuYXBwZW5kQ2hpbGQodGhpcy5fcmVsb2FkQnV0dG9uLmVsZW1lbnQpOwotICAgICAg ICAgICAgdGhpcy5zdGF0dXMgPSBmcmFnbWVudDsKLQotICAgICAgICAgICAgZGVsZXRlIHRoaXMu X2xvYWRpbmdNYWluRnJhbWVCdXR0b25zOwotICAgICAgICB9Ci0KLSAgICAgICAgaWYgKHRoaXMu X3JlbG9hZEJ1dHRvbiAmJiB0aGlzLl9kb3dubG9hZEJ1dHRvbikgewotICAgICAgICAgICAgbG9h ZGVkSW1hZ2VzLmNhbGwodGhpcyk7Ci0gICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIH0KLQot ICAgICAgICBpZiAoIXRoaXMuX2xvYWRpbmdNYWluRnJhbWVCdXR0b25zKSB7Ci0gICAgICAgICAg ICB0aGlzLl9sb2FkaW5nTWFpbkZyYW1lQnV0dG9ucyA9IHRydWU7Ci0KLSAgICAgICAgICAgIHZh ciB0b29sdGlwOwotICAgICAgICAgICAgaWYgKFdlYkluc3BlY3Rvci5kZWJ1Z2dhYmxlVHlwZSA9 PT0gV2ViSW5zcGVjdG9yLkRlYnVnZ2FibGVUeXBlLkphdmFTY3JpcHQpCi0gICAgICAgICAgICAg ICAgdG9vbHRpcCA9IFdlYkluc3BlY3Rvci5VSVN0cmluZygiUmVzdGFydCAoJXMpIikuZm9ybWF0 KFdlYkluc3BlY3Rvci5fcmVsb2FkUGFnZUtleWJvYXJkU2hvcnRjdXQuZGlzcGxheU5hbWUpOwot ICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAgICAgIHRvb2x0aXAgPSBXZWJJbnNwZWN0b3Iu VUlTdHJpbmcoIlJlbG9hZCBwYWdlICglcylcblJlbG9hZCBpZ25vcmluZyBjYWNoZSAoJXMpIiku Zm9ybWF0KFdlYkluc3BlY3Rvci5fcmVsb2FkUGFnZUtleWJvYXJkU2hvcnRjdXQuZGlzcGxheU5h bWUsIFdlYkluc3BlY3Rvci5fcmVsb2FkUGFnZUlnbm9yaW5nQ2FjaGVLZXlib2FyZFNob3J0Y3V0 LmRpc3BsYXlOYW1lKTsKLQotICAgICAgICAgICAgd3JhcHBlZFNWR0RvY3VtZW50KHBsYXRmb3Jt SW1hZ2VQYXRoKCJSZWxvYWQuc3ZnIiksIG51bGwsIHRvb2x0aXAsIGZ1bmN0aW9uKGVsZW1lbnQp IHsKLSAgICAgICAgICAgICAgICB0aGlzLl9yZWxvYWRCdXR0b24gPSBuZXcgV2ViSW5zcGVjdG9y LlRyZWVFbGVtZW50U3RhdHVzQnV0dG9uKGVsZW1lbnQpOwotICAgICAgICAgICAgICAgIHRoaXMu X3JlbG9hZEJ1dHRvbi5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5UcmVlRWxlbWVudFN0 YXR1c0J1dHRvbi5FdmVudC5DbGlja2VkLCB0aGlzLl9yZWxvYWRQYWdlQ2xpY2tlZCwgdGhpcyk7 Ci0gICAgICAgICAgICAgICAgbG9hZGVkSW1hZ2VzLmNhbGwodGhpcyk7Ci0gICAgICAgICAgICB9 LmJpbmQodGhpcykpOwotCi0gICAgICAgICAgICB3cmFwcGVkU1ZHRG9jdW1lbnQocGxhdGZvcm1J bWFnZVBhdGgoIkRvd25sb2FkQXJyb3cuc3ZnIiksIG51bGwsIFdlYkluc3BlY3Rvci5VSVN0cmlu ZygiRG93bmxvYWQgV2ViIEFyY2hpdmUiKSwgZnVuY3Rpb24oZWxlbWVudCkgewotICAgICAgICAg ICAgICAgIHRoaXMuX2Rvd25sb2FkQnV0dG9uID0gbmV3IFdlYkluc3BlY3Rvci5UcmVlRWxlbWVu dFN0YXR1c0J1dHRvbihlbGVtZW50KTsKLSAgICAgICAgICAgICAgICB0aGlzLl9kb3dubG9hZEJ1 dHRvbi5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5UcmVlRWxlbWVudFN0YXR1c0J1dHRv bi5FdmVudC5DbGlja2VkLCB0aGlzLl9kb3dubG9hZEJ1dHRvbkNsaWNrZWQsIHRoaXMpOwotICAg ICAgICAgICAgICAgIHRoaXMuX3VwZGF0ZURvd25sb2FkQnV0dG9uKCk7Ci0gICAgICAgICAgICAg ICAgbG9hZGVkSW1hZ2VzLmNhbGwodGhpcyk7Ci0gICAgICAgICAgICB9LmJpbmQodGhpcykpOwot ICAgICAgICB9Ci0gICAgfQotCiAgICAgLy8gT3ZlcnJpZGVzIGZyb20gVHJlZUVsZW1lbnQgKFBy aXZhdGUpLgogCiAgICAgb25wb3B1bGF0ZSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZVRyZWVFbGVtZW50LmpzIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVzb3VyY2VUcmVlRWxlbWVudC5q cwppbmRleCBlODg4ZTgxYjY4Y2EyY2Y4NjAwNzRhNGQyOTYzNTBkYTA0NzYwZmM2Li43YmZkMGQw ZTIzZWMxZTliYTg4MjMyNTExOTU0MDc3NDE1ODUyOTM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZVRyZWVFbGVtZW50LmpzCisr KyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlVHJl ZUVsZW1lbnQuanMKQEAgLTE2MCwxMiArMTYwLDggQEAgV2ViSW5zcGVjdG9yLlJlc291cmNlVHJl ZUVsZW1lbnQgPSBjbGFzcyBSZXNvdXJjZVRyZWVFbGVtZW50IGV4dGVuZHMgV2ViSW5zcGVjdG8K ICAgICAgICAgICAgIHRoaXMucmVtb3ZlQ2xhc3NOYW1lKFdlYkluc3BlY3Rvci5SZXNvdXJjZVRy ZWVFbGVtZW50LkZhaWxlZFN0eWxlQ2xhc3NOYW1lKTsKIAogICAgICAgICBpZiAodGhpcy5fcmVz b3VyY2UuZmluaXNoZWQgfHwgdGhpcy5fcmVzb3VyY2UuZmFpbGVkKSB7Ci0gICAgICAgICAgICAv LyBSZW1vdmUgdGhlIHNwaW5uZXIgYW5kIHJlcGxhY2Ugd2l0aCBhIHJlbG9hZCBidXR0b24gaW4g Y2FzZSBpdCdzIHRoZSBtYWluIGZyYW1lJ3MgbWFpbiByZXNvdXJjZS4KLSAgICAgICAgICAgIHZh ciBmcmFtZSA9IHRoaXMuX3Jlc291cmNlLnBhcmVudEZyYW1lOwotICAgICAgICAgICAgaWYgKHRo aXMuX3Jlc291cmNlLmlzTWFpblJlc291cmNlKCkgJiYgZnJhbWUgJiYgZnJhbWUuaXNNYWluRnJh bWUoKSAmJiB0aGlzIGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLkZyYW1lVHJlZUVsZW1lbnQpCi0g ICAgICAgICAgICAgICAgdGhpcy51cGRhdGVTdGF0dXNGb3JNYWluRnJhbWUoKTsKLSAgICAgICAg ICAgIGVsc2UKLSAgICAgICAgICAgICAgICB0aGlzLnN0YXR1cyA9ICIiOworICAgICAgICAgICAg Ly8gUmVtb3ZlIHRoZSBzcGlubmVyLgorICAgICAgICAgICAgdGhpcy5zdGF0dXMgPSAiIjsKICAg ICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgIHZhciBzcGlubmVyID0gbmV3IFdlYkluc3BlY3Rv ci5JbmRldGVybWluYXRlUHJvZ3Jlc3NTcGlubmVyOwogICAgICAgICAgICAgdGhpcy5zdGF0dXMg PSBzcGlubmVyLmVsZW1lbnQ7Cg==