144059 2015-04-22 11:48:17 -0700 [CMake] Use lowercase for local variables in macros 2015-04-22 12:02:48 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Trivial --- 144060 1 mcatanzaro mcatanzaro commit-queue mcatanzaro oldest_to_newest 1087485 0 mcatanzaro 2015-04-22 11:48:17 -0700 Requested by Martin Robinson, we should use lowercase for local variables inside macros in WebKitFeatures.cmake, as we do in WebKitMacros.cmake. 1087486 1 251347 mcatanzaro 2015-04-22 11:50:06 -0700 Created attachment 251347 Patch 1087488 2 251347 mrobinson 2015-04-22 11:51:24 -0700 Comment on attachment 251347 Patch Thanks for the cleanup! 1087489 3 mcatanzaro 2015-04-22 11:53:19 -0700 Committed r183116: <http://trac.webkit.org/changeset/183116> 1087493 4 commit-queue 2015-04-22 11:59:01 -0700 Re-opened since this is blocked by bug 144060 1087501 5 251347 mcatanzaro 2015-04-22 12:02:44 -0700 Comment on attachment 251347 Patch Clearing flags on attachment: 251347 Committed r183120: <http://trac.webkit.org/changeset/183120> 1087502 6 mcatanzaro 2015-04-22 12:02:48 -0700 All reviewed patches have been landed. Closing bug. 251347 2015-04-22 11:50:06 -0700 2015-04-22 12:02:44 -0700 Patch bug-144059-20150422134902.patch text/plain 3011 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzMTE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k ZXggNTRmZTMyNzY2ZWVjMTRmZGM5MjdkMDgzZTUyYzhmZDYwNTJhMmEzZi4uNDIzODUyZWM3OTky MmJlMzc0MzUzNWI2MzdhMzU0M2NmNGUxMTgzOCAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr ZQpAQCAtMTY4LDkgKzE2OCw5IEBAIG1hY3JvKFdFQktJVF9PUFRJT05fRU5EKQogICAgIGxpc3Qo U09SVCBfV0VCS0lUX0FWQUlMQUJMRV9PUFRJT05TKQogICAgIHNldChfTUFYX0ZFQVRVUkVfTEVO R1RIIDApCiAgICAgZm9yZWFjaCAoX25hbWUgJHtfV0VCS0lUX0FWQUlMQUJMRV9PUFRJT05TfSkK LSAgICAgICAgc3RyaW5nKExFTkdUSCAke19uYW1lfSBfTkFNRV9MRU5HVEgpCi0gICAgICAgIGlm IChfTkFNRV9MRU5HVEggR1JFQVRFUiBfTUFYX0ZFQVRVUkVfTEVOR1RIKQotICAgICAgICAgICAg c2V0KF9NQVhfRkVBVFVSRV9MRU5HVEggJHtfTkFNRV9MRU5HVEh9KQorICAgICAgICBzdHJpbmco TEVOR1RIICR7X25hbWV9IF9uYW1lX2xlbmd0aCkKKyAgICAgICAgaWYgKF9uYW1lX2xlbmd0aCBH UkVBVEVSIF9NQVhfRkVBVFVSRV9MRU5HVEgpCisgICAgICAgICAgICBzZXQoX01BWF9GRUFUVVJF X0xFTkdUSCAke19uYW1lX2xlbmd0aH0pCiAgICAgICAgIGVuZGlmICgpCiAKICAgICAgICAgb3B0 aW9uKCR7X25hbWV9ICIke19XRUJLSVRfQVZBSUxBQkxFX09QVElPTlNfREVTQ1JJUFRJT05fJHtf bmFtZX19IiAke19XRUJLSVRfQVZBSUxBQkxFX09QVElPTlNfSU5JVElBTF9WQUxVRV8ke19uYW1l fX0pCkBAIC0xOTUsMjUgKzE5NSwyNSBAQCBlbmRtYWNybygpCiBtYWNybyhQUklOVF9XRUJLSVRf T1BUSU9OUykKICAgICBtZXNzYWdlKFNUQVRVUyAiRW5hYmxlZCBmZWF0dXJlczoiKQogCi0gICAg c2V0KF9TSE9VTERfUFJJTlRfRE9UUyBPTikKKyAgICBzZXQoX3Nob3VsZF9wcmludF9kb3RzIE9O KQogICAgIGZvcmVhY2ggKF9uYW1lICR7X1dFQktJVF9BVkFJTEFCTEVfT1BUSU9OU30pCiAgICAg ICAgIGlmICgke19XRUJLSVRfQVZBSUxBQkxFX09QVElPTlNfSVNfUFVCTElDXyR7X25hbWV9fSkK LSAgICAgICAgICAgIHN0cmluZyhMRU5HVEggJHtfbmFtZX0gX05BTUVfTEVOR1RIKQotICAgICAg ICAgICAgc2V0KF9NRVNTQUdFICIgJHtfbmFtZX0gIikKKyAgICAgICAgICAgIHN0cmluZyhMRU5H VEggJHtfbmFtZX0gX25hbWVfbGVuZ3RoKQorICAgICAgICAgICAgc2V0KF9tZXNzYWdlICIgJHtf bmFtZX0gIikKIAogICAgICAgICAgICAgIyBQcmludCBkb3RzIG9uIGV2ZXJ5IG90aGVyIHJvdywg Zm9yIHJlYWRhYmlsaXR5LgotICAgICAgICAgICAgZm9yZWFjaCAoSUdOT1JFIFJBTkdFICR7X05B TUVfTEVOR1RIfSAke19NQVhfRkVBVFVSRV9MRU5HVEh9KQotICAgICAgICAgICAgICAgIGlmICgk e19TSE9VTERfUFJJTlRfRE9UU30pCi0gICAgICAgICAgICAgICAgICAgIHNldChfTUVTU0FHRSAi JHtfTUVTU0FHRX0uIikKKyAgICAgICAgICAgIGZvcmVhY2ggKElHTk9SRSBSQU5HRSAke19uYW1l X2xlbmd0aH0gJHtfTUFYX0ZFQVRVUkVfTEVOR1RIfSkKKyAgICAgICAgICAgICAgICBpZiAoJHtf c2hvdWxkX3ByaW50X2RvdHN9KQorICAgICAgICAgICAgICAgICAgICBzZXQoX21lc3NhZ2UgIiR7 X21lc3NhZ2V9LiIpCiAgICAgICAgICAgICAgICAgZWxzZSAoKQotICAgICAgICAgICAgICAgICAg ICBzZXQoX01FU1NBR0UgIiR7X01FU1NBR0V9ICIpCisgICAgICAgICAgICAgICAgICAgIHNldChf bWVzc2FnZSAiJHtfbWVzc2FnZX0gIikKICAgICAgICAgICAgICAgICBlbmRpZiAoKQogICAgICAg ICAgICAgZW5kZm9yZWFjaCAoKQogCi0gICAgICAgICAgICBzZXQoX1NIT1VMRF9QUklOVF9ET1RT IChOT1QgJHtfU0hPVUxEX1BSSU5UX0RPVFN9KSkKKyAgICAgICAgICAgIHNldChfc2hvdWxkX3By aW50X2RvdHMgKE5PVCAke19zaG91bGRfcHJpbnRfZG90c30pKQogCi0gICAgICAgICAgICBzZXQo X01FU1NBR0UgIiR7X01FU1NBR0V9ICR7JHtfbmFtZX19IikKLSAgICAgICAgICAgIG1lc3NhZ2Uo U1RBVFVTICIke19NRVNTQUdFfSIpCisgICAgICAgICAgICBzZXQoX21lc3NhZ2UgIiR7X21lc3Nh Z2V9ICR7JHtfbmFtZX19IikKKyAgICAgICAgICAgIG1lc3NhZ2UoU1RBVFVTICIke19tZXNzYWdl fSIpCiAgICAgICAgIGVuZGlmICgpCiAgICAgZW5kZm9yZWFjaCAoKQogZW5kbWFjcm8oKQpkaWZm IC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IGU5NTViZDBlNTgxMTI1ODUyMzRk OTQ2ZDYxNDM1ZGRiY2RiN2JjMzAuLjdlYWIxMjgyMWM0N2RhZWU3MDk3MmNjYzZkOTM1YWNlNjNk NTcxMWQgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwx NiBAQAogMjAxNS0wNC0yMiAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5j b20+CiAKKyAgICAgICAgW0NNYWtlXSBVc2UgbG93ZXJjYXNlIGZvciBsb2NhbCB2YXJpYWJsZXMg aW4gbWFjcm9zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDQwNTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBDb252ZXJ0IHNvbWUgdmFyaWFibGUgbmFtZXMgdG8gbG93ZXJjYXNlLgorCisgICAgICAgICog U291cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVzLmNtYWtlOgorCisyMDE1LTA0LTIyICBNaWNoYWVs IENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKwogICAgICAgICBbQ01ha2VdIEZl YXR1cmVzIGxpc3Qgc2hvdWxkIHByaW50IGRvdHMgZXZlcnkgb3RoZXIgcm93CiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM4MzIKIAo=