144053 2015-04-22 11:06:45 -0700 Web Inspector: Fix an exception preventing switching timelines 2015-04-22 12:02:17 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1087459 0 timothy 2015-04-22 11:06:45 -0700 Switching timelines is sometimes throwing an exception, preventing the timeline view from changing back to the overview view. This is a latent bug exposed by switching to ES6 classes / strict mode. 1087460 1 webkit-bug-importer 2015-04-22 11:07:28 -0700 <rdar://problem/20653689> 1087462 2 251339 timothy 2015-04-22 11:09:43 -0700 Created attachment 251339 Patch 1087499 3 251339 commit-queue 2015-04-22 12:02:14 -0700 Comment on attachment 251339 Patch Clearing flags on attachment: 251339 Committed r183119: <http://trac.webkit.org/changeset/183119> 1087500 4 commit-queue 2015-04-22 12:02:17 -0700 All reviewed patches have been landed. Closing bug. 251339 2015-04-22 11:09:43 -0700 2015-04-22 12:02:14 -0700 Patch bug-144053-20150422110839.patch text/plain 3123 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNzk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm ZDlkZTc5NDViYjIxMzEyNzVlNGJkMzU1YmI2ZmQ2ZDA5Mzc1MDQ0Li5kZjVhNGYwMTI2NmI3ZWJl YTJhNjU1Y2ZmNTdhZjMzM2M5NjIyYzk1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNS0wNC0yMiAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRml4IGFuIGV4Y2VwdGlvbiBwcmV2ZW50aW5n IHN3aXRjaGluZyB0aW1lbGluZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0NDA1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UcmVlT3V0bGluZS5qczoKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5UcmVlRWxlbWVudC5wcm90b3R5cGUuc2VsZWN0KTogU3RvcmUgdHJl ZU91dGxpbmUgaW4gYSBsb2NhbCBzbworICAgICAgICB3ZSBoYXZlIGEgcmVmZXJlbmNlIHRvIGl0 IHdoZW4gd2UgZ28gdG8gcmVzZXQgcHJvY2Vzc2luZ1NlbGVjdGlvbkNoYW5nZS4KKyAgICAgICAg VGhlIGNhbGxzIHRvIG9uc2VsZWN0IHdhcyByZW1vdmluZyB0aGUgdHJlZSBlbGVtZW50IGZyb20g dGhlIG91dGxpbmUsIGNhdXNpbmcKKyAgICAgICAgImRlbGV0ZSB0aGlzLnRyZWVPdXRsaW5lLnBy b2Nlc3NpbmdTZWxlY3Rpb25DaGFuZ2UiIHRvIHRocm93IGFuIGV4Y2VwdGlvbi4KKyAgICAgICAg VGhpcyBwYXRjaCBjaGFuZ2VzIHRoZSBkZWxldGUgdG8gYSBzZXQgdG8gZmFsc2UgZm9yIGdvb2Qg bWVhc3VyZSB0b28uCisKIDIwMTUtMDQtMTggIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBw bGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IERpc2FibGUgZ2xvYmFsIGtleWJvYXJk IHNob3J0Y3V0cyBmb3IgYmFja2dyb3VuZCB0YWJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UcmVlT3V0bGluZS5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVPdXRsaW5lLmpzCmluZGV4IGQ5ZjU0 NjM0NzAwNTQ2MWNjNmRiM2ZiOGZmNzBkYjBiM2I3YzQ1N2IuLmI0NmQxODg1Mzk0MjAyOWZjOTg3 MzA3YTNhZmZmY2IzNjMzMGEyNzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVPdXRsaW5lLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVPdXRsaW5lLmpzCkBAIC05NzQsMTcgKzk3NCwx OCBAQCBXZWJJbnNwZWN0b3IuVHJlZUVsZW1lbnQgPSBjbGFzcyBUcmVlRWxlbWVudCBleHRlbmRz IFdlYkluc3BlY3Rvci5PYmplY3QKICAgICAgICAgICAgIHRoaXMudHJlZU91dGxpbmUuX2NoaWxk cmVuTGlzdE5vZGUuZm9jdXMoKTsKIAogICAgICAgICAvLyBGb2N1c2luZyBvbiBhbm90aGVyIG5v ZGUgbWF5IGRldGFjaCAidGhpcyIgZnJvbSB0cmVlLgotICAgICAgICBpZiAoIXRoaXMudHJlZU91 dGxpbmUpCisgICAgICAgIHZhciB0cmVlT3V0bGluZSA9IHRoaXMudHJlZU91dGxpbmU7CisgICAg ICAgIGlmICghdHJlZU91dGxpbmUpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgdGhp cy50cmVlT3V0bGluZS5wcm9jZXNzaW5nU2VsZWN0aW9uQ2hhbmdlID0gdHJ1ZTsKKyAgICAgICAg dHJlZU91dGxpbmUucHJvY2Vzc2luZ1NlbGVjdGlvbkNoYW5nZSA9IHRydWU7CiAKICAgICAgICAg aWYgKCF0aGlzLnNlbGVjdGVkKSB7Ci0gICAgICAgICAgICBpZiAodGhpcy50cmVlT3V0bGluZS5z ZWxlY3RlZFRyZWVFbGVtZW50KQotICAgICAgICAgICAgICAgIHRoaXMudHJlZU91dGxpbmUuc2Vs ZWN0ZWRUcmVlRWxlbWVudC5kZXNlbGVjdChzdXBwcmVzc09uRGVzZWxlY3QpOworICAgICAgICAg ICAgaWYgKHRyZWVPdXRsaW5lLnNlbGVjdGVkVHJlZUVsZW1lbnQpCisgICAgICAgICAgICAgICAg dHJlZU91dGxpbmUuc2VsZWN0ZWRUcmVlRWxlbWVudC5kZXNlbGVjdChzdXBwcmVzc09uRGVzZWxl Y3QpOwogCiAgICAgICAgICAgICB0aGlzLnNlbGVjdGVkID0gdHJ1ZTsKLSAgICAgICAgICAgIHRo aXMudHJlZU91dGxpbmUuc2VsZWN0ZWRUcmVlRWxlbWVudCA9IHRoaXM7CisgICAgICAgICAgICB0 cmVlT3V0bGluZS5zZWxlY3RlZFRyZWVFbGVtZW50ID0gdGhpczsKIAogICAgICAgICAgICAgaWYg KHRoaXMuX2xpc3RJdGVtTm9kZSkKICAgICAgICAgICAgICAgICB0aGlzLl9saXN0SXRlbU5vZGUu Y2xhc3NMaXN0LmFkZCgic2VsZWN0ZWQiKTsKQEAgLTk5MywxMCArOTk0LDEwIEBAIFdlYkluc3Bl Y3Rvci5UcmVlRWxlbWVudCA9IGNsYXNzIFRyZWVFbGVtZW50IGV4dGVuZHMgV2ViSW5zcGVjdG9y Lk9iamVjdAogICAgICAgICBpZiAodGhpcy5vbnNlbGVjdCAmJiAhc3VwcHJlc3NPblNlbGVjdCkK ICAgICAgICAgICAgIHRoaXMub25zZWxlY3QodGhpcywgc2VsZWN0ZWRCeVVzZXIpOwogCi0gICAg ICAgIGlmICh0aGlzLnRyZWVPdXRsaW5lLm9uc2VsZWN0ICYmICFzdXBwcmVzc09uU2VsZWN0KQot ICAgICAgICAgICAgdGhpcy50cmVlT3V0bGluZS5vbnNlbGVjdCh0aGlzLCBzZWxlY3RlZEJ5VXNl cik7CisgICAgICAgIGlmICh0cmVlT3V0bGluZS5vbnNlbGVjdCAmJiAhc3VwcHJlc3NPblNlbGVj dCkKKyAgICAgICAgICAgIHRyZWVPdXRsaW5lLm9uc2VsZWN0KHRoaXMsIHNlbGVjdGVkQnlVc2Vy KTsKIAotICAgICAgICBkZWxldGUgdGhpcy50cmVlT3V0bGluZS5wcm9jZXNzaW5nU2VsZWN0aW9u Q2hhbmdlOworICAgICAgICB0cmVlT3V0bGluZS5wcm9jZXNzaW5nU2VsZWN0aW9uQ2hhbmdlID0g ZmFsc2U7CiAgICAgfQogCiAgICAgcmV2ZWFsQW5kU2VsZWN0KG9taXRGb2N1cywgc2VsZWN0ZWRC eVVzZXIsIHN1cHByZXNzT25TZWxlY3QsIHN1cHByZXNzT25EZXNlbGVjdCkK