144023 2015-04-21 17:27:26 -0700 [Mac][MediaSource] Crash when SourceBuffer::provideMediaData() is called re-entrantly. 2015-04-22 21:32:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble ap commit-queue eric.carlson webkit-bug-importer oldest_to_newest 1087234 0 jer.noble 2015-04-21 17:27:26 -0700 [Mac][MediaSource] Crash when SourceBuffer::provideMediaData() is called re-entrantly. 1087235 1 jer.noble 2015-04-21 17:29:15 -0700 rdar://problem/20643421 1087244 2 251280 jer.noble 2015-04-21 17:42:24 -0700 Created attachment 251280 Patch 1087319 3 251280 commit-queue 2015-04-21 22:11:48 -0700 Comment on attachment 251280 Patch Clearing flags on attachment: 251280 Committed r183097: <http://trac.webkit.org/changeset/183097> 1087320 4 commit-queue 2015-04-21 22:11:56 -0700 All reviewed patches have been landed. Closing bug. 1087606 5 jer.noble 2015-04-22 15:22:44 -0700 Did not completely fix the crash; re-opening. 1087649 6 251388 jer.noble 2015-04-22 17:06:15 -0700 Created attachment 251388 Patch 1087719 7 251388 commit-queue 2015-04-22 21:32:55 -0700 Comment on attachment 251388 Patch Clearing flags on attachment: 251388 Committed r183167: <http://trac.webkit.org/changeset/183167> 1087720 8 commit-queue 2015-04-22 21:32:59 -0700 All reviewed patches have been landed. Closing bug. 251280 2015-04-21 17:42:24 -0700 2015-04-22 17:06:13 -0700 Patch bug-144023-20150421174121.patch text/plain 2676 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzMDc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWNkYmFjZGQyZjhmNGNj MjUyYzY4ZmI1OTdiNTA0OWI1NzQxODkwNS4uZGMyNGNmYzM4YWQxNjUxNWZkZThjOWJkY2IzZWNi OTFjMGJhZTBhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTA0LTIxICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdW01lZGlhU291cmNl XSBDcmFzaCB3aGVuIFNvdXJjZUJ1ZmZlcjo6cHJvdmlkZU1lZGlhRGF0YSgpIGlzIGNhbGxlZCBy ZS1lbnRyYW50bHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDQwMjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBGaXhlcyBub24tZGV0ZXJtaW5pc3RpYyBjcmFzaCBpbiBtZWRpYS9tZWRpYS1zb3VyY2Uv bWVkaWEtc291cmNlLXN0YWxsZWQtaG9sZHMtc2xlZXAtYXNzZXJ0aW9uLmh0bWwuCisKKyAgICAg ICAgUGxhdGZvcm0gY2hhbmdlcyBoYXZlIGludHJvZHVjZWQgYSByZS1lbnRyYW5jeSB0byBwcm92 aWRlTWVkaWFEYXRhKCkuICBDYWxsaW5nCisgICAgICAgIFNvdXJjZUJ1ZmZlclByaXZhdGU6OmVu cXVldWVTYW1wbGUoKSBjYW4gcmVzdWx0IGluIGEgcmUtZW50cmFudCBjYWxsIGJhY2sgaW50bwor ICAgICAgICBTb3VyY2VCdWZmZXI6OnByb3ZpZGVNZWRpYURhdGEoKS4gVG8gcHJvdGVjdCBhZ2Fp bnN0IHRoaXMsIHdyYXAgdGhlIGNsaWVudCBjYWxsCisgICAgICAgIGZyb20gU291cmNlQnVmZmVy UHJpdmF0ZUFWRk9iakM6OmRpZEJlY29tZVJlYWR5Rm9yTW9yZVNhbXBsZXMoKSB0bworICAgICAg ICBTb3VyY2VCdWZmZXI6OnNvdXJjZUJ1ZmZlclByaXZhdGVEaWRCZWNvbWVSZWFkeUZvck1vcmVT YW1wbGVzKCkgaW4gYSBkaXNwYXRjaF9hc3luYygpIHRvIHRoZQorICAgICAgICBtYWluIHRocmVh ZC4gVGhpcyBnaXZlcyB0aGUgb3JpZ2luYWwgcHJvdmlkZU1lZGlhRGF0YSgpIGEgY2hhbmNlIHRv IGZpbmlzaCBiZWZvcmUgdGhlIG5leHQKKyAgICAgICAgb25lIGJlZ2lucy4KKworICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL1NvdXJjZUJ1ZmZlclByaXZhdGVB VkZPYmpDLm1tOgorICAgICAgICAoV2ViQ29yZTo6U291cmNlQnVmZmVyUHJpdmF0ZUFWRk9iakM6 OmRpZEJlY29tZVJlYWR5Rm9yTW9yZVNhbXBsZXMpOgorCiAyMDE1LTA0LTIxICBCcmVudCBGdWxn aGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIENvbnRleHQgbWVudSBkb2Vzbid0 IGFjY291bnQgZm9yIHNlbGVjdGlvbiBzZW1hbnRpY3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL1NvdXJjZUJ1ZmZlclByaXZh dGVBVkZPYmpDLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0 aW9uL29iamMvU291cmNlQnVmZmVyUHJpdmF0ZUFWRk9iakMubW0KaW5kZXggM2E1NDEyMmFhYmQz NTc0MGNmMWQ4MzczMjg0NzRkMDdjMGYwMGZhNi4uM2I1OTBjOTZkOTlhYmJlYTQ2NDA4ZDZkNDNj ZmMyNGRiMmE1ODY1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvYXZmb3VuZGF0aW9uL29iamMvU291cmNlQnVmZmVyUHJpdmF0ZUFWRk9iakMubW0KKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvU291cmNl QnVmZmVyUHJpdmF0ZUFWRk9iakMubW0KQEAgLTEwODcsOCArMTA4NywxMyBAQCB2b2lkIFNvdXJj ZUJ1ZmZlclByaXZhdGVBVkZPYmpDOjpkaWRCZWNvbWVSZWFkeUZvck1vcmVTYW1wbGVzKGludCB0 cmFja0lEKQogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgaWYgKG1fY2xpZW50KQotICAg ICAgICBtX2NsaWVudC0+c291cmNlQnVmZmVyUHJpdmF0ZURpZEJlY29tZVJlYWR5Rm9yTW9yZVNh bXBsZXModGhpcywgQXRvbWljU3RyaW5nOjpudW1iZXIodHJhY2tJRCkpOworICAgIC8vIEZJWE1F KHJkYXI6Ly9wcm9ibGVtLzIwNjM1OTY5KTogUmVtb3ZlIHRoaXMgZGlzcGF0Y2hfYXN5bmMoKSB3 aGVuIHRoZSBhZm9yZW1lbnRpb25lZCByYWRhciBpcyByZXNvbHZlZAorICAgIGF1dG8gd2Vha1Ro aXMgPSBjcmVhdGVXZWFrUHRyKCk7CisgICAgZGlzcGF0Y2hfYXN5bmMoZGlzcGF0Y2hfZ2V0X21h aW5fcXVldWUoKSwgW3dlYWtUaGlzLCB0cmFja0lEXSB7CisgICAgICAgIGlmICghd2Vha1RoaXMg fHwgIXdlYWtUaGlzLT5tX2NsaWVudCkKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgd2Vh a1RoaXMtPm1fY2xpZW50LT5zb3VyY2VCdWZmZXJQcml2YXRlRGlkQmVjb21lUmVhZHlGb3JNb3Jl U2FtcGxlcyh3ZWFrVGhpcy5nZXQoKSwgQXRvbWljU3RyaW5nOjpudW1iZXIodHJhY2tJRCkpOwor ICAgIH0pOwogfQogCiB2b2lkIFNvdXJjZUJ1ZmZlclByaXZhdGVBVkZPYmpDOjpub3RpZnlDbGll bnRXaGVuUmVhZHlGb3JNb3JlU2FtcGxlcyhBdG9taWNTdHJpbmcgdHJhY2tJRFN0cmluZykK 251388 2015-04-22 17:06:15 -0700 2015-04-22 21:32:55 -0700 Patch bug-144023-20150422170511.patch text/plain 4592 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzMTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDg0ZDE1Y2Q1YzlhN2Fh MjdkYzIyZjRkZmYyNmE2NWZiMmUzMDg0ZC4uNjE0Mzk2MGU3MTkzZTY5ZTdmNjE3NzI1OGUxZWQ3 Mzk1YmM4MzI2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE1LTA0LTIyICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCisgICAgICAgIFtNYWNdW01lZGlhU291cmNl XSBDcmFzaCB3aGVuIFNvdXJjZUJ1ZmZlcjo6cHJvdmlkZU1lZGlhRGF0YSgpIGlzIGNhbGxlZCBy ZS1lbnRyYW50bHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDQwMjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBQYXJ0aWFsbHkgcmV2ZXJ0IHIxODMwOTcgKGFzIGl0IHdhcyBub3Qgc3VmZmljaWVudCB0 byBwcm90ZWN0IGFnYWluc3QgcmUtZW50cmFuY3kpLiBJbnN0ZWFkLAorICAgICAgICBwcm90ZWN0 IGFnYWluc3QgcmUtZW50cmFuY3kgaW4gcHJvdmlkZU1lZGlhRGF0YSgpIGRpcmVjdGx5IGJ5IHJl bW92aW5nIHRoZSBmaXJzdCBzYW1wbGUKKyAgICAgICAgZnJvbSB0aGUgVHJhY2tCdWZmZXIncyBk ZWNvZGVRdWV1ZSBhdCBhIHRpbWUuIElmIHByb3ZpZGVNZWRpYURhdGEoKSBpcyBjYWxsZWQgcmUt ZW50cmFudGx5LAorICAgICAgICBvciBpZiBhbnkgb3RoZXIgbWV0aG9kIHdoaWNoIG1vZGlmaWVz IHRoZSBkZWNvZGVRdWV1ZSBpcyBjYWxsZWQgZnJvbSBpbnNpZGUKKyAgICAgICAgcHJvdmlkZU1l ZGlhRGF0YSwgbm8gaXRlcmF0b3JzIHdpbGwgYmUgaW52YWxpZGF0ZWQuCisKKyAgICAgICAgKiBN b2R1bGVzL21lZGlhc291cmNlL1NvdXJjZUJ1ZmZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpT b3VyY2VCdWZmZXI6OnByb3ZpZGVNZWRpYURhdGEpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2F2Zm91bmRhdGlvbi9vYmpjL1NvdXJjZUJ1ZmZlclByaXZhdGVBVkZPYmpDLm1tOgorICAg ICAgICAoV2ViQ29yZTo6U291cmNlQnVmZmVyUHJpdmF0ZUFWRk9iakM6OmRpZEJlY29tZVJlYWR5 Rm9yTW9yZVNhbXBsZXMpOgorCisyMDE1LTA0LTIyICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBw bGUuY29tPgorCiAgICAgICAgIEFkZCBuZXcgb3B0aW1pemVkIGZ1bGxzY3JlZW4gZGVsZWdhdGUg bWV0aG9kcwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQ0MDcxCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2Uv U291cmNlQnVmZmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvU291 cmNlQnVmZmVyLmNwcAppbmRleCA3MDE5YzQ3NTA4NzNmOTc1NDFiMzFkZTc3MmFmYmMzMzA2ZDIy NjVkLi4xYjY2NTc3MDlmOTEzMzgyMGUxOWUwZDYzOGU0OGI5MWJjMjcxYTg5IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc291cmNlL1NvdXJjZUJ1ZmZlci5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNvdXJjZS9Tb3VyY2VCdWZmZXIuY3BwCkBA IC0xNzkzLDE0ICsxNzkzLDE4IEBAIHZvaWQgU291cmNlQnVmZmVyOjpwcm92aWRlTWVkaWFEYXRh KFRyYWNrQnVmZmVyJiB0cmFja0J1ZmZlciwgQXRvbWljU3RyaW5nIHRyYWNrCiAgICAgdW5zaWdu ZWQgZW5xdWV1ZWRTYW1wbGVzID0gMDsKICNlbmRpZgogCi0gICAgYXV0byBzYW1wbGVJdCA9IHRy YWNrQnVmZmVyLmRlY29kZVF1ZXVlLmJlZ2luKCk7Ci0gICAgZm9yIChhdXRvIHNhbXBsZUVuZCA9 IHRyYWNrQnVmZmVyLmRlY29kZVF1ZXVlLmVuZCgpOyBzYW1wbGVJdCAhPSBzYW1wbGVFbmQ7ICsr c2FtcGxlSXQpIHsKKyAgICB3aGlsZSAoIXRyYWNrQnVmZmVyLmRlY29kZVF1ZXVlLmVtcHR5KCkp IHsKICAgICAgICAgaWYgKCFtX3ByaXZhdGUtPmlzUmVhZHlGb3JNb3JlU2FtcGxlcyh0cmFja0lE KSkgewogICAgICAgICAgICAgbV9wcml2YXRlLT5ub3RpZnlDbGllbnRXaGVuUmVhZHlGb3JNb3Jl U2FtcGxlcyh0cmFja0lEKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAKLSAgICAg ICAgUmVmUHRyPE1lZGlhU2FtcGxlPiBzYW1wbGUgPSBzYW1wbGVJdC0+c2Vjb25kOworICAgICAg ICAvLyBGSVhNRShyZGFyOi8vcHJvYmxlbS8yMDYzNTk2OSk6IFJlbW92ZSB0aGlzIHJlLWVudHJh bmN5IHByb3RlY3Rpb24gd2hlbiB0aGUgYWZvcmVtZW50aW9uZWQgcmFkYXIgaXMgcmVzb2x2ZWQ7 IHByb3RlY3RpbmcKKyAgICAgICAgLy8gYWdhaW5zdCByZS1lbnRyYW5jeSBpbnRyb2R1Y2VzIGEg c21hbGwgaW5lZmZpY2VuY3kgd2hlbiByZW1vdmluZyBhcHBlbmRlZCBzYW1wbGVzIGZyb20gdGhl IGRlY29kZSBxdWV1ZSBvbmUgYXQgYSB0aW1lCisgICAgICAgIC8vIHJhdGhlciB0aGFuIHdoZW4g YWxsIHNhbXBsZXMgaGF2ZSBiZWVuIGVucXVldWVkLgorICAgICAgICBSZWZQdHI8TWVkaWFTYW1w bGU+IHNhbXBsZSA9IHRyYWNrQnVmZmVyLmRlY29kZVF1ZXVlLmJlZ2luKCktPnNlY29uZDsKKyAg ICAgICAgdHJhY2tCdWZmZXIuZGVjb2RlUXVldWUuZXJhc2UodHJhY2tCdWZmZXIuZGVjb2RlUXVl dWUuYmVnaW4oKSk7CisKICAgICAgICAgLy8gRG8gbm90IGVucXVldWUgc2FtcGxlcyBzcGFubmlu ZyBhIHNpZ25pZmljYW50IHVuYnVmZmVyZWQgZ2FwLgogICAgICAgICAvLyBOT1RFOiBvbmUgc2Vj b25kIGlzIHNvbWV3aGF0IGFyYml0cmFyeS4gTWVkaWFTb3VyY2U6Om1vbml0b3JTb3VyY2VCdWZm ZXJzKCkgaXMgcnVuCiAgICAgICAgIC8vIG9uIHRoZSBwbGF5YmFja1RpbWVyLCB3aGljaCBpcyBl ZmZlY3RpdmVseSBldmVyeSAzNTBtcy4gQWxsb3dpbmcgPiAzNTBtcyBnYXAgYmV0d2VlbgpAQCAt MTgxOCw5ICsxODIyLDcgQEAgdm9pZCBTb3VyY2VCdWZmZXI6OnByb3ZpZGVNZWRpYURhdGEoVHJh Y2tCdWZmZXImIHRyYWNrQnVmZmVyLCBBdG9taWNTdHJpbmcgdHJhY2sKICNpZiAhTE9HX0RJU0FC TEVECiAgICAgICAgICsrZW5xdWV1ZWRTYW1wbGVzOwogI2VuZGlmCi0KICAgICB9Ci0gICAgdHJh Y2tCdWZmZXIuZGVjb2RlUXVldWUuZXJhc2UodHJhY2tCdWZmZXIuZGVjb2RlUXVldWUuYmVnaW4o KSwgc2FtcGxlSXQpOwogCiAgICAgTE9HKE1lZGlhU291cmNlLCAiU291cmNlQnVmZmVyOjpwcm92 aWRlTWVkaWFEYXRhKCVwKSAtIEVucXVldWVkICV1IHNhbXBsZXMiLCB0aGlzLCBlbnF1ZXVlZFNh bXBsZXMpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv YXZmb3VuZGF0aW9uL29iamMvU291cmNlQnVmZmVyUHJpdmF0ZUFWRk9iakMubW0gYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9Tb3VyY2VCdWZmZXJQ cml2YXRlQVZGT2JqQy5tbQppbmRleCAzYjU5MGM5NmQ5OWFiYmVhNDY0MDhkNmQ0M2NmYzI0ZGIy YTU4NjVmLi4zYTU0MTIyYWFiZDM1NzQwY2YxZDgzNzMyODQ3NGQwN2MwZjAwZmE2IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9T b3VyY2VCdWZmZXJQcml2YXRlQVZGT2JqQy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9Tb3VyY2VCdWZmZXJQcml2YXRlQVZGT2JqQy5t bQpAQCAtMTA4NywxMyArMTA4Nyw4IEBAIHZvaWQgU291cmNlQnVmZmVyUHJpdmF0ZUFWRk9iakM6 OmRpZEJlY29tZVJlYWR5Rm9yTW9yZVNhbXBsZXMoaW50IHRyYWNrSUQpCiAgICAgICAgIHJldHVy bjsKICAgICB9CiAKLSAgICAvLyBGSVhNRShyZGFyOi8vcHJvYmxlbS8yMDYzNTk2OSk6IFJlbW92 ZSB0aGlzIGRpc3BhdGNoX2FzeW5jKCkgd2hlbiB0aGUgYWZvcmVtZW50aW9uZWQgcmFkYXIgaXMg cmVzb2x2ZWQKLSAgICBhdXRvIHdlYWtUaGlzID0gY3JlYXRlV2Vha1B0cigpOwotICAgIGRpc3Bh dGNoX2FzeW5jKGRpc3BhdGNoX2dldF9tYWluX3F1ZXVlKCksIFt3ZWFrVGhpcywgdHJhY2tJRF0g ewotICAgICAgICBpZiAoIXdlYWtUaGlzIHx8ICF3ZWFrVGhpcy0+bV9jbGllbnQpCi0gICAgICAg ICAgICByZXR1cm47Ci0gICAgICAgIHdlYWtUaGlzLT5tX2NsaWVudC0+c291cmNlQnVmZmVyUHJp dmF0ZURpZEJlY29tZVJlYWR5Rm9yTW9yZVNhbXBsZXMod2Vha1RoaXMuZ2V0KCksIEF0b21pY1N0 cmluZzo6bnVtYmVyKHRyYWNrSUQpKTsKLSAgICB9KTsKKyAgICBpZiAobV9jbGllbnQpCisgICAg ICAgIG1fY2xpZW50LT5zb3VyY2VCdWZmZXJQcml2YXRlRGlkQmVjb21lUmVhZHlGb3JNb3JlU2Ft cGxlcyh0aGlzLCBBdG9taWNTdHJpbmc6Om51bWJlcih0cmFja0lEKSk7CiB9CiAKIHZvaWQgU291 cmNlQnVmZmVyUHJpdmF0ZUFWRk9iakM6Om5vdGlmeUNsaWVudFdoZW5SZWFkeUZvck1vcmVTYW1w bGVzKEF0b21pY1N0cmluZyB0cmFja0lEU3RyaW5nKQo=