14402 2007-06-25 19:49:54 -0700 Main resource of http://www.apple.com/safari/ is called "www.apple.com" instead of "safari" 2007-06-25 21:01:15 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 523.x (Safari 3) All All RESOLVED FIXED http://www.apple.com/safari/ P2 Normal --- 1 aroben aroben oldest_to_newest 6298 0 aroben 2007-06-25 19:49:54 -0700 If you inspect http://www.apple.com/safari/ you will notice that the main resource is labeled "www.apple.com", while it should be labeled "safari". Patch forthcoming. 6296 1 15234 aroben 2007-06-25 19:52:14 -0700 Created attachment 15234 Patch with ChangeLog 6286 2 15234 oliver 2007-06-25 20:09:30 -0700 Comment on attachment 15234 Patch with ChangeLog this scares me as it could have substantial effects throughout webkit, are you sure there isn't anything that depends on this behaviour? 6276 3 aroben 2007-06-25 20:16:16 -0700 (In reply to comment #2) > (From update of attachment 15234 [edit]) > this scares me as it could have substantial effects throughout webkit, are you > sure there isn't anything that depends on this behaviour? Surprisingly, there are only three calls to KURL::lastPathComponent outside of InspectorController.cpp. They are: 1) ClipboardWin.cpp::filesystemPathFromUrlOrTitle 2) ClipboardWin.cpp::writeURL 3) PasteboardWin.cpp::Pasteboard::writeURL I don't think any of these callers intended to get a "/" returned for http://www.apple.com/safari/, so I feel fairly safe making this change. 6277 4 15234 oliver 2007-06-25 20:17:25 -0700 Comment on attachment 15234 Patch with ChangeLog indeed you are correct, r=me 6283 5 aroben 2007-06-25 21:01:15 -0700 Landed as r23779 15234 2007-06-25 19:52:14 -0700 2007-06-25 20:17:25 -0700 Patch with ChangeLog 0001-Fix-Bug-14402-Main-resource-of-http-www.apple.com.patch text/plain 2109 aroben RnJvbSA3ZjQ5OTE2MTEzYjMwZDhkZjIwYjk0YWEyZDU0ZTY5NTNjOGZhZDVlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGFtIFJvYmVuIDxhcm9iZW5AYXBwbGUuY29tPgpEYXRlOiBX ZWQsIDMwIE1heSAyMDA3IDE3OjMwOjAzIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gRml4IEJ1ZyAx NDQwMjogTWFpbiByZXNvdXJjZSBvZiBodHRwOi8vd3d3LmFwcGxlLmNvbS9zYWZhcmkvIGlzIGNh bGxlZCAid3d3LmFwcGxlLmNvbSIgaW5zdGVhZCBvZiAic2FmYXJpIgpodHRwOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQwMgoKVGhlIHNvbHV0aW9uIHdhcyB0byBtYWtlIEtV Ukw6Omxhc3RQYXRoQ29tcG9uZW50IGlnbm9yZSB0cmFpbGluZwpzbGFzaGVzLCB3aGljaCBpcyB3 aGF0IC1bTlNVUkwgbGFzdFBhdGhDb21wb25lbnRdIGRvZXMsIHRvby4KClJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKKiBwbGF0Zm9ybS9LVVJMLmNwcDoKKFdlYkNvcmU6OktVUkw6Omxhc3RQ YXRoQ29tcG9uZW50KToKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgIHwgICAxMyArKysr KysrKysrKysrCiBXZWJDb3JlL3BsYXRmb3JtL0tVUkwuY3BwIHwgICAxMiArKysrKysrKysrLS0K IDIgZmlsZXMgY2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDQ5MTg5 MDguLmY0ZWE2Y2IgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDctMDYtMjUgIEFkYW0gUm9iZW4gIDxhcm9i ZW5AYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBCdWcgMTQ0MDI6IE1haW4gcmVzb3VyY2Ugb2Yg aHR0cDovL3d3dy5hcHBsZS5jb20vc2FmYXJpLyBpcyBjYWxsZWQgInd3dy5hcHBsZS5jb20iIGlu c3RlYWQgb2YgInNhZmFyaSIKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTQ0MDIKKworICAgICAgICBUaGUgc29sdXRpb24gd2FzIHRvIG1ha2UgS1VSTDo6 bGFzdFBhdGhDb21wb25lbnQgaWdub3JlIHRyYWlsaW5nCisgICAgICAgIHNsYXNoZXMsIHdoaWNo IGlzIHdoYXQgLVtOU1VSTCBsYXN0UGF0aENvbXBvbmVudF0gZG9lcywgdG9vLgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vS1VSTC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpLVVJMOjpsYXN0UGF0aENvbXBvbmVudCk6CisKIDIwMDct MDYtMjUgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBBZGFtIFJvYmVuLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9LVVJMLmNwcCBiL1dl YkNvcmUvcGxhdGZvcm0vS1VSTC5jcHAKaW5kZXggZGQwMGY5Ni4uZDhiMjc0MyAxMDA2NDQKLS0t IGEvV2ViQ29yZS9wbGF0Zm9ybS9LVVJMLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL0tVUkwu Y3BwCkBAIC00OTAsOCArNDkwLDE2IEBAIERlcHJlY2F0ZWRTdHJpbmcgS1VSTDo6bGFzdFBhdGhD b21wb25lbnQoKSBjb25zdAogICAgIGlmICghaGFzUGF0aCgpKQogICAgICAgICByZXR1cm4gRGVw cmVjYXRlZFN0cmluZygpOwogCi0gICAgaW50IHN0YXJ0ID0gdXJsU3RyaW5nLmZpbmRSZXYoJy8n LCBwYXRoRW5kUG9zKTsgICAgCi0gICAgcmV0dXJuIHVybFN0cmluZy5taWQoc3RhcnQgKyAxLCBw YXRoRW5kUG9zIC0gc3RhcnQgLSAxKTsKKyAgICBpbnQgZW5kID0gcGF0aEVuZFBvcyAtIDE7Cisg ICAgaWYgKHVybFN0cmluZ1tlbmRdID09ICcvJykKKyAgICAgICAgLS1lbmQ7CisKKyAgICBpbnQg c3RhcnQgPSB1cmxTdHJpbmcuZmluZFJldignLycsIGVuZCk7CisgICAgaWYgKHN0YXJ0IDwgcG9y dEVuZFBvcykKKyAgICAgICAgcmV0dXJuIERlcHJlY2F0ZWRTdHJpbmcoKTsKKyAgICArK3N0YXJ0 OworCisgICAgcmV0dXJuIHVybFN0cmluZy5taWQoc3RhcnQsIGVuZCAtIHN0YXJ0ICsgMSk7CiB9 CiAKIERlcHJlY2F0ZWRTdHJpbmcgS1VSTDo6cHJvdG9jb2woKSBjb25zdAotLSAKMS41LjIuMgoK