144017 2015-04-21 15:25:18 -0700 Long pause under _takeViewSnapshot when screen updates are disabled 2015-04-21 16:26:23 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca ap commit-queue sfalken simon.fraser oldest_to_newest 1087190 0 thorton 2015-04-21 15:25:18 -0700 Long pause under _takeViewSnapshot when screen updates are disabled 1087191 1 251268 thorton 2015-04-21 15:26:13 -0700 Created attachment 251268 Patch 1087192 2 commit-queue 2015-04-21 15:29:16 -0700 Attachment 251268 did not pass style-queue: ERROR: Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h:122: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h:123: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h:177: The parameter name "cid" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h:177: The parameter name "windowCount" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h:177: The parameter name "options" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 5 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1087220 3 thorton 2015-04-21 16:26:23 -0700 http://trac.webkit.org/changeset/183083 251268 2015-04-21 15:26:13 -0700 2015-04-21 15:33:59 -0700 Patch bug-144017-20150421152511.patch text/plain 4854 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzMDc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzA2MzZhZTJhZGFiM2Yx ZmU2ODI0OWQwODc4M2EyNGEwY2Y3YjNkMi4uM2YyZGI4NGJiNzVkMDNmYjMzZTUwYjQ0YjBlNDE1 NTZhNjhjYzVkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA0LTIxICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIExvbmcgcGF1c2Ug dW5kZXIgX3Rha2VWaWV3U25hcHNob3Qgd2hlbiBzY3JlZW4gdXBkYXRlcyBhcmUgZGlzYWJsZWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDAxNwor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjA1NDgzOTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9zcGkvY2cvQ29yZUdyYXBoaWNz U1BJLmg6CisgICAgICAgIEFkZCBzb21lIFNQSS4KKwogMjAxNS0wNC0yMSAgQW5kZXJzIENhcmxz c29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEdldCByaWQgb2YgYW4gdW5uZWVk ZWQgZnVuY3Rpb24gZnJvbSBMb2FkZXJOU1VSTEV4dHJhcy5tbQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDBjNDJl NTY4ZWZmMjVhMzIxNWVkN2JjMjE2N2NjN2FhMzA3ODdlMTIuLjYzMDEzYWU4ZGFiOTJiMmJlZDQ0 MmFiMjc5NDNlNjQ0N2Y5OGZlNmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxNS0w NC0yMSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAgICAgICBM b25nIHBhdXNlIHVuZGVyIF90YWtlVmlld1NuYXBzaG90IHdoZW4gc2NyZWVuIHVwZGF0ZXMgYXJl IGRpc2FibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDQwMTcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzIwNTQ4Mzk3PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMv V0tWaWV3Lm1tOgorICAgICAgICAoLVtXS1ZpZXcgX3Rha2VWaWV3U25hcHNob3RdKToKKyAgICAg ICAgVXNlIENHU0hXQ2FwdHVyZVdpbmRvd0xpc3QsIGZvciBzbmFwc2hvdHRpbmcgdGhhdCBkb2Vz bid0IGJsb2NrIG9uCisgICAgICAgIHRoZSBuZXh0IGNvbW1pdCwgYW5kIGNhbiBzdWNjZWVkIHdo aWxlIHNjcmVlbiB1cGRhdGVzIGFyZSBkaXNhYmxlZAorICAgICAgICB3aXRob3V0IGJsb2NraW5n LgorCiAyMDE1LTA0LTIxICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAK ICAgICAgICAgRml4IGJsb2NrIHNpZ25hdHVyZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL3NwaS9jZy9Db3JlR3JhcGhpY3NTUEkuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3NwaS9jZy9Db3JlR3JhcGhpY3NTUEkuaAppbmRleCBiY2U4YThkYjQ2ZGFkOTBjYjM0Njhj NmI5NTdiYWRlMWU5YWYwZDYxLi4wYzdhZTg5MGY0OGM0NTliNzc0ZDNkMTIxODgzMzJkYjZiMGZk OTcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcGkvY2cvQ29yZUdyYXBo aWNzU1BJLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3BpL2NnL0NvcmVHcmFwaGlj c1NQSS5oCkBAIC0xMTMsNiArMTEzLDE3IEBAIHN0YXRpYyBpbmxpbmUgQ0dGbG9hdCBDR0Zsb2F0 TWluKENHRmxvYXQgYSwgQ0dGbG9hdCBiKSB7IHJldHVybiBpc25hbihhKSA/IGIgOiAoCiAKIHR5 cGVkZWYgc3RydWN0IENHRm9udENhY2hlIENHRm9udENhY2hlOwogCit0eXBlZGVmIHVpbnQzMl90 IENHU0Nvbm5lY3Rpb25JRDsKK3R5cGVkZWYgdWludDMyX3QgQ0dTV2luZG93SUQ7Cit0eXBlZGVm IHVpbnQzMl90IENHU1dpbmRvd0NvdW50OwordHlwZWRlZiBDR1NXaW5kb3dJRCAqQ0dTV2luZG93 SURMaXN0OworCitlbnVtIHsKKyAgICBrQ0dTV2luZG93Q2FwdHVyZU5vbWluYWxSZXNvbHV0aW9u ID0gMHgwMjAwLAorICAgIGtDR1NDYXB0dXJlSWdub3JlR2xvYmFsQ2xpcFNoYXBlID0gMHgwODAw LAorfTsKK3R5cGVkZWYgdWludDMyX3QgQ0dTV2luZG93Q2FwdHVyZU9wdGlvbnM7CisKICNlbmRp ZiAvLyBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQogCiBXVEZfRVhURVJOX0NfQkVHSU4KQEAgLTE2 Miw2ICsxNzMsOSBAQCB2b2lkIENHRm9udENhY2hlU2V0U2hvdWxkQXV0b0V4cGlyZShDR0ZvbnRD YWNoZSosIGJvb2wpOwogdm9pZCBDR0ZvbnRDYWNoZVNldE1heFNpemUoQ0dGb250Q2FjaGUqLCBz aXplX3QpOwogI2VuZGlmCiAKK0NHU0Nvbm5lY3Rpb25JRCBDR1NNYWluQ29ubmVjdGlvbklEKHZv aWQpOworQ0ZBcnJheVJlZiBDR1NIV0NhcHR1cmVXaW5kb3dMaXN0KENHU0Nvbm5lY3Rpb25JRCBj aWQsIENHU1dpbmRvd0lETGlzdCB3aW5kb3dMaXN0LCBDR1NXaW5kb3dDb3VudCB3aW5kb3dDb3Vu dCwgQ0dTV2luZG93Q2FwdHVyZU9wdGlvbnMgb3B0aW9ucyk7CisKIFdURl9FWFRFUk5fQ19FTkQK IAogI2VuZGlmIC8vIENvcmVHcmFwaGljc1NQSV9oCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL21hYy9XS1ZpZXcubW0KaW5kZXggZWMwMjU3ZDcxNGQ5MmZhZDY3MmE1NGUyMWRmNDI2MjMw MWUxNTBmYi4uOTgyMTlhNmNmNzEwZTk2OTc5NDFmN2Y4OTE3NzFkYjZhMjFiNGExMSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQpAQCAtMzM3MCwxMiArMzM3 MCwyMiBAQCBzdGF0aWMgdm9pZCoga2V5VmFsdWVPYnNlcnZpbmdDb250ZXh0ID0gJmtleVZhbHVl T2JzZXJ2aW5nQ29udGV4dDsKICAgICBpZiAoIXdpbmRvd0lEIHx8ICFbd2luZG93IGlzVmlzaWJs ZV0pCiAgICAgICAgIHJldHVybiBudWxscHRyOwogCi0gICAgUmV0YWluUHRyPENHSW1hZ2VSZWY+ IHdpbmRvd1NuYXBzaG90SW1hZ2UgPSBhZG9wdENGKENHV2luZG93TGlzdENyZWF0ZUltYWdlKENH UmVjdE51bGwsIGtDR1dpbmRvd0xpc3RPcHRpb25JbmNsdWRpbmdXaW5kb3csIHdpbmRvd0lELCBr Q0dXaW5kb3dJbWFnZUJvdW5kc0lnbm9yZUZyYW1pbmcgfCBrQ0dXaW5kb3dJbWFnZVNob3VsZEJl T3BhcXVlKSk7CisgICAgQ0dTV2luZG93Q2FwdHVyZU9wdGlvbnMgb3B0aW9ucyA9IGtDR1NDYXB0 dXJlSWdub3JlR2xvYmFsQ2xpcFNoYXBlOworICAgIFJldGFpblB0cjxDRkFycmF5UmVmPiB3aW5k b3dTbmFwc2hvdEltYWdlcyA9IGFkb3B0Q0YoQ0dTSFdDYXB0dXJlV2luZG93TGlzdChDR1NNYWlu Q29ubmVjdGlvbklEKCksICZ3aW5kb3dJRCwgMSwgb3B0aW9ucykpOworICAgIGlmICghQ0ZBcnJh eUdldENvdW50KHdpbmRvd1NuYXBzaG90SW1hZ2VzLmdldCgpKSkKKyAgICAgICAgcmV0dXJuIG51 bGxwdHI7CisKKyAgICBSZXRhaW5QdHI8Q0dJbWFnZVJlZj4gd2luZG93U25hcHNob3RJbWFnZSA9 IChDR0ltYWdlUmVmKUNGQXJyYXlHZXRWYWx1ZUF0SW5kZXgod2luZG93U25hcHNob3RJbWFnZXMu Z2V0KCksIDApOwogCiAgICAgLy8gV29yayBhcm91bmQgPHJkYXI6Ly9wcm9ibGVtLzE3MDg0OTkz PjsgcmUtcmVxdWVzdCB0aGUgc25hcHNob3QgYXQga0NHV2luZG93SW1hZ2VOb21pbmFsUmVzb2x1 dGlvbiBpZiBpdCB3YXMgY2FwdHVyZWQgYXQgdGhlIHdyb25nIHNjYWxlLgogICAgIENHRmxvYXQg ZGVzaXJlZFNuYXBzaG90V2lkdGggPSB3aW5kb3cuZnJhbWUuc2l6ZS53aWR0aCAqIHdpbmRvdy5z Y3JlZW4uYmFja2luZ1NjYWxlRmFjdG9yOwotICAgIGlmIChDR0ltYWdlR2V0V2lkdGgod2luZG93 U25hcHNob3RJbWFnZS5nZXQoKSkgIT0gZGVzaXJlZFNuYXBzaG90V2lkdGgpCi0gICAgICAgIHdp bmRvd1NuYXBzaG90SW1hZ2UgPSBhZG9wdENGKENHV2luZG93TGlzdENyZWF0ZUltYWdlKENHUmVj dE51bGwsIGtDR1dpbmRvd0xpc3RPcHRpb25JbmNsdWRpbmdXaW5kb3csIHdpbmRvd0lELCBrQ0dX aW5kb3dJbWFnZUJvdW5kc0lnbm9yZUZyYW1pbmcgfCBrQ0dXaW5kb3dJbWFnZVNob3VsZEJlT3Bh cXVlIHwga0NHV2luZG93SW1hZ2VOb21pbmFsUmVzb2x1dGlvbikpOworICAgIGlmIChDR0ltYWdl R2V0V2lkdGgod2luZG93U25hcHNob3RJbWFnZS5nZXQoKSkgIT0gZGVzaXJlZFNuYXBzaG90V2lk dGgpIHsKKyAgICAgICAgb3B0aW9ucyB8PSBrQ0dTV2luZG93Q2FwdHVyZU5vbWluYWxSZXNvbHV0 aW9uOworICAgICAgICB3aW5kb3dTbmFwc2hvdEltYWdlcyA9IGFkb3B0Q0YoQ0dTSFdDYXB0dXJl V2luZG93TGlzdChDR1NNYWluQ29ubmVjdGlvbklEKCksICZ3aW5kb3dJRCwgMSwgb3B0aW9ucykp OworICAgICAgICBpZiAoIUNGQXJyYXlHZXRDb3VudCh3aW5kb3dTbmFwc2hvdEltYWdlcy5nZXQo KSkpCisgICAgICAgICAgICByZXR1cm4gbnVsbHB0cjsKKyAgICAgICAgd2luZG93U25hcHNob3RJ bWFnZSA9IChDR0ltYWdlUmVmKUNGQXJyYXlHZXRWYWx1ZUF0SW5kZXgod2luZG93U25hcHNob3RJ bWFnZXMuZ2V0KCksIDApOworICAgIH0KIAogICAgIFtzZWxmIF9lbnN1cmVHZXN0dXJlQ29udHJv bGxlcl07CiAK