144003 2015-04-21 12:50:55 -0700 Get rid of an unneeded function from LoaderNSURLExtras.mm 2015-04-21 13:33:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca cdumez commit-queue japhet oldest_to_newest 1087143 0 andersca 2015-04-21 12:50:55 -0700 Get rid of an unneeded function from LoaderNSURLExtras.mm 1087144 1 251257 andersca 2015-04-21 12:51:23 -0700 Created attachment 251257 Patch 1087152 2 cdumez 2015-04-21 13:28:24 -0700 Does not build? /Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/wtf/Vector.h:904:19: error: use of overloaded operator '==' is ambiguous (with operand types 'const WTF::String' and 'NSString *const') if (at(i) == value) ~~~~~ ^ ~~~~~ /Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/wtf/Vector.h:896:12: note: in instantiation of function template specialization 'WTF::Vector<WTF::String, 0, WTF::CrashOnOverflow>::find<NSString *>' requested here return find(value) != notFound; ^ /Volumes/Data/EWS/WebKit/Source/WebCore/loader/mac/LoaderNSURLExtras.mm:77:49: note: in instantiation of function template specialization 'WTF::Vector<WTF::String, 0, WTF::CrashOnOverflow>::contains<NSString *>' requested here if (extensions.isEmpty() || !extensions.contains(extension)) { ^ In file included from /Volumes/Data/EWS/WebKit/Source/WebCore/loader/mac/LoaderNSURLExtras.mm:35: In file included from /Volumes/Data/EWS/WebKit/Source/WebCore/platform/URL.h:32: /Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/wtf/text/WTFString.h:484:13: note: candidate function inline bool operator==(const String& a, const String& b) { return equal(a.impl(), b.impl()); } 1087153 3 251259 andersca 2015-04-21 13:31:12 -0700 Created attachment 251259 Patch 1087155 4 251259 cdumez 2015-04-21 13:32:25 -0700 Comment on attachment 251259 Patch r=me 1087156 5 andersca 2015-04-21 13:33:54 -0700 Committed r183074: <http://trac.webkit.org/changeset/183074> 251257 2015-04-21 12:51:23 -0700 2015-04-21 13:31:09 -0700 Patch bug-144003-20150421125021.patch text/plain 2234 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzMDcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWI4MjM3NmZiMDg1YzFm ZWYzMjZlNTMyZTZkOGEwOTAxZTdmMDAzYS4uNmJmZTY0YjQzMjViYWExM2U1ZDZkOTRhNzA1MWU5 NjNmYjkyNDc5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA0LTIxICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgR2V0IHJpZCBvZiBh biB1bm5lZWRlZCBmdW5jdGlvbiBmcm9tIExvYWRlck5TVVJMRXh0cmFzLm1tCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQwMDMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBKdXN0IHVzZSBWZWN0b3I6OmNv bnRhaW5zIGluc3RlYWQgb2YgdmVjdG9yQ29udGFpbnNTdHJpbmcuCisKKyAgICAgICAgKiBsb2Fk ZXIvbWFjL0xvYWRlck5TVVJMRXh0cmFzLm1tOgorICAgICAgICAoc3VnZ2VzdGVkRmlsZW5hbWVX aXRoTUlNRVR5cGUpOgorICAgICAgICAodmVjdG9yQ29udGFpbnNTdHJpbmcpOiBEZWxldGVkLgor CiAyMDE1LTA0LTIxICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAg TWFrZSBWZWN0b3IoY29uc3QgVmVjdG9yPFQsIG90aGVyQ2FwYWNpdHksIG90aGVyT3ZlcmZsb3dC ZWhhdmlvdXI+JikgY29uc3RydWN0b3IgZXhwbGljaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2xvYWRlci9tYWMvTG9hZGVyTlNVUkxFeHRyYXMubW0gYi9Tb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvbWFjL0xvYWRlck5TVVJMRXh0cmFzLm1tCmluZGV4IDhkODRkMGVjYmFkMzc3MDA1M2NjODgx M2MwMWI0OTM1ZDA0YTRmM2IuLjQyZGE0ZDU5MmM5N2ZlODNkMmJiMmQxMDUzYzNjOGQyMDYzMzUz ZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9tYWMvTG9hZGVyTlNVUkxFeHRy YXMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL21hYy9Mb2FkZXJOU1VSTEV4dHJhcy5t bQpAQCAtNDAsMTUgKzQwLDYgQEAKIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKLXN0YXRp YyBib29sIHZlY3RvckNvbnRhaW5zU3RyaW5nKGNvbnN0IFZlY3RvcjxTdHJpbmc+JiB2ZWN0b3Is IGNvbnN0IFN0cmluZyYgc3RyaW5nKQotewotICAgIGludCBzaXplID0gdmVjdG9yLnNpemUoKTsK LSAgICBmb3IgKGludCBpID0gMDsgaSA8IHNpemU7IGkrKykKLSAgICAgICAgaWYgKHZlY3Rvcltp XSA9PSBzdHJpbmcpCi0gICAgICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICByZXR1cm4gZmFsc2U7 Ci19Ci0KIE5TU3RyaW5nICpzdWdnZXN0ZWRGaWxlbmFtZVdpdGhNSU1FVHlwZShOU1VSTCAqdXJs LCBjb25zdCBTdHJpbmcmIG1pbWVUeXBlKQogewogICAgIC8vIEdldCB0aGUgZmlsZW5hbWUgZnJv bSB0aGUgVVJMLiBUcnkgdGhlIGxhc3RQYXRoQ29tcG9uZW50IGZpcnN0LgpAQCAtODMsNyArNzQs NyBAQCBOU1N0cmluZyAqc3VnZ2VzdGVkRmlsZW5hbWVXaXRoTUlNRVR5cGUoTlNVUkwgKnVybCwg Y29uc3QgU3RyaW5nJiBtaW1lVHlwZSkKICAgICBpZiAobWltZVR5cGUgIT0gImFwcGxpY2F0aW9u L29jdGV0LXN0cmVhbSIgJiYgbWltZVR5cGUgIT0gInRleHQvcGxhaW4iKSB7CiAgICAgICAgIFZl Y3RvcjxTdHJpbmc+IGV4dGVuc2lvbnMgPSBNSU1FVHlwZVJlZ2lzdHJ5OjpnZXRFeHRlbnNpb25z Rm9yTUlNRVR5cGUobWltZVR5cGUpOwogCi0gICAgICAgIGlmIChleHRlbnNpb25zLmlzRW1wdHko KSB8fCAhdmVjdG9yQ29udGFpbnNTdHJpbmcoZXh0ZW5zaW9ucywgZXh0ZW5zaW9uKSkgeworICAg ICAgICBpZiAoZXh0ZW5zaW9ucy5pc0VtcHR5KCkgfHwgIWV4dGVuc2lvbnMuY29udGFpbnMoZXh0 ZW5zaW9uKSkgewogICAgICAgICAgICAgLy8gVGhlIGV4dGVuc2lvbiBkb2Vzbid0IG1hdGNoIHRo ZSBNSU1FIHR5cGUuIENvcnJlY3QgdGhpcy4KICAgICAgICAgICAgIE5TU3RyaW5nICpjb3JyZWN0 RXh0ZW5zaW9uID0gTUlNRVR5cGVSZWdpc3RyeTo6Z2V0UHJlZmVycmVkRXh0ZW5zaW9uRm9yTUlN RVR5cGUobWltZVR5cGUpOwogICAgICAgICAgICAgaWYgKFtjb3JyZWN0RXh0ZW5zaW9uIGxlbmd0 aF0gIT0gMCkgewo= 251259 2015-04-21 13:31:12 -0700 2015-04-21 13:32:25 -0700 Patch bug-144003-20150421133011.patch text/plain 2242 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzMDcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWI4MjM3NmZiMDg1YzFm ZWYzMjZlNTMyZTZkOGEwOTAxZTdmMDAzYS4uNmJmZTY0YjQzMjViYWExM2U1ZDZkOTRhNzA1MWU5 NjNmYjkyNDc5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA0LTIxICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgR2V0IHJpZCBvZiBh biB1bm5lZWRlZCBmdW5jdGlvbiBmcm9tIExvYWRlck5TVVJMRXh0cmFzLm1tCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQwMDMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBKdXN0IHVzZSBWZWN0b3I6OmNv bnRhaW5zIGluc3RlYWQgb2YgdmVjdG9yQ29udGFpbnNTdHJpbmcuCisKKyAgICAgICAgKiBsb2Fk ZXIvbWFjL0xvYWRlck5TVVJMRXh0cmFzLm1tOgorICAgICAgICAoc3VnZ2VzdGVkRmlsZW5hbWVX aXRoTUlNRVR5cGUpOgorICAgICAgICAodmVjdG9yQ29udGFpbnNTdHJpbmcpOiBEZWxldGVkLgor CiAyMDE1LTA0LTIxICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAg TWFrZSBWZWN0b3IoY29uc3QgVmVjdG9yPFQsIG90aGVyQ2FwYWNpdHksIG90aGVyT3ZlcmZsb3dC ZWhhdmlvdXI+JikgY29uc3RydWN0b3IgZXhwbGljaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2xvYWRlci9tYWMvTG9hZGVyTlNVUkxFeHRyYXMubW0gYi9Tb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvbWFjL0xvYWRlck5TVVJMRXh0cmFzLm1tCmluZGV4IDhkODRkMGVjYmFkMzc3MDA1M2NjODgx M2MwMWI0OTM1ZDA0YTRmM2IuLmMyNmRlM2U1ZWQ2OWYwOTA3MzUxZTljZDFlZjliZmQ5ZGQ0OTA5 NDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9tYWMvTG9hZGVyTlNVUkxFeHRy YXMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL21hYy9Mb2FkZXJOU1VSTEV4dHJhcy5t bQpAQCAtNDAsMTUgKzQwLDYgQEAKIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKLXN0YXRp YyBib29sIHZlY3RvckNvbnRhaW5zU3RyaW5nKGNvbnN0IFZlY3RvcjxTdHJpbmc+JiB2ZWN0b3Is IGNvbnN0IFN0cmluZyYgc3RyaW5nKQotewotICAgIGludCBzaXplID0gdmVjdG9yLnNpemUoKTsK LSAgICBmb3IgKGludCBpID0gMDsgaSA8IHNpemU7IGkrKykKLSAgICAgICAgaWYgKHZlY3Rvcltp XSA9PSBzdHJpbmcpCi0gICAgICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICByZXR1cm4gZmFsc2U7 Ci19Ci0KIE5TU3RyaW5nICpzdWdnZXN0ZWRGaWxlbmFtZVdpdGhNSU1FVHlwZShOU1VSTCAqdXJs LCBjb25zdCBTdHJpbmcmIG1pbWVUeXBlKQogewogICAgIC8vIEdldCB0aGUgZmlsZW5hbWUgZnJv bSB0aGUgVVJMLiBUcnkgdGhlIGxhc3RQYXRoQ29tcG9uZW50IGZpcnN0LgpAQCAtODMsNyArNzQs NyBAQCBOU1N0cmluZyAqc3VnZ2VzdGVkRmlsZW5hbWVXaXRoTUlNRVR5cGUoTlNVUkwgKnVybCwg Y29uc3QgU3RyaW5nJiBtaW1lVHlwZSkKICAgICBpZiAobWltZVR5cGUgIT0gImFwcGxpY2F0aW9u L29jdGV0LXN0cmVhbSIgJiYgbWltZVR5cGUgIT0gInRleHQvcGxhaW4iKSB7CiAgICAgICAgIFZl Y3RvcjxTdHJpbmc+IGV4dGVuc2lvbnMgPSBNSU1FVHlwZVJlZ2lzdHJ5OjpnZXRFeHRlbnNpb25z Rm9yTUlNRVR5cGUobWltZVR5cGUpOwogCi0gICAgICAgIGlmIChleHRlbnNpb25zLmlzRW1wdHko KSB8fCAhdmVjdG9yQ29udGFpbnNTdHJpbmcoZXh0ZW5zaW9ucywgZXh0ZW5zaW9uKSkgeworICAg ICAgICBpZiAoZXh0ZW5zaW9ucy5pc0VtcHR5KCkgfHwgIWV4dGVuc2lvbnMuY29udGFpbnMoU3Ry aW5nKGV4dGVuc2lvbikpKSB7CiAgICAgICAgICAgICAvLyBUaGUgZXh0ZW5zaW9uIGRvZXNuJ3Qg bWF0Y2ggdGhlIE1JTUUgdHlwZS4gQ29ycmVjdCB0aGlzLgogICAgICAgICAgICAgTlNTdHJpbmcg KmNvcnJlY3RFeHRlbnNpb24gPSBNSU1FVHlwZVJlZ2lzdHJ5OjpnZXRQcmVmZXJyZWRFeHRlbnNp b25Gb3JNSU1FVHlwZShtaW1lVHlwZSk7CiAgICAgICAgICAgICBpZiAoW2NvcnJlY3RFeHRlbnNp b24gbGVuZ3RoXSAhPSAwKSB7Cg==