143976 2015-04-20 18:53:33 -0700 PDFs still don't snapshot properly in iOS Safari 2015-04-26 02:13:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca ian mitz simon.fraser oldest_to_newest 1086969 0 thorton 2015-04-20 18:53:33 -0700 PDFs still don't snapshot properly in iOS Safari 1086970 1 251210 thorton 2015-04-20 18:53:48 -0700 Created attachment 251210 Patch 1086971 2 thorton 2015-04-20 18:54:13 -0700 <rdar://problem/18283459> 1086988 3 251210 andersca 2015-04-20 21:16:53 -0700 Comment on attachment 251210 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251210&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2648 > + CGContextRef ctx = UIGraphicsGetCurrentContext(); Please use context instead of context. > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2650 > + CGContextTranslateCTM(ctx, destinationRect.origin.x, destinationRect.origin.y); > + CGContextScaleCTM(ctx, imageScale, imageScale); Do you need to save and restore the state here? 1087012 4 thorton 2015-04-21 00:58:14 -0700 (In reply to comment #3) > Comment on attachment 251210 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=251210&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2648 > > + CGContextRef ctx = UIGraphicsGetCurrentContext(); > > Please use context instead of context. You can't abbreviate it even if you want to :D > > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2650 > > + CGContextTranslateCTM(ctx, destinationRect.origin.x, destinationRect.origin.y); > > + CGContextScaleCTM(ctx, imageScale, imageScale); > > Do you need to save and restore the state here? I don't think so, because it's a new context that was just created and will be lost very soon. Seems like that would be a waste of time, right? 1087101 5 thorton 2015-04-21 11:02:49 -0700 http://trac.webkit.org/changeset/183068 251210 2015-04-20 18:53:48 -0700 2015-04-20 21:16:53 -0700 Patch bug-143976-20150420185246.patch text/plain 4837 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzMDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmE4MjE2YmI3ODg0Yzhl NTZhMGY3ODE3NmUwZWIzZjRjMGYyNDJiNS4uZjQyMjZiNmVjNTUyZTI5ZjFlN2MxOGU5ZjE0ZTIw MzgyMWIzMzNmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE1LTA0LTIwICBUaW1v dGh5IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAgICAgICBQREZzIHN0 aWxsIGRvbid0IHNuYXBzaG90IHByb3Blcmx5IGluIGlPUyBTYWZhcmkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0Mzk3NgorICAgICAgICA8cmRhcjov L3Byb2JsZW0vMTgyODM0NTk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktp dDo6V2ViUGFnZVByb3h5OjpkaWRMYXlvdXRGb3JDdXN0b21Db250ZW50UHJvdmlkZXIpOgorICAg ICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L0NvY29hL1dLV2ViVmlldy5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9kaWRGaW5pc2hMb2Fk aW5nRGF0YUZvckN1c3RvbUNvbnRlbnRQcm92aWRlcldpdGhTdWdnZXN0ZWRGaWxlbmFtZTpkYXRh Ol0pOgorICAgICAgICBJbmZvcm0gdGhlIGNsaWVudCB0aGF0IHdlJ3ZlIHBhc3NlZCBhbGwgcmVh c29uYWJsZSBsYXlvdXQgbWlsZXN0b25lcworICAgICAgICBhcyBzb29uIGFzIHRoZSBjdXN0b20g Y29udGVudCBwcm92aWRlciBoYXMgYmVlbiBoYW5kZWQgaXRzIGRhdGEuCisgICAgICAgIFdLUERG VmlldywgdGhlIG9ubHkgY3VzdG9tIGNvbnRlbnQgcHJvdmlkZXIsIHN5bmNocm9ub3VzbHkgbGF5 cyBvdXQKKyAgICAgICAgaXRzIHN1YnZpZXdzIHVwb24gaW5pdGlhbCByZWNlaXB0IG9mIGRhdGEs IHNvIHRoaXMgd29ya3MgZmluZSBmb3IgaXQuCisgICAgICAgIFRoaXMgZW5zdXJlcyB0aGF0IGNs aWVudHMgdGhhdCBub3JtYWxseSBkZXBlbmQgb24gbGF5b3V0IG1pbGVzdG9uZXMgZmlyaW5nCisg ICAgICAgIHdvbid0IGJyZWFrIHdoZW4gYSBjdXN0b20gY29udGVudCB2aWV3IGlzIGluc3RhbGxl ZC4KKworICAgICAgICAoLVtXS1dlYlZpZXcgX3NuYXBzaG90UmVjdDppbnRvSW1hZ2VPZldpZHRo OmNvbXBsZXRpb25IYW5kbGVyOl0pOgorICAgICAgICBGYWxsIGJhY2sgdG8gcmVuZGVySW5Db250 ZXh0OiBpZiB0aGUgY3VzdG9tIGNvbnRlbnQgdmlldyBpcyBub3QgcGFyZW50ZWQKKyAgICAgICAg d2hlbiBhIHNuYXBzaG90IGlzIHJlcXVlc3RlZC4KKwogMjAxNS0wNC0yMCAgVGltIEhvcnRvbiAg PHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgaW1tZWRpYXRl IGFjdGlvbiBzdXBwb3J0IGZvciB0ZWw6IGFuZCBtYWlsdG86IFVSTHMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KaW5kZXggN2MxNWY1ZWE3ODE5 MmRmMDQ4YTM4NjFlN2FlOTNhNjc2MjgwZjkzNS4uMGU1ZDkxZjU1YWQwYjAwYjI0OTc4ZmZmYmM4 OGZiNzliYzBhOTVmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9D b2NvYS9XS1dlYlZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2Nv YS9XS1dlYlZpZXcubW0KQEAgLTcxNyw2ICs3MTcsMTAgQEAgc3RhdGljIENHU2l6ZSByb3VuZFNj cm9sbFZpZXdDb250ZW50U2l6ZShjb25zdCBXZWJLaXQ6OldlYlBhZ2VQcm94eSYgcGFnZSwgQ0dT aXoKIHsKICAgICBBU1NFUlQoX2N1c3RvbUNvbnRlbnRWaWV3KTsKICAgICBbX2N1c3RvbUNvbnRl bnRWaWV3IHdlYl9zZXRDb250ZW50UHJvdmlkZXJEYXRhOmRhdGEgc3VnZ2VzdGVkRmlsZW5hbWU6 c3VnZ2VzdGVkRmlsZW5hbWVdOworCisgICAgLy8gRklYTUU6IEl0IG1heSBtYWtlIG1vcmUgc2Vu c2UgZm9yIGN1c3RvbSBjb250ZW50IHByb3ZpZGVycyB0byBpbnZva2UgdGhpcyB3aGVuIHRoZXkn cmUgcmVhZHksCisgICAgLy8gYmVjYXVzZSB0aGVyZSdzIG5vIGd1YXJhbnRlZSB0aGF0IGFsbCBj dXN0b20gY29udGVudCBwcm92aWRlcnMgd2lsbCBsYXkgb3V0IHN5bmNocm9ub3VzbHkuCisgICAg X3BhZ2UtPmRpZExheW91dEZvckN1c3RvbUNvbnRlbnRQcm92aWRlcigpOwogfQogCiAtICh2b2lk KV9zZXRWaWV3cG9ydE1ldGFUYWdXaWR0aDooZmxvYXQpbmV3V2lkdGgKQEAgLTI2MzcsNyArMjY0 MSwxNSBAQCBzdGF0aWMgaW5saW5lIFdlYktpdDo6RmluZE9wdGlvbnMgdG9GaW5kT3B0aW9ucyhf V0tGaW5kT3B0aW9ucyB3a0ZpbmRPcHRpb25zKQogICAgICAgICBkZXN0aW5hdGlvblJlY3Qub3Jp Z2luLnkgPSAtc25hcHNob3RSZWN0SW5Db250ZW50Q29vcmRpbmF0ZXMub3JpZ2luLnkgKiBpbWFn ZVNjYWxlOwogICAgICAgICBkZXN0aW5hdGlvblJlY3Quc2l6ZS53aWR0aCAqPSBpbWFnZVNjYWxl OwogICAgICAgICBkZXN0aW5hdGlvblJlY3Quc2l6ZS5oZWlnaHQgKj0gaW1hZ2VTY2FsZTsKLSAg ICAgICAgW2N1c3RvbUNvbnRlbnRWaWV3IGRyYXdWaWV3SGllcmFyY2h5SW5SZWN0OmRlc3RpbmF0 aW9uUmVjdCBhZnRlclNjcmVlblVwZGF0ZXM6Tk9dOworCisgICAgICAgIGlmIChbX2N1c3RvbUNv bnRlbnRWaWV3IHdpbmRvd10pCisgICAgICAgICAgICBbY3VzdG9tQ29udGVudFZpZXcgZHJhd1Zp ZXdIaWVyYXJjaHlJblJlY3Q6ZGVzdGluYXRpb25SZWN0IGFmdGVyU2NyZWVuVXBkYXRlczpOT107 CisgICAgICAgIGVsc2UgeworICAgICAgICAgICAgQ0dDb250ZXh0UmVmIGN0eCA9IFVJR3JhcGhp Y3NHZXRDdXJyZW50Q29udGV4dCgpOworICAgICAgICAgICAgQ0dDb250ZXh0VHJhbnNsYXRlQ1RN KGN0eCwgZGVzdGluYXRpb25SZWN0Lm9yaWdpbi54LCBkZXN0aW5hdGlvblJlY3Qub3JpZ2luLnkp OworICAgICAgICAgICAgQ0dDb250ZXh0U2NhbGVDVE0oY3R4LCBpbWFnZVNjYWxlLCBpbWFnZVNj YWxlKTsKKyAgICAgICAgICAgIFtjdXN0b21Db250ZW50Vmlldy5sYXllciByZW5kZXJJbkNvbnRl eHQ6Y3R4XTsKKyAgICAgICAgfQogCiAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKFtVSUdyYXBo aWNzR2V0SW1hZ2VGcm9tQ3VycmVudEltYWdlQ29udGV4dCgpIENHSW1hZ2VdKTsKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAppbmRleCBkYmIwODk5ZjBhOGI1OWE3 ZjE4NDdkNjk2ZmYxZjEzMDA5MzY3Yzc0Li4xZjRlMjQxODcxOGY3MzM3YWM0ZTkwYWNiMzQwMWY3 MzliNmQxZDA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVBy b3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApA QCAtMzA3Miw2ICszMDcyLDE1IEBAIHZvaWQgV2ViUGFnZVByb3h5OjpkaWRGaXJzdFZpc3VhbGx5 Tm9uRW1wdHlMYXlvdXRGb3JGcmFtZSh1aW50NjRfdCBmcmFtZUlELCBjb25zCiAgICAgICAgIG1f cGFnZUNsaWVudC5kaWRGaXJzdFZpc3VhbGx5Tm9uRW1wdHlMYXlvdXRGb3JNYWluRnJhbWUoKTsK IH0KIAordm9pZCBXZWJQYWdlUHJveHk6OmRpZExheW91dEZvckN1c3RvbUNvbnRlbnRQcm92aWRl cigpCit7CisgICAgTGF5b3V0TWlsZXN0b25lcyBtaWxlc3RvbmVzID0gRGlkRmlyc3RMYXlvdXQg fCBEaWRGaXJzdFZpc3VhbGx5Tm9uRW1wdHlMYXlvdXQgfCBEaWRIaXRSZWxldmFudFJlcGFpbnRl ZE9iamVjdHNBcmVhVGhyZXNob2xkOworICAgIGlmIChtX25hdmlnYXRpb25DbGllbnQpCisgICAg ICAgIG1fbmF2aWdhdGlvbkNsaWVudC0+cmVuZGVyaW5nUHJvZ3Jlc3NEaWRDaGFuZ2UoKnRoaXMs IG1pbGVzdG9uZXMsIG51bGxwdHIpOworICAgIGVsc2UKKyAgICAgICAgbV9sb2FkZXJDbGllbnQt PmRpZExheW91dCgqdGhpcywgbWlsZXN0b25lcywgbnVsbHB0cik7Cit9CisKIHZvaWQgV2ViUGFn ZVByb3h5OjpkaWRMYXlvdXQodWludDMyX3QgbGF5b3V0TWlsZXN0b25lcywgY29uc3QgVXNlckRh dGEmIHVzZXJEYXRhKQogewogICAgIGlmIChtX25hdmlnYXRpb25DbGllbnQpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmggYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgKaW5kZXggNmUyNTA5NjUzZTU1NjNjM2FmNWM2YWNm NjliMGFiMGViMjBkNGUzYy4uYzA4YjJiOTllNzA4YjYwY2Q4YWMxNmZhMGEwMjI3YTgwMTJhMmZj ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaApAQCAtMTAzMSw2ICsx MDMxLDcgQEAgcHVibGljOgogI2VuZGlmCiAKICAgICB2b2lkIGRpZENoYW5nZUJhY2tncm91bmRD b2xvcigpOworICAgIHZvaWQgZGlkTGF5b3V0Rm9yQ3VzdG9tQ29udGVudFByb3ZpZGVyKCk7CiAK IHByaXZhdGU6CiAgICAgV2ViUGFnZVByb3h5KFBhZ2VDbGllbnQmLCBXZWJQcm9jZXNzUHJveHkm LCB1aW50NjRfdCBwYWdlSUQsIGNvbnN0IFdlYlBhZ2VDb25maWd1cmF0aW9uJik7Cg==