143974 2015-04-20 18:08:30 -0700 PhantomNewObject should be marked NodeMustGenerate 2015-04-21 15:30:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 basile_clement webkit-unassigned commit-queue fpizlo ggaren mark.lam msaboff oldest_to_newest 1086963 0 basile_clement 2015-04-20 18:08:30 -0700 The allocation sinking optimization pass creates PhantomNewObject nodes to keep track of the old NewObject nodes, which must be kept as they are used to restore the state of allocations on OSR exit, and thus should be marked NodeMustGenerate. They are currently prevented from being removed by the PutHint for the object's structure, but that is a rather implicit safety net. 1086964 1 251208 basile_clement 2015-04-20 18:13:24 -0700 Created attachment 251208 The patch 1086975 2 251208 commit-queue 2015-04-20 19:38:47 -0700 Comment on attachment 251208 The patch Clearing flags on attachment: 251208 Committed r183040: <http://trac.webkit.org/changeset/183040> 1086976 3 commit-queue 2015-04-20 19:38:51 -0700 All reviewed patches have been landed. Closing bug. 1087148 4 basile_clement 2015-04-21 13:19:41 -0700 convertToPhantomNewObject() do not properly set the NodeMustGenerate flag. 1087170 5 251262 basile_clement 2015-04-21 14:21:23 -0700 Created attachment 251262 Fix convertToPhantomNewObject 1087193 6 251262 commit-queue 2015-04-21 15:30:24 -0700 Comment on attachment 251262 Fix convertToPhantomNewObject Clearing flags on attachment: 251262 Committed r183078: <http://trac.webkit.org/changeset/183078> 1087194 7 commit-queue 2015-04-21 15:30:28 -0700 All reviewed patches have been landed. Closing bug. 251208 2015-04-20 18:13:24 -0700 2015-04-20 19:38:47 -0700 The patch phantom_new_object_must_generate.patch text/plain 1213 basile_clement ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGM2M2JiNTQuLmQxMjliYzAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTA0LTIwICBCYXNpbGUgQ2xlbWVu dCAgPGJhc2lsZV9jbGVtZW50QGFwcGxlLmNvbT4KKworICAgICAgICBQaGFudG9tTmV3T2JqZWN0 IHNob3VsZCBiZSBtYXJrZWQgTm9kZU11c3RHZW5lcmF0ZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzOTc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkZmcvREZHTm9kZVR5cGUuaDogTWFyayBQaGFu dG9tTmV3T2JqZWN0IGFzIE5vZGVNdXN0R2VuZXJhdGUKKwogMjAxNS0wNC0yMCAgSm9zZXBoIFBl Y29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIENsZWFudXAgc29tZSBTdHJp bmdCdWlsZGVyIHVzZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdO b2RlVHlwZS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdOb2RlVHlwZS5oCmluZGV4 IGY5ODk5MTQuLjg0ZjVjZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHTm9kZVR5cGUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR05vZGVUeXBl LmgKQEAgLTIzOCw3ICsyMzgsNyBAQCBuYW1lc3BhY2UgSlNDIHsgbmFtZXNwYWNlIERGRyB7CiAg ICAgbWFjcm8oTmV3UmVnZXhwLCBOb2RlUmVzdWx0SlMpIFwKICAgICBcCiAgICAgLyogU3VwcG9y dCBmb3IgYWxsb2NhdGlvbiBzaW5raW5nLiAqL1wKLSAgICBtYWNybyhQaGFudG9tTmV3T2JqZWN0 LCBOb2RlUmVzdWx0SlMpIFwKKyAgICBtYWNybyhQaGFudG9tTmV3T2JqZWN0LCBOb2RlUmVzdWx0 SlMgfCBOb2RlTXVzdEdlbmVyYXRlKSBcCiAgICAgbWFjcm8oUHV0SGludCwgTm9kZU11c3RHZW5l cmF0ZSkgXAogICAgIG1hY3JvKENoZWNrU3RydWN0dXJlSW1tZWRpYXRlLCBOb2RlTXVzdEdlbmVy YXRlKSBcCiAgICAgbWFjcm8oTWF0ZXJpYWxpemVOZXdPYmplY3QsIE5vZGVSZXN1bHRKUyB8IE5v ZGVIYXNWYXJBcmdzKSBcCg== 251262 2015-04-21 14:21:23 -0700 2015-04-21 15:30:24 -0700 Fix convertToPhantomNewObject pno_nmg_2.patch text/plain 1187 basile_clement ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDNhZWFiZTMuLmY1ZDMyM2MgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA0LTIxICBCYXNpbGUgQ2xlbWVu dCAgPGJhc2lsZV9jbGVtZW50QGFwcGxlLmNvbT4KKworICAgICAgICBQaGFudG9tTmV3T2JqZWN0 IHNob3VsZCBiZSBtYXJrZWQgTm9kZU11c3RHZW5lcmF0ZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzOTc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkZmcvREZHTm9kZS5oOgorICAgICAgICAoSlND OjpERkc6Ok5vZGU6OmNvbnZlcnRUb1BoYW50b21OZXdPYmplY3QpOgorICAgICAgICBXYXMgbm90 IHByb3Blcmx5IG1hcmtpbmcgTm9kZU11c3RHZW5lcmF0ZSB3aGVuIGNvbnZlcnRpbmcuCisKIDIw MTUtMDQtMjEgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBERkcg Q2FsbC9Db25zdHJ1Y3RGb3J3YXJkVmFyYXJncyBmYWlscyB0byByZXN0b3JlIHRoZSBzdGFjayBw b2ludGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR05vZGUuaCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9kZS5oCmluZGV4IDQ1ZWRjOWUuLmVmYTkw ZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9kZS5oCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9kZS5oCkBAIC01NzUsNiArNTc1LDcgQEAg c3RydWN0IE5vZGUgewogICAgICAgICBBU1NFUlQobV9vcCA9PSBOZXdPYmplY3QgfHwgbV9vcCA9 PSBNYXRlcmlhbGl6ZU5ld09iamVjdCk7CiAgICAgICAgIG1fb3AgPSBQaGFudG9tTmV3T2JqZWN0 OwogICAgICAgICBtX2ZsYWdzICY9IH5Ob2RlSGFzVmFyQXJnczsKKyAgICAgICAgbV9mbGFncyB8 PSBOb2RlTXVzdEdlbmVyYXRlOwogICAgICAgICBtX29wSW5mbyA9IDA7CiAgICAgICAgIG1fb3BJ bmZvMiA9IDA7CiAgICAgICAgIGNoaWxkcmVuID0gQWRqYWNlbmN5TGlzdCgpOwo=