143964 2015-04-20 14:08:28 -0700 OpenGLShims appears to have a dead store if GLES2 2024-01-17 01:10:27 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED CONFIGURATION CHANGED P2 Normal --- 1 joepeck webkit-unassigned hausmann joepeck jturcotte kkinnunen noam oldest_to_newest 1086897 0 joepeck 2015-04-20 14:08:28 -0700 * SUMMARY Bug 95556 / r127874 introduced some GLES2 handling. It looks like it would cause a dead store. The code should be cleaned up in some way, or there is an actual bug. Currently the code looks like: https://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/OpenGLShims.cpp#L64 static void* lookupOpenGLFunctionAddress(const char* functionName, bool* success = 0) { ... fullFunctionName = functionName; fullFunctionName.append("EXT"); target = getProcAddress(fullFunctionName.utf8().data()); #if defined(GL_ES_VERSION_2_0) fullFunctionName = functionName; fullFunctionName.append("ANGLE"); target = getProcAddress(fullFunctionName.utf8().data()); if (target) return target; fullFunctionName = functionName; fullFunctionName.append("APPLE"); target = getProcAddress(fullFunctionName.utf8().data()); #endif // A null address is still a failure case. if (!target && success) *success = false; return target; } Note that the target assignment for "EXT" will just immediately get overwritten by the "ANGLE"/"APPLE" case if GL_ES_VERSION_2_0. So either there is a bug and the "EXT" case should be getting used, or there is not a bug and this is unnecessary work and the "EXT" case should just be an #else. 1086898 1 joepeck 2015-04-20 14:11:05 -0700 My guess is there should be an: if (target) return target; But I don't know how to test.