<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>143959</bug_id>
          
          <creation_ts>2015-04-20 12:32:58 -0700</creation_ts>
          <short_desc>Add a bool parameter to decidePolicyForNavigationAction and decidePolicyForNewWindowAction in WKPagePolicyClient to track whether it&apos;s user initiated</short_desc>
          <delta_ts>2017-07-28 20:28:15 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WONTFIX</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ada Chan">adachan</reporter>
          <assigned_to name="Ada Chan">adachan</assigned_to>
          <cc>adachan</cc>
    
    <cc>andersca</cc>
    
    <cc>ap</cc>
    
    <cc>mitz</cc>
    
    <cc>sam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1086871</commentid>
    <comment_count>0</comment_count>
    <who name="Ada Chan">adachan</who>
    <bug_when>2015-04-20 12:32:58 -0700</bug_when>
    <thetext>These are the new definitions of the decidePolicyForNavigationAction and decidePolicyForNewWindowAction callbacks:

typedef void (*WKPageDecidePolicyForNavigationActionCallback)(WKPageRef page, WKFrameRef frame, WKFrameNavigationType navigationType, WKEventModifiers modifiers, WKEventMouseButton mouseButton, bool isUserInitiated, WKFrameRef originatingFrame, WKURLRequestRef request, WKFramePolicyListenerRef listener, WKTypeRef userData, const void* clientInfo);
typedef void (*WKPageDecidePolicyForNewWindowActionCallback)(WKPageRef page, WKFrameRef frame, WKFrameNavigationType navigationType, WKEventModifiers modifiers, WKEventMouseButton mouseButton, bool isUserInitiated, WKURLRequestRef request, WKStringRef frameName, WKFramePolicyListenerRef listener, WKTypeRef userData, const void* clientInfo);

This is needed for &lt;rdar://problem/20139052&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1333178</commentid>
    <comment_count>1</comment_count>
    <who name="">mitz</who>
    <bug_when>2017-07-28 20:28:15 -0700</bug_when>
    <thetext>(In reply to Ada Chan from comment #0)
&gt; These are the new definitions of the decidePolicyForNavigationAction and
&gt; decidePolicyForNewWindowAction callbacks:
&gt; 
&gt; typedef void (*WKPageDecidePolicyForNavigationActionCallback)(WKPageRef
&gt; page, WKFrameRef frame, WKFrameNavigationType navigationType,
&gt; WKEventModifiers modifiers, WKEventMouseButton mouseButton, bool
&gt; isUserInitiated, WKFrameRef originatingFrame, WKURLRequestRef request,
&gt; WKFramePolicyListenerRef listener, WKTypeRef userData, const void*
&gt; clientInfo);
&gt; typedef void (*WKPageDecidePolicyForNewWindowActionCallback)(WKPageRef page,
&gt; WKFrameRef frame, WKFrameNavigationType navigationType, WKEventModifiers
&gt; modifiers, WKEventMouseButton mouseButton, bool isUserInitiated,
&gt; WKURLRequestRef request, WKStringRef frameName, WKFramePolicyListenerRef
&gt; listener, WKTypeRef userData, const void* clientInfo);
&gt; 
&gt; This is needed for &lt;rdar://problem/20139052&gt;

I see that that has been resolved without relying on the new callback, so I think we are not going to make this change.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>