143947 2015-04-20 01:07:23 -0700 HashMap storing PropertyKey StringImpl* need to use IdentifierRepHash to handle Symbols 2015-04-20 12:36:39 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki ysuzuki ap benjamin commit-queue darin fpizlo ggaren oldest_to_newest 1086750 0 ysuzuki 2015-04-20 01:07:23 -0700 HashMap storeing PropertyKey StringImpl* need to use IdentifierRepHash to handle Symbols 1086764 1 251155 ysuzuki 2015-04-20 01:53:58 -0700 Created attachment 251155 Patch 1086765 2 ysuzuki 2015-04-20 01:55:14 -0700 Could anyone take a look? It fixes JSC test failures in 32bit debug builds. https://build.webkit.org/builders/Apple%20Mavericks%2032-bit%20JSC%20%28BuildAndTest%29 1086766 3 commit-queue 2015-04-20 01:55:45 -0700 Attachment 251155 did not pass style-queue: ERROR: Source/JavaScriptCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] ERROR: Source/JavaScriptCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] ERROR: Source/JavaScriptCore/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] ERROR: Source/JavaScriptCore/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1086767 4 251156 ysuzuki 2015-04-20 01:57:37 -0700 Created attachment 251156 Patch 1086768 5 251157 ysuzuki 2015-04-20 01:58:42 -0700 Created attachment 251157 Patch 1086837 6 251157 ggaren 2015-04-20 11:31:10 -0700 Comment on attachment 251157 Patch Ha! I just had to fix this bug for another patch! 1086851 7 251157 ggaren 2015-04-20 11:46:13 -0700 Comment on attachment 251157 Patch Marking cq+ because we need this fix to fix the crash seen in https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20JSC%20%28Tests%29/builds/908/steps/jscore-test/logs/stdio. 1086873 8 251157 commit-queue 2015-04-20 12:36:35 -0700 Comment on attachment 251157 Patch Clearing flags on attachment: 251157 Committed r183022: <http://trac.webkit.org/changeset/183022> 1086874 9 commit-queue 2015-04-20 12:36:39 -0700 All reviewed patches have been landed. Closing bug. 251155 2015-04-20 01:53:58 -0700 2015-04-20 01:57:34 -0700 Patch bug-143947-20150420175256.patch text/plain 2001 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyOTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm YTA5YWU0MjlhZDliYWMyMDRmNzdjMzZlZGFkZWYzMmVkZTNkZWQ0Li4xNTdjYzA3M2YyODYyYTdi Njc4MWY5NjEzOTdmZmVkNTgzNzQxOTA3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNS0wNC0yMCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBIYXNoTWFwIHN0b3JlaW5nIFByb3BlcnR5S2V5IFN0cmluZ0ltcGwq IG5lZWQgdG8gdXNlIElkZW50aWZpZXJSZXBIYXNoIHRvIGhhbmRsZSBTeW1ib2xzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM5NDcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworCQlUeXBlIHByb2ZpbGVyIGhhcyBtYXAg YmV0d2VlbiBQcm9wZXJ0eUtleSAoU3RyaW5nSW1wbCopIGFuZCBvZmZzZXQuCisJCVN0cmluZ0lt cGwqIGlzIGFsc28gdXNlZCBmb3IgU3ltYm9sIFByb3BlcnR5S2V5LgorCQlTbyBlcXVhbGl0eSBv ZiBoYXNoIHRhYmxlcyBpcyBjb25zaWRlcmVkIGJ5IGludGVybmVkIFN0cmluZ0ltcGwqJ3MgcG9p bnRlciB2YWx1ZS4KKwkJVG8gZG8gc28sIHVzZSBJZGVudGlmaWVyUmVwSGFzaCBpbnN0ZWFkIG9m IFN0cmluZ0hhc2guCisKKyAgICAgICAgKiBydW50aW1lL1N5bWJvbFRhYmxlLmg6CisKIDIwMTUt MDQtMTkgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAg SW50cm9kdWNlIGJ5dGVjb2RlIGludHJpbnNpY3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL1N5bWJvbFRhYmxlLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9TeW1ib2xUYWJsZS5oCmluZGV4IGM1OTI0NTQwODM3NDVlMDMzYjcyNWZlZjhkZDM3NDMw MTViN2FlMzQuLjg5Y2FjNjA0NDQwNDBkYWNiM2ZmNmVmZmRjNmZkZmQzNThmMGNkNWYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N5bWJvbFRhYmxlLmgKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3ltYm9sVGFibGUuaApAQCAtNDI1LDggKzQy NSw4IEBAIGNsYXNzIFN5bWJvbFRhYmxlIGZpbmFsIDogcHVibGljIEpTQ2VsbCB7CiAgICAgc3Rh dGljIGNvbnN0IHVuc2lnbmVkIFN0cnVjdHVyZUZsYWdzID0gQmFzZTo6U3RydWN0dXJlRmxhZ3Mg fCBTdHJ1Y3R1cmVJc0ltbW9ydGFsOwogCiAgICAgdHlwZWRlZiBIYXNoTWFwPFJlZlB0cjxTdHJp bmdJbXBsPiwgU3ltYm9sVGFibGVFbnRyeSwgSWRlbnRpZmllclJlcEhhc2gsIEhhc2hUcmFpdHM8 UmVmUHRyPFN0cmluZ0ltcGw+PiwgU3ltYm9sVGFibGVJbmRleEhhc2hUcmFpdHM+IE1hcDsKLSAg ICB0eXBlZGVmIEhhc2hNYXA8UmVmUHRyPFN0cmluZ0ltcGw+LCBHbG9iYWxWYXJpYWJsZUlEPiBV bmlxdWVJRE1hcDsKLSAgICB0eXBlZGVmIEhhc2hNYXA8UmVmUHRyPFN0cmluZ0ltcGw+LCBSZWZQ dHI8VHlwZVNldD4+IFVuaXF1ZVR5cGVTZXRNYXA7CisgICAgdHlwZWRlZiBIYXNoTWFwPFJlZlB0 cjxTdHJpbmdJbXBsPiwgR2xvYmFsVmFyaWFibGVJRCwgSWRlbnRpZmllclJlcEhhc2g+IFVuaXF1 ZUlETWFwOworICAgIHR5cGVkZWYgSGFzaE1hcDxSZWZQdHI8U3RyaW5nSW1wbD4sIFJlZlB0cjxU eXBlU2V0PiwgSWRlbnRpZmllclJlcEhhc2g+IFVuaXF1ZVR5cGVTZXRNYXA7CiAgICAgdHlwZWRl ZiBIYXNoTWFwPFZhck9mZnNldCwgUmVmUHRyPFN0cmluZ0ltcGw+PiBPZmZzZXRUb1ZhcmlhYmxl TWFwOwogICAgIHR5cGVkZWYgVmVjdG9yPFN5bWJvbFRhYmxlRW50cnkqPiBMb2NhbFRvRW50cnlW ZWM7CiAK 251156 2015-04-20 01:57:37 -0700 2015-04-20 01:58:39 -0700 Patch bug-143947-20150420175636.patch text/plain 2025 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyOTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm YTA5YWU0MjlhZDliYWMyMDRmNzdjMzZlZGFkZWYzMmVkZTNkZWQ0Li5hNmFkMDU3MWU3OTM3ZWY4 YjJhZTdhNmU1YWUzMjdjMDg1ZjQ1ZjhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNS0wNC0yMCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBIYXNoTWFwIHN0b3JlaW5nIFByb3BlcnR5S2V5IFN0cmluZ0ltcGwq IG5lZWQgdG8gdXNlIElkZW50aWZpZXJSZXBIYXNoIHRvIGhhbmRsZSBTeW1ib2xzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM5NDcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUeXBlIHByb2ZpbGVyIGhh cyBtYXAgYmV0d2VlbiBQcm9wZXJ0eUtleSAoU3RyaW5nSW1wbCopIGFuZCBvZmZzZXQuCisgICAg ICAgIFN0cmluZ0ltcGwqIGlzIGFsc28gdXNlZCBmb3IgU3ltYm9sIFByb3BlcnR5S2V5LgorICAg ICAgICBTbyBlcXVhbGl0eSBvZiBoYXNoIHRhYmxlcyBpcyBjb25zaWRlcmVkIGJ5IGludGVybmVk IFN0cmluZ0ltcGwqJ3MgcG9pbnRlciB2YWx1ZS4KKyAgICAgICAgVG8gZG8gc28sIHVzZSBJZGVu dGlmaWVyUmVwSGFzaCBpbnN0ZWFkIG9mIFN0cmluZ0hhc2guCisKKyAgICAgICAgKiBydW50aW1l L1N5bWJvbFRhYmxlLmg6CisKIDIwMTUtMDQtMTkgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRl YUBnbWFpbC5jb20+CiAKICAgICAgICAgSW50cm9kdWNlIGJ5dGVjb2RlIGludHJpbnNpY3MKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N5bWJvbFRhYmxlLmggYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TeW1ib2xUYWJsZS5oCmluZGV4IGM1OTI0NTQw ODM3NDVlMDMzYjcyNWZlZjhkZDM3NDMwMTViN2FlMzQuLjg5Y2FjNjA0NDQwNDBkYWNiM2ZmNmVm ZmRjNmZkZmQzNThmMGNkNWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL1N5bWJvbFRhYmxlLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3lt Ym9sVGFibGUuaApAQCAtNDI1LDggKzQyNSw4IEBAIGNsYXNzIFN5bWJvbFRhYmxlIGZpbmFsIDog cHVibGljIEpTQ2VsbCB7CiAgICAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIFN0cnVjdHVyZUZsYWdz ID0gQmFzZTo6U3RydWN0dXJlRmxhZ3MgfCBTdHJ1Y3R1cmVJc0ltbW9ydGFsOwogCiAgICAgdHlw ZWRlZiBIYXNoTWFwPFJlZlB0cjxTdHJpbmdJbXBsPiwgU3ltYm9sVGFibGVFbnRyeSwgSWRlbnRp ZmllclJlcEhhc2gsIEhhc2hUcmFpdHM8UmVmUHRyPFN0cmluZ0ltcGw+PiwgU3ltYm9sVGFibGVJ bmRleEhhc2hUcmFpdHM+IE1hcDsKLSAgICB0eXBlZGVmIEhhc2hNYXA8UmVmUHRyPFN0cmluZ0lt cGw+LCBHbG9iYWxWYXJpYWJsZUlEPiBVbmlxdWVJRE1hcDsKLSAgICB0eXBlZGVmIEhhc2hNYXA8 UmVmUHRyPFN0cmluZ0ltcGw+LCBSZWZQdHI8VHlwZVNldD4+IFVuaXF1ZVR5cGVTZXRNYXA7Cisg ICAgdHlwZWRlZiBIYXNoTWFwPFJlZlB0cjxTdHJpbmdJbXBsPiwgR2xvYmFsVmFyaWFibGVJRCwg SWRlbnRpZmllclJlcEhhc2g+IFVuaXF1ZUlETWFwOworICAgIHR5cGVkZWYgSGFzaE1hcDxSZWZQ dHI8U3RyaW5nSW1wbD4sIFJlZlB0cjxUeXBlU2V0PiwgSWRlbnRpZmllclJlcEhhc2g+IFVuaXF1 ZVR5cGVTZXRNYXA7CiAgICAgdHlwZWRlZiBIYXNoTWFwPFZhck9mZnNldCwgUmVmUHRyPFN0cmlu Z0ltcGw+PiBPZmZzZXRUb1ZhcmlhYmxlTWFwOwogICAgIHR5cGVkZWYgVmVjdG9yPFN5bWJvbFRh YmxlRW50cnkqPiBMb2NhbFRvRW50cnlWZWM7CiAK 251157 2015-04-20 01:58:42 -0700 2015-04-20 12:36:35 -0700 Patch bug-143947-20150420175741.patch text/plain 2024 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyOTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm YTA5YWU0MjlhZDliYWMyMDRmNzdjMzZlZGFkZWYzMmVkZTNkZWQ0Li4wMzFjNTA4MWRmNGI1YThi OTdkNGRlNTQ3YjkxMmU4ODM5YzQ5YmNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNS0wNC0yMCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBIYXNoTWFwIHN0b3JpbmcgUHJvcGVydHlLZXkgU3RyaW5nSW1wbCog bmVlZCB0byB1c2UgSWRlbnRpZmllclJlcEhhc2ggdG8gaGFuZGxlIFN5bWJvbHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0Mzk0NworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFR5cGUgcHJvZmlsZXIgaGFz IG1hcCBiZXR3ZWVuIFByb3BlcnR5S2V5IChTdHJpbmdJbXBsKikgYW5kIG9mZnNldC4KKyAgICAg ICAgU3RyaW5nSW1wbCogaXMgYWxzbyB1c2VkIGZvciBTeW1ib2wgUHJvcGVydHlLZXkuCisgICAg ICAgIFNvIGVxdWFsaXR5IG9mIGhhc2ggdGFibGVzIGlzIGNvbnNpZGVyZWQgYnkgaW50ZXJuZWQg U3RyaW5nSW1wbConcyBwb2ludGVyIHZhbHVlLgorICAgICAgICBUbyBkbyBzbywgdXNlIElkZW50 aWZpZXJSZXBIYXNoIGluc3RlYWQgb2YgU3RyaW5nSGFzaC4KKworICAgICAgICAqIHJ1bnRpbWUv U3ltYm9sVGFibGUuaDoKKwogMjAxNS0wNC0xOSAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVh QGdtYWlsLmNvbT4KIAogICAgICAgICBJbnRyb2R1Y2UgYnl0ZWNvZGUgaW50cmluc2ljcwpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3ltYm9sVGFibGUuaCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N5bWJvbFRhYmxlLmgKaW5kZXggYzU5MjQ1NDA4 Mzc0NWUwMzNiNzI1ZmVmOGRkMzc0MzAxNWI3YWUzNC4uODljYWM2MDQ0NDA0MGRhY2IzZmY2ZWZm ZGM2ZmRmZDM1OGYwY2Q1ZiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvU3ltYm9sVGFibGUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TeW1i b2xUYWJsZS5oCkBAIC00MjUsOCArNDI1LDggQEAgY2xhc3MgU3ltYm9sVGFibGUgZmluYWwgOiBw dWJsaWMgSlNDZWxsIHsKICAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQgU3RydWN0dXJlRmxhZ3Mg PSBCYXNlOjpTdHJ1Y3R1cmVGbGFncyB8IFN0cnVjdHVyZUlzSW1tb3J0YWw7CiAKICAgICB0eXBl ZGVmIEhhc2hNYXA8UmVmUHRyPFN0cmluZ0ltcGw+LCBTeW1ib2xUYWJsZUVudHJ5LCBJZGVudGlm aWVyUmVwSGFzaCwgSGFzaFRyYWl0czxSZWZQdHI8U3RyaW5nSW1wbD4+LCBTeW1ib2xUYWJsZUlu ZGV4SGFzaFRyYWl0cz4gTWFwOwotICAgIHR5cGVkZWYgSGFzaE1hcDxSZWZQdHI8U3RyaW5nSW1w bD4sIEdsb2JhbFZhcmlhYmxlSUQ+IFVuaXF1ZUlETWFwOwotICAgIHR5cGVkZWYgSGFzaE1hcDxS ZWZQdHI8U3RyaW5nSW1wbD4sIFJlZlB0cjxUeXBlU2V0Pj4gVW5pcXVlVHlwZVNldE1hcDsKKyAg ICB0eXBlZGVmIEhhc2hNYXA8UmVmUHRyPFN0cmluZ0ltcGw+LCBHbG9iYWxWYXJpYWJsZUlELCBJ ZGVudGlmaWVyUmVwSGFzaD4gVW5pcXVlSURNYXA7CisgICAgdHlwZWRlZiBIYXNoTWFwPFJlZlB0 cjxTdHJpbmdJbXBsPiwgUmVmUHRyPFR5cGVTZXQ+LCBJZGVudGlmaWVyUmVwSGFzaD4gVW5pcXVl VHlwZVNldE1hcDsKICAgICB0eXBlZGVmIEhhc2hNYXA8VmFyT2Zmc2V0LCBSZWZQdHI8U3RyaW5n SW1wbD4+IE9mZnNldFRvVmFyaWFibGVNYXA7CiAgICAgdHlwZWRlZiBWZWN0b3I8U3ltYm9sVGFi bGVFbnRyeSo+IExvY2FsVG9FbnRyeVZlYzsKIAo=