143935 2015-04-19 07:29:32 -0700 [CMake] Synchronize variables between WebKitFeatures.cmake and cmakedonfig.h.cmake 2015-04-22 06:57:23 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim commit-queue mcatanzaro oldest_to_newest 1086636 0 gyuyoung.kim 2015-04-19 07:29:32 -0700 Some variables misses in these files or unused variables aren't removed. Let's fix it. 1086637 1 251119 gyuyoung.kim 2015-04-19 07:31:39 -0700 Created attachment 251119 Patch 1086645 2 251119 darin 2015-04-19 10:38:38 -0700 Comment on attachment 251119 Patch Is there a way we can change this so it’s not a manual process? 1086709 3 gyuyoung.kim 2015-04-19 17:42:33 -0700 (In reply to comment #2) > Comment on attachment 251119 [details] > Patch > > Is there a way we can change this so it’s not a manual process? I think we may add this policy to check-coding-style, let me check it soon. Thanks. 1086711 4 251119 commit-queue 2015-04-19 18:29:40 -0700 Comment on attachment 251119 Patch Clearing flags on attachment: 251119 Committed r182996: <http://trac.webkit.org/changeset/182996> 1086712 5 commit-queue 2015-04-19 18:29:45 -0700 All reviewed patches have been landed. Closing bug. 1087359 6 mcatanzaro 2015-04-22 06:57:23 -0700 > Is there a way we can change this so it’s not a manual process? See bug #143997. (Note that I hadn't noticed this bug yet when I filed that, so the lists I give in the first comment are a bit outdated.) 251119 2015-04-19 07:31:39 -0700 2015-04-19 18:29:40 -0700 Patch bug-143935-20150419233037.patch text/plain 7234 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyOTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k ZXggZjc0N2RjODE0MTEzM2M4OTVhM2RhMzc4M2I0YWU1NWRlNWEwNDJiYy4uYmY0NWYyM2U3YzM5 NmE5OTM2ZTJkNWNmYmNmOWRhNjNlODhlOWU3YiAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr ZQpAQCAtNDEsNiArNDEsNyBAQCBtYWNybyhXRUJLSVRfT1BUSU9OX0JFR0lOKQogICAgIFdFQktJ VF9PUFRJT05fREVGSU5FKEVOQUJMRV9FUzZfQ0xBU1NfU1lOVEFYICJUb2dnbGUgRVM2IGNsYXNz IHN5bnRheCBzdXBwb3J0IiBPTikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfQ09O VEVOVF9GSUxURVJJTkcgIlRvZ2dsZSBjb250ZW50IGZpbHRlcmluZyBzdXBwb3J0IiBPRkYpCiAg ICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0NPTlRFWFRfTUVOVVMgIlRvZ2dsZSBDb250 ZXh0IE1lbnUgc3VwcG9ydCIgT04pCisgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0NS RURFTlRJQUxfU1RPUkFHRSAiVG9nZ2xlIENyZWRlbnRpYWwgU3RvcmFnZSBzdXBwb3J0IiBPRkYp CiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0NTUF9ORVhUICJUb2dnbGUgQ29udGVu dCBTZWN1cml0eSBQb2xpY3kgMS4xIHN1cHBvcnQiIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RF RklORShFTkFCTEVfQ1NTM19URVhUICJUb2dnbGUgQ1NTMyBUZXh0IHN1cHBvcnQiIE9GRikKICAg ICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfQ1NTM19URVhUX0xJTkVfQlJFQUsgIlRvZ2ds ZSBDU1MzIFRleHQgTGluZSBCcmVhayBzdXBwb3J0IiBPRkYpCkBAIC01Miw4ICs1Myw4IEBAIG1h Y3JvKFdFQktJVF9PUFRJT05fQkVHSU4pCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxF X0NTU19JTUFHRV9SRVNPTFVUSU9OICJUb2dnbGUgQ1NTIGltYWdlLXJlc29sdXRpb24gc3VwcG9y dCIgT0ZGKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9DU1NfSU1BR0VfU0VUICJU b2dnbGUgQ1NTIGltYWdlLXNldCBzdXBwb3J0IiBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZJ TkUoRU5BQkxFX0NTU19SRUdJT05TICJUb2dnbGUgQ1NTIHJlZ2lvbnMgc3VwcG9ydCIgT0ZGKQot ICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9DU1NfU0VMRUNUT1JTX0xFVkVMNCAiVG9n Z2xlIENTUyBTZWxlY3RvcnMgTGV2ZWwgNCBzdXBwb3J0IiBPRkYpCiAgICAgV0VCS0lUX09QVElP Tl9ERUZJTkUoRU5BQkxFX0NTU19TQ1JPTExfU05BUCAiVG9nZ2xlIENTUyBzbmFwIHNjcm9sbCBz dXBwb3J0IiBPRkYpCisgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0NTU19TRUxFQ1RP UlNfTEVWRUw0ICJUb2dnbGUgQ1NTIFNlbGVjdG9ycyBMZXZlbCA0IHN1cHBvcnQiIE9GRikKICAg ICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfQ1NTX1NIQVBFUyAiVG9nZ2xlIENTUyBTaGFw ZXMgc3VwcG9ydCIgT0ZGKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9DVVJTT1Jf VklTSUJJTElUWSAiVG9nZ2xlIGN1cnNvciB2aXNpYmlsaXR5IHN1cHBvcnQiIE9GRikKICAgICBX RUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfQ1VTVE9NX1NDSEVNRV9IQU5ETEVSICJUb2dnbGUg Q3VzdG9tIFNjaGVtZSBIYW5kbGVyIHN1cHBvcnQiIE9GRikKQEAgLTcwLDggKzcxLDggQEAgbWFj cm8oV0VCS0lUX09QVElPTl9CRUdJTikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVf RU5DUllQVEVEX01FRElBX1YyICJTdXBwb3J0IEVNRSB2MiIgT0ZGKQogICAgIFdFQktJVF9PUFRJ T05fREVGSU5FKEVOQUJMRV9GSUxURVJTX0xFVkVMXzIgIlRvZ2dsZSBGaWx0ZXJzIE1vZHVsZSBM ZXZlbCAyIiBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0ZPTlRfTE9BRF9F VkVOVFMgIlRvZ2dsZSBGb250IExvYWQgRXZlbnRzIHN1cHBvcnQiIE9GRikKLSAgICBXRUJLSVRf T1BUSU9OX0RFRklORShFTkFCTEVfRlRMX0pJVCAiVG9nZ2xlIEZUTCBzdXBwb3J0IGZvciBKU0Mi IE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfRlRQRElSICJUb2dnbGUgRlRQ IGRpcmVjdG9yeSBzdXBwb3J0IiBPTikKKyAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVf RlRMX0pJVCAiVG9nZ2xlIEZUTCBzdXBwb3J0IGZvciBKU0MiIE9GRikKICAgICBXRUJLSVRfT1BU SU9OX0RFRklORShFTkFCTEVfRlVMTFNDUkVFTl9BUEkgIlRvZ2dsZSBGdWxsc2NyZWVuIEFQSSBz dXBwb3J0IiBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0dBTUVQQUQgIlRv Z2dsZSBHYW1lcGFkIHN1cHBvcnQiIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFC TEVfR0FNRVBBRF9ERVBSRUNBVEVEICJUb2dnbGUgZGVwcmVjYXRlZCBHYW1lcGFkIHN1cHBvcnQi IE9GRikKQEAgLTE1MSwxMiArMTUyLDEyIEBAIG1hY3JvKFdFQktJVF9PUFRJT05fQkVHSU4pCiAg ICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1ZJREVPICJUb2dnbGUgVmlkZW8gc3VwcG9y dCIgT0ZGKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9WSURFT19UUkFDSyAiVG9n Z2xlIFRyYWNrIHN1cHBvcnQgZm9yIEhUTUw1IHZpZGVvIiBPRkYpCiAgICAgV0VCS0lUX09QVElP Tl9ERUZJTkUoRU5BQkxFX1ZJRVdfTU9ERV9DU1NfTUVESUEgIlRvZ2dsZSBUcmFjayBzdXBwb3J0 IGZvciB0aGUgdmlldy1tb2RlIG1lZGlhIEZlYXR1cmUiIE9OKQorICAgIFdFQktJVF9PUFRJT05f REVGSU5FKEVOQUJMRV9XRUJHTCAiVG9nZ2xlIDNEIGNhbnZhcyAoV2ViR0wpIHN1cHBvcnQiIE9G RikKKyAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfV0VCVlRUX1JFR0lPTlMgIlRvZ2ds ZSB3ZWJ2dHQgcmVnaW9uIHN1cHBvcnQiIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShF TkFCTEVfV0VCX0FVRElPICJUb2dnbGUgV2ViIEF1ZGlvIHN1cHBvcnQiIE9GRikKICAgICBXRUJL SVRfT1BUSU9OX0RFRklORShFTkFCTEVfV0VCX1JFUExBWSAiVG9nZ2xlIFdlYiBSZXBsYXkgc3Vw cG9ydCIgT0ZGKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9XRUJfU09DS0VUUyAi VG9nZ2xlIFdlYiBTb2NrZXRzIHN1cHBvcnQiIE9OKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5F KEVOQUJMRV9XRUJfVElNSU5HICJUb2dnbGUgV2ViIFRpbWluZyBzdXBwb3J0IiBPRkYpCi0gICAg V0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1dFQkdMICJUb2dnbGUgM0QgY2FudmFzIChXZWJH TCkgc3VwcG9ydCIgT0ZGKQotICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9XRUJWVFRf UkVHSU9OUyAiVG9nZ2xlIHdlYnZ0dCByZWdpb24gc3VwcG9ydCIgT0ZGKQogICAgIFdFQktJVF9P UFRJT05fREVGSU5FKEVOQUJMRV9YSFJfVElNRU9VVCAiVG9nZ2xlIFhIUiB0aW1lb3V0IHN1cHBv cnQiIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfWFNMVCAiVG9nZ2xlIFhT TFQgc3VwcG9ydCIgT04pCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoVVNFX1NZU1RFTV9NQUxM T0MgIlRvZ2dsZSBzeXN0ZW0gYWxsb2NhdG9yIGluc3RlYWQgb2YgV2ViS2l0J3MgY3VzdG9tIGFs bG9jYXRvciIgT0ZGKQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlY29uZmlnLmguY21ha2UgYi9T b3VyY2UvY21ha2Vjb25maWcuaC5jbWFrZQppbmRleCA1ZTk4M2Q1ZTY1YjA3ZWY3ZGM1M2VjOWQz YzZhOGEyOTM5MTc1Y2IyLi44NzdlZjVjMWVhYjQyYWRhNTc5OGEwNGJmMDA2Nzk2NTFlZGI3ZGFm IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2Vjb25maWcuaC5jbWFrZQorKysgYi9Tb3VyY2UvY21h a2Vjb25maWcuaC5jbWFrZQpAQCAtNCw2ICs0LDcgQEAKICNjbWFrZWRlZmluZTAxIEVOQUJMRV8z RF9SRU5ERVJJTkcKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9BQ0NFTEVSQVRFRF8yRF9DQU5WQVMK ICNjbWFrZWRlZmluZTAxIEVOQUJMRV9BQ0NFTEVSQVRFRF9PVkVSRkxPV19TQ1JPTExJTkcKKyNj bWFrZWRlZmluZTAxIEVOQUJMRV9BQ0NFU1NJQklMSVRZCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVf QVBJX1RFU1RTCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfQVRUQUNITUVOVF9FTEVNRU5UCiAjY21h a2VkZWZpbmUwMSBFTkFCTEVfQVZGX0NBUFRJT05TCkBAIC0yMSw4ICsyMiw4IEBACiAjY21ha2Vk ZWZpbmUwMSBFTkFCTEVfQ1NTM19URVhUCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfQ1NTM19URVhU X0xJTkVfQlJFQUsKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9DU1NfQk9YX0RFQ09SQVRJT05fQlJF QUsKLSNjbWFrZWRlZmluZTAxIEVOQUJMRV9DU1NfREVWSUNFX0FEQVBUQVRJT04KICNjbWFrZWRl ZmluZTAxIEVOQUJMRV9DU1NfQ09NUE9TSVRJTkcKKyNjbWFrZWRlZmluZTAxIEVOQUJMRV9DU1Nf REVWSUNFX0FEQVBUQVRJT04KICNjbWFrZWRlZmluZTAxIEVOQUJMRV9DU1NfR1JJRF9MQVlPVVQK ICNjbWFrZWRlZmluZTAxIEVOQUJMRV9DU1NfSU1BR0VfT1JJRU5UQVRJT04KICNjbWFrZWRlZmlu ZTAxIEVOQUJMRV9DU1NfSU1BR0VfUkVTT0xVVElPTgpAQCAtNDQsMTMgKzQ1LDExIEBACiAjY21h a2VkZWZpbmUwMSBFTkFCTEVfRFJBR19TVVBQT1JUCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfRU5D UllQVEVEX01FRElBCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfRU5DUllQVEVEX01FRElBX1YyCi0j Y21ha2VkZWZpbmUwMSBFTkFCTEVfRVZFTlRfTU9ERV9NRVRBVEFHUwogI2NtYWtlZGVmaW5lMDEg RU5BQkxFX0ZJTFRFUlNfTEVWRUxfMgotI2NtYWtlZGVmaW5lMDEgRU5BQkxFX0ZJWEVEX1JFUE9S VEVEX1NJWkUKKyNjbWFrZWRlZmluZTAxIEVOQUJMRV9GT05UX0xPQURfRVZFTlRTCiAjY21ha2Vk ZWZpbmUwMSBFTkFCTEVfRlRQRElSCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfRlRMX0pJVAogI2Nt YWtlZGVmaW5lMDEgRU5BQkxFX0ZUTF9OQVRJVkVfQ0FMTF9JTkxJTklORwotI2NtYWtlZGVmaW5l MDEgRU5BQkxFX0ZPTlRfTE9BRF9FVkVOVFMKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9GVUxMU0NS RUVOX0FQSQogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX0dBTUVQQUQKICNjbWFrZWRlZmluZTAxIEVO QUJMRV9HQU1FUEFEX0RFUFJFQ0FURUQKQEAgLTc4LDYgKzc3LDcgQEAKICNjbWFrZWRlZmluZTAx IEVOQUJMRV9MRUdBQ1lfV0VCX0FVRElPCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfTElOS19QUkVG RVRDSAogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX0xMSU5UX0NfTE9PUAorI2NtYWtlZGVmaW5lMDEg RU5BQkxFX01BQ19MT05HX1BSRVNTCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfTUFUSE1MCiAjY21h a2VkZWZpbmUwMSBFTkFCTEVfTUVESUFfQ0FQVFVSRQogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX01F RElBX0NPTlRST0xTX1NDUklQVApAQCAtMTA4LDkgKzEwOCw5IEBACiAjY21ha2VkZWZpbmUwMSBF TkFCTEVfUkVRVUVTVF9BTklNQVRJT05fRlJBTUUKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9SRVNP TFVUSU9OX01FRElBX1FVRVJZCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfUkVTT1VSQ0VfVElNSU5H CisjY21ha2VkZWZpbmUwMSBFTkFCTEVfU0FUVVJBVEVEX0xBWU9VVF9BUklUSE1FVElDCiAjY21h a2VkZWZpbmUwMSBFTkFCTEVfU0VDQ09NUF9GSUxURVJTCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVf U0VSVklDRV9DT05UUk9MUwotI2NtYWtlZGVmaW5lMDEgRU5BQkxFX1NBVFVSQVRFRF9MQVlPVVRf QVJJVEhNRVRJQwogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX1NNT09USF9TQ1JPTExJTkcKICNjbWFr ZWRlZmluZTAxIEVOQUJMRV9TUEVMTENIRUNLCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfU1RSRUFN U19BUEkKQEAgLTEyOCwxMSArMTI4LDEwIEBACiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfVklCUkFU SU9OCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfVklERU8KICNjbWFrZWRlZmluZTAxIEVOQUJMRV9W SURFT19UUkFDSwotI2NtYWtlZGVmaW5lMDEgRU5BQkxFX1ZJRVdQT1JUX1JFRkxPVwogI2NtYWtl ZGVmaW5lMDEgRU5BQkxFX1ZJRVdfTU9ERV9DU1NfTUVESUEKICNjbWFrZWRlZmluZTAxIEVOQUJM RV9XRUJHTAotI2NtYWtlZGVmaW5lMDEgRU5BQkxFX1dFQl9BVURJTwogI2NtYWtlZGVmaW5lMDEg RU5BQkxFX1dFQlZUVF9SRUdJT05TCisjY21ha2VkZWZpbmUwMSBFTkFCTEVfV0VCX0FVRElPCiAj Y21ha2VkZWZpbmUwMSBFTkFCTEVfV0VCX1JFUExBWQogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX1dF Ql9TT0NLRVRTCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfV0VCX1RJTUlORwpkaWZmIC0tZ2l0IGEv Q2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDI5MTRmNjFkYmQxNjAzNzZkZTUyODFlMzE3Mjhm ZjdiMmE5NWY4ZGIuLmFjZGI4Zjk2ZTQzMTk4MTAyYTVmZjkyY2IzN2EzZjljYTk3MzBiMTQgMTAw NjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAx NS0wNC0xOSAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgW0NNYWtlXSBTeW5jaHJvbml6ZSB2YXJpYWJsZXMgYmV0d2VlbiBXZWJLaXRGZWF0dXJlcy5j bWFrZSBhbmQgY21ha2Vkb25maWcuaC5jbWFrZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzOTM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgU29tZSB2YXJpYWJsZXMgYXJlbid0IGRlZmluZWQgaW4gdGhl c2UgZmlsZXMgb3IgdW51c2VkIHZhcmlhYmxlcyBhcmVuJ3QgcmVtb3ZlZC4gVGhpcworICAgICAg ICBwYXRjaCBjbGVhbnMgdXAgaXQgYXMgd2VsbCBhcyBmaXggd3JvbmcgYWxwaGFiZXQgb3JkZXIu CisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2U6CisgICAgICAg ICogU291cmNlL2NtYWtlY29uZmlnLmguY21ha2U6CisKIDIwMTUtMDQtMTYgIEJhc2lsZSBDbGVt ZW50ICA8YmFzaWxlX2NsZW1lbnRAYXBwbGUuY29tPgogCiAgICAgICAgIEV4dHJhY3QgdGhlIGFs bG9jYXRpb24gcHJvZmlsZSBmcm9tIEpTRnVuY3Rpb24gaW50byBhIHJhcmUgb2JqZWN0Cg==