143925 2015-04-18 14:58:26 -0700 CSSParser::parseValue() copies the m_parsedProperties vector at addParsedProperties() 2015-04-20 19:27:25 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=143970 P2 Normal --- 1 simon.fraser cdumez cdumez commit-queue darin kling koivisto simon.fraser oldest_to_newest 1086588 0 simon.fraser 2015-04-18 14:58:26 -0700 MutableStyleProperties::addParsedProperties() takes a const Vector<CSSProperty>& but m_parsedProperties is a Vector<CSSProperty, 256>, and apparently this forces a copy. 1086817 1 cdumez 2015-04-20 10:34:36 -0700 Very nice find :) We really supposed to use ParsedPropertyVector type here. 1086840 2 251171 cdumez 2015-04-20 11:34:04 -0700 Created attachment 251171 Patch 1086852 3 251171 simon.fraser 2015-04-20 11:46:49 -0700 Comment on attachment 251171 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251171&action=review > Source/WebCore/css/CSSParser.h:84 > + using ParsedPropertyVector = Vector<CSSProperty, 256>; Does the compiler enforce a match between this and the typedef? > Source/WebCore/css/StyleProperties.cpp:770 > + for (auto& property : properties) const auto&? 1086859 4 251171 cdumez 2015-04-20 11:50:07 -0700 Comment on attachment 251171 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251171&action=review >> Source/WebCore/css/CSSParser.h:84 >> + using ParsedPropertyVector = Vector<CSSProperty, 256>; > > Does the compiler enforce a match between this and the typedef? Which typedef? I just made the typedef public so it could be used in StyleProperties. I used a 'using' statement but it is equivalent to a typedef in this case. >> Source/WebCore/css/StyleProperties.cpp:770 >> + for (auto& property : properties) > > const auto&? auto will be a const CSSProperty so it is equivalent but OK. 1086862 5 251179 cdumez 2015-04-20 11:57:05 -0700 Created attachment 251179 Patch 1086869 6 cdumez 2015-04-20 12:07:22 -0700 To avoid mistakes like this in the future, I think we should make the following constructor explicit: template<size_t otherCapacity, typename otherOverflowBehaviour> Vector(const Vector<T, otherCapacity, otherOverflowBehaviour>&); I can look into this in a follow-up patch as it likely is a larger change. 1086877 7 251179 cdumez 2015-04-20 12:41:07 -0700 Comment on attachment 251179 Patch Clearing flags on attachment: 251179 Committed r183024: <http://trac.webkit.org/changeset/183024> 1086878 8 cdumez 2015-04-20 12:41:13 -0700 All reviewed patches have been landed. Closing bug. 1086973 9 cdumez 2015-04-20 19:27:17 -0700 (In reply to comment #6) > To avoid mistakes like this in the future, I think we should make the > following constructor explicit: > template<size_t otherCapacity, typename otherOverflowBehaviour> > Vector(const Vector<T, otherCapacity, otherOverflowBehaviour>&); > > I can look into this in a follow-up patch as it likely is a larger change. -> https://bugs.webkit.org/show_bug.cgi?id=143970 251171 2015-04-20 11:34:04 -0700 2015-04-20 11:57:02 -0700 Patch bug-143925-20150420113302.patch text/plain 4216 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzMDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2UyOGMzZmRkNzFiYTJh MmU4NmNiODFlNzI0Zjg3Mzg4MTkwZjkyOS4uZmRmMmY5YzUyZjlmMDYxMGJmMDI3YTk1M2RiMjcw MGQ4YTljMGY1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA0LTIwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQ1NTUGFyc2VyOjpwYXJzZVZh bHVlKCkgY29waWVzIHRoZSBtX3BhcnNlZFByb3BlcnRpZXMgdmVjdG9yIGF0IGFkZFBhcnNlZFBy b3BlcnRpZXMoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQzOTI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVXBkYXRlIE11dGFibGVTdHlsZVByb3BlcnRpZXM6OmFkZFBhcnNlZFByb3BlcnRpZXMoKSB0 byB1c2UKKyAgICAgICAgQ1NTUGFyc2VyOjpQYXJzZWRQcm9wZXJ0eVZlY3RvciB0eXBlIChpLmUu IFZlY3RvcjxDU1NQcm9wZXJ0eSwgMjU2PikKKyAgICAgICAgaW5zdGVhZCBvZiBWZWN0b3I8Q1NT UHJvcGVydHk+IHNvIHRoYXQgdGhlIHByb3BlcnRpZXMgdmVjdG9yIGlzIG5vCisgICAgICAgIGxv bmdlciBjb3BpZWQgdW5uZWNlc3NhcmlseSB0byBjb252ZXJ0IG9uZSB0eXBlIHRvIHRoZSBvdGhl ci4KKworICAgICAgICAqIGNzcy9DU1NQYXJzZXIuaDoKKyAgICAgICAgKiBjc3MvU3R5bGVQcm9w ZXJ0aWVzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok11dGFibGVTdHlsZVByb3BlcnRpZXM6OmFk ZFBhcnNlZFByb3BlcnRpZXMpOgorICAgICAgICAqIGNzcy9TdHlsZVByb3BlcnRpZXMuaDoKKwog MjAxNS0wNC0yMCAgUGVyIEFybmUgVm9sbGFuICA8cGVhdm9Ab3V0bG9vay5jb20+CiAKICAgICAg ICAgRmF2aWNvbnMgYXJlIG5vdCBhbHdheXMgbG9hZGVkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvY3NzL0NTU1BhcnNlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNw cAppbmRleCAzMGUwNWI2ZmQxN2Q3MjgzZDBiYjdhMDZhZjlkNzZmM2IyNzNiNDllLi45MmZiNjZm YjQ5Y2YxNjZlMzRlZWQzOWVmYTNiMzRmYjU2NTMyNmI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTUGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2Vy LmNwcApAQCAtMTAzLDYgKzEwMyw3IEBACiAKICNpZiBFTkFCTEUoQ1NTX0dSSURfTEFZT1VUKQog I2luY2x1ZGUgIkNTU0dyaWRMaW5lTmFtZXNWYWx1ZS5oIgorI2luY2x1ZGUgIkNTU0dyaWRUZW1w bGF0ZUFyZWFzVmFsdWUuaCIKICNlbmRpZgogCiAjaWYgRU5BQkxFKENTU19JTUFHRV9TRVQpCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmggYi9Tb3VyY2UvV2ViQ29y ZS9jc3MvQ1NTUGFyc2VyLmgKaW5kZXggZWFkMDMyNzFmZGMwYTlkYzI4MDhhYmRiNzQ2MjU1ZWE2 NDY1MmVhOC4uYzdjNWQ4ZGQ1NThkZDA3YWFlOTBmNTJlMTA2NmFkMjkzYzE3ZjdmNCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2Nzcy9DU1NQYXJzZXIuaApAQCAtNDMsNyArNDMsNyBAQAogI2luY2x1ZGUgPHd0Zi90ZXh0L1Rl eHRQb3NpdGlvbi5oPgogCiAjaWYgRU5BQkxFKENTU19HUklEX0xBWU9VVCkKLSNpbmNsdWRlICJD U1NHcmlkVGVtcGxhdGVBcmVhc1ZhbHVlLmgiCisjaW5jbHVkZSAiR3JpZENvb3JkaW5hdGUuaCIK ICNlbmRpZgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC04MSw2ICs4MSw4IEBAIHB1YmxpYzoK ICAgICAgICAgR2VuZXJhbFN5bnRheEVycm9yCiAgICAgfTsKIAorICAgIHVzaW5nIFBhcnNlZFBy b3BlcnR5VmVjdG9yID0gVmVjdG9yPENTU1Byb3BlcnR5LCAyNTY+OworCiAgICAgY2xhc3MgVmFs dWVXaXRoQ2FsY3VsYXRpb24gewogICAgIHB1YmxpYzoKICAgICAgICAgZXhwbGljaXQgVmFsdWVX aXRoQ2FsY3VsYXRpb24oQ1NTUGFyc2VyVmFsdWUmIHZhbHVlKQpAQCAtMzg5LDcgKzM5MSw2IEBA IHB1YmxpYzoKICAgICBzdGQ6OnVuaXF1ZV9wdHI8Q1NTUGFyc2VyVmFsdWVMaXN0PiBtX3ZhbHVl TGlzdDsKICAgICBib29sIG1fc3VwcG9ydHNDb25kaXRpb247CiAKLSAgICB0eXBlZGVmIFZlY3Rv cjxDU1NQcm9wZXJ0eSwgMjU2PiBQYXJzZWRQcm9wZXJ0eVZlY3RvcjsKICAgICBQYXJzZWRQcm9w ZXJ0eVZlY3RvciBtX3BhcnNlZFByb3BlcnRpZXM7CiAgICAgQ1NTU2VsZWN0b3JMaXN0KiBtX3Nl bGVjdG9yTGlzdEZvclBhcnNlU2VsZWN0b3I7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2Nzcy9TdHlsZVByb3BlcnRpZXMuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVy dGllcy5jcHAKaW5kZXggY2U3MDcwN2NhOWIwZWUzNDZmZDc3MDI2ZmZlN2ViNDIyNzQ1MjdiZi4u OWRmZDY3YjU4NjdmZGMzNmY4YTRmM2M2NTRkZjhiNmEzMDA0MjE4NiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydGllcy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv Y3NzL1N0eWxlUHJvcGVydGllcy5jcHAKQEAgLTc2NCwxMSArNzY0LDExIEBAIHZvaWQgTXV0YWJs ZVN0eWxlUHJvcGVydGllczo6cGFyc2VEZWNsYXJhdGlvbihjb25zdCBTdHJpbmcmIHN0eWxlRGVj bGFyYXRpb24sIFN0CiAgICAgcGFyc2VyLnBhcnNlRGVjbGFyYXRpb24odGhpcywgc3R5bGVEZWNs YXJhdGlvbiwgMCwgY29udGV4dFN0eWxlU2hlZXQpOwogfQogCi12b2lkIE11dGFibGVTdHlsZVBy b3BlcnRpZXM6OmFkZFBhcnNlZFByb3BlcnRpZXMoY29uc3QgVmVjdG9yPENTU1Byb3BlcnR5PiYg cHJvcGVydGllcykKK3ZvaWQgTXV0YWJsZVN0eWxlUHJvcGVydGllczo6YWRkUGFyc2VkUHJvcGVy dGllcyhjb25zdCBDU1NQYXJzZXI6OlBhcnNlZFByb3BlcnR5VmVjdG9yJiBwcm9wZXJ0aWVzKQog ewogICAgIG1fcHJvcGVydHlWZWN0b3IucmVzZXJ2ZUNhcGFjaXR5KG1fcHJvcGVydHlWZWN0b3Iu c2l6ZSgpICsgcHJvcGVydGllcy5zaXplKCkpOwotICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkg PCBwcm9wZXJ0aWVzLnNpemUoKTsgKytpKQotICAgICAgICBhZGRQYXJzZWRQcm9wZXJ0eShwcm9w ZXJ0aWVzW2ldKTsKKyAgICBmb3IgKGF1dG8mIHByb3BlcnR5IDogcHJvcGVydGllcykKKyAgICAg ICAgYWRkUGFyc2VkUHJvcGVydHkocHJvcGVydHkpOwogfQogCiB2b2lkIE11dGFibGVTdHlsZVBy b3BlcnRpZXM6OmFkZFBhcnNlZFByb3BlcnR5KGNvbnN0IENTU1Byb3BlcnR5JiBwcm9wZXJ0eSkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnRpZXMuaCBiL1NvdXJj ZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnRpZXMuaAppbmRleCA5ZTljZjIyMTBlYzA1MjdiZGFm N2Q4NjkwNzZiODEyMDNmMGY5MDdmLi4zZjA5ZDVkODlkOGQxYjRkNTlhNTBiMzEyNGFhMDUxZGZj NTRlZDYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVQcm9wZXJ0aWVzLmgK KysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydGllcy5oCkBAIC0yMiw2ICsyMiw3 IEBACiAjaWZuZGVmIFN0eWxlUHJvcGVydGllc19oCiAjZGVmaW5lIFN0eWxlUHJvcGVydGllc19o CiAKKyNpbmNsdWRlICJDU1NQYXJzZXIuaCIKICNpbmNsdWRlICJDU1NQYXJzZXJNb2RlLmgiCiAj aW5jbHVkZSAiQ1NTUHJpbWl0aXZlVmFsdWUuaCIKICNpbmNsdWRlICJDU1NQcm9wZXJ0eS5oIgpA QCAtMTkzLDcgKzE5NCw3IEBAIHB1YmxpYzoKIAogICAgIFByb3BlcnR5U2V0Q1NTU3R5bGVEZWNs YXJhdGlvbiogY3NzU3R5bGVEZWNsYXJhdGlvbigpOwogCi0gICAgdm9pZCBhZGRQYXJzZWRQcm9w ZXJ0aWVzKGNvbnN0IFZlY3RvcjxDU1NQcm9wZXJ0eT4mKTsKKyAgICB2b2lkIGFkZFBhcnNlZFBy b3BlcnRpZXMoY29uc3QgQ1NTUGFyc2VyOjpQYXJzZWRQcm9wZXJ0eVZlY3RvciYpOwogICAgIHZv aWQgYWRkUGFyc2VkUHJvcGVydHkoY29uc3QgQ1NTUHJvcGVydHkmKTsKIAogICAgIC8vIFRoZXNl IGV4cGFuZCBzaG9ydGhhbmQgcHJvcGVydGllcyBpbnRvIG11bHRpcGxlIHByb3BlcnRpZXMuCg== 251179 2015-04-20 11:57:05 -0700 2015-04-20 12:41:07 -0700 Patch bug-143925-20150420115607.patch text/plain 4256 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzMDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODEyMGY0MTZiYmE1MGEz MDVjMTE4YjY2MWQ0NmY0YzViMzM3MTFlOC4uOTNlYjQ3Y2I5MDZjMmE1MzU0ODYwZTVmOTliNDdk Y2M5ZTNlNmFlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA0LTIwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQ1NTUGFyc2VyOjpwYXJzZVZh bHVlKCkgY29waWVzIHRoZSBtX3BhcnNlZFByb3BlcnRpZXMgdmVjdG9yIGF0IGFkZFBhcnNlZFBy b3BlcnRpZXMoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQzOTI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgorCisgICAgICAg IFVwZGF0ZSBNdXRhYmxlU3R5bGVQcm9wZXJ0aWVzOjphZGRQYXJzZWRQcm9wZXJ0aWVzKCkgdG8g dXNlCisgICAgICAgIENTU1BhcnNlcjo6UGFyc2VkUHJvcGVydHlWZWN0b3IgdHlwZSAoaS5lLiBW ZWN0b3I8Q1NTUHJvcGVydHksIDI1Nj4pCisgICAgICAgIGluc3RlYWQgb2YgVmVjdG9yPENTU1By b3BlcnR5PiBzbyB0aGF0IHRoZSBwcm9wZXJ0aWVzIHZlY3RvciBpcyBubworICAgICAgICBsb25n ZXIgY29waWVkIHVubmVjZXNzYXJpbHkgdG8gY29udmVydCBvbmUgdHlwZSB0byB0aGUgb3RoZXIu CisKKyAgICAgICAgKiBjc3MvQ1NTUGFyc2VyLmg6CisgICAgICAgICogY3NzL1N0eWxlUHJvcGVy dGllcy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNdXRhYmxlU3R5bGVQcm9wZXJ0aWVzOjphZGRQ YXJzZWRQcm9wZXJ0aWVzKToKKyAgICAgICAgKiBjc3MvU3R5bGVQcm9wZXJ0aWVzLmg6CisKIDIw MTUtMDQtMjAgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAg ICAgU2V0dGluZyBpbmxpbmUgc3R5bGUgdG8gdGhlIHNhbWUgdmFsdWUgaXQgYWxyZWFkeSBoYXMg dHJpZ2dlcnMgYSBzdHlsZSByZWNhbGMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NQYXJzZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKaW5kZXggNGYy Y2RmMTE3Y2M1N2Y0YWYwNDNlYWE5NDUyNjdhNmVlMWNmMTlmNC4uZGUwMzdlMWYyODE5MzQ2YWM4 NmY2N2Y5ZTM0OWMwMWQ0NmE3YzgwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NT U1BhcnNlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKQEAgLTEw Myw2ICsxMDMsNyBAQAogCiAjaWYgRU5BQkxFKENTU19HUklEX0xBWU9VVCkKICNpbmNsdWRlICJD U1NHcmlkTGluZU5hbWVzVmFsdWUuaCIKKyNpbmNsdWRlICJDU1NHcmlkVGVtcGxhdGVBcmVhc1Zh bHVlLmgiCiAjZW5kaWYKIAogI2lmIEVOQUJMRShDU1NfSU1BR0VfU0VUKQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5oIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1Bh cnNlci5oCmluZGV4IDdjYTAyMjQ0NzU2NmFjODcwOTkzM2ZiYTgwMWUxMjExYTQ5OGJmNGYuLjA3 ZTM2OTlkYzc5Mzk1NDg0MGU0MDRhMjljYjkwNWJjOGFlZmQwNWYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFy c2VyLmgKQEAgLTQzLDcgKzQzLDcgQEAKICNpbmNsdWRlIDx3dGYvdGV4dC9UZXh0UG9zaXRpb24u aD4KIAogI2lmIEVOQUJMRShDU1NfR1JJRF9MQVlPVVQpCi0jaW5jbHVkZSAiQ1NTR3JpZFRlbXBs YXRlQXJlYXNWYWx1ZS5oIgorI2luY2x1ZGUgIkdyaWRDb29yZGluYXRlLmgiCiAjZW5kaWYKIAog bmFtZXNwYWNlIFdlYkNvcmUgewpAQCAtODcsNiArODcsOCBAQCBwdWJsaWM6CiAgICAgICAgIEVy cm9yCiAgICAgfTsKIAorICAgIHVzaW5nIFBhcnNlZFByb3BlcnR5VmVjdG9yID0gVmVjdG9yPENT U1Byb3BlcnR5LCAyNTY+OworCiAgICAgY2xhc3MgVmFsdWVXaXRoQ2FsY3VsYXRpb24gewogICAg IHB1YmxpYzoKICAgICAgICAgZXhwbGljaXQgVmFsdWVXaXRoQ2FsY3VsYXRpb24oQ1NTUGFyc2Vy VmFsdWUmIHZhbHVlKQpAQCAtMzk3LDcgKzM5OSw2IEBAIHB1YmxpYzoKICAgICBzdGQ6OnVuaXF1 ZV9wdHI8Q1NTUGFyc2VyVmFsdWVMaXN0PiBtX3ZhbHVlTGlzdDsKICAgICBib29sIG1fc3VwcG9y dHNDb25kaXRpb247CiAKLSAgICB0eXBlZGVmIFZlY3RvcjxDU1NQcm9wZXJ0eSwgMjU2PiBQYXJz ZWRQcm9wZXJ0eVZlY3RvcjsKICAgICBQYXJzZWRQcm9wZXJ0eVZlY3RvciBtX3BhcnNlZFByb3Bl cnRpZXM7CiAgICAgQ1NTU2VsZWN0b3JMaXN0KiBtX3NlbGVjdG9yTGlzdEZvclBhcnNlU2VsZWN0 b3I7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnRpZXMuY3Bw IGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydGllcy5jcHAKaW5kZXggN2MwMDM2YTc4 MTlkOGI0ZjRmZjJkZjc0NjBjMTkxNDZmZWM2NmIwMC4uMmU1NzBkM2Q2YmM4ZmJlNTI3MjYwNDgz NzM4MzAzN2Y1MTEyZGM4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJv cGVydGllcy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydGllcy5jcHAK QEAgLTc2NywxMiArNzY3LDEyIEBAIHZvaWQgTXV0YWJsZVN0eWxlUHJvcGVydGllczo6cGFyc2VE ZWNsYXJhdGlvbihjb25zdCBTdHJpbmcmIHN0eWxlRGVjbGFyYXRpb24sIFN0CiAgICAgcGFyc2Vy LnBhcnNlRGVjbGFyYXRpb24odGhpcywgc3R5bGVEZWNsYXJhdGlvbiwgMCwgY29udGV4dFN0eWxl U2hlZXQpOwogfQogCi1ib29sIE11dGFibGVTdHlsZVByb3BlcnRpZXM6OmFkZFBhcnNlZFByb3Bl cnRpZXMoY29uc3QgVmVjdG9yPENTU1Byb3BlcnR5PiYgcHJvcGVydGllcykKK2Jvb2wgTXV0YWJs ZVN0eWxlUHJvcGVydGllczo6YWRkUGFyc2VkUHJvcGVydGllcyhjb25zdCBDU1NQYXJzZXI6OlBh cnNlZFByb3BlcnR5VmVjdG9yJiBwcm9wZXJ0aWVzKQogewogICAgIGJvb2wgYW55Q2hhbmdlZCA9 IGZhbHNlOwogICAgIG1fcHJvcGVydHlWZWN0b3IucmVzZXJ2ZUNhcGFjaXR5KG1fcHJvcGVydHlW ZWN0b3Iuc2l6ZSgpICsgcHJvcGVydGllcy5zaXplKCkpOwotICAgIGZvciAodW5zaWduZWQgaSA9 IDA7IGkgPCBwcm9wZXJ0aWVzLnNpemUoKTsgKytpKSB7Ci0gICAgICAgIGlmIChhZGRQYXJzZWRQ cm9wZXJ0eShwcm9wZXJ0aWVzW2ldKSkKKyAgICBmb3IgKGNvbnN0IGF1dG8mIHByb3BlcnR5IDog cHJvcGVydGllcykgeworICAgICAgICBpZiAoYWRkUGFyc2VkUHJvcGVydHkocHJvcGVydHkpKQog ICAgICAgICAgICAgYW55Q2hhbmdlZCA9IHRydWU7CiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9jc3MvU3R5bGVQcm9wZXJ0aWVzLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5 bGVQcm9wZXJ0aWVzLmgKaW5kZXggMzIyM2NhNWE3YzNmZjQ3YTk0YzRiMmI4ZDI2MjNiMThiOWUx Y2NhMC4uMzdjZmUxYzc1YzhjYzU0NTJlNTVlMDIyMzMxY2RhNTdmOWYxOWM2OSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydGllcy5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL2Nzcy9TdHlsZVByb3BlcnRpZXMuaApAQCAtMjIsNiArMjIsNyBAQAogI2lmbmRlZiBTdHls ZVByb3BlcnRpZXNfaAogI2RlZmluZSBTdHlsZVByb3BlcnRpZXNfaAogCisjaW5jbHVkZSAiQ1NT UGFyc2VyLmgiCiAjaW5jbHVkZSAiQ1NTUGFyc2VyTW9kZS5oIgogI2luY2x1ZGUgIkNTU1ByaW1p dGl2ZVZhbHVlLmgiCiAjaW5jbHVkZSAiQ1NTUHJvcGVydHkuaCIKQEAgLTE5Myw3ICsxOTQsNyBA QCBwdWJsaWM6CiAKICAgICBQcm9wZXJ0eVNldENTU1N0eWxlRGVjbGFyYXRpb24qIGNzc1N0eWxl RGVjbGFyYXRpb24oKTsKIAotICAgIGJvb2wgYWRkUGFyc2VkUHJvcGVydGllcyhjb25zdCBWZWN0 b3I8Q1NTUHJvcGVydHk+Jik7CisgICAgYm9vbCBhZGRQYXJzZWRQcm9wZXJ0aWVzKGNvbnN0IENT U1BhcnNlcjo6UGFyc2VkUHJvcGVydHlWZWN0b3ImKTsKICAgICBib29sIGFkZFBhcnNlZFByb3Bl cnR5KGNvbnN0IENTU1Byb3BlcnR5Jik7CiAKICAgICAvLyBUaGVzZSBleHBhbmQgc2hvcnRoYW5k IHByb3BlcnRpZXMgaW50byBtdWx0aXBsZSBwcm9wZXJ0aWVzLgo=