143909 2015-04-17 17:04:07 -0700 Web Inspector: All sans-serif font family rules should be set the same way. 2015-04-20 18:40:46 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 jonowells jonowells commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1086493 0 jonowells 2015-04-17 17:04:07 -0700 Our font-family rules for the sans-serif font are set in one of three ways: font-family: -webkit-system-font, sans-serif; /* the is preferred */ font-family: Helvetica, sans-serif; font-family: sans-serif; All should be: font-family: -webkit-system-font, sans-serif; 1086494 1 webkit-bug-importer 2015-04-17 17:04:25 -0700 <rdar://problem/20596200> 1086513 2 251079 jonowells 2015-04-17 20:03:27 -0700 Created attachment 251079 [PATCH] style update 1086517 3 251079 commit-queue 2015-04-17 21:05:44 -0700 Comment on attachment 251079 [PATCH] style update Clearing flags on attachment: 251079 Committed r182982: <http://trac.webkit.org/changeset/182982> 1086518 4 commit-queue 2015-04-17 21:05:49 -0700 All reviewed patches have been landed. Closing bug. 1086965 5 joepeck 2015-04-20 18:40:46 -0700 This caused a lot of regressions in ObjectTrees. On Yosemite, all of the text looks like it moved down a pixel, and is therefore off-balance. Is there a way we can fix this easily? Will we need to add body.yosemite adjustments? 251079 2015-04-17 20:03:27 -0700 2015-04-17 21:05:44 -0700 [PATCH] style update bug-143909-20150417200227.patch text/plain 3902 jonowells U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyOTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA1 Mjc5YTI0ZWU2MTVmNzcyZmY3ZWY2MDA5Y2MzNGFiZDU1MzgxYWNiLi5lMTljZmE5NDJmZWE3MTJh ZGZlYTdiMWM5YzMxYTc3YTVhNWFiMjU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNS0wNC0xNyAgSm9ubyBXZWxscyAgPGpvbm93ZWxsc0BhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQWxsIHNhbnMtc2VyaWYgZm9udCBmYW1pbHkgcnVs ZXMgc2hvdWxkIGJlIHNldCB0aGUgc2FtZSB3YXkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM5MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgc3R5bGVzIHNvIHRoYXQgYWxsIHVzZXMgb2Yg c2Fucy1zZXJpZiBmb250IHVzZSAtd2Via2l0LXN5c3RlbS1mb250IGNvbnNpc3RlbnRseS4KKwor ICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvRGVmYXVsdERhc2hib2FyZFZpZXcuY3NzOgor ICAgICAgICAoYm9keS5tYWMtcGxhdGZvcm0ubGVnYWN5IC50b29sYmFyIC5kYXNoYm9hcmQuZGVm YXVsdCA+IC5pdGVtKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL09iamVjdFRyZWVQ cm9wZXJ0eVRyZWVFbGVtZW50LmNzczoKKyAgICAgICAgKC5vYmplY3QtdHJlZS1wcm9wZXJ0eSAu cHJvdG90eXBlLW5hbWUpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0VHJl ZVZpZXcuY3NzOgorICAgICAgICAoLm9iamVjdC10cmVlLW91dGxpbmUgbGkgLmVtcHR5LW1lc3Nh Z2UpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvUmVuZGVyaW5nRnJhbWVUaW1lbGlu ZU92ZXJ2aWV3R3JhcGguY3NzOgorICAgICAgICAoLnRpbWVsaW5lLW92ZXJ2aWV3LWdyYXBoLnJl bmRlcmluZy1mcmFtZSA+IC5kaXZpZGVyID4gLmxhYmVsKToKKwogMjAxNS0wNC0xNyAgVGltb3Ro eSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog SGF2ZSBiZXR0ZXIgaW5hY3RpdmUgd2luZG93IGNvbG9yIGZvciBwaXhlbCBib3JkZXJzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EZWZhdWx0 RGFzaGJvYXJkVmlldy5jc3MgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9EZWZhdWx0RGFzaGJvYXJkVmlldy5jc3MKaW5kZXggZDI1YjcwODA3OWQ4ZDBkM2ZjNzQ5 ZWM1N2NkY2NhODVmYmFmY2I4Yy4uNDFlY2YwMWYyNGU2ZDNlZmUzMjI0MjU4NmQ5ZjUxN2U3ZTIx NmNmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvRGVmYXVsdERhc2hib2FyZFZpZXcuY3NzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0RlZmF1bHREYXNoYm9hcmRWaWV3LmNzcwpAQCAtNTQsNyArNTQs NyBAQCBib2R5LmphdmFzY3JpcHQgLnRvb2xiYXIgLmRhc2hib2FyZC5kZWZhdWx0ID4gOm1hdGNo ZXMoLnRpbWUsIC5yZXNvdXJjZXNTaXplLCAucgogfQogCiBib2R5Lm1hYy1wbGF0Zm9ybS5sZWdh Y3kgLnRvb2xiYXIgLmRhc2hib2FyZC5kZWZhdWx0ID4gLml0ZW0gewotICAgIGZvbnQtZmFtaWx5 OiBIZWx2ZXRpY2EsIHNhbnMtc2VyaWY7CisgICAgZm9udC1mYW1pbHk6IC13ZWJraXQtc3lzdGVt LWZvbnQsIHNhbnMtc2VyaWY7CiAgICAgZm9udC13ZWlnaHQ6IGJvbGQ7CiB9CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL09iamVjdFRyZWVQ cm9wZXJ0eVRyZWVFbGVtZW50LmNzcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL09iamVjdFRyZWVQcm9wZXJ0eVRyZWVFbGVtZW50LmNzcwppbmRleCA1YTVhMDYx Y2Y3NzViZjc3YmFjMzdlMGY1OWFlOThmOWVhNThmYjhlLi5jZGU0NTRjYjkzYTNhYjU1YWQzMTg0 NGU5NDc4YzZkNWE4OTIxYzM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9PYmplY3RUcmVlUHJvcGVydHlUcmVlRWxlbWVudC5jc3MKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0VHJlZVByb3Bl cnR5VHJlZUVsZW1lbnQuY3NzCkBAIC0xMjIsNyArMTIyLDcgQEAKIC5vYmplY3QtdHJlZS1wcm9w ZXJ0eSAucHJvcGVydHktbmFtZSwKIC5vYmplY3QtdHJlZS1wcm9wZXJ0eSAuZnVuY3Rpb24tcGFy YW1ldGVycywKIC5vYmplY3QtdHJlZS1wcm9wZXJ0eSAucHJvdG90eXBlLW5hbWUgewotICAgIGZv bnQtZmFtaWx5OiBzYW5zLXNlcmlmOworICAgIGZvbnQtZmFtaWx5OiAtd2Via2l0LXN5c3RlbS1m b250LCBzYW5zLXNlcmlmOwogICAgIGZvbnQtc2l6ZTogMTJweDsKIH0KIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0VHJlZVZpZXcu Y3NzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0VHJl ZVZpZXcuY3NzCmluZGV4IGE2YzUwY2FmN2M1NDFkMzlmMTY2YjdlNzM4ZjQ4ZWNiYmUwNDY5NmUu LmMyNGQ1YzE5OGExMWY1YWYxYzIwYjhlNDY0NGYzM2JjOWRjNDAxODEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL09iamVjdFRyZWVWaWV3LmNz cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9PYmplY3RU cmVlVmlldy5jc3MKQEAgLTExOCw3ICsxMTgsNyBAQAogLm9iamVjdC10cmVlLW91dGxpbmUgbGkg LmVtcHR5LW1lc3NhZ2UgewogICAgIGNvbG9yOiByZ2IoNjAlLCA2MCUsIDYwJSk7CiAgICAgbWFy Z2luLWxlZnQ6IDdweDsKLSAgICBmb250LWZhbWlseTogc2Fucy1zZXJpZjsKKyAgICBmb250LWZh bWlseTogLXdlYmtpdC1zeXN0ZW0tZm9udCwgc2Fucy1zZXJpZjsKICAgICBmb250LXNpemU6IDEy cHg7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL1JlbmRlcmluZ0ZyYW1lVGltZWxpbmVPdmVydmlld0dyYXBoLmNzcyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1JlbmRlcmluZ0ZyYW1lVGltZWxpbmVP dmVydmlld0dyYXBoLmNzcwppbmRleCBjMzVmYzA2MTI3ZmUwMTU2N2IxMmVkMmY4NWU2NTRhMzFk NmQxYTI5Li45YzhmMTUwZTIwOWM1Yjg3NDE4ZjlhYWI5MDFiMTM5MDYxNDAzOTlhIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZW5kZXJpbmdG cmFtZVRpbWVsaW5lT3ZlcnZpZXdHcmFwaC5jc3MKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvUmVuZGVyaW5nRnJhbWVUaW1lbGluZU92ZXJ2aWV3R3JhcGgu Y3NzCkBAIC0zNiw3ICszNiw3IEBACiAKIC50aW1lbGluZS1vdmVydmlldy1ncmFwaC5yZW5kZXJp bmctZnJhbWUgPiAuZGl2aWRlciA+IC5sYWJlbCB7CiAgICAgcGFkZGluZzogMnB4OwotICAgIGZv bnQtZmFtaWx5OiBIZWx2ZXRpY2EsIHNhbnMtc2VyaWY7CisgICAgZm9udC1mYW1pbHk6IC13ZWJr aXQtc3lzdGVtLWZvbnQsIHNhbnMtc2VyaWY7CiAgICAgZm9udC1zaXplOiA4cHg7CiAKICAgICBj b2xvcjogcmdiKDE1NSwgMTU1LCAxNTUpOwo=