<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>143900</bug_id>
          
          <creation_ts>2015-04-17 15:51:46 -0700</creation_ts>
          <short_desc>[CMake] Include ICU unconditionally on the source lists</short_desc>
          <delta_ts>2015-04-20 08:24:54 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Martin Robinson">mrobinson</reporter>
          <assigned_to name="Martin Robinson">mrobinson</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1086459</commentid>
    <comment_count>0</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2015-04-17 15:51:46 -0700</bug_when>
    <thetext>Now that ICU is used by all CMake ports, it can be integrated directly into WebCore&apos;s main source list.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1086460</commentid>
    <comment_count>1</comment_count>
      <attachid>251060</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2015-04-17 15:54:19 -0700</bug_when>
    <thetext>Created attachment 251060
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1086785</commentid>
    <comment_count>2</comment_count>
      <attachid>251060</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2015-04-20 08:24:50 -0700</bug_when>
    <thetext>Comment on attachment 251060
Patch

Clearing flags on attachment: 251060

Committed r183012: &lt;http://trac.webkit.org/changeset/183012&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1086786</commentid>
    <comment_count>3</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2015-04-20 08:24:54 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>251060</attachid>
            <date>2015-04-17 15:54:19 -0700</date>
            <delta_ts>2015-04-20 08:24:50 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-143900-20150417155319.patch</filename>
            <type>text/plain</type>
            <size>4285</size>
            <attacher name="Martin Robinson">mrobinson</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyOTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjc4ZDQ2MjY3MmEwNjUw
ZjBlODdjOTliOTcwZDQ3NTc5YTYyNWM1ZS4uOGU1NGNkYjQ2ODRmMGMxMDI1ZWQ2ZTRmNzVmNDZk
YmRmOWVmYWIwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA0LTE3ICBNYXJ0
aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBbQ01ha2VdIElu
Y2x1ZGUgSUNVIHVuY29uZGl0aW9uYWxseSBvbiB0aGUgc291cmNlIGxpc3RzCisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM5MDAKKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFRoaXMg
aXMganVzdCBhIGJ1aWxkIGZpbGUgY2hhbmdlLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6
IEludGVncmF0ZSBJQ1Ugc291cmNlIGZpbGVzLCBpbmNsdWRlcywgYW5kIGxpYnJhcmllcyBpbnRv
IHRoZSBtYWluCisgICAgICAgIHNlY3Rpb25zLiBUaGV5IGFyZSBzaGFyZWQgYnkgYWxsIHBsYXRm
b3Jtcy4KKyAgICAgICAgKiBQbGF0Zm9ybUdUSy5jbWFrZTogRWxpbWluYXRlIGJ1aWxkIHJ1bGVz
IHRoYXQgYXJlIGR1cGxpY2F0ZWQgZnJvbSB0aGUgbWFpbiBDTWFrZUxpc3RzLnR4dC4KKwogMjAx
NS0wNC0xNyAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAgICAgRm9yY2Ug
bW91c2UgZXZlbnRzIHNob3VsZCBnbyB0aHJvdWdoIG5vcm1hbCBtb3VzZSBldmVudCBoYW5kbGlu
ZyBjb2RlIHBhdGhzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dCBi
L1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CmluZGV4IGE2OTA1MTU4NmU2YzJlYmIwNGJk
ZDg4OWU0YmY1NWI0NDg0NWY4NTkuLjNkZjk0ZWYzOTRhZmE4ZmU1MzA0NjM4MTNkZDEyOGMwZWZl
MGFjNTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CkBAIC0xMjksNiArMTI5LDcgQEAgc2V0KFdlYkNv
cmVfSU5DTFVERV9ESVJFQ1RPUklFUwogICAgICIke0RFUklWRURfU09VUkNFU19XRUJDT1JFX0RJ
Un0iCiAgICAgIiR7Q01BS0VfU09VUkNFX0RJUn0vU291cmNlIgogICAgICIke0NNQUtFX0JJTkFS
WV9ESVJ9IgorICAgICR7SUNVX0lOQ0xVREVfRElSU30KICkKIAogc2V0KFdlYkNvcmVfSURMX0lO
Q0xVREVTCkBAIC0yMjcyLDE0ICsyMjczLDIwIEBAIHNldChXZWJDb3JlX1NPVVJDRVMKICAgICBw
bGF0Zm9ybS90ZXh0L1RleHRCb3VuZGFyaWVzLmNwcAogICAgIHBsYXRmb3JtL3RleHQvVGV4dEJy
ZWFrSXRlcmF0b3IuY3BwCiAgICAgcGxhdGZvcm0vdGV4dC9UZXh0Q29kZWMuY3BwCisgICAgcGxh
dGZvcm0vdGV4dC9UZXh0Q29kZWNJQ1UuY3BwCiAgICAgcGxhdGZvcm0vdGV4dC9UZXh0Q29kZWNM
YXRpbjEuY3BwCiAgICAgcGxhdGZvcm0vdGV4dC9UZXh0Q29kZWNVVEYxNi5jcHAKICAgICBwbGF0
Zm9ybS90ZXh0L1RleHRDb2RlY1VURjguY3BwCiAgICAgcGxhdGZvcm0vdGV4dC9UZXh0Q29kZWNV
c2VyRGVmaW5lZC5jcHAKICAgICBwbGF0Zm9ybS90ZXh0L1RleHRFbmNvZGluZy5jcHAKKyAgICBw
bGF0Zm9ybS90ZXh0L1RleHRFbmNvZGluZ0RldGVjdG9ySUNVLmNwcAogICAgIHBsYXRmb3JtL3Rl
eHQvVGV4dEVuY29kaW5nUmVnaXN0cnkuY3BwCiAgICAgcGxhdGZvcm0vdGV4dC9UZXh0U3RyZWFt
LmNwcAogCisgICAgcGxhdGZvcm0vdGV4dC9pY3UvVVRleHRQcm92aWRlci5jcHAKKyAgICBwbGF0
Zm9ybS90ZXh0L2ljdS9VVGV4dFByb3ZpZGVyTGF0aW4xLmNwcAorICAgIHBsYXRmb3JtL3RleHQv
aWN1L1VUZXh0UHJvdmlkZXJVVEYxNi5jcHAKKwogICAgIHBsdWdpbnMvRE9NTWltZVR5cGUuY3Bw
CiAgICAgcGx1Z2lucy9ET01NaW1lVHlwZUFycmF5LmNwcAogICAgIHBsdWdpbnMvRE9NUGx1Z2lu
LmNwcApAQCAtMjc3Niw2ICsyNzgzLDcgQEAgc2V0KFdlYkNvcmVfUExVR19JTlNfUkVTT1VSQ0VT
CiApCiAKIHNldChXZWJDb3JlX0xJQlJBUklFUworICAgICR7SUNVX0xJQlJBUklFU30KICAgICBK
YXZhU2NyaXB0Q29yZQogICAgIFdURgogKQpAQCAtMjk4MiwyMCArMjk5MCw2IEBAIGlmIChFTkFC
TEVfUVVPVEEpCiAgICAgKQogZW5kaWYgKCkKIAotbGlzdChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VT
Ci0gICAgcGxhdGZvcm0vdGV4dC9UZXh0Q29kZWNJQ1UuY3BwCi0gICAgcGxhdGZvcm0vdGV4dC9U
ZXh0RW5jb2RpbmdEZXRlY3RvcklDVS5jcHAKLSAgICBwbGF0Zm9ybS90ZXh0L2ljdS9VVGV4dFBy
b3ZpZGVyLmNwcAotICAgIHBsYXRmb3JtL3RleHQvaWN1L1VUZXh0UHJvdmlkZXJMYXRpbjEuY3Bw
Ci0gICAgcGxhdGZvcm0vdGV4dC9pY3UvVVRleHRQcm92aWRlclVURjE2LmNwcAotKQotbGlzdChB
UFBFTkQgV2ViQ29yZV9JTkNMVURFX0RJUkVDVE9SSUVTCi0gICAgJHtJQ1VfSU5DTFVERV9ESVJT
fQotKQotbGlzdChBUFBFTkQgV2ViQ29yZV9MSUJSQVJJRVMKLSAgICAke0lDVV9MSUJSQVJJRVN9
Ci0pCi0KIGlmIChXVEZfVVNFXzNEX0dSQVBISUNTKQogICAgICMgRm9yIHBsYXRmb3JtcyB0aGF0
IHdhbnQgdG8gdXNlIHN5c3RlbS1wcm92aWRlZCBPcGVuR0wgKEVTKSBoZWFkZXJzLAogICAgICMg
dGhlc2UgaW5jbHVkZSBkaXJlY3RvcmllcyBuZWVkIHRvIGJlIGFkZGVkIGJlZm9yZSB0aGUgQU5H
TEUgZGlyZWN0b3JpZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdUSy5j
bWFrZSBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtlCmluZGV4IDIxMDU3MjhlY2E5
ODQwOTFjNTBlYjAyY2U5ZGY0OTE0ZTU0ZjM3MGUuLmI4MWM5ZDU3MmIzNWU2YjM3ZDgzZWY2ZjYz
MDc0MDYzMmFhOTE1MjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNt
YWtlCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtlCkBAIC0yMSw3ICsyMSw2
IEBAIGxpc3QoQVBQRU5EIFdlYkNvcmVfSU5DTFVERV9ESVJFQ1RPUklFUwogICAgICIke1dFQkNP
UkVfRElSfS9wbGF0Zm9ybS9uZXR3b3JrL2d0ayIKICAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZv
cm0vbmV0d29yay9zb3VwIgogICAgICIke1dFQkNPUkVfRElSfS9wbGF0Zm9ybS90ZXh0L2d0ayIK
LSAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vdGV4dC9pY3UiCiApCiAKIGxpc3QoQVBQRU5E
IFdlYkNvcmVfU09VUkNFUwpAQCAtMTc0LDEyICsxNzMsNyBAQCBsaXN0KEFQUEVORCBXZWJDb3Jl
X1NPVVJDRVMKICAgICBwbGF0Zm9ybS9zb3VwL1NoYXJlZEJ1ZmZlclNvdXAuY3BwCiAgICAgcGxh
dGZvcm0vc291cC9VUkxTb3VwLmNwcAogCi0gICAgcGxhdGZvcm0vdGV4dC9pY3UvVVRleHRQcm92
aWRlci5jcHAKLSAgICBwbGF0Zm9ybS90ZXh0L2ljdS9VVGV4dFByb3ZpZGVyTGF0aW4xLmNwcAot
ICAgIHBsYXRmb3JtL3RleHQvaWN1L1VUZXh0UHJvdmlkZXJVVEYxNi5jcHAKICAgICBwbGF0Zm9y
bS90ZXh0L0xvY2FsZUlDVS5jcHAKLSAgICBwbGF0Zm9ybS90ZXh0L1RleHRDb2RlY0lDVS5jcHAK
LSAgICBwbGF0Zm9ybS90ZXh0L1RleHRFbmNvZGluZ0RldGVjdG9ySUNVLmNwcAogCiAgICAgcGxh
dGZvcm0vdGV4dC9lbmNoYW50L1RleHRDaGVja2VyRW5jaGFudC5jcHAKIApAQCAtMjY4LDcgKzI2
Miw2IEBAIGxpc3QoQVBQRU5EIFdlYkNvcmVfTElCUkFSSUVTCiAgICAgJHtHTElCX0xJQlJBUklF
U30KICAgICAke0dVREVWX0xJQlJBUklFU30KICAgICAke0hBUkZCVVpaX0xJQlJBUklFU30KLSAg
ICAke0lDVV9MSUJSQVJJRVN9CiAgICAgJHtKUEVHX0xJQlJBUklFU30KICAgICAke0xJQlNFQ1JF
VF9MSUJSQVJJRVN9CiAgICAgJHtMSUJTT1VQX0xJQlJBUklFU30KQEAgLTI5NSw3ICsyODgsNiBA
QCBsaXN0KEFQUEVORCBXZWJDb3JlX0lOQ0xVREVfRElSRUNUT1JJRVMKICAgICAke0dMSUJfSU5D
TFVERV9ESVJTfQogICAgICR7R1VERVZfSU5DTFVERV9ESVJTfQogICAgICR7SEFSRkJVWlpfSU5D
TFVERV9ESVJTfQotICAgICR7SUNVX0lOQ0xVREVfRElSU30KICAgICAke0xJQlNFQ1JFVF9JTkNM
VURFX0RJUlN9CiAgICAgJHtMSUJTT1VQX0lOQ0xVREVfRElSU30KICAgICAke0xJQlhNTDJfSU5D
TFVERV9ESVJ9Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>