143887 2015-04-17 11:25:38 -0700 RenderTableCell::computeCollapsed*Border() should check if the cell is still attached to the render tree. 2015-04-17 12:54:13 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser oldest_to_newest 1086372 0 zalan 2015-04-17 11:25:38 -0700 Detached cell can't access to its parent table renderer. 1086373 1 zalan 2015-04-17 11:26:26 -0700 rdar://problem/20568989 1086377 2 251035 zalan 2015-04-17 11:35:24 -0700 Created attachment 251035 Patch 1086393 3 251035 commit-queue 2015-04-17 12:54:09 -0700 Comment on attachment 251035 Patch Clearing flags on attachment: 251035 Committed r182962: <http://trac.webkit.org/changeset/182962> 1086394 4 commit-queue 2015-04-17 12:54:13 -0700 All reviewed patches have been landed. Closing bug. 251035 2015-04-17 11:35:24 -0700 2015-04-17 12:54:09 -0700 Patch bug-143887-20150417113425.patch text/plain 6521 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyOTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzlkZWY4MGQwNzRhNDlh ODY0ZTZiZjVlNDZkZWM5ODc5YTUyMTZmNC4uNTE0NDU3YTUzMjNjMzViZmY4M2YyOWIzMjVjNjE5 YzQ4NzY3OTFiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA0LTE3ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmVuZGVyVGFibGVDZWxsOjpj b21wdXRlQ29sbGFwc2VkKkJvcmRlcigpIHNob3VsZCBjaGVjayBpZiB0aGUgY2VsbCBpcyBzdGls bCBhdHRhY2hlZCB0byB0aGUgcmVuZGVyIHRyZWUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM4ODcKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMjA1 Njg5ODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBE ZXRhY2hlZCB0YWJsZSBjZWxsIGhhcyBubyBhY2Nlc3MgdG8gaXRzIHBhcmVudCB0YWJsZS4gVGhp cyBpcyBhIHNwZWN1bGF0aXZlIGZpeCB0bworICAgICAgICBhdm9pZCBkZXJlZmVyZW5jaW5nIHRo ZSBpbnZhbGlkIHRhYmxlIHBvaW50ZXIuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGFi bGVDZWxsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRhYmxlQ2VsbDo6Y29tcHV0ZUNv bGxhcHNlZFN0YXJ0Qm9yZGVyKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRhYmxlQ2VsbDo6 Y29tcHV0ZUNvbGxhcHNlZEVuZEJvcmRlcik6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUYWJs ZUNlbGw6OmNvbXB1dGVDb2xsYXBzZWRCZWZvcmVCb3JkZXIpOgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyVGFibGVDZWxsOjpjb21wdXRlQ29sbGFwc2VkQWZ0ZXJCb3JkZXIpOgorCiAyMDE1LTA0 LTE3ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBV bnJldmlld2VkLCByb2xsaW5nIG91dCByMTgyOTEyIGFuZCByMTgyOTIwLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlQ2VsbC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmNwcAppbmRleCBiY2M1ZGIzOWM2ZjBkMzkx MmJlZTFlNmQ3NmJhNDg0NGExODk4ZGQ2Li4yMjk3YjI4YmI4NThmZTgwZTJkY2RkYTUwNGYwMzI1 MGIyNjlmZTBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFi bGVDZWxsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxs LmNwcApAQCAtNTM3LDE0ICs1MzcsMTUgQEAgQ29sbGFwc2VkQm9yZGVyVmFsdWUgUmVuZGVyVGFi bGVDZWxsOjpjb2xsYXBzZWRTdGFydEJvcmRlcihJbmNsdWRlQm9yZGVyQ29sb3JPck4KIAogQ29s bGFwc2VkQm9yZGVyVmFsdWUgUmVuZGVyVGFibGVDZWxsOjpjb21wdXRlQ29sbGFwc2VkU3RhcnRC b3JkZXIoSW5jbHVkZUJvcmRlckNvbG9yT3JOb3QgaW5jbHVkZUNvbG9yKSBjb25zdAogewotICAg IFJlbmRlclRhYmxlKiB0YWJsZSA9IHRoaXMtPnRhYmxlKCk7Ci0KICAgICAvLyBGb3IgdGhlIHN0 YXJ0IGJvcmRlciwgd2UgbmVlZCB0byBjaGVjaywgaW4gb3JkZXIgb2YgcHJlY2VkZW5jZToKICAg ICAvLyAoMSkgT3VyIHN0YXJ0IGJvcmRlci4KICAgICBpbnQgc3RhcnRDb2xvclByb3BlcnR5ID0g aW5jbHVkZUNvbG9yID8gQ1NTUHJvcGVydHk6OnJlc29sdmVEaXJlY3Rpb25Bd2FyZVByb3BlcnR5 KENTU1Byb3BlcnR5V2Via2l0Qm9yZGVyU3RhcnRDb2xvciwgc3R5bGVGb3JDZWxsRmxvdygpLmRp cmVjdGlvbigpLCBzdHlsZUZvckNlbGxGbG93KCkud3JpdGluZ01vZGUoKSkgOiAwOwogICAgIGlu dCBlbmRDb2xvclByb3BlcnR5ID0gaW5jbHVkZUNvbG9yID8gQ1NTUHJvcGVydHk6OnJlc29sdmVE aXJlY3Rpb25Bd2FyZVByb3BlcnR5KENTU1Byb3BlcnR5V2Via2l0Qm9yZGVyRW5kQ29sb3IsIHN0 eWxlRm9yQ2VsbEZsb3coKS5kaXJlY3Rpb24oKSwgc3R5bGVGb3JDZWxsRmxvdygpLndyaXRpbmdN b2RlKCkpIDogMDsKICAgICBDb2xsYXBzZWRCb3JkZXJWYWx1ZSByZXN1bHQoc3R5bGUoKS5ib3Jk ZXJTdGFydCgpLCBpbmNsdWRlQ29sb3IgPyBzdHlsZSgpLnZpc2l0ZWREZXBlbmRlbnRDb2xvcihz dGFydENvbG9yUHJvcGVydHkpIDogQ29sb3IoKSwgQkNFTEwpOwogCisgICAgUmVuZGVyVGFibGUq IHRhYmxlID0gdGhpcy0+dGFibGUoKTsKKyAgICBpZiAoIXRhYmxlKQorICAgICAgICByZXR1cm4g cmVzdWx0OwogICAgIC8vICgyKSBUaGUgZW5kIGJvcmRlciBvZiB0aGUgcHJlY2VkaW5nIGNlbGwu CiAgICAgUmVuZGVyVGFibGVDZWxsKiBjZWxsQmVmb3JlID0gdGFibGUtPmNlbGxCZWZvcmUodGhp cyk7CiAgICAgaWYgKGNlbGxCZWZvcmUpIHsKQEAgLTY0NywxNyArNjQ4LDE4IEBAIENvbGxhcHNl ZEJvcmRlclZhbHVlIFJlbmRlclRhYmxlQ2VsbDo6Y29sbGFwc2VkRW5kQm9yZGVyKEluY2x1ZGVC b3JkZXJDb2xvck9yTm90CiAKIENvbGxhcHNlZEJvcmRlclZhbHVlIFJlbmRlclRhYmxlQ2VsbDo6 Y29tcHV0ZUNvbGxhcHNlZEVuZEJvcmRlcihJbmNsdWRlQm9yZGVyQ29sb3JPck5vdCBpbmNsdWRl Q29sb3IpIGNvbnN0CiB7Ci0gICAgUmVuZGVyVGFibGUqIHRhYmxlID0gdGhpcy0+dGFibGUoKTsK LSAgICAvLyBOb3RlOiBXZSBoYXZlIHRvIHVzZSB0aGUgZWZmZWN0aXZlIGNvbHVtbiBpbmZvcm1h dGlvbiBpbnN0ZWFkIG9mIHdoZXRoZXIgd2UgaGF2ZSBhIGNlbGwgYWZ0ZXIgYXMgYSB0YWJsZSBk b2Vzbid0Ci0gICAgLy8gaGF2ZSB0byBiZSByZWd1bGFyIChhbnkgcm93IGNhbiBoYXZlIGxlc3Mg Y2VsbHMgdGhhbiB0aGUgdG90YWwgY2VsbCBjb3VudCkuCi0gICAgYm9vbCBpc0VuZENvbHVtbiA9 IHRhYmxlLT5jb2xUb0VmZkNvbChjb2woKSArIGNvbFNwYW4oKSAtIDEpID09IHRhYmxlLT5udW1F ZmZDb2xzKCkgLSAxOwotCiAgICAgLy8gRm9yIGVuZCBib3JkZXIsIHdlIG5lZWQgdG8gY2hlY2ss IGluIG9yZGVyIG9mIHByZWNlZGVuY2U6CiAgICAgLy8gKDEpIE91ciBlbmQgYm9yZGVyLgogICAg IGludCBzdGFydENvbG9yUHJvcGVydHkgPSBpbmNsdWRlQ29sb3IgPyBDU1NQcm9wZXJ0eTo6cmVz b2x2ZURpcmVjdGlvbkF3YXJlUHJvcGVydHkoQ1NTUHJvcGVydHlXZWJraXRCb3JkZXJTdGFydENv bG9yLCBzdHlsZUZvckNlbGxGbG93KCkuZGlyZWN0aW9uKCksIHN0eWxlRm9yQ2VsbEZsb3coKS53 cml0aW5nTW9kZSgpKSA6IDA7CiAgICAgaW50IGVuZENvbG9yUHJvcGVydHkgPSBpbmNsdWRlQ29s b3IgPyBDU1NQcm9wZXJ0eTo6cmVzb2x2ZURpcmVjdGlvbkF3YXJlUHJvcGVydHkoQ1NTUHJvcGVy dHlXZWJraXRCb3JkZXJFbmRDb2xvciwgc3R5bGVGb3JDZWxsRmxvdygpLmRpcmVjdGlvbigpLCBz dHlsZUZvckNlbGxGbG93KCkud3JpdGluZ01vZGUoKSkgOiAwOwogICAgIENvbGxhcHNlZEJvcmRl clZhbHVlIHJlc3VsdCA9IENvbGxhcHNlZEJvcmRlclZhbHVlKHN0eWxlKCkuYm9yZGVyRW5kKCks IGluY2x1ZGVDb2xvciA/IHN0eWxlKCkudmlzaXRlZERlcGVuZGVudENvbG9yKGVuZENvbG9yUHJv cGVydHkpIDogQ29sb3IoKSwgQkNFTEwpOwotICAgIAorCisgICAgUmVuZGVyVGFibGUqIHRhYmxl ID0gdGhpcy0+dGFibGUoKTsKKyAgICBpZiAoIXRhYmxlKQorICAgICAgICByZXR1cm4gcmVzdWx0 OworICAgIC8vIE5vdGU6IFdlIGhhdmUgdG8gdXNlIHRoZSBlZmZlY3RpdmUgY29sdW1uIGluZm9y bWF0aW9uIGluc3RlYWQgb2Ygd2hldGhlciB3ZSBoYXZlIGEgY2VsbCBhZnRlciBhcyBhIHRhYmxl IGRvZXNuJ3QKKyAgICAvLyBoYXZlIHRvIGJlIHJlZ3VsYXIgKGFueSByb3cgY2FuIGhhdmUgbGVz cyBjZWxscyB0aGFuIHRoZSB0b3RhbCBjZWxsIGNvdW50KS4KKyAgICBib29sIGlzRW5kQ29sdW1u ID0gdGFibGUtPmNvbFRvRWZmQ29sKGNvbCgpICsgY29sU3BhbigpIC0gMSkgPT0gdGFibGUtPm51 bUVmZkNvbHMoKSAtIDE7CiAgICAgLy8gKDIpIFRoZSBzdGFydCBib3JkZXIgb2YgdGhlIGZvbGxv d2luZyBjZWxsLgogICAgIGlmICghaXNFbmRDb2x1bW4pIHsKICAgICAgICAgaWYgKFJlbmRlclRh YmxlQ2VsbCogY2VsbEFmdGVyID0gdGFibGUtPmNlbGxBZnRlcih0aGlzKSkgewpAQCAtNzU5LDE0 ICs3NjEsMTUgQEAgQ29sbGFwc2VkQm9yZGVyVmFsdWUgUmVuZGVyVGFibGVDZWxsOjpjb2xsYXBz ZWRCZWZvcmVCb3JkZXIoSW5jbHVkZUJvcmRlckNvbG9yT3IKIAogQ29sbGFwc2VkQm9yZGVyVmFs dWUgUmVuZGVyVGFibGVDZWxsOjpjb21wdXRlQ29sbGFwc2VkQmVmb3JlQm9yZGVyKEluY2x1ZGVC b3JkZXJDb2xvck9yTm90IGluY2x1ZGVDb2xvcikgY29uc3QKIHsKLSAgICBSZW5kZXJUYWJsZSog dGFibGUgPSB0aGlzLT50YWJsZSgpOwotCiAgICAgLy8gRm9yIGJlZm9yZSBib3JkZXIsIHdlIG5l ZWQgdG8gY2hlY2ssIGluIG9yZGVyIG9mIHByZWNlZGVuY2U6CiAgICAgLy8gKDEpIE91ciBiZWZv cmUgYm9yZGVyLgogICAgIGludCBiZWZvcmVDb2xvclByb3BlcnR5ID0gaW5jbHVkZUNvbG9yID8g Q1NTUHJvcGVydHk6OnJlc29sdmVEaXJlY3Rpb25Bd2FyZVByb3BlcnR5KENTU1Byb3BlcnR5V2Vi a2l0Qm9yZGVyQmVmb3JlQ29sb3IsIHN0eWxlRm9yQ2VsbEZsb3coKS5kaXJlY3Rpb24oKSwgc3R5 bGVGb3JDZWxsRmxvdygpLndyaXRpbmdNb2RlKCkpIDogMDsKICAgICBpbnQgYWZ0ZXJDb2xvclBy b3BlcnR5ID0gaW5jbHVkZUNvbG9yID8gQ1NTUHJvcGVydHk6OnJlc29sdmVEaXJlY3Rpb25Bd2Fy ZVByb3BlcnR5KENTU1Byb3BlcnR5V2Via2l0Qm9yZGVyQWZ0ZXJDb2xvciwgc3R5bGVGb3JDZWxs RmxvdygpLmRpcmVjdGlvbigpLCBzdHlsZUZvckNlbGxGbG93KCkud3JpdGluZ01vZGUoKSkgOiAw OwogICAgIENvbGxhcHNlZEJvcmRlclZhbHVlIHJlc3VsdCA9IENvbGxhcHNlZEJvcmRlclZhbHVl KHN0eWxlKCkuYm9yZGVyQmVmb3JlKCksIGluY2x1ZGVDb2xvciA/IHN0eWxlKCkudmlzaXRlZERl cGVuZGVudENvbG9yKGJlZm9yZUNvbG9yUHJvcGVydHkpIDogQ29sb3IoKSwgQkNFTEwpOwogICAg IAorICAgIFJlbmRlclRhYmxlKiB0YWJsZSA9IHRoaXMtPnRhYmxlKCk7CisgICAgaWYgKCF0YWJs ZSkKKyAgICAgICAgcmV0dXJuIHJlc3VsdDsKICAgICBSZW5kZXJUYWJsZUNlbGwqIHByZXZDZWxs ID0gdGFibGUtPmNlbGxBYm92ZSh0aGlzKTsKICAgICBpZiAocHJldkNlbGwpIHsKICAgICAgICAg Ly8gKDIpIEEgYmVmb3JlIGNlbGwncyBhZnRlciBib3JkZXIuCkBAIC04NTUsMTQgKzg1OCwxNSBA QCBDb2xsYXBzZWRCb3JkZXJWYWx1ZSBSZW5kZXJUYWJsZUNlbGw6OmNvbGxhcHNlZEFmdGVyQm9y ZGVyKEluY2x1ZGVCb3JkZXJDb2xvck9yTgogCiBDb2xsYXBzZWRCb3JkZXJWYWx1ZSBSZW5kZXJU YWJsZUNlbGw6OmNvbXB1dGVDb2xsYXBzZWRBZnRlckJvcmRlcihJbmNsdWRlQm9yZGVyQ29sb3JP ck5vdCBpbmNsdWRlQ29sb3IpIGNvbnN0CiB7Ci0gICAgUmVuZGVyVGFibGUqIHRhYmxlID0gdGhp cy0+dGFibGUoKTsKLQogICAgIC8vIEZvciBhZnRlciBib3JkZXIsIHdlIG5lZWQgdG8gY2hlY2ss IGluIG9yZGVyIG9mIHByZWNlZGVuY2U6CiAgICAgLy8gKDEpIE91ciBhZnRlciBib3JkZXIuCiAg ICAgaW50IGJlZm9yZUNvbG9yUHJvcGVydHkgPSBpbmNsdWRlQ29sb3IgPyBDU1NQcm9wZXJ0eTo6 cmVzb2x2ZURpcmVjdGlvbkF3YXJlUHJvcGVydHkoQ1NTUHJvcGVydHlXZWJraXRCb3JkZXJCZWZv cmVDb2xvciwgc3R5bGVGb3JDZWxsRmxvdygpLmRpcmVjdGlvbigpLCBzdHlsZUZvckNlbGxGbG93 KCkud3JpdGluZ01vZGUoKSkgOiAwOwogICAgIGludCBhZnRlckNvbG9yUHJvcGVydHkgPSBpbmNs dWRlQ29sb3IgPyBDU1NQcm9wZXJ0eTo6cmVzb2x2ZURpcmVjdGlvbkF3YXJlUHJvcGVydHkoQ1NT UHJvcGVydHlXZWJraXRCb3JkZXJBZnRlckNvbG9yLCBzdHlsZUZvckNlbGxGbG93KCkuZGlyZWN0 aW9uKCksIHN0eWxlRm9yQ2VsbEZsb3coKS53cml0aW5nTW9kZSgpKSA6IDA7CiAgICAgQ29sbGFw c2VkQm9yZGVyVmFsdWUgcmVzdWx0ID0gQ29sbGFwc2VkQm9yZGVyVmFsdWUoc3R5bGUoKS5ib3Jk ZXJBZnRlcigpLCBpbmNsdWRlQ29sb3IgPyBzdHlsZSgpLnZpc2l0ZWREZXBlbmRlbnRDb2xvcihh ZnRlckNvbG9yUHJvcGVydHkpIDogQ29sb3IoKSwgQkNFTEwpOwogICAgIAorICAgIFJlbmRlclRh YmxlKiB0YWJsZSA9IHRoaXMtPnRhYmxlKCk7CisgICAgaWYgKCF0YWJsZSkKKyAgICAgICAgcmV0 dXJuIHJlc3VsdDsKICAgICBSZW5kZXJUYWJsZUNlbGwqIG5leHRDZWxsID0gdGFibGUtPmNlbGxC ZWxvdyh0aGlzKTsKICAgICBpZiAobmV4dENlbGwpIHsKICAgICAgICAgLy8gKDIpIEFuIGFmdGVy IGNlbGwncyBiZWZvcmUgYm9yZGVyLgo=