143866 2015-04-17 01:51:35 -0700 [SOUP] Redirect to non HTTP destination is broken 2015-04-17 03:15:02 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, Soup P2 Normal --- 1 cgarcia webkit-unassigned danw svillar oldest_to_newest 1086264 0 cgarcia 2015-04-17 01:51:35 -0700 This is because we are passing true unconditionally as isHTTPFamilyRequest parameter of createSoupRequestAndMessageForHandle in continueAfterWillSendRequest. I wrote a unit tests using a data URI to reproduce it: $ bin/TestWebKitAPI/WebKit2Gtk/TestLoaderClient -p /webkit2/WebKitWebPage/redirect-to-data-uri /webkit2/WebKitWebPage/redirect-to-data-uri: (WebKitWebProcess:19126): GLib-GObject-WARNING **: invalid cast from 'SoupRequestData' to 'SoupRequestHTTP' (WebKitWebProcess:19126): libsoup-CRITICAL **: soup_request_http_get_message: assertion 'SOUP_IS_REQUEST_HTTP (http)' failed ** ERROR:../../Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:292:void resourceGetDataCallback(GObject*, GAsyncResult*, gpointer): assertion failed: (data) Abortado 1086267 1 251007 cgarcia 2015-04-17 02:05:02 -0700 Created attachment 251007 Patch 1086279 2 251007 svillar 2015-04-17 02:57:05 -0700 Comment on attachment 251007 Patch Nice catch! 1086283 3 cgarcia 2015-04-17 03:15:02 -0700 Committed r182943: <http://trac.webkit.org/changeset/182943> 251007 2015-04-17 02:05:02 -0700 2015-04-17 02:57:05 -0700 Patch wk-redirect-to-data.diff text/plain 7214 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyNzhiN2VmLi5lMThhYjliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTUtMDQtMTcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtTT1VQXSBSZWRpcmVjdCB0byBub24gSFRUUCBkZXN0aW5hdGlvbiBpcyBi cm9rZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 Mzg2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo aXMgaXMgYmVjYXVzZSB3ZSBhcmUgcGFzc2luZyB0cnVlIHVuY29uZGl0aW9uYWxseSBhcworICAg ICAgICBpc0hUVFBGYW1pbHlSZXF1ZXN0IHBhcmFtZXRlciBvZgorICAgICAgICBjcmVhdGVTb3Vw UmVxdWVzdEFuZE1lc3NhZ2VGb3JIYW5kbGUgaW4gY29udGludWVBZnRlcldpbGxTZW5kUmVxdWVz dC4KKyAgICAgICAgV2UgZG9uJ3QgYWN0dWFsbHkgbmVlZCB0byBwYXNzIGlzSFRUUEZhbWlseVJl cXVlc3QgcGFyYW1ldGVyIHRvCisgICAgICAgIGNyZWF0ZVNvdXBSZXF1ZXN0QW5kTWVzc2FnZUZv ckhhbmRsZSwgc2luY2UgaXQgY2FuIHNpbXBseSBjaGVjaworICAgICAgICB0aGF0IGZyb20gdGhl IGdpdmVuIHJlcXVlc3QuCisKKyAgICAgICAgQ292ZXJlZCBieSB1bml0IHRldHMgYW5kIGFsc28g Y2FjaGUvZGlzay1jYWNoZS9kaXNrLWNhY2hlLXJlZGlyZWN0LXRvLWRhdGEuaHRtbC4KKworICAg ICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6Y29udGludWVBZnRlcldpbGxTZW5kUmVxdWVzdCk6CisgICAgICAgIChX ZWJDb3JlOjpjcmVhdGVTb3VwUmVxdWVzdEFuZE1lc3NhZ2VGb3JIYW5kbGUpOgorICAgICAgICAo V2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OnN0YXJ0KToKKwogMjAxNS0wNC0xNiAgQWxleCBDaHJp c3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFVzZSBsZXNzIG1l bW9yeSB3aGVuIGNvbXBpbGluZyBjb250ZW50IGV4dGVuc2lvbnMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5j cHAKaW5kZXggNTViODBmMC4uMTljZDUxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKQEAgLTIy Nyw3ICsyMjcsNyBAQCBwcml2YXRlOgogICAgIEhhc2hTZXQ8U3RyaW5nPiBtX2NlcnRpZmljYXRl czsKIH07CiAKLXN0YXRpYyBib29sIGNyZWF0ZVNvdXBSZXF1ZXN0QW5kTWVzc2FnZUZvckhhbmRs ZShSZXNvdXJjZUhhbmRsZSosIGNvbnN0IFJlc291cmNlUmVxdWVzdCYsIGJvb2wgaXNIVFRQRmFt aWx5UmVxdWVzdCk7CitzdGF0aWMgYm9vbCBjcmVhdGVTb3VwUmVxdWVzdEFuZE1lc3NhZ2VGb3JI YW5kbGUoUmVzb3VyY2VIYW5kbGUqLCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmKTsKIHN0YXRpYyB2 b2lkIGNsZWFudXBTb3VwUmVxdWVzdE9wZXJhdGlvbihSZXNvdXJjZUhhbmRsZSosIGJvb2wgaXNE ZXN0cm95aW5nID0gZmFsc2UpOwogc3RhdGljIHZvaWQgc2VuZFJlcXVlc3RDYWxsYmFjayhHT2Jq ZWN0KiwgR0FzeW5jUmVzdWx0KiwgZ3BvaW50ZXIpOwogc3RhdGljIHZvaWQgcmVhZENhbGxiYWNr KEdPYmplY3QqLCBHQXN5bmNSZXN1bHQqLCBncG9pbnRlcik7CkBAIC00NjgsNyArNDY4LDcgQEAg c3RhdGljIHZvaWQgY29udGludWVBZnRlcldpbGxTZW5kUmVxdWVzdChSZXNvdXJjZUhhbmRsZSog aGFuZGxlLCBjb25zdCBSZXNvdXJjZVIKICAgICBpZiAocHJvdG9jb2xIb3N0QW5kUG9ydEFyZUVx dWFsKG5ld1JlcXVlc3QudXJsKCksIGQtPm1fcmVzcG9uc2UudXJsKCkpKQogICAgICAgICBhcHBs eUF1dGhlbnRpY2F0aW9uVG9SZXF1ZXN0KGhhbmRsZSwgbmV3UmVxdWVzdCwgdHJ1ZSk7CiAKLSAg ICBpZiAoIWNyZWF0ZVNvdXBSZXF1ZXN0QW5kTWVzc2FnZUZvckhhbmRsZShoYW5kbGUsIG5ld1Jl cXVlc3QsIHRydWUpKSB7CisgICAgaWYgKCFjcmVhdGVTb3VwUmVxdWVzdEFuZE1lc3NhZ2VGb3JI YW5kbGUoaGFuZGxlLCBuZXdSZXF1ZXN0KSkgewogICAgICAgICBkLT5jbGllbnQoKS0+Y2Fubm90 U2hvd1VSTChoYW5kbGUpOwogICAgICAgICByZXR1cm47CiAgICAgfQpAQCAtOTY3LDcgKzk2Nyw3 IEBAIHN0YXRpYyBib29sIGNyZWF0ZVNvdXBNZXNzYWdlRm9ySGFuZGxlQW5kUmVxdWVzdChSZXNv dXJjZUhhbmRsZSogaGFuZGxlLCBjb25zdCBSCiAgICAgcmV0dXJuIHRydWU7CiB9CiAKLXN0YXRp YyBib29sIGNyZWF0ZVNvdXBSZXF1ZXN0QW5kTWVzc2FnZUZvckhhbmRsZShSZXNvdXJjZUhhbmRs ZSogaGFuZGxlLCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QsIGJvb2wgaXNIVFRQRmFt aWx5UmVxdWVzdCkKK3N0YXRpYyBib29sIGNyZWF0ZVNvdXBSZXF1ZXN0QW5kTWVzc2FnZUZvckhh bmRsZShSZXNvdXJjZUhhbmRsZSogaGFuZGxlLCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmIHJlcXVl c3QpCiB7CiAgICAgUmVzb3VyY2VIYW5kbGVJbnRlcm5hbCogZCA9IGhhbmRsZS0+Z2V0SW50ZXJu YWwoKTsKIApAQCAtOTgzLDcgKzk4Myw3IEBAIHN0YXRpYyBib29sIGNyZWF0ZVNvdXBSZXF1ZXN0 QW5kTWVzc2FnZUZvckhhbmRsZShSZXNvdXJjZUhhbmRsZSogaGFuZGxlLCBjb25zdCBSCiAgICAg fQogCiAgICAgLy8gU291cE1lc3NhZ2VzIGFyZSBvbmx5IGFwcGxpY2FibGUgdG8gSFRUUC1mYW1p bHkgcmVxdWVzdHMuCi0gICAgaWYgKGlzSFRUUEZhbWlseVJlcXVlc3QgJiYgIWNyZWF0ZVNvdXBN ZXNzYWdlRm9ySGFuZGxlQW5kUmVxdWVzdChoYW5kbGUsIHJlcXVlc3QpKSB7CisgICAgaWYgKHJl cXVlc3QudXJsKCkucHJvdG9jb2xJc0luSFRUUEZhbWlseSgpICYmICFjcmVhdGVTb3VwTWVzc2Fn ZUZvckhhbmRsZUFuZFJlcXVlc3QoaGFuZGxlLCByZXF1ZXN0KSkgewogICAgICAgICBkLT5tX3Nv dXBSZXF1ZXN0LmNsZWFyKCk7CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CkBAIC0xMDA3 LDE1ICsxMDA3LDE0IEBAIGJvb2wgUmVzb3VyY2VIYW5kbGU6OnN0YXJ0KCkKIAogICAgIC8vIE9u bHkgYWxsb3cgdGhlIFBPU1QgYW5kIEdFVCBtZXRob2RzIGZvciBub24tSFRUUCByZXF1ZXN0cy4K ICAgICBjb25zdCBSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QgPSBmaXJzdFJlcXVlc3QoKTsKLSAg ICBib29sIGlzSFRUUEZhbWlseVJlcXVlc3QgPSByZXF1ZXN0LnVybCgpLnByb3RvY29sSXNJbkhU VFBGYW1pbHkoKTsKLSAgICBpZiAoIWlzSFRUUEZhbWlseVJlcXVlc3QgJiYgcmVxdWVzdC5odHRw TWV0aG9kKCkgIT0gIkdFVCIgJiYgcmVxdWVzdC5odHRwTWV0aG9kKCkgIT0gIlBPU1QiKSB7Cisg ICAgaWYgKCFyZXF1ZXN0LnVybCgpLnByb3RvY29sSXNJbkhUVFBGYW1pbHkoKSAmJiByZXF1ZXN0 Lmh0dHBNZXRob2QoKSAhPSAiR0VUIiAmJiByZXF1ZXN0Lmh0dHBNZXRob2QoKSAhPSAiUE9TVCIp IHsKICAgICAgICAgdGhpcy0+c2NoZWR1bGVGYWlsdXJlKEludmFsaWRVUkxGYWlsdXJlKTsgLy8g RXJyb3IgbXVzdCBub3QgYmUgcmVwb3J0ZWQgaW1tZWRpYXRlbHkKICAgICAgICAgcmV0dXJuIHRy dWU7CiAgICAgfQogCiAgICAgYXBwbHlBdXRoZW50aWNhdGlvblRvUmVxdWVzdCh0aGlzLCBmaXJz dFJlcXVlc3QoKSwgZmFsc2UpOwogCi0gICAgaWYgKCFjcmVhdGVTb3VwUmVxdWVzdEFuZE1lc3Nh Z2VGb3JIYW5kbGUodGhpcywgcmVxdWVzdCwgaXNIVFRQRmFtaWx5UmVxdWVzdCkpIHsKKyAgICBp ZiAoIWNyZWF0ZVNvdXBSZXF1ZXN0QW5kTWVzc2FnZUZvckhhbmRsZSh0aGlzLCByZXF1ZXN0KSkg ewogICAgICAgICB0aGlzLT5zY2hlZHVsZUZhaWx1cmUoSW52YWxpZFVSTEZhaWx1cmUpOyAvLyBF cnJvciBtdXN0IG5vdCBiZSByZXBvcnRlZCBpbW1lZGlhdGVseQogICAgICAgICByZXR1cm4gdHJ1 ZTsKICAgICB9CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cK aW5kZXggNWEwOTcyOC4uNTJkNTBkYyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA0LTE3ICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbU09VUF0gUmVkaXJl Y3QgdG8gbm9uIEhUVFAgZGVzdGluYXRpb24gaXMgYnJva2VuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM4NjYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSB1bml0IHRlc3QgdG8gY2hlY2sgdGhh dCByZWRpcmVjdCB0byBhIGRhdGEgVVJJIHdvcmtzLgorCisgICAgICAgICogVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJLaXQyR3RrL1Rlc3RMb2FkZXJDbGllbnQuY3BwOgorICAgICAgICAodGVzdFJl ZGlyZWN0VG9EYXRhVVJJKToKKyAgICAgICAgKHNlcnZlckNhbGxiYWNrKToKKyAgICAgICAgKGJl Zm9yZUFsbCk6CisKIDIwMTUtMDQtMTYgIEpha2UgTmllbHNlbiAgPGphY29iX25pZWxzZW5AYXBw bGUuY29tPgogCiAgICAgICAgIENoYW5nZXMgbWV0aG9kIG9mIHF1aXR0aW5nIGlPUyBTaW11bGF0 b3IgdG8gYmUgbW9yZSBjb3JyZWN0LgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9U ZXN0cy9XZWJLaXQyR3RrL1Rlc3RMb2FkZXJDbGllbnQuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJLaXQyR3RrL1Rlc3RMb2FkZXJDbGllbnQuY3BwCmluZGV4IDQxNmZjOTUuLjBl ODY4Y2IgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mkd0ay9U ZXN0TG9hZGVyQ2xpZW50LmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktp dDJHdGsvVGVzdExvYWRlckNsaWVudC5jcHAKQEAgLTQyNSw2ICs0MjUsMTggQEAgc3RhdGljIHZv aWQgdGVzdFVSSVJlc3BvbnNlSFRUUEhlYWRlcnMoV2ViVmlld1Rlc3QqIHRlc3QsIGdjb25zdHBv aW50ZXIpCiAgICAgZ19hc3NlcnRfY21wc3RyKHNvdXBfbWVzc2FnZV9oZWFkZXJzX2dldF9vbmUo aGVhZGVycywgIkZvbyIpLCA9PSwgImJhciIpOwogfQogCitzdGF0aWMgdm9pZCB0ZXN0UmVkaXJl Y3RUb0RhdGFVUkkoV2ViVmlld1Rlc3QqIHRlc3QsIGdjb25zdHBvaW50ZXIpCit7CisgICAgdGVz dC0+bG9hZFVSSShrU2VydmVyLT5nZXRVUklGb3JQYXRoKCIvcmVkaXJlY3QtdG8tZGF0YSIpLmRh dGEoKSk7CisgICAgdGVzdC0+d2FpdFVudGlsTG9hZEZpbmlzaGVkKCk7CisKKyAgICBzdGF0aWMg Y29uc3QgY2hhciogZXhwZWN0ZWREYXRhID0gImRhdGEtdXJpIjsKKyAgICBzaXplX3QgbWFpblJl c291cmNlRGF0YVNpemUgPSAwOworICAgIGNvbnN0IGNoYXIqIG1haW5SZXNvdXJjZURhdGEgPSB0 ZXN0LT5tYWluUmVzb3VyY2VEYXRhKG1haW5SZXNvdXJjZURhdGFTaXplKTsKKyAgICBnX2Fzc2Vy dF9jbXBpbnQobWFpblJlc291cmNlRGF0YVNpemUsID09LCBzdHJsZW4oZXhwZWN0ZWREYXRhKSk7 CisgICAgZ19hc3NlcnQoIXN0cm5jbXAobWFpblJlc291cmNlRGF0YSwgZXhwZWN0ZWREYXRhLCBt YWluUmVzb3VyY2VEYXRhU2l6ZSkpOworfQorCiBzdGF0aWMgdm9pZCBzZXJ2ZXJDYWxsYmFjayhT b3VwU2VydmVyKiBzZXJ2ZXIsIFNvdXBNZXNzYWdlKiBtZXNzYWdlLCBjb25zdCBjaGFyKiBwYXRo LCBHSGFzaFRhYmxlKiwgU291cENsaWVudENvbnRleHQqLCBncG9pbnRlcikKIHsKICAgICBzdGF0 aWMgY29uc3QgY2hhciogcmVzcG9uc2VTdHJpbmcgPSAiPGh0bWw+PGJvZHk+VGVzdGluZyFUZXN0 aW5nIVRlc3RpbmchVGVzdGluZyFUZXN0aW5nIVRlc3RpbmchVGVzdGluZyEiCkBAIC00NjUsNiAr NDc3LDkgQEAgc3RhdGljIHZvaWQgc2VydmVyQ2FsbGJhY2soU291cFNlcnZlciogc2VydmVyLCBT b3VwTWVzc2FnZSogbWVzc2FnZSwgY29uc3QgY2hhcioKICAgICB9IGVsc2UgaWYgKGdfc3RyX2Vx dWFsKHBhdGgsICIvaGVhZGVycyIpKSB7CiAgICAgICAgIHNvdXBfbWVzc2FnZV9oZWFkZXJzX2Fw cGVuZChtZXNzYWdlLT5yZXNwb25zZV9oZWFkZXJzLCAiRm9vIiwgImJhciIpOwogICAgICAgICBz b3VwX21lc3NhZ2VfYm9keV9hcHBlbmQobWVzc2FnZS0+cmVzcG9uc2VfYm9keSwgU09VUF9NRU1P UllfU1RBVElDLCByZXNwb25zZVN0cmluZywgc3RybGVuKHJlc3BvbnNlU3RyaW5nKSk7CisgICAg fSBlbHNlIGlmIChnX3N0cl9lcXVhbChwYXRoLCAiL3JlZGlyZWN0LXRvLWRhdGEiKSkgeworICAg ICAgICBzb3VwX21lc3NhZ2Vfc2V0X3N0YXR1cyhtZXNzYWdlLCBTT1VQX1NUQVRVU19NT1ZFRF9Q RVJNQU5FTlRMWSk7CisgICAgICAgIHNvdXBfbWVzc2FnZV9oZWFkZXJzX2FwcGVuZChtZXNzYWdl LT5yZXNwb25zZV9oZWFkZXJzLCAiTG9jYXRpb24iLCAiZGF0YTp0ZXh0L3BsYWluO2NoYXJzZXQ9 dXRmLTgsZGF0YS11cmkiKTsKICAgICB9IGVsc2UKICAgICAgICAgc291cF9tZXNzYWdlX3NldF9z dGF0dXMobWVzc2FnZSwgU09VUF9TVEFUVVNfTk9UX0ZPVU5EKTsKIApAQCAtNTAyLDYgKzUxNyw3 IEBAIHZvaWQgYmVmb3JlQWxsKCkKICAgICBXZWJQYWdlVVJJVGVzdDo6YWRkKCJXZWJLaXRXZWJQ YWdlIiwgImdldC11cmkiLCB0ZXN0V2ViUGFnZVVSSSk7CiAgICAgV2ViVmlld1Rlc3Q6OmFkZCgi V2ViS2l0VVJJUmVxdWVzdCIsICJodHRwLWhlYWRlcnMiLCB0ZXN0VVJJUmVxdWVzdEhUVFBIZWFk ZXJzKTsKICAgICBXZWJWaWV3VGVzdDo6YWRkKCJXZWJLaXRVUklSZXNwb25zZSIsICJodHRwLWhl YWRlcnMiLCB0ZXN0VVJJUmVzcG9uc2VIVFRQSGVhZGVycyk7CisgICAgV2ViVmlld1Rlc3Q6OmFk ZCgiV2ViS2l0V2ViUGFnZSIsICJyZWRpcmVjdC10by1kYXRhLXVyaSIsIHRlc3RSZWRpcmVjdFRv RGF0YVVSSSk7CiB9CiAKIHZvaWQgYWZ0ZXJBbGwoKQo=