143863 2015-04-16 21:48:00 -0700 Large values for line-height cause integer overflow in RenderStyle::computedLineHeight 2015-04-17 15:26:54 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bjonesbe bjonesbe commit-queue esprehn+autocc glenn kondapallykalyan rwlbuis oldest_to_newest 1086249 0 bjonesbe 2015-04-16 21:48:00 -0700 This was filed in Blink (https://code.google.com/p/chromium/issues/detail?id=458461), but WebKit has the same issue. 1086250 1 251003 bjonesbe 2015-04-16 21:56:59 -0700 Created attachment 251003 Patch 1086349 2 251003 rwlbuis 2015-04-17 10:40:10 -0700 Comment on attachment 251003 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251003&action=review Looks good. > Source/WebCore/rendering/style/RenderStyle.cpp:1411 > + return clampTo<int>(lh.value()); I wonder if this does too much work compared to the Blink approach, since AFAIK the CSS Parser will not allow a negative value here. 1086438 3 bjonesbe 2015-04-17 14:56:10 -0700 (In reply to comment #2) > Comment on attachment 251003 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=251003&action=review > > Looks good. > > > Source/WebCore/rendering/style/RenderStyle.cpp:1411 > > + return clampTo<int>(lh.value()); > > I wonder if this does too much work compared to the Blink approach, since > AFAIK the CSS Parser will not allow a negative value here. Unless we have proof that the extra check is a bottleneck, I feel like using clampTo is more readable and simpler than the alternative. 1086448 4 251003 commit-queue 2015-04-17 15:26:51 -0700 Comment on attachment 251003 Patch Clearing flags on attachment: 251003 Committed r182974: <http://trac.webkit.org/changeset/182974> 1086449 5 commit-queue 2015-04-17 15:26:54 -0700 All reviewed patches have been landed. Closing bug. 251003 2015-04-16 21:56:59 -0700 2015-04-17 15:26:51 -0700 Patch bug-143863-20150416215601.patch text/plain 4089 bjonesbe U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyODAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWY5NTFiMTRkZWZjOTUw YzkxZGYxNjcyYWUwMGQ5ZGEyOWMyNjE4Yy4uM2Y4ZWFlZTNlZGQzZGU2MGVhMTk4YWUyYjkwNDM1 MzBjOGNmNjk1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE1LTA0LTE2ICBCZW0g Sm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRvYmUuY29tPgorCisgICAgICAgIExhcmdlIHZhbHVlcyBm b3IgbGluZS1oZWlnaHQgY2F1c2UgaW50ZWdlciBvdmVyZmxvdyBpbiBSZW5kZXJTdHlsZTo6Y29t cHV0ZWRMaW5lSGVpZ2h0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDM4NjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBXaGVuIHdlIGNvbXB1dGUgaHVnZSB2YWx1ZXMgZm9yIGxpbmUtaGVpZ2h0IHRocm91 Z2ggcGVyY2VudGFnZSBvciBDU1MKKyAgICAgICAgY2FsYywgd2UnbGwgb3ZlcmZsb3cgdGhlIGlu dGVnZXIgYW5kIGxhdGVyIG9uCisgICAgICAgIFNoYXBlT3V0c2lkZUluZm86OmNvbXB1dGVEZWx0 YXNGb3JDb250YWluaW5nQmxvY2tMaW5lIHdpbGwgQVNTRVJUCisgICAgICAgIGJlY2F1c2UgaXQg ZXhwZWN0cyBub24tbmVnYXRpdmUgbGluZSBoZWlnaHQuICBTbyBmb3IgdGhlIGNvbXB1dGVkCisg ICAgICAgIGxpbmUtaGVpZ2h0LCBjbGFtcCB0byBhbiBpbnRlZ2VyIHJhbmdlIHRvIGF2b2lkIG92 ZXJmbG93LiBOb3RlIHRoYXQKKyAgICAgICAgdGhlIGNvZGUgcGF0aCBmb3IgcGVyY2VudGFnZXMg aGVyZSBpcyBzYWZlIGJlY2F1c2UgTGF5b3V0VW5pdCBjbGFtcHMKKyAgICAgICAgdG8gYW4gaW50 IG9uIGNvbnZlcnNpb24uCisKKyAgICAgICAgVGhpcyBpcyBiYXNlZCBvbiBhIEJsaW5rIHBhdGNo IGJ5IFJvYiBCdWlzLgorCisgICAgICAgIFRlc3Q6IGZhc3Qvc2hhcGVzL3NoYXBlLW91dHNpZGUt ZmxvYXRzL3NoYXBlLW91dHNpZGUtbmVnYXRpdmUtbGluZS1oZWlnaHQtY3Jhc2guaHRtbAorCisg ICAgICAgICogcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlclN0eWxlOjpjb21wdXRlZExpbmVIZWlnaHQpOiBDbGFtcCBsaW5lLWhlaWdodCB0 byBhbgorICAgICAgICAgICAgaW50IHRvIGF2b2lkIG92ZXJmbG93LgorCiAyMDE1LTA0LTEzICBT aW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1MgV0sy XSBJbnRlcmFjdGl2ZSBlbGVtZW50cyBvZiBkZXZlbG9wZXIuYXBwbGUuY29tIGFyZSBicm9rZW4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3BwCmluZGV4 IDk1OGZmMDI0MmNiZDQxYWVjZmU0ZDE3NjliZWI4YjhmNmExNjU4MzYuLjhlODQ5NjJkMDE4YmMz NDg4ODk3NWJhOTgwNDJhODRkZTBlODFjYjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL3N0eWxlL1JlbmRlclN0eWxlLmNwcApAQCAtMTQwOCw3ICsxNDA4LDcgQEAgaW50IFJlbmRl clN0eWxlOjpjb21wdXRlZExpbmVIZWlnaHQoKSBjb25zdAogICAgIGlmIChsaC5pc1BlcmNlbnQo KSkKICAgICAgICAgcmV0dXJuIG1pbmltdW1WYWx1ZUZvckxlbmd0aChsaCwgZm9udFNpemUoKSk7 CiAKLSAgICByZXR1cm4gbGgudmFsdWUoKTsKKyAgICByZXR1cm4gY2xhbXBUbzxpbnQ+KGxoLnZh bHVlKCkpOwogfQogCiB2b2lkIFJlbmRlclN0eWxlOjpzZXRXb3JkU3BhY2luZyhMZW5ndGggdmFs dWUpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKaW5kZXggNDA2ODAyYzRmZDBiMDI0ZDM5Zjk2MThiMDI2MWM0MmUwMDVhOTQ0OS4uOGI1 NzQ4ZWUyY2FjNWYxOTFjMmQwMzJjYjY1MmQwN2M1MzhjNDZmYyAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE1LTA0LTE2ICBCZW0gSm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRvYmUuY29tPgorCisg ICAgICAgIExhcmdlIHZhbHVlcyBmb3IgbGluZS1oZWlnaHQgY2F1c2UgaW50ZWdlciBvdmVyZmxv dyBpbiBSZW5kZXJTdHlsZTo6Y29tcHV0ZWRMaW5lSGVpZ2h0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM4NjMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW1wbGlmaWVkIHRlc3QgZnJvbSBhIGZ1enpl ci4KKworICAgICAgICAqIGZhc3Qvc2hhcGVzL3NoYXBlLW91dHNpZGUtZmxvYXRzL3NoYXBlLW91 dHNpZGUtbmVnYXRpdmUtbGluZS1oZWlnaHQtY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAg ICAgICAgKiBmYXN0L3NoYXBlcy9zaGFwZS1vdXRzaWRlLWZsb2F0cy9zaGFwZS1vdXRzaWRlLW5l Z2F0aXZlLWxpbmUtaGVpZ2h0LWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDE1LTA0LTE0ICBBbGV4 ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIGZhc3Qvc3ViLXBpeGVs L2lucHV0LWNhcmV0LW9uLXN1YnBpeGVsLWJvdW5kLmh0bWwgaXMgZmxha3kKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2Zhc3Qvc2hhcGVzL3NoYXBlLW91dHNpZGUtZmxvYXRzL3NoYXBlLW91dHNp ZGUtbmVnYXRpdmUtbGluZS1oZWlnaHQtY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv ZmFzdC9zaGFwZXMvc2hhcGUtb3V0c2lkZS1mbG9hdHMvc2hhcGUtb3V0c2lkZS1uZWdhdGl2ZS1s aW5lLWhlaWdodC1jcmFzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNzMwZWJmNjZhMGRhNDk4 MDAxN2U5YmMwMzdjNmUzZjg0YWI3ZTc5ZQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L2Zhc3Qvc2hhcGVzL3NoYXBlLW91dHNpZGUtZmxvYXRzL3NoYXBlLW91dHNpZGUtbmVnYXRpdmUt bGluZS1oZWlnaHQtY3Jhc2gtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEgQEAKK1RoaXMgdGVzdCBw YXNzZXMgaWYgaXQgZG9lc24ndCBjcmFzaC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv c2hhcGVzL3NoYXBlLW91dHNpZGUtZmxvYXRzL3NoYXBlLW91dHNpZGUtbmVnYXRpdmUtbGluZS1o ZWlnaHQtY3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qvc2hhcGVzL3NoYXBlLW91dHNpZGUt ZmxvYXRzL3NoYXBlLW91dHNpZGUtbmVnYXRpdmUtbGluZS1oZWlnaHQtY3Jhc2guaHRtbApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi42YTA0ZDM4ODg2MTI2MGY2NmU0NDgxODJmMTgxNmQ5MWYyZmM4OWZmCi0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9zaGFwZXMvc2hhcGUtb3V0c2lkZS1mbG9hdHMv c2hhcGUtb3V0c2lkZS1uZWdhdGl2ZS1saW5lLWhlaWdodC1jcmFzaC5odG1sCkBAIC0wLDAgKzEs MTcgQEAKKzwhRE9DVFlQRSBodG1sPgorPHN0eWxlPgorYm9keSB7CisgICAgZm9udDogY2FsYygg MTAwMDAgKiAxMDAwJSApL2NhbGMoIDEwMDAwICogMTAwMCUgKSBzYW5zLXNlcmlmOworfQorcCB7 CisgICAgLXdlYmtpdC1zaGFwZS1vdXRzaWRlOiBjaXJjbGUoKTsKKyAgICBmbG9hdDogcmlnaHQ7 Cit9Cis8L3N0eWxlPgorPGJvZHk+CisgICAgPHA+VGhpcyB0ZXN0IHBhc3NlcyBpZiBpdCBkb2Vz bid0IGNyYXNoLjwvcD4KKzwvYm9keT4KKzxzY3JpcHQ+CitpZiAod2luZG93LnRlc3RSdW5uZXIp CisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7Cis8L3NjcmlwdD4K