143861 2015-04-16 19:58:58 -0700 Update fullscreen button visibility on fullscreen change. 2015-04-17 11:37:38 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned eric.carlson roger_fong oldest_to_newest 1086239 0 roger_fong 2015-04-16 19:58:58 -0700 rdar://problem/20143218 Covers some issues where the fullscreen button may not be updated correctly from just handling the video's ready state events. 1086240 1 250998 roger_fong 2015-04-16 20:03:14 -0700 Created attachment 250998 patch 1086380 2 roger_fong 2015-04-17 11:37:38 -0700 http://trac.webkit.org/changeset/182958 250998 2015-04-16 20:03:14 -0700 2015-04-17 06:40:07 -0700 patch patch.patch text/plain 2616 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MjkzOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA0LTE2ICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgVXBkYXRlIGZ1bGxzY3JlZW4g YnV0dG9uIHZpc2liaWxpdHkgb24gZnVsbHNjcmVlbiBjaGFuZ2UuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM4NjEuCisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS8yMDE0MzIxOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIE1vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanM6 CisgICAgICAgIChDb250cm9sbGVyKTogVGhlcmUgaXMgbm8gbmVlZCBmb3IgaGFzVmlzdWFsTWVk aWEgdG8gYmUgYSBjbGFzcyB2YXJpYWJsZS4KKyAgICAgICAgKENvbnRyb2xsZXIucHJvdG90eXBl LmhhbmRsZVJlYWR5U3RhdGVDaGFuZ2UpOgorICAgICAgICAoQ29udHJvbGxlci5wcm90b3R5cGUu aGFuZGxlRnVsbHNjcmVlbkNoYW5nZSk6CisgICAgICAgIChDb250cm9sbGVyLnByb3RvdHlwZS51 cGRhdGVGdWxsc2NyZWVuQnV0dG9ucyk6CisKIDIwMTUtMDQtMTYgIEFsZXggQ2hyaXN0ZW5zZW4g IDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBVc2UgbGVzcyBtZW1vcnkgd2hl biBjb21waWxpbmcgY29udGVudCBleHRlbnNpb25zCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpzCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanMJ KHJldmlzaW9uIDE4MjkwMCkKKysrIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9s cy9tZWRpYUNvbnRyb2xzQXBwbGUuanMJKHdvcmtpbmcgY29weSkKQEAgLTEyLDcgKzEyLDYgQEAg ZnVuY3Rpb24gQ29udHJvbGxlcihyb290LCB2aWRlbywgaG9zdCkKICAgICB0aGlzLmxpc3RlbmVy cyA9IHt9OwogICAgIHRoaXMuaXNMaXZlID0gZmFsc2U7CiAgICAgdGhpcy5zdGF0dXNIaWRkZW4g PSB0cnVlOwotICAgIHRoaXMuaGFzVmlzdWFsTWVkaWEgPSBmYWxzZTsKICAgICB0aGlzLmhhc1dp cmVsZXNzUGxheWJhY2tUYXJnZXRzID0gZmFsc2U7CiAgICAgdGhpcy5pc0xpc3RlbmluZ0ZvclBs YXliYWNrVGFyZ2V0QXZhaWxhYmlsaXR5RXZlbnQgPSBmYWxzZTsKICAgICB0aGlzLmN1cnJlbnRU YXJnZXRJc1dpcmVsZXNzID0gZmFsc2U7CkBAIC02NDYsNyArNjQ1LDYgQEAgQ29udHJvbGxlci5w cm90b3R5cGUgPSB7CiAKICAgICBoYW5kbGVSZWFkeVN0YXRlQ2hhbmdlOiBmdW5jdGlvbihldmVu dCkKICAgICB7Ci0gICAgICAgIHRoaXMuaGFzVmlzdWFsTWVkaWEgPSB0aGlzLnZpZGVvLnZpZGVv VHJhY2tzICYmIHRoaXMudmlkZW8udmlkZW9UcmFja3MubGVuZ3RoID4gMDsKICAgICAgICAgdGhp cy51cGRhdGVSZWFkeVN0YXRlKCk7CiAgICAgICAgIHRoaXMudXBkYXRlRHVyYXRpb24oKTsKICAg ICAgICAgdGhpcy51cGRhdGVDYXB0aW9uQnV0dG9uKCk7CkBAIC03MzksNiArNzM3LDcgQEAgQ29u dHJvbGxlci5wcm90b3R5cGUgPSB7CiAgICAgewogICAgICAgICB0aGlzLnVwZGF0ZUJhc2UoKTsK ICAgICAgICAgdGhpcy51cGRhdGVDb250cm9scygpOworICAgICAgICB0aGlzLnVwZGF0ZUZ1bGxz Y3JlZW5CdXR0b25zKCk7CiAgICAgICAgIHRoaXMudXBkYXRlV2lyZWxlc3NQbGF5YmFja1N0YXR1 cygpOwogCiAgICAgICAgIGlmICh0aGlzLmlzRnVsbFNjcmVlbigpKSB7CkBAIC05NzUsNyArOTc0 LDggQEAgQ29udHJvbGxlci5wcm90b3R5cGUgPSB7CiAKICAgICB1cGRhdGVGdWxsc2NyZWVuQnV0 dG9uczogZnVuY3Rpb24oKQogICAgIHsKLSAgICAgICAgdmFyIHNob3VsZEJlSGlkZGVuID0gIXRo aXMudmlkZW8ud2Via2l0U3VwcG9ydHNGdWxsc2NyZWVuIHx8ICF0aGlzLmhhc1Zpc3VhbE1lZGlh OworICAgICAgICB2YXIgaGFzVmlzdWFsTWVkaWEgPSB0aGlzLnZpZGVvLnZpZGVvVHJhY2tzICYm IHRoaXMudmlkZW8udmlkZW9UcmFja3MubGVuZ3RoID4gMDsKKyAgICAgICAgdmFyIHNob3VsZEJl SGlkZGVuID0gIXRoaXMudmlkZW8ud2Via2l0U3VwcG9ydHNGdWxsc2NyZWVuIHx8ICFoYXNWaXN1 YWxNZWRpYTsKICAgICAgICAgdGhpcy5jb250cm9scy5mdWxsc2NyZWVuQnV0dG9uLmNsYXNzTGlz dC50b2dnbGUodGhpcy5DbGFzc05hbWVzLmhpZGRlbiwgc2hvdWxkQmVIaWRkZW4pOwogICAgICAg ICB0aGlzLmNvbnRyb2xzLm9wdGltaXplZEZ1bGxzY3JlZW5CdXR0b24uY2xhc3NMaXN0LnRvZ2ds ZSh0aGlzLkNsYXNzTmFtZXMuaGlkZGVuLCBzaG91bGRCZUhpZGRlbik7CiAgICAgfSwK